* [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n
@ 2018-12-24 17:20 Qian Cai
2018-12-25 2:44 ` Hanjun Guo
0 siblings, 1 reply; 4+ messages in thread
From: Qian Cai @ 2018-12-24 17:20 UTC (permalink / raw)
To: sfr, lorenzo.pieralisi, hanjun.guo, sudeep.holla
Cc: linux-acpi, linux-next, linux-kernel, Qian Cai
rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' token
{ return NULL; }
^
drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but never defined
static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Qian Cai <cai@lca.pw>
---
drivers/acpi/arm64/iort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index fdd90ffceb85..5d29783ee5bd 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -876,7 +876,7 @@ int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head *head)
return (resv == its->its_count) ? resv : -ENODEV;
}
#else
-static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
+static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
{ return NULL; }
static inline int iort_add_device_replay(const struct iommu_ops *ops,
struct device *dev)
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n
2018-12-24 17:20 [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n Qian Cai
@ 2018-12-25 2:44 ` Hanjun Guo
0 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2018-12-25 2:44 UTC (permalink / raw)
To: Qian Cai, sfr, lorenzo.pieralisi, hanjun.guo, sudeep.holla
Cc: linux-acpi, linux-next, linux-kernel
Hi Qian,
Good catch, minor comments below.
On 2018/12/25 1:20, Qian Cai wrote:
> rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' token
^^
drivers
> { return NULL; }
> ^
> drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but never defined
> static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> ^~~~~~~~~~~~~~~~~~~~~
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index fdd90ffceb85..5d29783ee5bd 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -876,7 +876,7 @@ int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head *head)
> return (resv == its->its_count) ? resv : -ENODEV;
> }
> #else
> -static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> +static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
> { return NULL; }
> static inline int iort_add_device_replay(const struct iommu_ops *ops,
> struct device *dev)
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Lorenzo, I think this is 4.21-rc1 material if it's OK for you.
Thanks
Hanjun
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n
@ 2018-12-25 2:44 ` Hanjun Guo
0 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2018-12-25 2:44 UTC (permalink / raw)
To: Qian Cai, sfr, lorenzo.pieralisi, hanjun.guo, sudeep.holla
Cc: linux-acpi, linux-next, linux-kernel
Hi Qian,
Good catch, minor comments below.
On 2018/12/25 1:20, Qian Cai wrote:
> rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' token
^^
drivers
> { return NULL; }
> ^
> drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but never defined
> static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> ^~~~~~~~~~~~~~~~~~~~~
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index fdd90ffceb85..5d29783ee5bd 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -876,7 +876,7 @@ int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head *head)
> return (resv == its->its_count) ? resv : -ENODEV;
> }
> #else
> -static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> +static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
> { return NULL; }
> static inline int iort_add_device_replay(const struct iommu_ops *ops,
> struct device *dev)
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Lorenzo, I think this is 4.21-rc1 material if it's OK for you.
Thanks
Hanjun
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n
2018-12-25 2:44 ` Hanjun Guo
(?)
@ 2019-01-04 16:16 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2019-01-04 16:16 UTC (permalink / raw)
To: Hanjun Guo
Cc: Qian Cai, sfr, hanjun.guo, sudeep.holla, linux-acpi, linux-next,
linux-kernel
On Tue, Dec 25, 2018 at 10:44:38AM +0800, Hanjun Guo wrote:
> Hi Qian,
>
> Good catch, minor comments below.
>
> On 2018/12/25 1:20, Qian Cai wrote:
> > rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' token
> ^^
> drivers
>
> > { return NULL; }
> > ^
> > drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but never defined
> > static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> > ^~~~~~~~~~~~~~~~~~~~~
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
> > drivers/acpi/arm64/iort.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> > index fdd90ffceb85..5d29783ee5bd 100644
> > --- a/drivers/acpi/arm64/iort.c
> > +++ b/drivers/acpi/arm64/iort.c
> > @@ -876,7 +876,7 @@ int iort_iommu_msi_get_resv_regions(struct device *dev, struct list_head *head)
> > return (resv == its->its_count) ? resv : -ENODEV;
> > }
> > #else
> > -static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);
> > +static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
> > { return NULL; }
> > static inline int iort_add_device_replay(const struct iommu_ops *ops,
> > struct device *dev)
>
> Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
>
> Lorenzo, I think this is 4.21-rc1 material if it's OK for you.
It is a bit late for -rc1 but I will send it asap, with a proper Fixes:
tag that points at the commit that introduced the typo.
Lorenzo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-04 16:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-24 17:20 [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n Qian Cai
2018-12-25 2:44 ` Hanjun Guo
2018-12-25 2:44 ` Hanjun Guo
2019-01-04 16:16 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.