All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Alexander Graf <agraf@suse.de>
Cc: grub-devel@gnu.org, Peter Jones <pjones@redhat.com>,
	Jon Masters <jcm@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 0/2] arm64: Support HP Envy X2
Date: Mon, 7 Jan 2019 09:58:04 +0000	[thread overview]
Message-ID: <20190107095804.vmjhqs4kybdxmwm2@bivouac.eciton.net> (raw)
In-Reply-To: <20181223025207.40755-1-agraf@suse.de>

On Sun, Dec 23, 2018 at 03:52:05AM +0100, Alexander Graf wrote:
> I got a new toy this week: An HP Envy X2 system. This is one of those shiny
> new Qualcomm Snapdragon based Windows tablet/notebook hybrid things.
> 
> While running Windows on those is actually not a terribly bad experience now
> that WSL is out, I would like to see Linux run on those as well in the future.
> 
> Unfortunately as far as I'm aware so far nobody was able to run self built
> binaries on the built-in UEFI version.
> 
> Turns out, it's a problem with aligning the start of the header to 4k. Once
> we do that, binaries can be loaded just fine and run.
> 
> The reason behind that is simple: Its firmware tries to ensure NX protection
> flags and can do so only when the code is 4K aligned.
> 
> So to maintain compatibility with that device, this patch set just bumps the
> header alignment to 4K always on arm64-efi. This way we improve overall
> compatibility - there surely will be more devices coming with similar
> constraints.
> 
> v1 -> v2:
> 
>   - Remove explicit device wording from patch
>   - Use GRUB_EFI_PAGE_SIZE

Looks good to me, thanks!
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>

> Alexander Graf (2):
>   mkimage: Simplify header size logic
>   mkimage: arm64-efi: Align first section to page
> 
>  util/mkimage.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> -- 
> 2.12.3
> 


      parent reply	other threads:[~2019-01-07  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23  2:52 [PATCH v2 0/2] arm64: Support HP Envy X2 Alexander Graf
2018-12-23  2:52 ` [PATCH v2 1/2] mkimage: Simplify header size logic Alexander Graf
2019-01-14 13:29   ` Daniel Kiper
2018-12-23  2:52 ` [PATCH v2 2/2] mkimage: arm64-efi: Align first section to page Alexander Graf
2019-01-14 13:37   ` Daniel Kiper
2019-01-14 13:41     ` Alexander Graf
2019-01-14 14:21       ` Leif Lindholm
2019-01-07  9:58 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107095804.vmjhqs4kybdxmwm2@bivouac.eciton.net \
    --to=leif.lindholm@linaro.org \
    --cc=agraf@suse.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=grub-devel@gnu.org \
    --cc=jcm@redhat.com \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.