From: Daniel Kiper <dkiper@net-space.pl>
To: Alexander Graf <agraf@suse.de>
Cc: grub-devel@gnu.org, Jon Masters <jcm@redhat.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 1/2] mkimage: Simplify header size logic
Date: Mon, 14 Jan 2019 14:29:11 +0100 [thread overview]
Message-ID: <20190114132911.mmk34h3ku3ghqyod@tomti.i.net-space.pl> (raw)
In-Reply-To: <20181223025207.40755-2-agraf@suse.de>
On Sun, Dec 23, 2018 at 03:52:06AM +0100, Alexander Graf wrote:
> For EFI images, we always have the following layout:
>
> [PE header]
> [padding]
> [first section (which also is the entry point)]
>
> Currently there are 2 places where we define how big header+padding are:
> in the .vaddr_offset member of our target image definition struct as well
> as in code in grub_install_generate_image().
>
> Remove the latter, so that we only have a single place to modify if we
> need to change the padding.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
next prev parent reply other threads:[~2019-01-14 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 2:52 [PATCH v2 0/2] arm64: Support HP Envy X2 Alexander Graf
2018-12-23 2:52 ` [PATCH v2 1/2] mkimage: Simplify header size logic Alexander Graf
2019-01-14 13:29 ` Daniel Kiper [this message]
2018-12-23 2:52 ` [PATCH v2 2/2] mkimage: arm64-efi: Align first section to page Alexander Graf
2019-01-14 13:37 ` Daniel Kiper
2019-01-14 13:41 ` Alexander Graf
2019-01-14 14:21 ` Leif Lindholm
2019-01-07 9:58 ` [PATCH v2 0/2] arm64: Support HP Envy X2 Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114132911.mmk34h3ku3ghqyod@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=agraf@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=grub-devel@gnu.org \
--cc=jcm@redhat.com \
--cc=leif.lindholm@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.