From: Bjorn Helgaas <helgaas@kernel.org>
To: Koen Vandeputte <koen.vandeputte@ncentric.com>
Cc: "Krzysztof Hałasa" <khalasa@piap.pl>,
"Rob Herring" <robh@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
linux-pci@vger.kernel.org, "Tim Harvey" <tharvey@gateworks.com>,
"Russell King" <linux@armlinux.org.uk>,
stable@vger.kernel.org,
"Robin Leblon" <robin.leblon@ncentric.com>,
"Olof Johansson" <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment
Date: Mon, 7 Jan 2019 07:24:34 -0600 [thread overview]
Message-ID: <20190107132434.GA113458@google.com> (raw)
In-Reply-To: <a7531ef2-d6d0-0a48-1558-23474c97b838@ncentric.com>
On Mon, Jan 07, 2019 at 09:58:42AM +0100, Koen Vandeputte wrote:
> On 31.12.18 16:29, Bjorn Helgaas wrote:
> > 1) The current one that corrects the address alignment error, and
> Is it required to resend this specific patch?
It's easier if you resend this patch along with the other. When I
suggest changes to a patch, I mark it (and the whole series if it's
part of a series) as "changes requested" in the patchwork patch
tracker. That means it falls off my to-do list until the resend
happens.
> > 2) A new one that converts cns3xxx_pci_read_config() to use
> > pci_generic_config_read() instead of pci_generic_config_read32().
> I'll first extensively test non-32b reads later today and will send a patch
> for it
Perfect, thanks!
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Koen Vandeputte <koen.vandeputte@ncentric.com>
Cc: "Rob Herring" <robh@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
linux-pci@vger.kernel.org, "Tim Harvey" <tharvey@gateworks.com>,
"Russell King" <linux@armlinux.org.uk>,
stable@vger.kernel.org,
"Robin Leblon" <robin.leblon@ncentric.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Olof Johansson" <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment
Date: Mon, 7 Jan 2019 07:24:34 -0600 [thread overview]
Message-ID: <20190107132434.GA113458@google.com> (raw)
In-Reply-To: <a7531ef2-d6d0-0a48-1558-23474c97b838@ncentric.com>
On Mon, Jan 07, 2019 at 09:58:42AM +0100, Koen Vandeputte wrote:
> On 31.12.18 16:29, Bjorn Helgaas wrote:
> > 1) The current one that corrects the address alignment error, and
> Is it required to resend this specific patch?
It's easier if you resend this patch along with the other. When I
suggest changes to a patch, I mark it (and the whole series if it's
part of a series) as "changes requested" in the patchwork patch
tracker. That means it falls off my to-do list until the resend
happens.
> > 2) A new one that converts cns3xxx_pci_read_config() to use
> > pci_generic_config_read() instead of pci_generic_config_read32().
> I'll first extensively test non-32b reads later today and will send a patch
> for it
Perfect, thanks!
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-07 13:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 11:17 [PATCH] arm: cns3xxx: fix writing to wrong PCI registers after alignment Koen Vandeputte
2018-12-18 11:17 ` Koen Vandeputte
2018-12-18 16:04 ` Tim Harvey
2018-12-18 16:04 ` Tim Harvey
2018-12-20 5:34 ` Krzysztof Hałasa
2018-12-20 5:34 ` Krzysztof Hałasa
2018-12-29 14:40 ` Koen Vandeputte
2018-12-29 14:40 ` Koen Vandeputte
2018-12-30 1:06 ` Bjorn Helgaas
2018-12-30 1:06 ` Bjorn Helgaas
2018-12-31 10:14 ` Krzysztof Hałasa
2018-12-31 10:14 ` Krzysztof Hałasa
2018-12-31 15:29 ` Bjorn Helgaas
2018-12-31 15:29 ` Bjorn Helgaas
2019-01-07 8:58 ` Koen Vandeputte
2019-01-07 8:58 ` Koen Vandeputte
2019-01-07 13:24 ` Bjorn Helgaas [this message]
2019-01-07 13:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107132434.GA113458@google.com \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=khalasa@piap.pl \
--cc=koen.vandeputte@ncentric.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=robin.leblon@ncentric.com \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.