From: Michal Hocko <mhocko@kernel.org> To: <linux-mm@kvack.org> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Johannes Weiner <hannes@cmpxchg.org>, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH 1/2] mm, oom: marks all killed tasks as oom victims Date: Mon, 7 Jan 2019 15:38:01 +0100 [thread overview] Message-ID: <20190107143802.16847-2-mhocko@kernel.org> (raw) In-Reply-To: <20190107143802.16847-1-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> Historically we have called mark_oom_victim only to the main task selected as the oom victim because oom victims have access to memory reserves and granting the access to all killed tasks could deplete memory reserves very quickly and cause even larger problems. Since only a partial access to memory reserves is allowed there is no longer this risk and so all tasks killed along with the oom victim can be considered as well. The primary motivation for that is that process groups which do not shared signals would behave more like standard thread groups wrt oom handling (aka tsk_is_oom_victim will work the same way for them). - Use find_lock_task_mm to stabilize mm as suggested by Tetsuo Signed-off-by: Michal Hocko <mhocko@suse.com> --- mm/oom_kill.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index f0e8cd9edb1a..0246c7a4e44e 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -892,6 +892,7 @@ static void __oom_kill_process(struct task_struct *victim) */ rcu_read_lock(); for_each_process(p) { + struct task_struct *t; if (!process_shares_mm(p, mm)) continue; if (same_thread_group(p, victim)) @@ -911,6 +912,11 @@ static void __oom_kill_process(struct task_struct *victim) if (unlikely(p->flags & PF_KTHREAD)) continue; do_send_sig_info(SIGKILL, SEND_SIG_PRIV, p, PIDTYPE_TGID); + t = find_lock_task_mm(p); + if (!t) + continue; + mark_oom_victim(t); + task_unlock(t); } rcu_read_unlock(); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Johannes Weiner <hannes@cmpxchg.org>, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH 1/2] mm, oom: marks all killed tasks as oom victims Date: Mon, 7 Jan 2019 15:38:01 +0100 [thread overview] Message-ID: <20190107143802.16847-2-mhocko@kernel.org> (raw) In-Reply-To: <20190107143802.16847-1-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> Historically we have called mark_oom_victim only to the main task selected as the oom victim because oom victims have access to memory reserves and granting the access to all killed tasks could deplete memory reserves very quickly and cause even larger problems. Since only a partial access to memory reserves is allowed there is no longer this risk and so all tasks killed along with the oom victim can be considered as well. The primary motivation for that is that process groups which do not shared signals would behave more like standard thread groups wrt oom handling (aka tsk_is_oom_victim will work the same way for them). - Use find_lock_task_mm to stabilize mm as suggested by Tetsuo Signed-off-by: Michal Hocko <mhocko@suse.com> --- mm/oom_kill.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index f0e8cd9edb1a..0246c7a4e44e 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -892,6 +892,7 @@ static void __oom_kill_process(struct task_struct *victim) */ rcu_read_lock(); for_each_process(p) { + struct task_struct *t; if (!process_shares_mm(p, mm)) continue; if (same_thread_group(p, victim)) @@ -911,6 +912,11 @@ static void __oom_kill_process(struct task_struct *victim) if (unlikely(p->flags & PF_KTHREAD)) continue; do_send_sig_info(SIGKILL, SEND_SIG_PRIV, p, PIDTYPE_TGID); + t = find_lock_task_mm(p); + if (!t) + continue; + mark_oom_victim(t); + task_unlock(t); } rcu_read_unlock(); -- 2.20.1
next prev parent reply other threads:[~2019-01-07 14:39 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-07 14:38 [PATCH 0/2] oom, memcg: do not report racy no-eligible OOM Michal Hocko 2019-01-07 14:38 ` Michal Hocko 2019-01-07 14:38 ` Michal Hocko [this message] 2019-01-07 14:38 ` [PATCH 1/2] mm, oom: marks all killed tasks as oom victims Michal Hocko 2019-01-07 20:58 ` Tetsuo Handa 2019-01-08 8:11 ` Michal Hocko 2019-01-07 14:38 ` [PATCH 2/2] memcg: do not report racy no-eligible OOM tasks Michal Hocko 2019-01-07 14:38 ` Michal Hocko 2019-01-07 20:59 ` Tetsuo Handa 2019-01-08 8:14 ` Michal Hocko 2019-01-08 10:39 ` Tetsuo Handa 2019-01-08 11:46 ` Michal Hocko 2019-01-08 8:35 ` kbuild test robot 2019-01-08 9:39 ` Michal Hocko 2019-01-11 0:23 ` [kbuild-all] " Rong Chen 2019-01-08 14:21 ` [PATCH 3/2] memcg: Facilitate termination of memcg OOM victims Tetsuo Handa 2019-01-08 14:38 ` Michal Hocko 2019-01-09 11:03 ` [PATCH 0/2] oom, memcg: do not report racy no-eligible OOM Michal Hocko 2019-01-09 11:34 ` Tetsuo Handa 2019-01-09 12:02 ` Michal Hocko 2019-01-10 23:59 ` Tetsuo Handa 2019-01-11 10:25 ` Tetsuo Handa 2019-01-11 11:33 ` Michal Hocko 2019-01-11 12:40 ` Tetsuo Handa 2019-01-11 13:34 ` Michal Hocko 2019-01-11 14:31 ` Tetsuo Handa 2019-01-11 15:07 ` Michal Hocko 2019-01-11 15:37 ` Tetsuo Handa 2019-01-11 16:45 ` Michal Hocko 2019-01-12 10:52 ` Tetsuo Handa 2019-01-13 17:36 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190107143802.16847-2-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.