* [PATCH] USB: serial: simple: add Motorola Tetra driver for TPG2200
@ 2019-01-07 7:31 ` Max Schulze
0 siblings, 0 replies; 4+ messages in thread
From: Max Schulze @ 2019-01-07 7:31 UTC (permalink / raw)
To: johan, gregkh, linux-usb, linux-kernel; +Cc: Max Schulze
Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
device
T: Bus=02 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=0cad ProdID=9016 Rev=24.16
S: Manufacturer=Motorola Solutions, Inc.
S: Product=TETRA PEI interface
C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
Signed-off-by: Max Schulze <max.schulze@posteo.de>
Tested-by: Max Schulze <max.schulze@posteo.de>
---
drivers/usb/serial/usb-serial-simple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 4d0273508043..edbbb13d6de6 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -85,7 +85,8 @@ DEVICE(moto_modem, MOTO_IDS);
/* Motorola Tetra driver */
#define MOTOROLA_TETRA_IDS() \
{ USB_DEVICE(0x0cad, 0x9011) }, /* Motorola Solutions TETRA PEI */ \
- { USB_DEVICE(0x0cad, 0x9012) } /* MTP6550 */
+ { USB_DEVICE(0x0cad, 0x9012) }, /* MTP6550 */ \
+ { USB_DEVICE(0x0cad, 0x9016) } /* TPG2200 */
DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
/* Novatel Wireless GPS driver */
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* USB: serial: simple: add Motorola Tetra driver for TPG2200
@ 2019-01-07 7:31 ` Max Schulze
0 siblings, 0 replies; 4+ messages in thread
From: Max Schulze @ 2019-01-07 7:31 UTC (permalink / raw)
To: johan, gregkh, linux-usb, linux-kernel; +Cc: Max Schulze
Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
device
T: Bus=02 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=0cad ProdID=9016 Rev=24.16
S: Manufacturer=Motorola Solutions, Inc.
S: Product=TETRA PEI interface
C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
Signed-off-by: Max Schulze <max.schulze@posteo.de>
Tested-by: Max Schulze <max.schulze@posteo.de>
---
drivers/usb/serial/usb-serial-simple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 4d0273508043..edbbb13d6de6 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -85,7 +85,8 @@ DEVICE(moto_modem, MOTO_IDS);
/* Motorola Tetra driver */
#define MOTOROLA_TETRA_IDS() \
{ USB_DEVICE(0x0cad, 0x9011) }, /* Motorola Solutions TETRA PEI */ \
- { USB_DEVICE(0x0cad, 0x9012) } /* MTP6550 */
+ { USB_DEVICE(0x0cad, 0x9012) }, /* MTP6550 */ \
+ { USB_DEVICE(0x0cad, 0x9016) } /* TPG2200 */
DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
/* Novatel Wireless GPS driver */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: serial: simple: add Motorola Tetra driver for TPG2200
@ 2019-01-07 15:42 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2019-01-07 15:42 UTC (permalink / raw)
To: Max Schulze; +Cc: johan, gregkh, linux-usb, linux-kernel
On Mon, Jan 07, 2019 at 08:31:49AM +0100, Max Schulze wrote:
> Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
> device
I rephrased the summary and comment above since you're adding a new
device id to an existing driver (rather than a new driver).
> T: Bus=02 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0cad ProdID=9016 Rev=24.16
> S: Manufacturer=Motorola Solutions, Inc.
> S: Product=TETRA PEI interface
> C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
>
> Signed-off-by: Max Schulze <max.schulze@posteo.de>
> Tested-by: Max Schulze <max.schulze@posteo.de>
And no need to add Tested-by for your own patches; submissions are
always supposed to be tested.
Applied for -rc2.
Thanks,
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* USB: serial: simple: add Motorola Tetra driver for TPG2200
@ 2019-01-07 15:42 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2019-01-07 15:42 UTC (permalink / raw)
To: Max Schulze; +Cc: johan, gregkh, linux-usb, linux-kernel
On Mon, Jan 07, 2019 at 08:31:49AM +0100, Max Schulze wrote:
> Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
> device
I rephrased the summary and comment above since you're adding a new
device id to an existing driver (rather than a new driver).
> T: Bus=02 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0cad ProdID=9016 Rev=24.16
> S: Manufacturer=Motorola Solutions, Inc.
> S: Product=TETRA PEI interface
> C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=usb_serial_simple
>
> Signed-off-by: Max Schulze <max.schulze@posteo.de>
> Tested-by: Max Schulze <max.schulze@posteo.de>
And no need to add Tested-by for your own patches; submissions are
always supposed to be tested.
Applied for -rc2.
Thanks,
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-07 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 7:31 [PATCH] USB: serial: simple: add Motorola Tetra driver for TPG2200 Max Schulze
2019-01-07 7:31 ` Max Schulze
2019-01-07 15:42 ` [PATCH] " Johan Hovold
2019-01-07 15:42 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.