* [U-Boot] [PATCH] lib: uuid: Do not enable UUID command SPL
@ 2019-01-07 20:23 Marek Vasut
2019-01-16 2:43 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2019-01-07 20:23 UTC (permalink / raw)
To: u-boot
The uuid command is only really useful in U-Boot, but it's useless in
SPL. Worse yet, it pulls in various environment manipulation functions
as it call env_set(). Do not compile the command in in SPL.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
---
lib/uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/uuid.c b/lib/uuid.c
index 5d5adf6b2d..fa20ee39fc 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -271,7 +271,7 @@ void gen_rand_uuid_str(char *uuid_str, int str_format)
uuid_bin_to_str(uuid_bin, uuid_str, str_format);
}
-#ifdef CONFIG_CMD_UUID
+#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_CMD_UUID)
int do_uuid(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
char uuid[UUID_STR_LEN + 1];
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] lib: uuid: Do not enable UUID command SPL
2019-01-07 20:23 [U-Boot] [PATCH] lib: uuid: Do not enable UUID command SPL Marek Vasut
@ 2019-01-16 2:43 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-01-16 2:43 UTC (permalink / raw)
To: u-boot
On Mon, Jan 07, 2019 at 09:23:38PM +0100, Marek Vasut wrote:
> The uuid command is only really useful in U-Boot, but it's useless in
> SPL. Worse yet, it pulls in various environment manipulation functions
> as it call env_set(). Do not compile the command in in SPL.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/6a667d1e/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 20:23 [U-Boot] [PATCH] lib: uuid: Do not enable UUID command SPL Marek Vasut
2019-01-16 2:43 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.