From: Venu Busireddy <venu.busireddy@oracle.com> To: Dongli Zhang <dongli.zhang@oracle.com> Cc: si-wei.liu@oracle.com, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, Sridhar Samudrala <sridhar.samudrala@intel.com>, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org Subject: Re: [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit. Date: Tue, 8 Jan 2019 11:25:22 -0600 [thread overview] Message-ID: <20190108172522.GA28457@troi> (raw) In-Reply-To: <6f5632f5-1469-7000-9b92-ef2564a63f63@oracle.com> On 2019-01-09 00:56:38 +0800, Dongli Zhang wrote: > I am not familiar with libvirt and I would like to play with this only with qemu. > > With failover, we need to hotplug the VF on destination server to VM after live > migration. However, the VF on destination server would have different mac address. > > How can we specify the mac for the new VF to hotplug via qemu, as VF is only a > vfio pci device? How is the VF device on the destination host any different from the VF on the source host? As you do on the source host, you first assign the MAC address of 00:00:00:00:00:00 to the VF. After the migration, you assign the same MAC address as that of the virtio_net device to the VF, and hotadd the VF device to the VM. And then, after you receive the FAILOVER_PRIMARY_CHANGED event, set the macvtap device to down state. Venu > > I am trying to play with this with only qemu (w/o libvirt). > > Thank you very much! > > Dongli Zhang > > On 01/08/2019 06:29 AM, Venu Busireddy wrote: > > From: Sridhar Samudrala <sridhar.samudrala@intel.com> > > > > This feature bit can be used by a hypervisor to indicate to the virtio_net > > device that it can act as a standby for another device with the same MAC > > address. > > > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > > Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com> > > --- > > hw/net/virtio-net.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index 385b1a0..411f8fb 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -2198,6 +2198,8 @@ static Property virtio_net_properties[] = { > > true), > > DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN), > > DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str), > > + DEFINE_PROP_BIT64("standby", VirtIONet, host_features, VIRTIO_NET_F_STANDBY, > > + false), > > DEFINE_PROP_END_OF_LIST(), > > }; > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Venu Busireddy <venu.busireddy@oracle.com> To: Dongli Zhang <dongli.zhang@oracle.com> Cc: si-wei.liu@oracle.com, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, Sridhar Samudrala <sridhar.samudrala@intel.com>, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org Subject: [virtio-dev] Re: [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit. Date: Tue, 8 Jan 2019 11:25:22 -0600 [thread overview] Message-ID: <20190108172522.GA28457@troi> (raw) In-Reply-To: <6f5632f5-1469-7000-9b92-ef2564a63f63@oracle.com> On 2019-01-09 00:56:38 +0800, Dongli Zhang wrote: > I am not familiar with libvirt and I would like to play with this only with qemu. > > With failover, we need to hotplug the VF on destination server to VM after live > migration. However, the VF on destination server would have different mac address. > > How can we specify the mac for the new VF to hotplug via qemu, as VF is only a > vfio pci device? How is the VF device on the destination host any different from the VF on the source host? As you do on the source host, you first assign the MAC address of 00:00:00:00:00:00 to the VF. After the migration, you assign the same MAC address as that of the virtio_net device to the VF, and hotadd the VF device to the VM. And then, after you receive the FAILOVER_PRIMARY_CHANGED event, set the macvtap device to down state. Venu > > I am trying to play with this with only qemu (w/o libvirt). > > Thank you very much! > > Dongli Zhang > > On 01/08/2019 06:29 AM, Venu Busireddy wrote: > > From: Sridhar Samudrala <sridhar.samudrala@intel.com> > > > > This feature bit can be used by a hypervisor to indicate to the virtio_net > > device that it can act as a standby for another device with the same MAC > > address. > > > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > > Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com> > > --- > > hw/net/virtio-net.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index 385b1a0..411f8fb 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -2198,6 +2198,8 @@ static Property virtio_net_properties[] = { > > true), > > DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN), > > DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str), > > + DEFINE_PROP_BIT64("standby", VirtIONet, host_features, VIRTIO_NET_F_STANDBY, > > + false), > > DEFINE_PROP_END_OF_LIST(), > > }; > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2019-01-08 17:25 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-07 22:29 [Qemu-devel] [PATCH v3 0/5] Support for datapath switching during live migration Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-07 22:29 ` [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-08 16:56 ` [Qemu-devel] " Dongli Zhang 2019-01-08 17:25 ` Venu Busireddy [this message] 2019-01-08 17:25 ` [virtio-dev] " Venu Busireddy 2019-01-09 0:14 ` Dongli Zhang 2019-01-09 0:18 ` Samudrala, Sridhar 2019-01-09 0:18 ` [virtio-dev] " Samudrala, Sridhar 2019-01-09 0:39 ` Dongli Zhang 2019-01-09 4:17 ` Michael S. Tsirkin 2019-01-09 4:17 ` [virtio-dev] " Michael S. Tsirkin 2019-01-07 22:29 ` [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-09 13:39 ` [Qemu-devel] " Cornelia Huck 2019-01-09 13:39 ` Cornelia Huck 2019-01-09 15:56 ` [Qemu-devel] " Michael S. Tsirkin 2019-01-09 15:56 ` [virtio-dev] " Michael S. Tsirkin 2019-01-11 2:09 ` [Qemu-devel] " si-wei liu 2019-01-11 2:09 ` [virtio-dev] " si-wei liu 2019-01-11 3:20 ` Michael S. Tsirkin 2019-01-11 3:20 ` [virtio-dev] " Michael S. Tsirkin 2019-01-11 7:09 ` [Qemu-devel] [virtio-dev] " si-wei liu 2019-01-11 7:09 ` [virtio-dev] Re: [Qemu-devel] " si-wei liu 2019-01-14 11:10 ` [Qemu-devel] [virtio-dev] " Roman Kagan 2019-01-07 22:29 ` [Qemu-devel] [PATCH v3 3/5] virtio_net: Add a query command for FAILOVER_STANDBY_CHANGED event Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-08 0:10 ` [Qemu-devel] " Michael S. Tsirkin 2019-01-08 0:10 ` [virtio-dev] " Michael S. Tsirkin 2019-01-07 22:29 ` [Qemu-devel] [PATCH v3 4/5] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-07 23:17 ` [Qemu-devel] " Alex Williamson 2019-01-07 23:22 ` Michael S. Tsirkin 2019-01-07 23:22 ` [virtio-dev] " Michael S. Tsirkin 2019-01-07 23:41 ` Alex Williamson 2019-01-08 0:12 ` Michael S. Tsirkin 2019-01-08 0:12 ` [virtio-dev] " Michael S. Tsirkin 2019-01-08 0:24 ` Alex Williamson 2019-01-08 0:43 ` Michael S. Tsirkin 2019-01-08 0:43 ` [virtio-dev] " Michael S. Tsirkin 2019-01-08 1:13 ` si-wei liu 2019-01-08 1:13 ` [virtio-dev] " si-wei liu 2019-01-07 22:29 ` [Qemu-devel] [PATCH v3 5/5] pci: query command extension to check the bus master enabling status of the failover-primary device Venu Busireddy 2019-01-07 22:29 ` [virtio-dev] " Venu Busireddy 2019-01-07 23:32 ` [Qemu-devel] [PATCH v3 0/5] Support for datapath switching during live migration Michael S. Tsirkin 2019-01-07 23:32 ` [virtio-dev] " Michael S. Tsirkin 2019-01-08 1:45 ` [Qemu-devel] " si-wei liu 2019-01-08 1:45 ` si-wei liu 2019-01-08 2:25 ` [Qemu-devel] " Michael S. Tsirkin 2019-01-08 2:25 ` Michael S. Tsirkin 2019-01-09 4:55 ` [Qemu-devel] " si-wei liu 2019-01-09 4:55 ` si-wei liu 2019-01-09 13:39 ` [Qemu-devel] " Michael S. Tsirkin 2019-01-09 13:39 ` Michael S. Tsirkin 2019-01-11 6:57 ` [Qemu-devel] " si-wei liu 2019-01-11 6:57 ` si-wei liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190108172522.GA28457@troi \ --to=venu.busireddy@oracle.com \ --cc=dongli.zhang@oracle.com \ --cc=marcel@redhat.com \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=si-wei.liu@oracle.com \ --cc=sridhar.samudrala@intel.com \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.