* [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware
@ 2019-01-08 10:11 Chris Wilson
2019-01-08 10:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (10 more replies)
0 siblings, 11 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 10:11 UTC (permalink / raw)
To: intel-gfx
If we haven't shipped and enabled firmware for a particular platform,
there is nothing the user can do about it. Don't scare the user with an
unactionable, unindentifiable warning!
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
<4> [310.769458] [drm] HuC: No firmware known for this platform!
Unify both GuC/HuC messages to include the device for which we lack the
firmware, and provide the platform name as an aide-memoire.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 +---
drivers/gpu/drm/i915/intel_huc_fw.c | 3 +--
drivers/gpu/drm/i915/intel_uc_fw.c | 8 ++++++++
drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++
4 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
index 4b437e05e2cd..b8364bd8ccf8 100644
--- a/drivers/gpu/drm/i915/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/intel_guc_fw.c
@@ -78,9 +78,7 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
guc_fw->major_ver_wanted = KBL_FW_MAJOR;
guc_fw->minor_ver_wanted = KBL_FW_MINOR;
} else {
- dev_info(dev_priv->drm.dev,
- "%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(guc_fw->type));
+ intel_uc_fw_unknown(dev_priv, guc_fw);
}
}
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c b/drivers/gpu/drm/i915/intel_huc_fw.c
index 9612227b3c44..ba584321554c 100644
--- a/drivers/gpu/drm/i915/intel_huc_fw.c
+++ b/drivers/gpu/drm/i915/intel_huc_fw.c
@@ -77,8 +77,7 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
} else {
- DRM_WARN("%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(huc_fw->type));
+ intel_uc_fw_unknown(dev_priv, huc_fw);
}
}
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
index fd496416087c..7673e3a3d237 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/intel_uc_fw.c
@@ -310,3 +310,11 @@ void intel_uc_fw_dump(const struct intel_uc_fw *uc_fw, struct drm_printer *p)
drm_printf(p, "\tRSA: offset %u, size %u\n",
uc_fw->rsa_offset, uc_fw->rsa_size);
}
+
+void intel_uc_fw_unknown(struct drm_i915_private *i915, struct intel_uc_fw *fw)
+{
+ dev_info(i915->drm.dev,
+ "%s: No firmware known for %s!\n",
+ intel_uc_fw_type_repr(fw->type),
+ intel_platform_name(INTEL_INFO(i915)->platform));
+}
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
index 0e3bd580e267..4367f3d28c41 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.h
+++ b/drivers/gpu/drm/i915/intel_uc_fw.h
@@ -150,4 +150,6 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw,
void intel_uc_fw_fini(struct intel_uc_fw *uc_fw);
void intel_uc_fw_dump(const struct intel_uc_fw *uc_fw, struct drm_printer *p);
+void intel_uc_fw_unknown(struct drm_i915_private *i915, struct intel_uc_fw *fw);
+
#endif
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
@ 2019-01-08 10:43 ` Patchwork
2019-01-08 11:02 ` ✓ Fi.CI.BAT: success " Patchwork
` (9 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 10:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware
URL : https://patchwork.freedesktop.org/series/54868/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
88f84f06d6cb drm/i915: Downgrade scare message for unknwown HuC firmware
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
total: 0 errors, 1 warnings, 0 checks, 36 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Downgrade scare message for unknwown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
2019-01-08 10:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-01-08 11:02 ` Patchwork
2019-01-08 12:48 ` [PATCH] " Michal Wajdeczko
` (8 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 11:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware
URL : https://patchwork.freedesktop.org/series/54868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5374 -> Patchwork_11209
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54868/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_11209 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: DMESG-WARN [fdo#102614] -> PASS
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y
Build changes
-------------
* Linux: CI_DRM_5374 -> Patchwork_11209
CI_DRM_5374: 660fdbea17392c943a65cd4a7196cd119c139df3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11209: 88f84f06d6cb1401ab8c9737943917eafe1596c2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
88f84f06d6cb drm/i915: Downgrade scare message for unknwown HuC firmware
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11209/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
2019-01-08 10:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-01-08 11:02 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-01-08 12:48 ` Michal Wajdeczko
2019-01-08 12:52 ` Chris Wilson
2019-01-08 12:56 ` [PATCH v2] drm/i915: Downgrade scare message for unknown " Chris Wilson
` (7 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Michal Wajdeczko @ 2019-01-08 12:48 UTC (permalink / raw)
To: intel-gfx, Chris Wilson
typo in title
On Tue, 08 Jan 2019 11:11:45 +0100, Chris Wilson
<chris@chris-wilson.co.uk> wrote:
> If we haven't shipped and enabled firmware for a particular platform,
> there is nothing the user can do about it. Don't scare the user with an
> unactionable, unindentifiable warning!
Did you mean: unidentifiable ?
>
> <6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this
> platform!
> <4> [310.769458] [drm] HuC: No firmware known for this platform!
>
> Unify both GuC/HuC messages to include the device for which we lack the
> firmware, and provide the platform name as an aide-memoire.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_guc_fw.c | 4 +---
> drivers/gpu/drm/i915/intel_huc_fw.c | 3 +--
> drivers/gpu/drm/i915/intel_uc_fw.c | 8 ++++++++
> drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++
> 4 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
> b/drivers/gpu/drm/i915/intel_guc_fw.c
> index 4b437e05e2cd..b8364bd8ccf8 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fw.c
> +++ b/drivers/gpu/drm/i915/intel_guc_fw.c
> @@ -78,9 +78,7 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
> guc_fw->major_ver_wanted = KBL_FW_MAJOR;
> guc_fw->minor_ver_wanted = KBL_FW_MINOR;
> } else {
> - dev_info(dev_priv->drm.dev,
> - "%s: No firmware known for this platform!\n",
> - intel_uc_fw_type_repr(guc_fw->type));
> + intel_uc_fw_unknown(dev_priv, guc_fw);
Maybe instead of adding extra function that have to be explicitly called,
just move message to intel_uc_fw_fetch() where we already check for fw
path:
if (!uc_fw->path) {
dev_info(i915->drm.dev,
"No %s firmware was defined for %s!\n",
intel_uc_fw_type_repr(uc_fw->type),
intel_platform_name(INTEL_INFO(i915)->platform));
return;
}
> }
> }
> diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c
> b/drivers/gpu/drm/i915/intel_huc_fw.c
> index 9612227b3c44..ba584321554c 100644
> --- a/drivers/gpu/drm/i915/intel_huc_fw.c
> +++ b/drivers/gpu/drm/i915/intel_huc_fw.c
> @@ -77,8 +77,7 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
> huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
> huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
> } else {
> - DRM_WARN("%s: No firmware known for this platform!\n",
> - intel_uc_fw_type_repr(huc_fw->type));
> + intel_uc_fw_unknown(dev_priv, huc_fw);
> }
> }
> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c
> b/drivers/gpu/drm/i915/intel_uc_fw.c
> index fd496416087c..7673e3a3d237 100644
> --- a/drivers/gpu/drm/i915/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/intel_uc_fw.c
> @@ -310,3 +310,11 @@ void intel_uc_fw_dump(const struct intel_uc_fw
> *uc_fw, struct drm_printer *p)
> drm_printf(p, "\tRSA: offset %u, size %u\n",
> uc_fw->rsa_offset, uc_fw->rsa_size);
> }
> +
> +void intel_uc_fw_unknown(struct drm_i915_private *i915, struct
> intel_uc_fw *fw)
> +{
> + dev_info(i915->drm.dev,
> + "%s: No firmware known for %s!\n",
[nitpick] Maybe
"No %s firmware known for %s!\n" or
"No %s firmware was defined for %s!\n"
to get nicer:
i915 0000:00:02.0: No GuC firmware known for XXX!
i915 0000:00:02.0: No GuC firmware was defined for XXX!
> + intel_uc_fw_type_repr(fw->type),
> + intel_platform_name(INTEL_INFO(i915)->platform));
> +}
> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h
> b/drivers/gpu/drm/i915/intel_uc_fw.h
> index 0e3bd580e267..4367f3d28c41 100644
> --- a/drivers/gpu/drm/i915/intel_uc_fw.h
> +++ b/drivers/gpu/drm/i915/intel_uc_fw.h
> @@ -150,4 +150,6 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw,
> void intel_uc_fw_fini(struct intel_uc_fw *uc_fw);
> void intel_uc_fw_dump(const struct intel_uc_fw *uc_fw, struct
> drm_printer *p);
> +void intel_uc_fw_unknown(struct drm_i915_private *i915, struct
> intel_uc_fw *fw);
> +
> #endif
Thanks,
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware
2019-01-08 12:48 ` [PATCH] " Michal Wajdeczko
@ 2019-01-08 12:52 ` Chris Wilson
0 siblings, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 12:52 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx
Quoting Michal Wajdeczko (2019-01-08 12:48:24)
> typo in title
>
> On Tue, 08 Jan 2019 11:11:45 +0100, Chris Wilson
> <chris@chris-wilson.co.uk> wrote:
>
> > If we haven't shipped and enabled firmware for a particular platform,
> > there is nothing the user can do about it. Don't scare the user with an
> > unactionable, unindentifiable warning!
>
> Did you mean: unidentifiable ?
Unindentable!
>
> >
> > <6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this
> > platform!
> > <4> [310.769458] [drm] HuC: No firmware known for this platform!
> >
> > Unify both GuC/HuC messages to include the device for which we lack the
> > firmware, and provide the platform name as an aide-memoire.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/i915/intel_guc_fw.c | 4 +---
> > drivers/gpu/drm/i915/intel_huc_fw.c | 3 +--
> > drivers/gpu/drm/i915/intel_uc_fw.c | 8 ++++++++
> > drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++
> > 4 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c
> > b/drivers/gpu/drm/i915/intel_guc_fw.c
> > index 4b437e05e2cd..b8364bd8ccf8 100644
> > --- a/drivers/gpu/drm/i915/intel_guc_fw.c
> > +++ b/drivers/gpu/drm/i915/intel_guc_fw.c
> > @@ -78,9 +78,7 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
> > guc_fw->major_ver_wanted = KBL_FW_MAJOR;
> > guc_fw->minor_ver_wanted = KBL_FW_MINOR;
> > } else {
> > - dev_info(dev_priv->drm.dev,
> > - "%s: No firmware known for this platform!\n",
> > - intel_uc_fw_type_repr(guc_fw->type));
> > + intel_uc_fw_unknown(dev_priv, guc_fw);
>
> Maybe instead of adding extra function that have to be explicitly called,
> just move message to intel_uc_fw_fetch() where we already check for fw
> path:
If that suits; I presumed there was something inherent with why it was
there :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (2 preceding siblings ...)
2019-01-08 12:48 ` [PATCH] " Michal Wajdeczko
@ 2019-01-08 12:56 ` Chris Wilson
2019-01-08 16:14 ` kbuild test robot
2019-01-08 17:30 ` kbuild test robot
2019-01-08 13:06 ` [PATCH v3] " Chris Wilson
` (6 subsequent siblings)
10 siblings, 2 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 12:56 UTC (permalink / raw)
To: intel-gfx
If we haven't shipped and enabled firmware for a particular platform,
there is nothing the user can do about it. Don't scare the user with an
unactionable, unidentifiable warning!
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
<4> [310.769458] [drm] HuC: No firmware known for this platform!
Unify both GuC/HuC messages to include the device for which we lack the
firmware, and provide the platform name as an aide-memoire.
v2: Move and refine the message to common site of intel_uc_fw_fetch.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ----
drivers/gpu/drm/i915/intel_huc_fw.c | 3 ---
drivers/gpu/drm/i915/intel_uc_fw.c | 11 ++++++++---
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
index 4b437e05e2cd..13ff7003c6be 100644
--- a/drivers/gpu/drm/i915/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/intel_guc_fw.c
@@ -77,10 +77,6 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
guc_fw->path = I915_KBL_GUC_UCODE;
guc_fw->major_ver_wanted = KBL_FW_MAJOR;
guc_fw->minor_ver_wanted = KBL_FW_MINOR;
- } else {
- dev_info(dev_priv->drm.dev,
- "%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(guc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c b/drivers/gpu/drm/i915/intel_huc_fw.c
index 9612227b3c44..7d7bfc7f7ca7 100644
--- a/drivers/gpu/drm/i915/intel_huc_fw.c
+++ b/drivers/gpu/drm/i915/intel_huc_fw.c
@@ -76,9 +76,6 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
huc_fw->path = I915_KBL_HUC_UCODE;
huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
- } else {
- DRM_WARN("%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(huc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
index fd496416087c..46a933db2eb6 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/intel_uc_fw.c
@@ -46,12 +46,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
size_t size;
int err;
+ if (!uc_fw->path) {
+ dev_info(i915->drm.dev,
+ "%s: No firmware was defined for %s!\n",
+ intel_uc_fw_type_repr(fw->type),
+ intel_platform_name(INTEL_INFO(i915)->platform));
+ return;
+ }
+
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
- if (!uc_fw->path)
- return;
-
uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type),
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (3 preceding siblings ...)
2019-01-08 12:56 ` [PATCH v2] drm/i915: Downgrade scare message for unknown " Chris Wilson
@ 2019-01-08 13:06 ` Chris Wilson
2019-01-08 14:19 ` Chris Wilson
2019-01-08 20:01 ` kbuild test robot
2019-01-08 14:16 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade scare message for unknwown HuC firmware (rev3) Patchwork
` (5 subsequent siblings)
10 siblings, 2 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 13:06 UTC (permalink / raw)
To: intel-gfx
If we haven't shipped and enabled firmware for a particular platform,
there is nothing the user can do about it. Don't scare the user with an
unactionable, unidentifiable warning!
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
<4> [310.769458] [drm] HuC: No firmware known for this platform!
Unify both GuC/HuC messages to include the device for which we lack the
firmware, and provide the platform name as an aide-memoire.
v2: Move and refine the message to common site of intel_uc_fw_fetch.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ----
drivers/gpu/drm/i915/intel_huc_fw.c | 3 ---
drivers/gpu/drm/i915/intel_uc_fw.c | 11 ++++++++---
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
index 4b437e05e2cd..13ff7003c6be 100644
--- a/drivers/gpu/drm/i915/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/intel_guc_fw.c
@@ -77,10 +77,6 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
guc_fw->path = I915_KBL_GUC_UCODE;
guc_fw->major_ver_wanted = KBL_FW_MAJOR;
guc_fw->minor_ver_wanted = KBL_FW_MINOR;
- } else {
- dev_info(dev_priv->drm.dev,
- "%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(guc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c b/drivers/gpu/drm/i915/intel_huc_fw.c
index 9612227b3c44..7d7bfc7f7ca7 100644
--- a/drivers/gpu/drm/i915/intel_huc_fw.c
+++ b/drivers/gpu/drm/i915/intel_huc_fw.c
@@ -76,9 +76,6 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
huc_fw->path = I915_KBL_HUC_UCODE;
huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
- } else {
- DRM_WARN("%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(huc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
index fd496416087c..ace8853e81b2 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/intel_uc_fw.c
@@ -46,12 +46,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
size_t size;
int err;
+ if (!uc_fw->path) {
+ dev_info(dev_priv->drm.dev,
+ "%s: No firmware was defined for %s!\n",
+ intel_uc_fw_type_repr(fw->type),
+ intel_platform_name(INTEL_INFO(dev_priv)->platform));
+ return;
+ }
+
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
- if (!uc_fw->path)
- return;
-
uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type),
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Downgrade scare message for unknwown HuC firmware (rev3)
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (4 preceding siblings ...)
2019-01-08 13:06 ` [PATCH v3] " Chris Wilson
@ 2019-01-08 14:16 ` Patchwork
2019-01-08 15:02 ` ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware Patchwork
` (4 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 14:16 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev3)
URL : https://patchwork.freedesktop.org/series/54868/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/intel_uc_fw.o
In file included from ./include/drm/drm_print.h:32:0,
from drivers/gpu/drm/i915/intel_uc_fw.c:26:
drivers/gpu/drm/i915/intel_uc_fw.c: In function ‘intel_uc_fw_fetch’:
drivers/gpu/drm/i915/intel_uc_fw.c:52:29: error: ‘const struct firmware’ has no member named ‘type’
intel_uc_fw_type_repr(fw->type),
^
./include/linux/device.h:1470:33: note: in definition of macro ‘dev_info’
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
scripts/Makefile.build:276: recipe for target 'drivers/gpu/drm/i915/intel_uc_fw.o' failed
make[4]: *** [drivers/gpu/drm/i915/intel_uc_fw.o] Error 1
scripts/Makefile.build:492: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:492: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:492: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1042: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 13:06 ` [PATCH v3] " Chris Wilson
@ 2019-01-08 14:19 ` Chris Wilson
2019-01-08 20:01 ` kbuild test robot
1 sibling, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 14:19 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2019-01-08 13:06:37)
> diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
> index fd496416087c..ace8853e81b2 100644
> --- a/drivers/gpu/drm/i915/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/intel_uc_fw.c
> @@ -46,12 +46,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
> size_t size;
> int err;
>
> + if (!uc_fw->path) {
> + dev_info(dev_priv->drm.dev,
> + "%s: No firmware was defined for %s!\n",
> + intel_uc_fw_type_repr(fw->type),
s/fw/uc_fw/
-Chris
> + intel_platform_name(INTEL_INFO(dev_priv)->platform));
> + return;
> + }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (5 preceding siblings ...)
2019-01-08 14:16 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade scare message for unknwown HuC firmware (rev3) Patchwork
@ 2019-01-08 15:02 ` Patchwork
2019-01-08 15:02 ` [PATCH v4] drm/i915: Downgrade scare message for unknown " Chris Wilson
` (3 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 15:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware
URL : https://patchwork.freedesktop.org/series/54868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5374_full -> Patchwork_11209_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_11209_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-iclb: PASS -> INCOMPLETE [fdo#107713]
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-skl: NOTRUN -> TIMEOUT [fdo#108039]
* igt@gem_userptr_blits@readonly-unsync:
- shard-skl: NOTRUN -> TIMEOUT [fdo#108887]
* igt@kms_atomic_transition@1x-modeset-transitions:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108470]
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +4
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +4
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_chv_cursor_fail@pipe-b-128x128-top-edge:
- shard-skl: NOTRUN -> FAIL [fdo#104671]
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-iclb: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-offscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#106509] / [fdo#107409]
* igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
- shard-skl: NOTRUN -> FAIL [fdo#103184]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107882]
* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-skl: NOTRUN -> FAIL [fdo#105683]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +3
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +2
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-panning-top-left-pipe-a-planes:
- shard-skl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +1
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +4
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-skl: NOTRUN -> FAIL [fdo#103166] / [fdo#107815]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> FAIL [fdo#100047]
* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]
* igt@pm_rpm@modeset-lpsp-stress-no-wait:
- shard-iclb: PASS -> DMESG-WARN [fdo#108654]
#### Possible fixes ####
* igt@kms_atomic_transition@plane-all-transition-fencing:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#109225] -> PASS
* igt@kms_busy@extended-modeset-hang-oldfb-render-c:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-iclb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS +1
* igt@kms_concurrent@pipe-b:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +15
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +3
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: FAIL [fdo#100368] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-iclb: DMESG-FAIL [fdo#107720] / [fdo#107724] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-iclb: FAIL [fdo#103167] -> PASS +8
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +5
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +10
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@pm_rps@min-max-config-loaded:
- shard-glk: FAIL [fdo#102250] -> PASS
#### Warnings ####
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> DMESG-FAIL [fdo#108950]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107720]: https://bugs.freedesktop.org/show_bug.cgi?id=107720
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108470]: https://bugs.freedesktop.org/show_bug.cgi?id=108470
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5374 -> Patchwork_11209
CI_DRM_5374: 660fdbea17392c943a65cd4a7196cd119c139df3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11209: 88f84f06d6cb1401ab8c9737943917eafe1596c2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11209/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (6 preceding siblings ...)
2019-01-08 15:02 ` ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware Patchwork
@ 2019-01-08 15:02 ` Chris Wilson
2019-01-08 22:33 ` Michal Wajdeczko
2019-01-08 15:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) Patchwork
` (2 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 15:02 UTC (permalink / raw)
To: intel-gfx
If we haven't shipped and enabled firmware for a particular platform,
there is nothing the user can do about it. Don't scare the user with an
unactionable, unidentifiable warning!
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
<4> [310.769458] [drm] HuC: No firmware known for this platform!
Unify both GuC/HuC messages to include the device for which we lack the
firmware, and provide the platform name as an aide-memoire.
v2: Move and refine the message to common site of intel_uc_fw_fetch.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/intel_guc_fw.c | 4 ----
drivers/gpu/drm/i915/intel_huc_fw.c | 3 ---
drivers/gpu/drm/i915/intel_uc_fw.c | 11 ++++++++---
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
index 4b437e05e2cd..13ff7003c6be 100644
--- a/drivers/gpu/drm/i915/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/intel_guc_fw.c
@@ -77,10 +77,6 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw)
guc_fw->path = I915_KBL_GUC_UCODE;
guc_fw->major_ver_wanted = KBL_FW_MAJOR;
guc_fw->minor_ver_wanted = KBL_FW_MINOR;
- } else {
- dev_info(dev_priv->drm.dev,
- "%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(guc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_huc_fw.c b/drivers/gpu/drm/i915/intel_huc_fw.c
index 9612227b3c44..7d7bfc7f7ca7 100644
--- a/drivers/gpu/drm/i915/intel_huc_fw.c
+++ b/drivers/gpu/drm/i915/intel_huc_fw.c
@@ -76,9 +76,6 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw)
huc_fw->path = I915_KBL_HUC_UCODE;
huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR;
huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR;
- } else {
- DRM_WARN("%s: No firmware known for this platform!\n",
- intel_uc_fw_type_repr(huc_fw->type));
}
}
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
index fd496416087c..becf05ebae4d 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/intel_uc_fw.c
@@ -46,12 +46,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
size_t size;
int err;
+ if (!uc_fw->path) {
+ dev_info(dev_priv->drm.dev,
+ "%s: No firmware was defined for %s!\n",
+ intel_uc_fw_type_repr(uc_fw->type),
+ intel_platform_name(INTEL_INFO(dev_priv)->platform));
+ return;
+ }
+
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
- if (!uc_fw->path)
- return;
-
uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
DRM_DEBUG_DRIVER("%s fw fetch %s\n",
intel_uc_fw_type_repr(uc_fw->type),
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 19+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (7 preceding siblings ...)
2019-01-08 15:02 ` [PATCH v4] drm/i915: Downgrade scare message for unknown " Chris Wilson
@ 2019-01-08 15:08 ` Patchwork
2019-01-08 15:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-08 22:45 ` ✓ Fi.CI.IGT: " Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 15:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
URL : https://patchwork.freedesktop.org/series/54868/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
010a74bc116c drm/i915: Downgrade scare message for unknown HuC firmware
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
<6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this platform!
total: 0 errors, 1 warnings, 0 checks, 39 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (8 preceding siblings ...)
2019-01-08 15:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) Patchwork
@ 2019-01-08 15:33 ` Patchwork
2019-01-08 22:45 ` ✓ Fi.CI.IGT: " Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 15:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
URL : https://patchwork.freedesktop.org/series/54868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11253
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54868/revisions/4/
Known issues
------------
Here are the changes found in Patchwork_11253 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-bsw-kefka: DMESG-WARN -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: DMESG-FAIL [fdo#109228] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS
* igt@kms_psr@sprite_plane_onoff:
- fi-skl-6700hq: FAIL [fdo#107383] -> PASS +3
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109228]: https://bugs.freedesktop.org/show_bug.cgi?id=109228
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
Participating hosts (48 -> 45)
------------------------------
Additional (1): fi-icl-y
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005
Build changes
-------------
* Linux: CI_DRM_5378 -> Patchwork_11253
CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11253: 010a74bc116c4fb15c1dd8682c2db0c4eab6645f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
010a74bc116c drm/i915: Downgrade scare message for unknown HuC firmware
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11253/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 12:56 ` [PATCH v2] drm/i915: Downgrade scare message for unknown " Chris Wilson
@ 2019-01-08 16:14 ` kbuild test robot
2019-01-08 17:30 ` kbuild test robot
1 sibling, 0 replies; 19+ messages in thread
From: kbuild test robot @ 2019-01-08 16:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8375 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.0-rc1 next-20190108]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Downgrade-scare-message-for-unknown-HuC-firmware/20190108-232025
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x073-201901 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/drm/drm_print.h:32:0,
from drivers/gpu//drm/i915/intel_uc_fw.c:26:
drivers/gpu//drm/i915/intel_uc_fw.c: In function 'intel_uc_fw_fetch':
>> drivers/gpu//drm/i915/intel_uc_fw.c:50:12: error: 'i915' undeclared (first use in this function); did you mean 'to_i915'?
dev_info(i915->drm.dev,
^
include/linux/device.h:1469:12: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/gpu//drm/i915/intel_uc_fw.c:50:12: note: each undeclared identifier is reported only once for each function it appears in
dev_info(i915->drm.dev,
^
include/linux/device.h:1469:12: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
>> drivers/gpu//drm/i915/intel_uc_fw.c:52:29: error: 'const struct firmware' has no member named 'type'
intel_uc_fw_type_repr(fw->type),
^
include/linux/device.h:1469:33: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
vim +50 drivers/gpu//drm/i915/intel_uc_fw.c
> 26 #include <drm/drm_print.h>
27
28 #include "intel_uc_fw.h"
29 #include "i915_drv.h"
30
31 /**
32 * intel_uc_fw_fetch - fetch uC firmware
33 *
34 * @dev_priv: device private
35 * @uc_fw: uC firmware
36 *
37 * Fetch uC firmware into GEM obj.
38 */
39 void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
40 struct intel_uc_fw *uc_fw)
41 {
42 struct pci_dev *pdev = dev_priv->drm.pdev;
43 struct drm_i915_gem_object *obj;
44 const struct firmware *fw = NULL;
45 struct uc_css_header *css;
46 size_t size;
47 int err;
48
49 if (!uc_fw->path) {
> 50 dev_info(i915->drm.dev,
51 "%s: No firmware was defined for %s!\n",
> 52 intel_uc_fw_type_repr(fw->type),
53 intel_platform_name(INTEL_INFO(i915)->platform));
54 return;
55 }
56
57 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
58 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
59
60 uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
61 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
62 intel_uc_fw_type_repr(uc_fw->type),
63 intel_uc_fw_status_repr(uc_fw->fetch_status));
64
65 err = request_firmware(&fw, uc_fw->path, &pdev->dev);
66 if (err) {
67 DRM_DEBUG_DRIVER("%s fw request_firmware err=%d\n",
68 intel_uc_fw_type_repr(uc_fw->type), err);
69 goto fail;
70 }
71
72 DRM_DEBUG_DRIVER("%s fw size %zu ptr %p\n",
73 intel_uc_fw_type_repr(uc_fw->type), fw->size, fw);
74
75 /* Check the size of the blob before examining buffer contents */
76 if (fw->size < sizeof(struct uc_css_header)) {
77 DRM_WARN("%s: Unexpected firmware size (%zu, min %zu)\n",
78 intel_uc_fw_type_repr(uc_fw->type),
79 fw->size, sizeof(struct uc_css_header));
80 err = -ENODATA;
81 goto fail;
82 }
83
84 css = (struct uc_css_header *)fw->data;
85
86 /* Firmware bits always start from header */
87 uc_fw->header_offset = 0;
88 uc_fw->header_size = (css->header_size_dw - css->modulus_size_dw -
89 css->key_size_dw - css->exponent_size_dw) *
90 sizeof(u32);
91
92 if (uc_fw->header_size != sizeof(struct uc_css_header)) {
93 DRM_WARN("%s: Mismatched firmware header definition\n",
94 intel_uc_fw_type_repr(uc_fw->type));
95 err = -ENOEXEC;
96 goto fail;
97 }
98
99 /* then, uCode */
100 uc_fw->ucode_offset = uc_fw->header_offset + uc_fw->header_size;
101 uc_fw->ucode_size = (css->size_dw - css->header_size_dw) * sizeof(u32);
102
103 /* now RSA */
104 if (css->key_size_dw != UOS_RSA_SCRATCH_COUNT) {
105 DRM_WARN("%s: Mismatched firmware RSA key size (%u)\n",
106 intel_uc_fw_type_repr(uc_fw->type), css->key_size_dw);
107 err = -ENOEXEC;
108 goto fail;
109 }
110 uc_fw->rsa_offset = uc_fw->ucode_offset + uc_fw->ucode_size;
111 uc_fw->rsa_size = css->key_size_dw * sizeof(u32);
112
113 /* At least, it should have header, uCode and RSA. Size of all three. */
114 size = uc_fw->header_size + uc_fw->ucode_size + uc_fw->rsa_size;
115 if (fw->size < size) {
116 DRM_WARN("%s: Truncated firmware (%zu, expected %zu)\n",
117 intel_uc_fw_type_repr(uc_fw->type), fw->size, size);
118 err = -ENOEXEC;
119 goto fail;
120 }
121
122 /*
123 * The GuC firmware image has the version number embedded at a
124 * well-known offset within the firmware blob; note that major / minor
125 * version are TWO bytes each (i.e. u16), although all pointers and
126 * offsets are defined in terms of bytes (u8).
127 */
128 switch (uc_fw->type) {
129 case INTEL_UC_FW_TYPE_GUC:
130 uc_fw->major_ver_found = css->guc.sw_version >> 16;
131 uc_fw->minor_ver_found = css->guc.sw_version & 0xFFFF;
132 break;
133
134 case INTEL_UC_FW_TYPE_HUC:
135 uc_fw->major_ver_found = css->huc.sw_version >> 16;
136 uc_fw->minor_ver_found = css->huc.sw_version & 0xFFFF;
137 break;
138
139 default:
140 MISSING_CASE(uc_fw->type);
141 break;
142 }
143
144 DRM_DEBUG_DRIVER("%s fw version %u.%u (wanted %u.%u)\n",
145 intel_uc_fw_type_repr(uc_fw->type),
146 uc_fw->major_ver_found, uc_fw->minor_ver_found,
147 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
148
149 if (uc_fw->major_ver_wanted == 0 && uc_fw->minor_ver_wanted == 0) {
150 DRM_NOTE("%s: Skipping firmware version check\n",
151 intel_uc_fw_type_repr(uc_fw->type));
152 } else if (uc_fw->major_ver_found != uc_fw->major_ver_wanted ||
153 uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) {
154 DRM_NOTE("%s: Wrong firmware version (%u.%u, required %u.%u)\n",
155 intel_uc_fw_type_repr(uc_fw->type),
156 uc_fw->major_ver_found, uc_fw->minor_ver_found,
157 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
158 err = -ENOEXEC;
159 goto fail;
160 }
161
162 obj = i915_gem_object_create_from_data(dev_priv, fw->data, fw->size);
163 if (IS_ERR(obj)) {
164 err = PTR_ERR(obj);
165 DRM_DEBUG_DRIVER("%s fw object_create err=%d\n",
166 intel_uc_fw_type_repr(uc_fw->type), err);
167 goto fail;
168 }
169
170 uc_fw->obj = obj;
171 uc_fw->size = fw->size;
172 uc_fw->fetch_status = INTEL_UC_FIRMWARE_SUCCESS;
173 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
174 intel_uc_fw_type_repr(uc_fw->type),
175 intel_uc_fw_status_repr(uc_fw->fetch_status));
176
177 release_firmware(fw);
178 return;
179
180 fail:
181 uc_fw->fetch_status = INTEL_UC_FIRMWARE_FAIL;
182 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
183 intel_uc_fw_type_repr(uc_fw->type),
184 intel_uc_fw_status_repr(uc_fw->fetch_status));
185
186 DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
187 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
188 DRM_INFO("%s: Firmware can be downloaded from %s\n",
189 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
190
191 release_firmware(fw); /* OK even if fw is NULL */
192 }
193
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35235 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 12:56 ` [PATCH v2] drm/i915: Downgrade scare message for unknown " Chris Wilson
2019-01-08 16:14 ` kbuild test robot
@ 2019-01-08 17:30 ` kbuild test robot
1 sibling, 0 replies; 19+ messages in thread
From: kbuild test robot @ 2019-01-08 17:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8358 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.0-rc1 next-20190108]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Downgrade-scare-message-for-unknown-HuC-firmware/20190108-232025
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-s3-201901 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/drm/drm_print.h:32:0,
from drivers/gpu/drm/i915/intel_uc_fw.c:26:
drivers/gpu/drm/i915/intel_uc_fw.c: In function 'intel_uc_fw_fetch':
>> drivers/gpu/drm/i915/intel_uc_fw.c:50:12: error: 'i915' undeclared (first use in this function)
dev_info(i915->drm.dev,
^
include/linux/device.h:1469:12: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/gpu/drm/i915/intel_uc_fw.c:50:12: note: each undeclared identifier is reported only once for each function it appears in
dev_info(i915->drm.dev,
^
include/linux/device.h:1469:12: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/gpu/drm/i915/intel_uc_fw.c:52:29: error: 'const struct firmware' has no member named 'type'
intel_uc_fw_type_repr(fw->type),
^
include/linux/device.h:1469:33: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
vim +/i915 +50 drivers/gpu/drm/i915/intel_uc_fw.c
> 26 #include <drm/drm_print.h>
27
28 #include "intel_uc_fw.h"
29 #include "i915_drv.h"
30
31 /**
32 * intel_uc_fw_fetch - fetch uC firmware
33 *
34 * @dev_priv: device private
35 * @uc_fw: uC firmware
36 *
37 * Fetch uC firmware into GEM obj.
38 */
39 void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
40 struct intel_uc_fw *uc_fw)
41 {
42 struct pci_dev *pdev = dev_priv->drm.pdev;
43 struct drm_i915_gem_object *obj;
44 const struct firmware *fw = NULL;
45 struct uc_css_header *css;
46 size_t size;
47 int err;
48
49 if (!uc_fw->path) {
> 50 dev_info(i915->drm.dev,
51 "%s: No firmware was defined for %s!\n",
52 intel_uc_fw_type_repr(fw->type),
53 intel_platform_name(INTEL_INFO(i915)->platform));
54 return;
55 }
56
57 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
58 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
59
60 uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
61 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
62 intel_uc_fw_type_repr(uc_fw->type),
63 intel_uc_fw_status_repr(uc_fw->fetch_status));
64
65 err = request_firmware(&fw, uc_fw->path, &pdev->dev);
66 if (err) {
67 DRM_DEBUG_DRIVER("%s fw request_firmware err=%d\n",
68 intel_uc_fw_type_repr(uc_fw->type), err);
69 goto fail;
70 }
71
72 DRM_DEBUG_DRIVER("%s fw size %zu ptr %p\n",
73 intel_uc_fw_type_repr(uc_fw->type), fw->size, fw);
74
75 /* Check the size of the blob before examining buffer contents */
76 if (fw->size < sizeof(struct uc_css_header)) {
77 DRM_WARN("%s: Unexpected firmware size (%zu, min %zu)\n",
78 intel_uc_fw_type_repr(uc_fw->type),
79 fw->size, sizeof(struct uc_css_header));
80 err = -ENODATA;
81 goto fail;
82 }
83
84 css = (struct uc_css_header *)fw->data;
85
86 /* Firmware bits always start from header */
87 uc_fw->header_offset = 0;
88 uc_fw->header_size = (css->header_size_dw - css->modulus_size_dw -
89 css->key_size_dw - css->exponent_size_dw) *
90 sizeof(u32);
91
92 if (uc_fw->header_size != sizeof(struct uc_css_header)) {
93 DRM_WARN("%s: Mismatched firmware header definition\n",
94 intel_uc_fw_type_repr(uc_fw->type));
95 err = -ENOEXEC;
96 goto fail;
97 }
98
99 /* then, uCode */
100 uc_fw->ucode_offset = uc_fw->header_offset + uc_fw->header_size;
101 uc_fw->ucode_size = (css->size_dw - css->header_size_dw) * sizeof(u32);
102
103 /* now RSA */
104 if (css->key_size_dw != UOS_RSA_SCRATCH_COUNT) {
105 DRM_WARN("%s: Mismatched firmware RSA key size (%u)\n",
106 intel_uc_fw_type_repr(uc_fw->type), css->key_size_dw);
107 err = -ENOEXEC;
108 goto fail;
109 }
110 uc_fw->rsa_offset = uc_fw->ucode_offset + uc_fw->ucode_size;
111 uc_fw->rsa_size = css->key_size_dw * sizeof(u32);
112
113 /* At least, it should have header, uCode and RSA. Size of all three. */
114 size = uc_fw->header_size + uc_fw->ucode_size + uc_fw->rsa_size;
115 if (fw->size < size) {
116 DRM_WARN("%s: Truncated firmware (%zu, expected %zu)\n",
117 intel_uc_fw_type_repr(uc_fw->type), fw->size, size);
118 err = -ENOEXEC;
119 goto fail;
120 }
121
122 /*
123 * The GuC firmware image has the version number embedded at a
124 * well-known offset within the firmware blob; note that major / minor
125 * version are TWO bytes each (i.e. u16), although all pointers and
126 * offsets are defined in terms of bytes (u8).
127 */
128 switch (uc_fw->type) {
129 case INTEL_UC_FW_TYPE_GUC:
130 uc_fw->major_ver_found = css->guc.sw_version >> 16;
131 uc_fw->minor_ver_found = css->guc.sw_version & 0xFFFF;
132 break;
133
134 case INTEL_UC_FW_TYPE_HUC:
135 uc_fw->major_ver_found = css->huc.sw_version >> 16;
136 uc_fw->minor_ver_found = css->huc.sw_version & 0xFFFF;
137 break;
138
139 default:
140 MISSING_CASE(uc_fw->type);
141 break;
142 }
143
144 DRM_DEBUG_DRIVER("%s fw version %u.%u (wanted %u.%u)\n",
145 intel_uc_fw_type_repr(uc_fw->type),
146 uc_fw->major_ver_found, uc_fw->minor_ver_found,
147 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
148
149 if (uc_fw->major_ver_wanted == 0 && uc_fw->minor_ver_wanted == 0) {
150 DRM_NOTE("%s: Skipping firmware version check\n",
151 intel_uc_fw_type_repr(uc_fw->type));
152 } else if (uc_fw->major_ver_found != uc_fw->major_ver_wanted ||
153 uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) {
154 DRM_NOTE("%s: Wrong firmware version (%u.%u, required %u.%u)\n",
155 intel_uc_fw_type_repr(uc_fw->type),
156 uc_fw->major_ver_found, uc_fw->minor_ver_found,
157 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
158 err = -ENOEXEC;
159 goto fail;
160 }
161
162 obj = i915_gem_object_create_from_data(dev_priv, fw->data, fw->size);
163 if (IS_ERR(obj)) {
164 err = PTR_ERR(obj);
165 DRM_DEBUG_DRIVER("%s fw object_create err=%d\n",
166 intel_uc_fw_type_repr(uc_fw->type), err);
167 goto fail;
168 }
169
170 uc_fw->obj = obj;
171 uc_fw->size = fw->size;
172 uc_fw->fetch_status = INTEL_UC_FIRMWARE_SUCCESS;
173 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
174 intel_uc_fw_type_repr(uc_fw->type),
175 intel_uc_fw_status_repr(uc_fw->fetch_status));
176
177 release_firmware(fw);
178 return;
179
180 fail:
181 uc_fw->fetch_status = INTEL_UC_FIRMWARE_FAIL;
182 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
183 intel_uc_fw_type_repr(uc_fw->type),
184 intel_uc_fw_status_repr(uc_fw->fetch_status));
185
186 DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
187 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
188 DRM_INFO("%s: Firmware can be downloaded from %s\n",
189 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
190
191 release_firmware(fw); /* OK even if fw is NULL */
192 }
193
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33185 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 13:06 ` [PATCH v3] " Chris Wilson
2019-01-08 14:19 ` Chris Wilson
@ 2019-01-08 20:01 ` kbuild test robot
1 sibling, 0 replies; 19+ messages in thread
From: kbuild test robot @ 2019-01-08 20:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 7737 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.0-rc1 next-20190108]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Downgrade-scare-message-for-unknown-HuC-firmware/20190109-020625
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel-7.2-clear (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from include/drm/drm_print.h:32:0,
from drivers/gpu/drm/i915/intel_uc_fw.c:26:
drivers/gpu/drm/i915/intel_uc_fw.c: In function 'intel_uc_fw_fetch':
>> drivers/gpu/drm/i915/intel_uc_fw.c:52:29: error: 'const struct firmware' has no member named 'type'
intel_uc_fw_type_repr(fw->type),
^
include/linux/device.h:1469:33: note: in definition of macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
vim +52 drivers/gpu/drm/i915/intel_uc_fw.c
> 26 #include <drm/drm_print.h>
27
28 #include "intel_uc_fw.h"
29 #include "i915_drv.h"
30
31 /**
32 * intel_uc_fw_fetch - fetch uC firmware
33 *
34 * @dev_priv: device private
35 * @uc_fw: uC firmware
36 *
37 * Fetch uC firmware into GEM obj.
38 */
39 void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
40 struct intel_uc_fw *uc_fw)
41 {
42 struct pci_dev *pdev = dev_priv->drm.pdev;
43 struct drm_i915_gem_object *obj;
44 const struct firmware *fw = NULL;
45 struct uc_css_header *css;
46 size_t size;
47 int err;
48
49 if (!uc_fw->path) {
50 dev_info(dev_priv->drm.dev,
51 "%s: No firmware was defined for %s!\n",
> 52 intel_uc_fw_type_repr(fw->type),
53 intel_platform_name(INTEL_INFO(dev_priv)->platform));
54 return;
55 }
56
57 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
58 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
59
60 uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
61 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
62 intel_uc_fw_type_repr(uc_fw->type),
63 intel_uc_fw_status_repr(uc_fw->fetch_status));
64
65 err = request_firmware(&fw, uc_fw->path, &pdev->dev);
66 if (err) {
67 DRM_DEBUG_DRIVER("%s fw request_firmware err=%d\n",
68 intel_uc_fw_type_repr(uc_fw->type), err);
69 goto fail;
70 }
71
72 DRM_DEBUG_DRIVER("%s fw size %zu ptr %p\n",
73 intel_uc_fw_type_repr(uc_fw->type), fw->size, fw);
74
75 /* Check the size of the blob before examining buffer contents */
76 if (fw->size < sizeof(struct uc_css_header)) {
77 DRM_WARN("%s: Unexpected firmware size (%zu, min %zu)\n",
78 intel_uc_fw_type_repr(uc_fw->type),
79 fw->size, sizeof(struct uc_css_header));
80 err = -ENODATA;
81 goto fail;
82 }
83
84 css = (struct uc_css_header *)fw->data;
85
86 /* Firmware bits always start from header */
87 uc_fw->header_offset = 0;
88 uc_fw->header_size = (css->header_size_dw - css->modulus_size_dw -
89 css->key_size_dw - css->exponent_size_dw) *
90 sizeof(u32);
91
92 if (uc_fw->header_size != sizeof(struct uc_css_header)) {
93 DRM_WARN("%s: Mismatched firmware header definition\n",
94 intel_uc_fw_type_repr(uc_fw->type));
95 err = -ENOEXEC;
96 goto fail;
97 }
98
99 /* then, uCode */
100 uc_fw->ucode_offset = uc_fw->header_offset + uc_fw->header_size;
101 uc_fw->ucode_size = (css->size_dw - css->header_size_dw) * sizeof(u32);
102
103 /* now RSA */
104 if (css->key_size_dw != UOS_RSA_SCRATCH_COUNT) {
105 DRM_WARN("%s: Mismatched firmware RSA key size (%u)\n",
106 intel_uc_fw_type_repr(uc_fw->type), css->key_size_dw);
107 err = -ENOEXEC;
108 goto fail;
109 }
110 uc_fw->rsa_offset = uc_fw->ucode_offset + uc_fw->ucode_size;
111 uc_fw->rsa_size = css->key_size_dw * sizeof(u32);
112
113 /* At least, it should have header, uCode and RSA. Size of all three. */
114 size = uc_fw->header_size + uc_fw->ucode_size + uc_fw->rsa_size;
115 if (fw->size < size) {
116 DRM_WARN("%s: Truncated firmware (%zu, expected %zu)\n",
117 intel_uc_fw_type_repr(uc_fw->type), fw->size, size);
118 err = -ENOEXEC;
119 goto fail;
120 }
121
122 /*
123 * The GuC firmware image has the version number embedded at a
124 * well-known offset within the firmware blob; note that major / minor
125 * version are TWO bytes each (i.e. u16), although all pointers and
126 * offsets are defined in terms of bytes (u8).
127 */
128 switch (uc_fw->type) {
129 case INTEL_UC_FW_TYPE_GUC:
130 uc_fw->major_ver_found = css->guc.sw_version >> 16;
131 uc_fw->minor_ver_found = css->guc.sw_version & 0xFFFF;
132 break;
133
134 case INTEL_UC_FW_TYPE_HUC:
135 uc_fw->major_ver_found = css->huc.sw_version >> 16;
136 uc_fw->minor_ver_found = css->huc.sw_version & 0xFFFF;
137 break;
138
139 default:
140 MISSING_CASE(uc_fw->type);
141 break;
142 }
143
144 DRM_DEBUG_DRIVER("%s fw version %u.%u (wanted %u.%u)\n",
145 intel_uc_fw_type_repr(uc_fw->type),
146 uc_fw->major_ver_found, uc_fw->minor_ver_found,
147 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
148
149 if (uc_fw->major_ver_wanted == 0 && uc_fw->minor_ver_wanted == 0) {
150 DRM_NOTE("%s: Skipping firmware version check\n",
151 intel_uc_fw_type_repr(uc_fw->type));
152 } else if (uc_fw->major_ver_found != uc_fw->major_ver_wanted ||
153 uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) {
154 DRM_NOTE("%s: Wrong firmware version (%u.%u, required %u.%u)\n",
155 intel_uc_fw_type_repr(uc_fw->type),
156 uc_fw->major_ver_found, uc_fw->minor_ver_found,
157 uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
158 err = -ENOEXEC;
159 goto fail;
160 }
161
162 obj = i915_gem_object_create_from_data(dev_priv, fw->data, fw->size);
163 if (IS_ERR(obj)) {
164 err = PTR_ERR(obj);
165 DRM_DEBUG_DRIVER("%s fw object_create err=%d\n",
166 intel_uc_fw_type_repr(uc_fw->type), err);
167 goto fail;
168 }
169
170 uc_fw->obj = obj;
171 uc_fw->size = fw->size;
172 uc_fw->fetch_status = INTEL_UC_FIRMWARE_SUCCESS;
173 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
174 intel_uc_fw_type_repr(uc_fw->type),
175 intel_uc_fw_status_repr(uc_fw->fetch_status));
176
177 release_firmware(fw);
178 return;
179
180 fail:
181 uc_fw->fetch_status = INTEL_UC_FIRMWARE_FAIL;
182 DRM_DEBUG_DRIVER("%s fw fetch %s\n",
183 intel_uc_fw_type_repr(uc_fw->type),
184 intel_uc_fw_status_repr(uc_fw->fetch_status));
185
186 DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
187 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
188 DRM_INFO("%s: Firmware can be downloaded from %s\n",
189 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
190
191 release_firmware(fw); /* OK even if fw is NULL */
192 }
193
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41533 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 15:02 ` [PATCH v4] drm/i915: Downgrade scare message for unknown " Chris Wilson
@ 2019-01-08 22:33 ` Michal Wajdeczko
2019-01-08 22:54 ` Chris Wilson
0 siblings, 1 reply; 19+ messages in thread
From: Michal Wajdeczko @ 2019-01-08 22:33 UTC (permalink / raw)
To: intel-gfx, Chris Wilson
On Tue, 08 Jan 2019 16:02:46 +0100, Chris Wilson
<chris@chris-wilson.co.uk> wrote:
> If we haven't shipped and enabled firmware for a particular platform,
> there is nothing the user can do about it. Don't scare the user with an
> unactionable, unidentifiable warning!
>
> <6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this
> platform!
> <4> [310.769458] [drm] HuC: No firmware known for this platform!
>
> Unify both GuC/HuC messages to include the device for which we lack the
> firmware, and provide the platform name as an aide-memoire.
>
> v2: Move and refine the message to common site of intel_uc_fw_fetch.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Thanks,
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
` (9 preceding siblings ...)
2019-01-08 15:33 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-01-08 22:45 ` Patchwork
10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-01-08 22:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Downgrade scare message for unknwown HuC firmware (rev4)
URL : https://patchwork.freedesktop.org/series/54868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11253_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_11253_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-skl: NOTRUN -> TIMEOUT [fdo#108039]
* igt@kms_atomic@plane_primary_legacy:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +8
* igt@kms_atomic_transition@1x-modeset-transitions-fencing:
- shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108470]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +3
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_chv_cursor_fail@pipe-b-64x64-left-edge:
- shard-skl: NOTRUN -> FAIL [fdo#104671]
* igt@kms_color@pipe-a-ctm-0-5:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +3
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +5
* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +3
* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-iclb: PASS -> FAIL [fdo#105683] / [fdo#108040]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- shard-skl: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
- shard-skl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-iclb: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-kbl: NOTRUN -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-iclb: PASS -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@pm_rpm@modeset-lpsp-stress-no-wait:
- shard-iclb: PASS -> INCOMPLETE [fdo#108840]
* igt@pm_rpm@universal-planes:
- shard-iclb: PASS -> DMESG-WARN [fdo#108654] / [fdo#108756]
* igt@sw_sync@sync_busy_fork:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
#### Possible fixes ####
* igt@i915_selftest@live_workarounds:
- shard-iclb: DMESG-FAIL [fdo#108954] -> PASS
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-skl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +2
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
- shard-skl: FAIL [fdo#103184] -> PASS
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: WARN [fdo#108336] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: DMESG-FAIL [fdo#107720] / [fdo#107724] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-iclb: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +7
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-skl: FAIL [fdo#103167] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-iclb: DMESG-FAIL [fdo#103166] / [fdo#107724] -> PASS
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@perf_pmu@event-wait-rcs0:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +15
* igt@pm_rpm@modeset-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
* igt@pm_rpm@modeset-stress-extra-wait:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS
* igt@pm_rps@min-max-config-loaded:
- shard-apl: FAIL [fdo#102250] -> PASS
#### Warnings ####
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#107725]
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#108134]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-iclb: FAIL [fdo#103166] -> DMESG-WARN [fdo#107724] / [fdo#108336]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107720]: https://bugs.freedesktop.org/show_bug.cgi?id=107720
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108470]: https://bugs.freedesktop.org/show_bug.cgi?id=108470
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5378 -> Patchwork_11253
CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11253: 010a74bc116c4fb15c1dd8682c2db0c4eab6645f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11253/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v4] drm/i915: Downgrade scare message for unknown HuC firmware
2019-01-08 22:33 ` Michal Wajdeczko
@ 2019-01-08 22:54 ` Chris Wilson
0 siblings, 0 replies; 19+ messages in thread
From: Chris Wilson @ 2019-01-08 22:54 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx
Quoting Michal Wajdeczko (2019-01-08 22:33:18)
> On Tue, 08 Jan 2019 16:02:46 +0100, Chris Wilson
> <chris@chris-wilson.co.uk> wrote:
>
> > If we haven't shipped and enabled firmware for a particular platform,
> > there is nothing the user can do about it. Don't scare the user with an
> > unactionable, unidentifiable warning!
> >
> > <6> [310.769452] i915 0000:00:02.0: GuC: No firmware known for this
> > platform!
> > <4> [310.769458] [drm] HuC: No firmware known for this platform!
> >
> > Unify both GuC/HuC messages to include the device for which we lack the
> > firmware, and provide the platform name as an aide-memoire.
> >
> > v2: Move and refine the message to common site of intel_uc_fw_fetch.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > ---
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Ta, fwiw this brings us one step closer to turning off dmesg filtering
ala https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2194/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-01-08 22:54 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 10:11 [PATCH] drm/i915: Downgrade scare message for unknwown HuC firmware Chris Wilson
2019-01-08 10:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-01-08 11:02 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-08 12:48 ` [PATCH] " Michal Wajdeczko
2019-01-08 12:52 ` Chris Wilson
2019-01-08 12:56 ` [PATCH v2] drm/i915: Downgrade scare message for unknown " Chris Wilson
2019-01-08 16:14 ` kbuild test robot
2019-01-08 17:30 ` kbuild test robot
2019-01-08 13:06 ` [PATCH v3] " Chris Wilson
2019-01-08 14:19 ` Chris Wilson
2019-01-08 20:01 ` kbuild test robot
2019-01-08 14:16 ` ✗ Fi.CI.BAT: failure for drm/i915: Downgrade scare message for unknwown HuC firmware (rev3) Patchwork
2019-01-08 15:02 ` ✓ Fi.CI.IGT: success for drm/i915: Downgrade scare message for unknwown HuC firmware Patchwork
2019-01-08 15:02 ` [PATCH v4] drm/i915: Downgrade scare message for unknown " Chris Wilson
2019-01-08 22:33 ` Michal Wajdeczko
2019-01-08 22:54 ` Chris Wilson
2019-01-08 15:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Downgrade scare message for unknwown HuC firmware (rev4) Patchwork
2019-01-08 15:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-08 22:45 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.