* [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration @ 2019-01-08 14:50 ` Chris Wilson 0 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2019-01-08 14:50 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev Currently blt-vs-render runs for a fixed loop count, and exceeds 360s on a slow Skylake-y. It really doesn't tell us anything useful about low likelihood events after the first few seconds it takes to fill memory, so limit it to 30s (and hope that repeated runs in CI is enough to exercise the even rarer corner cases). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108039 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/i915/gem_ppgtt.c | 55 ++++++++++++++++++++++++++++++------------ 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c index c2e4ca679..11ca31e74 100644 --- a/tests/i915/gem_ppgtt.c +++ b/tests/i915/gem_ppgtt.c @@ -85,7 +85,9 @@ static void scratch_buf_fini(struct igt_buf *buf) memset(buf, 0, sizeof(*buf)); } -static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned flags) +static void fork_rcs_copy(int timeout, uint32_t final, + drm_intel_bo **dst, int count, + unsigned flags) #define CREATE_CONTEXT 0x1 { igt_render_copyfunc_t render_copy; @@ -117,6 +119,8 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl igt_fork(child, count) { struct intel_batchbuffer *batch; struct igt_buf buf = {}; + struct igt_buf src; + unsigned long i; batch = intel_batchbuffer_alloc(dst[child]->bufmgr, devid); @@ -135,23 +139,29 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl buf.size = SIZE; buf.bpp = 32; - for (int i = 0; i <= target; i++) { - struct igt_buf src; - + i = 0; + igt_until_timeout(timeout) { scratch_buf_init(&src, dst[child]->bufmgr, - i | child << 16); - + i++ | child << 16); render_copy(batch, NULL, &src, 0, 0, WIDTH, HEIGHT, &buf, 0, 0); - scratch_buf_fini(&src); } + + scratch_buf_init(&src, dst[child]->bufmgr, + final | child << 16); + render_copy(batch, NULL, + &src, 0, 0, + WIDTH, HEIGHT, + &buf, 0, 0); + scratch_buf_fini(&src); } } -static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) +static void fork_bcs_copy(int timeout, uint32_t final, + drm_intel_bo **dst, int count) { int devid; @@ -169,18 +179,20 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) igt_fork(child, count) { struct intel_batchbuffer *batch; + drm_intel_bo *src[2]; + unsigned long i; + batch = intel_batchbuffer_alloc(dst[child]->bufmgr, devid); igt_assert(batch); - for (int i = 0; i <= target; i++) { - drm_intel_bo *src[2]; - + i = 0; + igt_until_timeout(timeout) { src[0] = create_bo(dst[child]->bufmgr, ~0); src[1] = create_bo(dst[child]->bufmgr, - i | child << 16); + i++ | child << 16); intel_copy_bo(batch, src[0], src[1], SIZE); intel_copy_bo(batch, dst[child], src[0], SIZE); @@ -188,6 +200,17 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) drm_intel_bo_unreference(src[1]); drm_intel_bo_unreference(src[0]); } + + src[0] = create_bo(dst[child]->bufmgr, + ~0); + src[1] = create_bo(dst[child]->bufmgr, + final | child << 16); + + intel_copy_bo(batch, src[0], src[1], SIZE); + intel_copy_bo(batch, dst[child], src[0], SIZE); + + drm_intel_bo_unreference(src[1]); + drm_intel_bo_unreference(src[0]); } } @@ -314,8 +337,8 @@ int main(int argc, char **argv) igt_subtest("blt-vs-render-ctx0") { drm_intel_bo *bcs[1], *rcs[N_CHILD]; - fork_bcs_copy(0x4000, bcs, 1); - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, 0); + fork_bcs_copy(30, 0x4000, bcs, 1); + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, 0); igt_waitchildren(); @@ -326,8 +349,8 @@ int main(int argc, char **argv) igt_subtest("blt-vs-render-ctxN") { drm_intel_bo *bcs[1], *rcs[N_CHILD]; - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); - fork_bcs_copy(0x4000, bcs, 1); + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); + fork_bcs_copy(30, 0x4000, bcs, 1); igt_waitchildren(); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration @ 2019-01-08 14:50 ` Chris Wilson 0 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2019-01-08 14:50 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev Currently blt-vs-render runs for a fixed loop count, and exceeds 360s on a slow Skylake-y. It really doesn't tell us anything useful about low likelihood events after the first few seconds it takes to fill memory, so limit it to 30s (and hope that repeated runs in CI is enough to exercise the even rarer corner cases). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108039 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/i915/gem_ppgtt.c | 55 ++++++++++++++++++++++++++++++------------ 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c index c2e4ca679..11ca31e74 100644 --- a/tests/i915/gem_ppgtt.c +++ b/tests/i915/gem_ppgtt.c @@ -85,7 +85,9 @@ static void scratch_buf_fini(struct igt_buf *buf) memset(buf, 0, sizeof(*buf)); } -static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned flags) +static void fork_rcs_copy(int timeout, uint32_t final, + drm_intel_bo **dst, int count, + unsigned flags) #define CREATE_CONTEXT 0x1 { igt_render_copyfunc_t render_copy; @@ -117,6 +119,8 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl igt_fork(child, count) { struct intel_batchbuffer *batch; struct igt_buf buf = {}; + struct igt_buf src; + unsigned long i; batch = intel_batchbuffer_alloc(dst[child]->bufmgr, devid); @@ -135,23 +139,29 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl buf.size = SIZE; buf.bpp = 32; - for (int i = 0; i <= target; i++) { - struct igt_buf src; - + i = 0; + igt_until_timeout(timeout) { scratch_buf_init(&src, dst[child]->bufmgr, - i | child << 16); - + i++ | child << 16); render_copy(batch, NULL, &src, 0, 0, WIDTH, HEIGHT, &buf, 0, 0); - scratch_buf_fini(&src); } + + scratch_buf_init(&src, dst[child]->bufmgr, + final | child << 16); + render_copy(batch, NULL, + &src, 0, 0, + WIDTH, HEIGHT, + &buf, 0, 0); + scratch_buf_fini(&src); } } -static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) +static void fork_bcs_copy(int timeout, uint32_t final, + drm_intel_bo **dst, int count) { int devid; @@ -169,18 +179,20 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) igt_fork(child, count) { struct intel_batchbuffer *batch; + drm_intel_bo *src[2]; + unsigned long i; + batch = intel_batchbuffer_alloc(dst[child]->bufmgr, devid); igt_assert(batch); - for (int i = 0; i <= target; i++) { - drm_intel_bo *src[2]; - + i = 0; + igt_until_timeout(timeout) { src[0] = create_bo(dst[child]->bufmgr, ~0); src[1] = create_bo(dst[child]->bufmgr, - i | child << 16); + i++ | child << 16); intel_copy_bo(batch, src[0], src[1], SIZE); intel_copy_bo(batch, dst[child], src[0], SIZE); @@ -188,6 +200,17 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) drm_intel_bo_unreference(src[1]); drm_intel_bo_unreference(src[0]); } + + src[0] = create_bo(dst[child]->bufmgr, + ~0); + src[1] = create_bo(dst[child]->bufmgr, + final | child << 16); + + intel_copy_bo(batch, src[0], src[1], SIZE); + intel_copy_bo(batch, dst[child], src[0], SIZE); + + drm_intel_bo_unreference(src[1]); + drm_intel_bo_unreference(src[0]); } } @@ -314,8 +337,8 @@ int main(int argc, char **argv) igt_subtest("blt-vs-render-ctx0") { drm_intel_bo *bcs[1], *rcs[N_CHILD]; - fork_bcs_copy(0x4000, bcs, 1); - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, 0); + fork_bcs_copy(30, 0x4000, bcs, 1); + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, 0); igt_waitchildren(); @@ -326,8 +349,8 @@ int main(int argc, char **argv) igt_subtest("blt-vs-render-ctxN") { drm_intel_bo *bcs[1], *rcs[N_CHILD]; - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); - fork_bcs_copy(0x4000, bcs, 1); + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); + fork_bcs_copy(30, 0x4000, bcs, 1); igt_waitchildren(); -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_ppgtt: Convert stress test to run for a fixed duration 2019-01-08 14:50 ` [igt-dev] " Chris Wilson (?) @ 2019-01-08 15:01 ` Patchwork -1 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-01-08 15:01 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_ppgtt: Convert stress test to run for a fixed duration URL : https://patchwork.freedesktop.org/series/54885/ State : failure == Summary == Patch is empty. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_ppgtt: Convert stress test to run for a fixed duration (rev2) 2019-01-08 14:50 ` [igt-dev] " Chris Wilson (?) (?) @ 2019-01-08 16:15 ` Patchwork -1 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-01-08 16:15 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_ppgtt: Convert stress test to run for a fixed duration (rev2) URL : https://patchwork.freedesktop.org/series/54885/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378 -> IGTPW_2200 ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_2200 need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_2200, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/54885/revisions/2/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_2200: ### IGT changes ### #### Warnings #### * igt@kms_busy@basic-flip-a: - fi-kbl-7567u: PASS -> SKIP +2 Known issues ------------ Here are the changes found in IGTPW_2200 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-compute: - fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094] * igt@amdgpu/amd_prime@amd-to-i915: - fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341] * igt@debugfs_test@read_all_entries: - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] * igt@gem_exec_suspend@basic-s3: - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] +3 * igt@kms_chamelium@hdmi-edid-read: - fi-kbl-7567u: PASS -> FAIL [fdo#108767] +2 * igt@kms_flip@basic-flip-vs-modeset: - fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998] #### Possible fixes #### * igt@amdgpu/amd_basic@userptr: - fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS * igt@gem_exec_suspend@basic-s4-devices: - fi-bsw-kefka: DMESG-WARN -> PASS - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS * igt@i915_selftest@live_hangcheck: - fi-apl-guc: DMESG-FAIL [fdo#109228] -> PASS * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7567u: DMESG-WARN [fdo#108473] -> PASS * igt@kms_frontbuffer_tracking@basic: - fi-byt-clapper: FAIL [fdo#103167] -> PASS * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS * igt@kms_psr@sprite_plane_onoff: - fi-skl-6700hq: FAIL [fdo#107383] -> PASS +3 {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998 [fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094 [fdo#108473]: https://bugs.freedesktop.org/show_bug.cgi?id=108473 [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767 [fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915 [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965 [fdo#109228]: https://bugs.freedesktop.org/show_bug.cgi?id=109228 [fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241 Participating hosts (48 -> 45) ------------------------------ Additional (1): fi-icl-y Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005 Build changes ------------- * IGT: IGT_4756 -> IGTPW_2200 CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2200: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2200/ IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2200/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_ppgtt: Convert stress test to run for a fixed duration (rev2) 2019-01-08 14:50 ` [igt-dev] " Chris Wilson ` (2 preceding siblings ...) (?) @ 2019-01-08 23:31 ` Patchwork -1 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2019-01-08 23:31 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_ppgtt: Convert stress test to run for a fixed duration (rev2) URL : https://patchwork.freedesktop.org/series/54885/ State : success == Summary == CI Bug Log - changes from CI_DRM_5378_full -> IGTPW_2200_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_2200_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_2200_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/54885/revisions/2/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_2200_full: ### IGT changes ### #### Warnings #### * igt@pm_rc6_residency@rc6-accuracy: - shard-snb: SKIP -> PASS Known issues ------------ Here are the changes found in IGTPW_2200_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_available_modes_crc@available_mode_test_crc: - shard-snb: NOTRUN -> FAIL [fdo#106641] * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a: - shard-snb: NOTRUN -> DMESG-WARN [fdo#107956] - shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956] * igt@kms_cursor_crc@cursor-128x128-random: - shard-apl: PASS -> FAIL [fdo#103232] +5 * igt@kms_cursor_crc@cursor-64x64-dpms: - shard-kbl: PASS -> FAIL [fdo#103232] +2 * igt@kms_cursor_crc@cursor-64x64-sliding: - shard-glk: PASS -> FAIL [fdo#103232] +2 * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: PASS -> FAIL [fdo#105363] * igt@kms_flip@basic-plain-flip: - shard-hsw: PASS -> DMESG-WARN [fdo#102614] * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render: - shard-apl: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: - shard-glk: PASS -> FAIL [fdo#103167] +6 * igt@kms_plane@pixel-format-pipe-c-planes: - shard-apl: PASS -> FAIL [fdo#103166] +2 - shard-glk: PASS -> FAIL [fdo#103166] +1 * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +3 * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-glk: PASS -> FAIL [fdo#108145] * igt@kms_setmode@basic: - shard-kbl: NOTRUN -> FAIL [fdo#99912] #### Possible fixes #### * igt@kms_available_modes_crc@available_mode_test_crc: - shard-apl: FAIL [fdo#106641] -> PASS * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b: - shard-kbl: DMESG-WARN [fdo#107956] -> PASS * igt@kms_color@pipe-c-legacy-gamma: - shard-apl: FAIL [fdo#104782] -> PASS * igt@kms_cursor_crc@cursor-128x128-suspend: - shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1 * igt@kms_cursor_crc@cursor-256x85-random: - shard-apl: FAIL [fdo#103232] -> PASS +2 * igt@kms_cursor_crc@cursor-256x85-sliding: - shard-glk: FAIL [fdo#103232] -> PASS +2 * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: - shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: - shard-apl: FAIL [fdo#103167] -> PASS +1 * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc: - shard-glk: FAIL [fdo#103167] -> PASS +1 * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-glk: FAIL [fdo#108145] -> PASS * igt@kms_plane_multiple@atomic-pipe-c-tiling-x: - shard-glk: FAIL [fdo#103166] -> PASS +3 * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: - shard-apl: FAIL [fdo#103166] -> PASS +2 - shard-kbl: FAIL [fdo#103166] -> PASS * igt@kms_setmode@basic: - shard-hsw: FAIL [fdo#99912] -> PASS * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-kbl: INCOMPLETE [fdo#103665] -> PASS * igt@pm_rps@min-max-config-loaded: - shard-apl: FAIL [fdo#102250] -> PASS - shard-glk: FAIL [fdo#102250] -> PASS #### Warnings #### * igt@kms_rotation_crc@multiplane-rotation-cropping-top: - shard-kbl: DMESG-FAIL [fdo#108950] -> DMESG-WARN [fdo#105604] {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250 [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604 [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509 [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641 [fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469 [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784 [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950 [fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 5) ------------------------------ Missing (2): shard-skl shard-iclb Build changes ------------- * IGT: IGT_4756 -> IGTPW_2200 * Piglit: piglit_4509 -> None CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2200: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2200/ IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2200/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration 2019-01-08 14:50 ` [igt-dev] " Chris Wilson @ 2019-01-11 13:40 ` Tvrtko Ursulin -1 siblings, 0 replies; 7+ messages in thread From: Tvrtko Ursulin @ 2019-01-11 13:40 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 08/01/2019 14:50, Chris Wilson wrote: > Currently blt-vs-render runs for a fixed loop count, and exceeds 360s > on a slow Skylake-y. It really doesn't tell us anything useful about low > likelihood events after the first few seconds it takes to fill memory, > so limit it to 30s (and hope that repeated runs in CI is enough to > exercise the even rarer corner cases). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108039 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ppgtt.c | 55 ++++++++++++++++++++++++++++++------------ > 1 file changed, 39 insertions(+), 16 deletions(-) > > diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c > index c2e4ca679..11ca31e74 100644 > --- a/tests/i915/gem_ppgtt.c > +++ b/tests/i915/gem_ppgtt.c > @@ -85,7 +85,9 @@ static void scratch_buf_fini(struct igt_buf *buf) > memset(buf, 0, sizeof(*buf)); > } > > -static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned flags) > +static void fork_rcs_copy(int timeout, uint32_t final, > + drm_intel_bo **dst, int count, > + unsigned flags) > #define CREATE_CONTEXT 0x1 > { > igt_render_copyfunc_t render_copy; > @@ -117,6 +119,8 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl > igt_fork(child, count) { > struct intel_batchbuffer *batch; > struct igt_buf buf = {}; > + struct igt_buf src; > + unsigned long i; > > batch = intel_batchbuffer_alloc(dst[child]->bufmgr, > devid); > @@ -135,23 +139,29 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl > buf.size = SIZE; > buf.bpp = 32; > > - for (int i = 0; i <= target; i++) { > - struct igt_buf src; > - > + i = 0; > + igt_until_timeout(timeout) { > scratch_buf_init(&src, dst[child]->bufmgr, > - i | child << 16); > - > + i++ | child << 16); > render_copy(batch, NULL, > &src, 0, 0, > WIDTH, HEIGHT, > &buf, 0, 0); > - > scratch_buf_fini(&src); > } > + > + scratch_buf_init(&src, dst[child]->bufmgr, > + final | child << 16); > + render_copy(batch, NULL, > + &src, 0, 0, > + WIDTH, HEIGHT, > + &buf, 0, 0); > + scratch_buf_fini(&src); > } > } > > -static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > +static void fork_bcs_copy(int timeout, uint32_t final, > + drm_intel_bo **dst, int count) > { > int devid; > > @@ -169,18 +179,20 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > > igt_fork(child, count) { > struct intel_batchbuffer *batch; > + drm_intel_bo *src[2]; > + unsigned long i; > + > > batch = intel_batchbuffer_alloc(dst[child]->bufmgr, > devid); > igt_assert(batch); > > - for (int i = 0; i <= target; i++) { > - drm_intel_bo *src[2]; > - > + i = 0; > + igt_until_timeout(timeout) { > src[0] = create_bo(dst[child]->bufmgr, > ~0); > src[1] = create_bo(dst[child]->bufmgr, > - i | child << 16); > + i++ | child << 16); > > intel_copy_bo(batch, src[0], src[1], SIZE); > intel_copy_bo(batch, dst[child], src[0], SIZE); > @@ -188,6 +200,17 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > drm_intel_bo_unreference(src[1]); > drm_intel_bo_unreference(src[0]); > } > + > + src[0] = create_bo(dst[child]->bufmgr, > + ~0); > + src[1] = create_bo(dst[child]->bufmgr, > + final | child << 16); > + > + intel_copy_bo(batch, src[0], src[1], SIZE); > + intel_copy_bo(batch, dst[child], src[0], SIZE); > + > + drm_intel_bo_unreference(src[1]); > + drm_intel_bo_unreference(src[0]); > } > } > > @@ -314,8 +337,8 @@ int main(int argc, char **argv) > igt_subtest("blt-vs-render-ctx0") { > drm_intel_bo *bcs[1], *rcs[N_CHILD]; > > - fork_bcs_copy(0x4000, bcs, 1); > - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, 0); > + fork_bcs_copy(30, 0x4000, bcs, 1); > + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, 0); > > igt_waitchildren(); > > @@ -326,8 +349,8 @@ int main(int argc, char **argv) > igt_subtest("blt-vs-render-ctxN") { > drm_intel_bo *bcs[1], *rcs[N_CHILD]; > > - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); > - fork_bcs_copy(0x4000, bcs, 1); > + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); > + fork_bcs_copy(30, 0x4000, bcs, 1); > > igt_waitchildren(); > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration @ 2019-01-11 13:40 ` Tvrtko Ursulin 0 siblings, 0 replies; 7+ messages in thread From: Tvrtko Ursulin @ 2019-01-11 13:40 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 08/01/2019 14:50, Chris Wilson wrote: > Currently blt-vs-render runs for a fixed loop count, and exceeds 360s > on a slow Skylake-y. It really doesn't tell us anything useful about low > likelihood events after the first few seconds it takes to fill memory, > so limit it to 30s (and hope that repeated runs in CI is enough to > exercise the even rarer corner cases). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108039 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ppgtt.c | 55 ++++++++++++++++++++++++++++++------------ > 1 file changed, 39 insertions(+), 16 deletions(-) > > diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c > index c2e4ca679..11ca31e74 100644 > --- a/tests/i915/gem_ppgtt.c > +++ b/tests/i915/gem_ppgtt.c > @@ -85,7 +85,9 @@ static void scratch_buf_fini(struct igt_buf *buf) > memset(buf, 0, sizeof(*buf)); > } > > -static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned flags) > +static void fork_rcs_copy(int timeout, uint32_t final, > + drm_intel_bo **dst, int count, > + unsigned flags) > #define CREATE_CONTEXT 0x1 > { > igt_render_copyfunc_t render_copy; > @@ -117,6 +119,8 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl > igt_fork(child, count) { > struct intel_batchbuffer *batch; > struct igt_buf buf = {}; > + struct igt_buf src; > + unsigned long i; > > batch = intel_batchbuffer_alloc(dst[child]->bufmgr, > devid); > @@ -135,23 +139,29 @@ static void fork_rcs_copy(int target, drm_intel_bo **dst, int count, unsigned fl > buf.size = SIZE; > buf.bpp = 32; > > - for (int i = 0; i <= target; i++) { > - struct igt_buf src; > - > + i = 0; > + igt_until_timeout(timeout) { > scratch_buf_init(&src, dst[child]->bufmgr, > - i | child << 16); > - > + i++ | child << 16); > render_copy(batch, NULL, > &src, 0, 0, > WIDTH, HEIGHT, > &buf, 0, 0); > - > scratch_buf_fini(&src); > } > + > + scratch_buf_init(&src, dst[child]->bufmgr, > + final | child << 16); > + render_copy(batch, NULL, > + &src, 0, 0, > + WIDTH, HEIGHT, > + &buf, 0, 0); > + scratch_buf_fini(&src); > } > } > > -static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > +static void fork_bcs_copy(int timeout, uint32_t final, > + drm_intel_bo **dst, int count) > { > int devid; > > @@ -169,18 +179,20 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > > igt_fork(child, count) { > struct intel_batchbuffer *batch; > + drm_intel_bo *src[2]; > + unsigned long i; > + > > batch = intel_batchbuffer_alloc(dst[child]->bufmgr, > devid); > igt_assert(batch); > > - for (int i = 0; i <= target; i++) { > - drm_intel_bo *src[2]; > - > + i = 0; > + igt_until_timeout(timeout) { > src[0] = create_bo(dst[child]->bufmgr, > ~0); > src[1] = create_bo(dst[child]->bufmgr, > - i | child << 16); > + i++ | child << 16); > > intel_copy_bo(batch, src[0], src[1], SIZE); > intel_copy_bo(batch, dst[child], src[0], SIZE); > @@ -188,6 +200,17 @@ static void fork_bcs_copy(int target, drm_intel_bo **dst, int count) > drm_intel_bo_unreference(src[1]); > drm_intel_bo_unreference(src[0]); > } > + > + src[0] = create_bo(dst[child]->bufmgr, > + ~0); > + src[1] = create_bo(dst[child]->bufmgr, > + final | child << 16); > + > + intel_copy_bo(batch, src[0], src[1], SIZE); > + intel_copy_bo(batch, dst[child], src[0], SIZE); > + > + drm_intel_bo_unreference(src[1]); > + drm_intel_bo_unreference(src[0]); > } > } > > @@ -314,8 +337,8 @@ int main(int argc, char **argv) > igt_subtest("blt-vs-render-ctx0") { > drm_intel_bo *bcs[1], *rcs[N_CHILD]; > > - fork_bcs_copy(0x4000, bcs, 1); > - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, 0); > + fork_bcs_copy(30, 0x4000, bcs, 1); > + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, 0); > > igt_waitchildren(); > > @@ -326,8 +349,8 @@ int main(int argc, char **argv) > igt_subtest("blt-vs-render-ctxN") { > drm_intel_bo *bcs[1], *rcs[N_CHILD]; > > - fork_rcs_copy(0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); > - fork_bcs_copy(0x4000, bcs, 1); > + fork_rcs_copy(30, 0x8000 / N_CHILD, rcs, N_CHILD, CREATE_CONTEXT); > + fork_bcs_copy(30, 0x4000, bcs, 1); > > igt_waitchildren(); > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-11 13:40 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-01-08 14:50 [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration Chris Wilson 2019-01-08 14:50 ` [igt-dev] " Chris Wilson 2019-01-08 15:01 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2019-01-08 16:15 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_ppgtt: Convert stress test to run for a fixed duration (rev2) Patchwork 2019-01-08 23:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-01-11 13:40 ` [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Convert stress test to run for a fixed duration Tvrtko Ursulin 2019-01-11 13:40 ` Tvrtko Ursulin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.