From: Pankaj Gupta <pagupta@redhat.com> To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Cc: jack@suse.cz, stefanha@redhat.com, dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com, kwolf@redhat.com, pbonzini@redhat.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, david@redhat.com, jmoyer@redhat.com, xiaoguangrong.eric@gmail.com, hch@infradead.org, mst@redhat.com, jasowang@redhat.com, lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com, willy@infradead.org, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, rjw@rjwysocki.net, pagupta@redhat.com Subject: [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Date: Wed, 9 Jan 2019 20:17:35 +0530 [thread overview] Message-ID: <20190109144736.17452-5-pagupta@redhat.com> (raw) In-Reply-To: <20190109144736.17452-1-pagupta@redhat.com> Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta <pagupta@redhat.com> --- fs/ext4/file.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 69d65d4..e54f48b 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -360,8 +360,10 @@ static const struct vm_operations_struct ext4_file_vm_ops = { static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) { struct inode *inode = file->f_mapping->host; + struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); + struct dax_device *dax_dev = sbi->s_daxdev; - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) + if (unlikely(ext4_forced_shutdown(sbi))) return -EIO; /* @@ -371,6 +373,13 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC)) return -EOPNOTSUPP; + /* We don't support synchronous mappings with guest direct access + * and virtio based host page cache flush mechanism. + */ + if (IS_DAX(file_inode(file)) && virtio_pmem_host_cache_enabled(dax_dev) + && (vma->vm_flags & VM_SYNC)) + return -EOPNOTSUPP; + file_accessed(file); if (IS_DAX(file_inode(file))) { vma->vm_ops = &ext4_dax_vm_ops; -- 2.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com> To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Cc: jack@suse.cz, stefanha@redhat.com, dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com, kwolf@redhat.com, pbonzini@redhat.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, david@redhat.com, jmoyer@redhat.com, xiaoguangrong.eric@gmail.com, hch@infradead.org, mst@redhat.com, jasowang@redhat.com, lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com, willy@infradead.org, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, rjw@rjwysocki.net, pagupta@redhat.com Subject: [Qemu-devel] [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Date: Wed, 9 Jan 2019 20:17:35 +0530 [thread overview] Message-ID: <20190109144736.17452-5-pagupta@redhat.com> (raw) In-Reply-To: <20190109144736.17452-1-pagupta@redhat.com> Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta <pagupta@redhat.com> --- fs/ext4/file.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 69d65d4..e54f48b 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -360,8 +360,10 @@ static const struct vm_operations_struct ext4_file_vm_ops = { static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) { struct inode *inode = file->f_mapping->host; + struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); + struct dax_device *dax_dev = sbi->s_daxdev; - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) + if (unlikely(ext4_forced_shutdown(sbi))) return -EIO; /* @@ -371,6 +373,13 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC)) return -EOPNOTSUPP; + /* We don't support synchronous mappings with guest direct access + * and virtio based host page cache flush mechanism. + */ + if (IS_DAX(file_inode(file)) && virtio_pmem_host_cache_enabled(dax_dev) + && (vma->vm_flags & VM_SYNC)) + return -EOPNOTSUPP; + file_accessed(file); if (IS_DAX(file_inode(file))) { vma->vm_ops = &ext4_dax_vm_ops; -- 2.9.3
next prev parent reply other threads:[~2019-01-09 14:47 UTC|newest] Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-09 14:47 [PATCH v3 0/5] kvm "virtio pmem" device Pankaj Gupta 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` [PATCH v3 1/5] libnvdimm: nd_region flush callback support Pankaj Gupta 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` Pankaj Gupta 2019-01-09 14:47 ` [PATCH v3 2/5] virtio-pmem: Add virtio pmem driver Pankaj Gupta 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` Pankaj Gupta 2019-01-14 15:54 ` Michael S. Tsirkin 2019-01-14 15:54 ` [Qemu-devel] " Michael S. Tsirkin [not found] ` <20190114105314-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2019-01-15 6:33 ` Pankaj Gupta 2019-01-15 6:33 ` [Qemu-devel] " Pankaj Gupta 2019-01-15 6:33 ` Pankaj Gupta 2019-01-15 6:33 ` Pankaj Gupta 2019-01-14 15:54 ` Michael S. Tsirkin 2019-01-09 14:47 ` [PATCH v3 3/5] libnvdimm: add nd_region buffered dax_dev flag Pankaj Gupta 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` Pankaj Gupta 2019-01-09 14:47 ` [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Pankaj Gupta 2019-01-09 14:47 ` Pankaj Gupta [this message] 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` [PATCH v3 5/5] xfs: " Pankaj Gupta 2019-01-09 14:47 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 14:47 ` Pankaj Gupta 2019-01-09 16:26 ` Darrick J. Wong [not found] ` <20190109144736.17452-6-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-09 16:26 ` Darrick J. Wong 2019-01-09 16:26 ` [Qemu-devel] " Darrick J. Wong 2019-01-09 16:26 ` Darrick J. Wong 2019-01-09 18:08 ` Pankaj Gupta 2019-01-09 18:08 ` [Qemu-devel] " Pankaj Gupta 2019-01-09 18:08 ` Pankaj Gupta 2019-01-09 18:08 ` Pankaj Gupta 2019-01-10 1:26 ` [PATCH v3 0/5] kvm "virtio pmem" device Dave Chinner [not found] ` <20190109144736.17452-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-10 1:26 ` Dave Chinner 2019-01-10 1:26 ` [Qemu-devel] " Dave Chinner 2019-01-10 1:26 ` Dave Chinner 2019-01-10 2:40 ` Rik van Riel 2019-01-10 2:40 ` [Qemu-devel] " Rik van Riel 2019-01-10 10:17 ` Jan Kara 2019-01-10 10:17 ` Jan Kara 2019-01-10 10:17 ` [Qemu-devel] " Jan Kara 2019-01-10 10:17 ` Jan Kara [not found] ` <20190110101757.GC15790-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> 2019-01-13 1:38 ` Pankaj Gupta 2019-01-13 1:38 ` [Qemu-devel] " Pankaj Gupta 2019-01-13 1:38 ` Pankaj Gupta [not found] ` <1354249849.63357171.1547343519970.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-13 1:43 ` Dan Williams 2019-01-13 1:43 ` [Qemu-devel] " Dan Williams 2019-01-13 1:43 ` Dan Williams [not found] ` <CAPcyv4hwcgTUpgNCefCGu4DvgkYBp5b=f+hJ+FC=s5APYKoycg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-01-13 2:17 ` [Qemu-devel] " Pankaj Gupta 2019-01-13 2:17 ` Pankaj Gupta 2019-01-13 2:17 ` Pankaj Gupta [not found] ` <540171952.63371441.1547345866585.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-14 9:55 ` Jan Kara 2019-01-14 9:55 ` Jan Kara 2019-01-14 9:55 ` Jan Kara [not found] ` <20190114095520.GC13316-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> 2019-01-14 10:16 ` Pankaj Gupta 2019-01-14 10:16 ` Pankaj Gupta 2019-01-14 10:16 ` Pankaj Gupta 2019-01-14 9:55 ` Jan Kara 2019-01-13 2:17 ` Pankaj Gupta 2019-01-13 1:43 ` Dan Williams 2019-01-13 1:38 ` Pankaj Gupta 2019-01-11 7:45 ` Pankaj Gupta 2019-01-11 7:45 ` Pankaj Gupta 2019-01-11 7:45 ` [Qemu-devel] " Pankaj Gupta 2019-01-11 7:45 ` Pankaj Gupta 2019-01-11 7:45 ` Pankaj Gupta 2019-01-13 23:29 ` Dave Chinner [not found] ` <1326478078.61913951.1547192704870.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-13 23:29 ` Dave Chinner 2019-01-13 23:29 ` [Qemu-devel] " Dave Chinner 2019-01-13 23:29 ` Dave Chinner 2019-01-13 23:38 ` Matthew Wilcox 2019-01-13 23:38 ` Matthew Wilcox 2019-01-13 23:38 ` [Qemu-devel] " Matthew Wilcox 2019-01-13 23:38 ` Matthew Wilcox 2019-01-14 2:50 ` Dave Chinner [not found] ` <20190113233820.GX6310-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> 2019-01-14 2:50 ` Dave Chinner 2019-01-14 2:50 ` [Qemu-devel] " Dave Chinner 2019-01-14 2:50 ` Dave Chinner 2019-01-14 7:15 ` Pankaj Gupta 2019-01-14 7:15 ` [Qemu-devel] " Pankaj Gupta 2019-01-14 7:15 ` Pankaj Gupta 2019-01-14 21:25 ` Dave Chinner [not found] ` <942065073.64011540.1547450140670.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-14 21:25 ` Dave Chinner 2019-01-14 21:25 ` [Qemu-devel] " Dave Chinner 2019-01-14 21:25 ` Dave Chinner 2019-01-14 21:35 ` Dan Williams 2019-01-14 21:35 ` Dan Williams 2019-01-14 21:35 ` [Qemu-devel] " Dan Williams 2019-01-14 21:35 ` Dan Williams 2019-01-14 21:35 ` Dan Williams 2019-01-14 22:21 ` Dave Chinner [not found] ` <CAPcyv4jtPcLV-s0sKNHwwk0ug7GLBV6699dpm1h3r2xSo879dg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-01-14 22:21 ` Dave Chinner 2019-01-14 22:21 ` [Qemu-devel] " Dave Chinner 2019-01-14 22:21 ` Dave Chinner 2019-01-14 22:21 ` Dave Chinner 2019-01-15 2:19 ` Michael S. Tsirkin 2019-01-15 2:19 ` Michael S. Tsirkin 2019-01-15 2:19 ` [Qemu-devel] " Michael S. Tsirkin 2019-01-15 2:19 ` Michael S. Tsirkin 2019-01-15 2:19 ` Michael S. Tsirkin 2019-01-15 5:37 ` [Qemu-devel] " Pankaj Gupta [not found] ` <20190114205031-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2019-01-15 5:37 ` Pankaj Gupta 2019-01-15 5:37 ` Pankaj Gupta 2019-01-15 5:37 ` Pankaj Gupta 2019-01-15 5:35 ` Pankaj Gupta 2019-01-15 5:35 ` [Qemu-devel] " Pankaj Gupta 2019-01-15 5:35 ` Pankaj Gupta 2019-01-15 5:35 ` Pankaj Gupta [not found] ` <1684638419.64320214.1547530506805.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-01-15 20:42 ` Dave Chinner 2019-01-15 20:42 ` [Qemu-devel] " Dave Chinner 2019-01-15 20:42 ` Dave Chinner 2019-01-15 20:42 ` Dave Chinner 2019-01-15 20:42 ` Dave Chinner 2019-01-15 5:35 ` Pankaj Gupta 2019-01-14 7:15 ` Pankaj Gupta 2019-02-04 22:56 ` security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device) Michael S. Tsirkin 2019-02-04 22:56 ` Michael S. Tsirkin 2019-02-04 22:56 ` [Qemu-devel] " Michael S. Tsirkin 2019-02-05 7:29 ` Pankaj Gupta 2019-02-05 7:29 ` Pankaj Gupta 2019-02-05 7:29 ` Pankaj Gupta 2019-02-06 14:00 ` David Hildenbrand 2019-02-06 14:00 ` David Hildenbrand 2019-02-06 14:00 ` [Qemu-devel] " David Hildenbrand 2019-02-06 18:01 ` Michael S. Tsirkin 2019-02-06 18:01 ` Michael S. Tsirkin 2019-02-06 18:01 ` [Qemu-devel] " Michael S. Tsirkin 2019-02-11 7:29 ` Pankaj Gupta 2019-02-11 7:29 ` Pankaj Gupta [not found] ` <888328358.132676.1549870186945.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-02-11 22:29 ` Dave Chinner 2019-02-11 22:29 ` Dave Chinner 2019-02-11 22:58 ` David Hildenbrand 2019-02-11 22:58 ` David Hildenbrand 2019-02-11 22:58 ` David Hildenbrand 2019-02-11 22:58 ` David Hildenbrand 2019-02-11 23:07 ` Michael S. Tsirkin 2019-02-11 23:07 ` Michael S. Tsirkin 2019-02-11 23:07 ` Michael S. Tsirkin 2019-02-11 22:29 ` Dave Chinner 2019-02-11 7:29 ` Pankaj Gupta -- strict thread matches above, loose matches on Subject: below -- 2019-01-09 13:56 [PATCH v3 4/5] ext4: disable map_sync for virtio pmem Pankaj Gupta 2019-01-09 13:56 Pankaj Gupta 2019-01-09 13:56 ` Pankaj Gupta 2019-01-09 14:42 ` Jan Kara 2019-01-09 14:42 ` Jan Kara 2019-01-09 14:54 ` Pankaj Gupta 2019-01-09 14:54 ` Pankaj Gupta 2019-01-09 14:54 ` Pankaj Gupta 2019-01-09 14:54 ` Pankaj Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190109144736.17452-5-pagupta@redhat.com \ --to=pagupta@redhat.com \ --cc=adilger.kernel@dilger.ca \ --cc=dan.j.williams@intel.com \ --cc=darrick.wong@oracle.com \ --cc=dave.jiang@intel.com \ --cc=david@redhat.com \ --cc=eblake@redhat.com \ --cc=hch@infradead.org \ --cc=imammedo@redhat.com \ --cc=jack@suse.cz \ --cc=jasowang@redhat.com \ --cc=jmoyer@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kwolf@redhat.com \ --cc=lcapitulino@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@ml01.01.org \ --cc=linux-xfs@vger.kernel.org \ --cc=mst@redhat.com \ --cc=nilal@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=riel@surriel.com \ --cc=rjw@rjwysocki.net \ --cc=stefanha@redhat.com \ --cc=tytso@mit.edu \ --cc=virtualization@lists.linux-foundation.org \ --cc=vishal.l.verma@intel.com \ --cc=willy@infradead.org \ --cc=xiaoguangrong.eric@gmail.com \ --cc=zwisler@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.