* [PATCH] drm/i915: Fix the static code analysis warning in debugfs
@ 2019-01-09 21:14 Radhakrishna Sripada
2019-01-09 21:22 ` Manasi Navare
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Radhakrishna Sripada @ 2019-01-09 21:14 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
intel_dp->dsc_dpcd is defined as an array making the if check redundant.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 95813e21ae02..908e41f9cb7d 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
crtc_state = to_intel_crtc_state(crtc->state);
seq_printf(m, "DSC_Enabled: %s\n",
yesno(crtc_state->dsc_params.compression_enable));
- if (intel_dp->dsc_dpcd)
- seq_printf(m, "DSC_Sink_Support: %s\n",
- yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
+ seq_printf(m, "DSC_Sink_Support: %s\n",
+ yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
if (!intel_dp_is_edp(intel_dp))
seq_printf(m, "FEC_Sink_Support: %s\n",
yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
--
2.20.0.rc2.7.g965798d1f299
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix the static code analysis warning in debugfs
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
@ 2019-01-09 21:22 ` Manasi Navare
2019-01-15 10:52 ` Jani Nikula
2019-01-09 22:55 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Manasi Navare @ 2019-01-09 21:22 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx, Rodrigo Vivi
On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
>
Yes I agree, I guess when I added that if check it was anot an array to begin
with and then forgot to take it off.
Looks good to me.
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 95813e21ae02..908e41f9cb7d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> crtc_state = to_intel_crtc_state(crtc->state);
> seq_printf(m, "DSC_Enabled: %s\n",
> yesno(crtc_state->dsc_params.compression_enable));
> - if (intel_dp->dsc_dpcd)
> - seq_printf(m, "DSC_Sink_Support: %s\n",
> - yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> + seq_printf(m, "DSC_Sink_Support: %s\n",
> + yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> if (!intel_dp_is_edp(intel_dp))
> seq_printf(m, "FEC_Sink_Support: %s\n",
> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
> --
> 2.20.0.rc2.7.g965798d1f299
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Fix the static code analysis warning in debugfs
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
2019-01-09 21:22 ` Manasi Navare
@ 2019-01-09 22:55 ` Patchwork
2019-01-10 1:53 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-14 19:31 ` Nathan Chancellor
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-01-09 22:55 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix the static code analysis warning in debugfs
URL : https://patchwork.freedesktop.org/series/54961/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5386 -> Patchwork_11267
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11267 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11267, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54961/revisions/1/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11267:
### IGT changes ###
#### Warnings ####
* igt@pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: SKIP -> PASS
Known issues
------------
Here are the changes found in Patchwork_11267 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@pm_rpm@basic-rte:
- fi-byt-j1900: NOTRUN -> FAIL [fdo#108800]
#### Possible fixes ####
* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: FAIL [fdo#108800] -> PASS
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
Participating hosts (48 -> 45)
------------------------------
Additional (3): fi-byt-j1900 fi-hsw-peppy fi-apl-guc
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5386 -> Patchwork_11267
CI_DRM_5386: c7b430c73b52681e3b7206a53c0d5d6f8000ebe2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4757: 738f43a54d626f08e250c926a5aeec53458fbd3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11267: 9e929310d7a85e6f89ad10e88659e6ef00f0c87f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9e929310d7a8 drm/i915: Fix the static code analysis warning in debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11267/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Fix the static code analysis warning in debugfs
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
2019-01-09 21:22 ` Manasi Navare
2019-01-09 22:55 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-10 1:53 ` Patchwork
2019-01-14 19:31 ` Nathan Chancellor
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-01-10 1:53 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix the static code analysis warning in debugfs
URL : https://patchwork.freedesktop.org/series/54961/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5386_full -> Patchwork_11267_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11267_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11267_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11267_full:
### IGT changes ###
#### Warnings ####
* igt@kms_vblank@pipe-b-query-forked-busy-hang:
- shard-snb: PASS -> SKIP
* igt@pm_rpm@gem-mmap-gtt:
- shard-kbl: PASS -> SKIP
Known issues
------------
Here are the changes found in Patchwork_11267_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-b:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled:
- shard-skl: PASS -> FAIL [fdo#107791]
* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +6
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-iclb: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166]
- shard-apl: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-iclb: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]
* igt@pm_rpm@i2c:
- shard-iclb: NOTRUN -> FAIL [fdo#104097]
* igt@pm_rpm@reg-read-ioctl:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
#### Possible fixes ####
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +16
* igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#109225] -> PASS
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: FAIL [fdo#108682] -> PASS
* igt@kms_color@pipe-a-ctm-max:
- shard-skl: FAIL [fdo#108147] -> PASS
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: FAIL [fdo#104782] / [fdo#108145] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS +1
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
- shard-skl: FAIL [fdo#103184] -> PASS
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled:
- shard-iclb: WARN [fdo#108336] -> PASS
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-iclb: DMESG-FAIL [fdo#105681] / [fdo#107724] -> PASS
* igt@kms_flip@busy-flip-interruptible:
- shard-skl: FAIL [fdo#103257] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: FAIL [fdo#105363] -> PASS
* igt@kms_flip@plain-flip-fb-recreate:
- shard-iclb: FAIL -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-iclb: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +2
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +8
* igt@kms_panel_fitting@atomic-fastset:
- shard-iclb: DMESG-WARN [fdo#109263] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: DMESG-FAIL [fdo#103166] / [fdo#107724] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@pm_rpm@debugfs-read:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
#### Warnings ####
* igt@gem_cpu_reloc@full:
- shard-skl: INCOMPLETE [fdo#108248] -> TIMEOUT [fdo#108248]
* igt@i915_suspend@shrink:
- shard-snb: DMESG-WARN [fdo#109244] -> INCOMPLETE [fdo#105411] / [fdo#106886]
* igt@kms_ccs@pipe-b-crc-primary-basic:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#107725]
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103166]
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103257]: https://bugs.freedesktop.org/show_bug.cgi?id=103257
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105681]: https://bugs.freedesktop.org/show_bug.cgi?id=105681
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107791]: https://bugs.freedesktop.org/show_bug.cgi?id=107791
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108248]: https://bugs.freedesktop.org/show_bug.cgi?id=108248
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108682]: https://bugs.freedesktop.org/show_bug.cgi?id=108682
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109263]: https://bugs.freedesktop.org/show_bug.cgi?id=109263
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5386 -> Patchwork_11267
CI_DRM_5386: c7b430c73b52681e3b7206a53c0d5d6f8000ebe2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4757: 738f43a54d626f08e250c926a5aeec53458fbd3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11267: 9e929310d7a85e6f89ad10e88659e6ef00f0c87f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11267/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: drm/i915: Fix the static code analysis warning in debugfs
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
` (2 preceding siblings ...)
2019-01-10 1:53 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-14 19:31 ` Nathan Chancellor
3 siblings, 0 replies; 7+ messages in thread
From: Nathan Chancellor @ 2019-01-14 19:31 UTC (permalink / raw)
To: Radhakrishna Sripada; +Cc: intel-gfx
On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
This fixes a Clang warning I saw after the patch that added this hit
linux-next.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 95813e21ae02..908e41f9cb7d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> crtc_state = to_intel_crtc_state(crtc->state);
> seq_printf(m, "DSC_Enabled: %s\n",
> yesno(crtc_state->dsc_params.compression_enable));
> - if (intel_dp->dsc_dpcd)
> - seq_printf(m, "DSC_Sink_Support: %s\n",
> - yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> + seq_printf(m, "DSC_Sink_Support: %s\n",
> + yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> if (!intel_dp_is_edp(intel_dp))
> seq_printf(m, "FEC_Sink_Support: %s\n",
> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix the static code analysis warning in debugfs
2019-01-09 21:22 ` Manasi Navare
@ 2019-01-15 10:52 ` Jani Nikula
2019-01-15 18:10 ` Manasi Navare
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2019-01-15 10:52 UTC (permalink / raw)
To: Manasi Navare, Radhakrishna Sripada; +Cc: intel-gfx
On Wed, 09 Jan 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
>> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
>>
>
> Yes I agree, I guess when I added that if check it was anot an array to begin
> with and then forgot to take it off.
>
> Looks good to me.
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi, you've got commit rights, please use them!
Pushed now, with proper Fixes: tag added, thanks for the patch, review,
testing, etc.
BR,
Jani.
>
> Manasi
>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 95813e21ae02..908e41f9cb7d 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
>> crtc_state = to_intel_crtc_state(crtc->state);
>> seq_printf(m, "DSC_Enabled: %s\n",
>> yesno(crtc_state->dsc_params.compression_enable));
>> - if (intel_dp->dsc_dpcd)
>> - seq_printf(m, "DSC_Sink_Support: %s\n",
>> - yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
>> + seq_printf(m, "DSC_Sink_Support: %s\n",
>> + yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
>> if (!intel_dp_is_edp(intel_dp))
>> seq_printf(m, "FEC_Sink_Support: %s\n",
>> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
>> --
>> 2.20.0.rc2.7.g965798d1f299
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Fix the static code analysis warning in debugfs
2019-01-15 10:52 ` Jani Nikula
@ 2019-01-15 18:10 ` Manasi Navare
0 siblings, 0 replies; 7+ messages in thread
From: Manasi Navare @ 2019-01-15 18:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, Jan 15, 2019 at 12:52:29PM +0200, Jani Nikula wrote:
> On Wed, 09 Jan 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> > On Wed, Jan 09, 2019 at 01:14:14PM -0800, Radhakrishna Sripada wrote:
> >> intel_dp->dsc_dpcd is defined as an array making the if check redundant.
> >>
> >
> > Yes I agree, I guess when I added that if check it was anot an array to begin
> > with and then forgot to take it off.
> >
> > Looks good to me.
> >
> > Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> Manasi, you've got commit rights, please use them!
>
> Pushed now, with proper Fixes: tag added, thanks for the patch, review,
> testing, etc.
>
Thanks Jani for merging this one. I know I had this in my list of patches to merge
but got heads down busy with getting the IGT commit rights and merging the kms_dsc IGT test
last few days.
Thanks for catching this and for fixes patch RK!
Regards
Manasi
> BR,
> Jani.
>
>
> >
> > Manasi
> >
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++---
> >> 1 file changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> >> index 95813e21ae02..908e41f9cb7d 100644
> >> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> >> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> >> @@ -4958,9 +4958,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> >> crtc_state = to_intel_crtc_state(crtc->state);
> >> seq_printf(m, "DSC_Enabled: %s\n",
> >> yesno(crtc_state->dsc_params.compression_enable));
> >> - if (intel_dp->dsc_dpcd)
> >> - seq_printf(m, "DSC_Sink_Support: %s\n",
> >> - yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> >> + seq_printf(m, "DSC_Sink_Support: %s\n",
> >> + yesno(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> >> if (!intel_dp_is_edp(intel_dp))
> >> seq_printf(m, "FEC_Sink_Support: %s\n",
> >> yesno(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
> >> --
> >> 2.20.0.rc2.7.g965798d1f299
> >>
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-15 18:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09 21:14 [PATCH] drm/i915: Fix the static code analysis warning in debugfs Radhakrishna Sripada
2019-01-09 21:22 ` Manasi Navare
2019-01-15 10:52 ` Jani Nikula
2019-01-15 18:10 ` Manasi Navare
2019-01-09 22:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-10 1:53 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-14 19:31 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.