From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Matthias Reichl <hias@horus.com>,
Marcel Ziswiler <marcel@ziswiler.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Fix deferral of machine drivers
Date: Thu, 10 Jan 2019 16:48:35 +0000 [thread overview]
Message-ID: <20190110164835.GF9541@sirena.org.uk> (raw)
In-Reply-To: <44a64e6e-c9ec-8eba-60fe-eda092250d82@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]
On Thu, Jan 10, 2019 at 12:13:36PM +0000, Jon Hunter wrote:
> On 09/01/2019 18:36, Mark Brown wrote:
> > On Tue, Jan 08, 2019 at 05:28:14PM +0000, Jon Hunter wrote:
> >> - struct snd_soc_dai_link_component *platform;
> >> + struct snd_soc_dai_link_component platform;
> > This breaks the build for the SCU cards (and we needs a little rebase
> > against another fix I just merged, though I did do that when applying).
> Sorry I still don't see the build break, can you point me to it?
I'd need to find your patch again and fix the rebase issue. It was
assigning a pointer to a platform IIRC.
> > I do think that this is going to be the safest thing to do for v5.0, it
> > can always be reverted later on when it's not needed but it seems clear
> > that a better fix is going to be way too invasive for the -rcs. Can you
> > respin and retest please?
> Yes will do. I do wonder if we should be concerned about
> snd_soc_init_multicodec() as well? Looks like it could have a different
> problem if a machine driver already allocated the memory for the codec
> link component.
Since you appear to be volunteering to check... :)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
Marcel Ziswiler <marcel@ziswiler.com>,
Matthias Reichl <hias@horus.com>
Subject: Re: [PATCH] ASoC: core: Fix deferral of machine drivers
Date: Thu, 10 Jan 2019 16:48:35 +0000 [thread overview]
Message-ID: <20190110164835.GF9541@sirena.org.uk> (raw)
In-Reply-To: <44a64e6e-c9ec-8eba-60fe-eda092250d82@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Thu, Jan 10, 2019 at 12:13:36PM +0000, Jon Hunter wrote:
> On 09/01/2019 18:36, Mark Brown wrote:
> > On Tue, Jan 08, 2019 at 05:28:14PM +0000, Jon Hunter wrote:
> >> - struct snd_soc_dai_link_component *platform;
> >> + struct snd_soc_dai_link_component platform;
> > This breaks the build for the SCU cards (and we needs a little rebase
> > against another fix I just merged, though I did do that when applying).
> Sorry I still don't see the build break, can you point me to it?
I'd need to find your patch again and fix the rebase issue. It was
assigning a pointer to a platform IIRC.
> > I do think that this is going to be the safest thing to do for v5.0, it
> > can always be reverted later on when it's not needed but it seems clear
> > that a better fix is going to be way too invasive for the -rcs. Can you
> > respin and retest please?
> Yes will do. I do wonder if we should be concerned about
> snd_soc_init_multicodec() as well? Looks like it could have a different
> problem if a machine driver already allocated the memory for the codec
> link component.
Since you appear to be volunteering to check... :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-10 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 17:28 [PATCH] ASoC: core: Fix deferral of machine drivers Jon Hunter
2019-01-08 17:28 ` Jon Hunter
2019-01-09 2:09 ` Kuninori Morimoto
2019-01-09 2:09 ` Kuninori Morimoto
2019-01-09 10:52 ` Jon Hunter
2019-01-09 10:52 ` Jon Hunter
2019-01-09 18:36 ` Mark Brown
2019-01-10 12:13 ` Jon Hunter
2019-01-10 12:13 ` Jon Hunter
2019-01-10 16:48 ` Mark Brown [this message]
2019-01-10 16:48 ` Mark Brown
2019-01-11 8:43 ` Jon Hunter
2019-01-11 8:43 ` Jon Hunter
2019-01-11 13:23 ` Mark Brown
2019-01-11 13:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110164835.GF9541@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=hias@horus.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel@ziswiler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.