* [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
@ 2019-01-10 19:22 Heiner Kallweit
2019-01-10 19:24 ` Florian Fainelli
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Heiner Kallweit @ 2019-01-10 19:22 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev, Tony Lindgren
So far genphy_soft_reset was used automatically if the PHY driver
didn't implement the soft_reset callback. This changed with the
mentioned commit and broke KSZ9031. To fix this configure the
KSZ9031 PHY driver to use genphy_soft_reset.
Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index c33384710..7828d17f0 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
.driver_data = &ksz9021_type,
.probe = kszphy_probe,
.config_init = ksz9031_config_init,
+ .soft_reset = genphy_soft_reset,
.read_status = ksz9031_read_status,
.ack_interrupt = kszphy_ack_interrupt,
.config_intr = kszphy_config_intr,
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:22 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Heiner Kallweit
@ 2019-01-10 19:24 ` Florian Fainelli
2019-01-10 19:41 ` Heiner Kallweit
2019-01-10 21:24 ` Tony Lindgren
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Florian Fainelli @ 2019-01-10 19:24 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, David Miller; +Cc: netdev, Tony Lindgren
On 1/10/19 11:22 AM, Heiner Kallweit wrote:
> So far genphy_soft_reset was used automatically if the PHY driver
> didn't implement the soft_reset callback. This changed with the
> mentioned commit and broke KSZ9031. To fix this configure the
> KSZ9031 PHY driver to use genphy_soft_reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks a lot for following up with the people at TI on this. We should
really get a better understanding of what the issue is, and whether
there is a possibly better workaround that could be developed which is
not just as hard as a big hammer software reset. Maybe we can get some
people/contacts at Micrel to help here.
> ---
> drivers/net/phy/micrel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c33384710..7828d17f0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
> .driver_data = &ksz9021_type,
> .probe = kszphy_probe,
> .config_init = ksz9031_config_init,
> + .soft_reset = genphy_soft_reset,
> .read_status = ksz9031_read_status,
> .ack_interrupt = kszphy_ack_interrupt,
> .config_intr = kszphy_config_intr,
>
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:24 ` Florian Fainelli
@ 2019-01-10 19:41 ` Heiner Kallweit
2019-01-10 21:27 ` Tony Lindgren
0 siblings, 1 reply; 9+ messages in thread
From: Heiner Kallweit @ 2019-01-10 19:41 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn, David Miller; +Cc: netdev, Tony Lindgren
On 10.01.2019 20:24, Florian Fainelli wrote:
> On 1/10/19 11:22 AM, Heiner Kallweit wrote:
>> So far genphy_soft_reset was used automatically if the PHY driver
>> didn't implement the soft_reset callback. This changed with the
>> mentioned commit and broke KSZ9031. To fix this configure the
>> KSZ9031 PHY driver to use genphy_soft_reset.
>>
>> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
>> Reported-by: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Thanks a lot for following up with the people at TI on this. We should
> really get a better understanding of what the issue is, and whether
> there is a possibly better workaround that could be developed which is
> not just as hard as a big hammer software reset. Maybe we can get some
> people/contacts at Micrel to help here.
>
In ksz9031_config_init() quite some settings are done and IMO it's not
that unusual that it takes a soft reset for such settings to become
effective. But I agree it would be nice if somebody from the PHY vendor
could comment on whether a soft reset is actually needed. Not sure who
has a contact to Microchip.
If the feedback takes time it may be better to apply the soft reset as
fix and replace it later in case we have a less intrusive option.
>> ---
>> drivers/net/phy/micrel.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>> index c33384710..7828d17f0 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
>> .driver_data = &ksz9021_type,
>> .probe = kszphy_probe,
>> .config_init = ksz9031_config_init,
>> + .soft_reset = genphy_soft_reset,
>> .read_status = ksz9031_read_status,
>> .ack_interrupt = kszphy_ack_interrupt,
>> .config_intr = kszphy_config_intr,
>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:22 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Heiner Kallweit
2019-01-10 19:24 ` Florian Fainelli
@ 2019-01-10 21:24 ` Tony Lindgren
2019-01-13 5:14 ` Florian Fainelli
2019-01-16 5:41 ` David Miller
3 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2019-01-10 21:24 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Andrew Lunn, Florian Fainelli, David Miller, netdev, Sekhar Nori
* Heiner Kallweit <hkallweit1@gmail.com> [190110 19:22]:
> So far genphy_soft_reset was used automatically if the PHY driver
> didn't implement the soft_reset callback. This changed with the
> mentioned commit and broke KSZ9031. To fix this configure the
> KSZ9031 PHY driver to use genphy_soft_reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks this fixes the regression for me:
Tested-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/net/phy/micrel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c33384710..7828d17f0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
> .driver_data = &ksz9021_type,
> .probe = kszphy_probe,
> .config_init = ksz9031_config_init,
> + .soft_reset = genphy_soft_reset,
> .read_status = ksz9031_read_status,
> .ack_interrupt = kszphy_ack_interrupt,
> .config_intr = kszphy_config_intr,
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:41 ` Heiner Kallweit
@ 2019-01-10 21:27 ` Tony Lindgren
2019-01-10 21:29 ` Tony Lindgren
2019-01-11 11:22 ` Sekhar Nori
0 siblings, 2 replies; 9+ messages in thread
From: Tony Lindgren @ 2019-01-10 21:27 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Florian Fainelli, Andrew Lunn, David Miller, netdev
* Heiner Kallweit <hkallweit1@gmail.com> [190110 19:41]:
> On 10.01.2019 20:24, Florian Fainelli wrote:
> > On 1/10/19 11:22 AM, Heiner Kallweit wrote:
> >> So far genphy_soft_reset was used automatically if the PHY driver
> >> didn't implement the soft_reset callback. This changed with the
> >> mentioned commit and broke KSZ9031. To fix this configure the
> >> KSZ9031 PHY driver to use genphy_soft_reset.
> >>
> >> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> >> Reported-by: Tony Lindgren <tony@atomide.com>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > Thanks a lot for following up with the people at TI on this. We should
> > really get a better understanding of what the issue is, and whether
> > there is a possibly better workaround that could be developed which is
> > not just as hard as a big hammer software reset. Maybe we can get some
> > people/contacts at Micrel to help here.
> >
> In ksz9031_config_init() quite some settings are done and IMO it's not
> that unusual that it takes a soft reset for such settings to become
> effective. But I agree it would be nice if somebody from the PHY vendor
> could comment on whether a soft reset is actually needed. Not sure who
> has a contact to Microchip.
Adding Sekhar to Cc, maybe he has some contacts to ask.
> If the feedback takes time it may be better to apply the soft reset as
> fix and replace it later in case we have a less intrusive option.
Yes please let's fix the regression first and then patch
more later as needed.
Regards,
Tony
> >> ---
> >> drivers/net/phy/micrel.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> >> index c33384710..7828d17f0 100644
> >> --- a/drivers/net/phy/micrel.c
> >> +++ b/drivers/net/phy/micrel.c
> >> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
> >> .driver_data = &ksz9021_type,
> >> .probe = kszphy_probe,
> >> .config_init = ksz9031_config_init,
> >> + .soft_reset = genphy_soft_reset,
> >> .read_status = ksz9031_read_status,
> >> .ack_interrupt = kszphy_ack_interrupt,
> >> .config_intr = kszphy_config_intr,
> >>
> >
> >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 21:27 ` Tony Lindgren
@ 2019-01-10 21:29 ` Tony Lindgren
2019-01-11 11:22 ` Sekhar Nori
1 sibling, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2019-01-10 21:29 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Florian Fainelli, Andrew Lunn, David Miller, netdev, Sekhar Nori
* Tony Lindgren <tony@atomide.com> [190110 13:27]:
> * Heiner Kallweit <hkallweit1@gmail.com> [190110 19:41]:
> > On 10.01.2019 20:24, Florian Fainelli wrote:
> > > On 1/10/19 11:22 AM, Heiner Kallweit wrote:
> > >> So far genphy_soft_reset was used automatically if the PHY driver
> > >> didn't implement the soft_reset callback. This changed with the
> > >> mentioned commit and broke KSZ9031. To fix this configure the
> > >> KSZ9031 PHY driver to use genphy_soft_reset.
> > >>
> > >> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> > >> Reported-by: Tony Lindgren <tony@atomide.com>
> > >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > >
> > > Thanks a lot for following up with the people at TI on this. We should
> > > really get a better understanding of what the issue is, and whether
> > > there is a possibly better workaround that could be developed which is
> > > not just as hard as a big hammer software reset. Maybe we can get some
> > > people/contacts at Micrel to help here.
> > >
> > In ksz9031_config_init() quite some settings are done and IMO it's not
> > that unusual that it takes a soft reset for such settings to become
> > effective. But I agree it would be nice if somebody from the PHY vendor
> > could comment on whether a soft reset is actually needed. Not sure who
> > has a contact to Microchip.
>
> Adding Sekhar to Cc, maybe he has some contacts to ask.
Oops.. Second attempt of adding Sekhar to Cc.
> > If the feedback takes time it may be better to apply the soft reset as
> > fix and replace it later in case we have a less intrusive option.
>
> Yes please let's fix the regression first and then patch
> more later as needed.
>
> Regards,
>
> Tony
>
> > >> ---
> > >> drivers/net/phy/micrel.c | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> > >> index c33384710..7828d17f0 100644
> > >> --- a/drivers/net/phy/micrel.c
> > >> +++ b/drivers/net/phy/micrel.c
> > >> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
> > >> .driver_data = &ksz9021_type,
> > >> .probe = kszphy_probe,
> > >> .config_init = ksz9031_config_init,
> > >> + .soft_reset = genphy_soft_reset,
> > >> .read_status = ksz9031_read_status,
> > >> .ack_interrupt = kszphy_ack_interrupt,
> > >> .config_intr = kszphy_config_intr,
> > >>
> > >
> > >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 21:27 ` Tony Lindgren
2019-01-10 21:29 ` Tony Lindgren
@ 2019-01-11 11:22 ` Sekhar Nori
1 sibling, 0 replies; 9+ messages in thread
From: Sekhar Nori @ 2019-01-11 11:22 UTC (permalink / raw)
To: Tony Lindgren, Heiner Kallweit
Cc: Florian Fainelli, Andrew Lunn, David Miller, netdev
On 11/01/19 2:57 AM, Tony Lindgren wrote:
> * Heiner Kallweit <hkallweit1@gmail.com> [190110 19:41]:
>> On 10.01.2019 20:24, Florian Fainelli wrote:
>>> On 1/10/19 11:22 AM, Heiner Kallweit wrote:
>>>> So far genphy_soft_reset was used automatically if the PHY driver
>>>> didn't implement the soft_reset callback. This changed with the
>>>> mentioned commit and broke KSZ9031. To fix this configure the
>>>> KSZ9031 PHY driver to use genphy_soft_reset.
>>>>
>>>> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
>>>> Reported-by: Tony Lindgren <tony@atomide.com>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> Thanks a lot for following up with the people at TI on this. We should
>>> really get a better understanding of what the issue is, and whether
>>> there is a possibly better workaround that could be developed which is
>>> not just as hard as a big hammer software reset. Maybe we can get some
>>> people/contacts at Micrel to help here.
>>>
>> In ksz9031_config_init() quite some settings are done and IMO it's not
>> that unusual that it takes a soft reset for such settings to become
>> effective. But I agree it would be nice if somebody from the PHY vendor
>> could comment on whether a soft reset is actually needed. Not sure who
>> has a contact to Microchip.
>
> Adding Sekhar to Cc, maybe he has some contacts to ask.
I dont have any direct contacts, but I will ask internally.
>
>> If the feedback takes time it may be better to apply the soft reset as
>> fix and replace it later in case we have a less intrusive option.
>
> Yes please let's fix the regression first and then patch
> more later as needed.
+1
I justed tested AM437x GP EVM with 10 times cable plug-unplug and this
fixes the regression.
Tested-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:22 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Heiner Kallweit
2019-01-10 19:24 ` Florian Fainelli
2019-01-10 21:24 ` Tony Lindgren
@ 2019-01-13 5:14 ` Florian Fainelli
2019-01-16 5:41 ` David Miller
3 siblings, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2019-01-13 5:14 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, David Miller; +Cc: netdev, Tony Lindgren
On January 10, 2019 11:22:26 AM PST, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>So far genphy_soft_reset was used automatically if the PHY driver
>didn't implement the soft_reset callback. This changed with the
>mentioned commit and broke KSZ9031. To fix this configure the
>KSZ9031 PHY driver to use genphy_soft_reset.
>
>Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
>Reported-by: Tony Lindgren <tony@atomide.com>
>Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031
2019-01-10 19:22 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Heiner Kallweit
` (2 preceding siblings ...)
2019-01-13 5:14 ` Florian Fainelli
@ 2019-01-16 5:41 ` David Miller
3 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2019-01-16 5:41 UTC (permalink / raw)
To: hkallweit1; +Cc: andrew, f.fainelli, netdev, tony
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 10 Jan 2019 20:22:26 +0100
> So far genphy_soft_reset was used automatically if the PHY driver
> didn't implement the soft_reset callback. This changed with the
> mentioned commit and broke KSZ9031. To fix this configure the
> KSZ9031 PHY driver to use genphy_soft_reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-16 5:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 19:22 [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Heiner Kallweit
2019-01-10 19:24 ` Florian Fainelli
2019-01-10 19:41 ` Heiner Kallweit
2019-01-10 21:27 ` Tony Lindgren
2019-01-10 21:29 ` Tony Lindgren
2019-01-11 11:22 ` Sekhar Nori
2019-01-10 21:24 ` Tony Lindgren
2019-01-13 5:14 ` Florian Fainelli
2019-01-16 5:41 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.