All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
       [not found] <CALvuzg43uSodseEHjNaRcPFBKKPTY2mcppUbYgiLL=QO9RxX_Q@mail.gmail.com>
@ 2019-01-03 17:16 ` Laurent Vivier
  2019-01-04 10:41   ` Roman Kapl
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2019-01-03 17:16 UTC (permalink / raw)
  To: Jon Diekema
  Cc: qemu-trivial, David Gibson, qemu-ppc, QEMU Developers, Roman Kapl

Please cc: qemu-devel and maintainers (see MAINTAINERS file)

Le 25/12/2018 à 10:50, Jon Diekema a écrit :
> From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001
> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>

it's better to use the same email address for the patch author and to
send it.

> Date: Tue, 25 Dec 2018 04:36:06 -0500
> Subject: ppc: e6500 registers SPR 604 twice
> 
> When using the e6500 CPU, QEMU generates a fatal error after
> complaining about registering SPR 604 twice.
> 
> Building and testing with commit
> 9b2e891ec5ccdb4a7d583b77988848282606fdea shows the issue:
> 
> qemu-system-ppc64 --version
> QEMU emulator version 3.1.50 (v3.1.0-456-g9b2e891ec5-dirty)
> Copyright (c) 2003-2018 Fabrice Bellard and the QEMU Project developers
> 
> qemu-system-ppc64 -M none -cpu e6500
> Error: Trying to register SPR 604 (25c) twice !

Fixes: 0e3bf48909
       ppc: add DBCR based debugging

> Signed-off-by: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
> ---
>  target/ppc/translate_init.inc.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/target/ppc/translate_init.inc.c
> b/target/ppc/translate_init.inc.c
> index 03f1d34a97..c971a5faf7 100644
> --- a/target/ppc/translate_init.inc.c
> +++ b/target/ppc/translate_init.inc.c
> @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int
> version)
>      }
>  
>      if (version == fsl_e6500) {
> -        spr_register(env, SPR_BOOKE_SPRG8, "SPRG8",
> -                     SPR_NOACCESS, SPR_NOACCESS,
> -                     &spr_read_generic, &spr_write_generic,
> -                     0x00000000);
> -        spr_register(env, SPR_BOOKE_SPRG9, "SPRG9",
> -                     SPR_NOACCESS, SPR_NOACCESS,
> -                     &spr_read_generic, &spr_write_generic,
> -                     0x00000000);
>          /* Thread identification */
>          spr_register(env, SPR_TIR, "TIR",
>                       SPR_NOACCESS, SPR_NOACCESS,
> -- 
> 2.20.1.3.gf17a2b179
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Tested-by: Laurent Vivier <laurent@vivier.eu>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
  2019-01-03 17:16 ` [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice Laurent Vivier
@ 2019-01-04 10:41   ` Roman Kapl
  2019-01-09 10:17     ` Laurent Vivier
  0 siblings, 1 reply; 6+ messages in thread
From: Roman Kapl @ 2019-01-04 10:41 UTC (permalink / raw)
  To: Laurent Vivier, Jon Diekema
  Cc: qemu-trivial, David Gibson, qemu-ppc, QEMU Developers, Roman Kapl

> Le 25/12/2018 à 10:50, Jon Diekema a écrit :
>>  From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001
>> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
>> Date: Tue, 25 Dec 2018 04:36:06 -0500
>> Subject: ppc: e6500 registers SPR 604 twice
>>
>> When using the e6500 CPU, QEMU generates a fatal error after
>> complaining about registering SPR 604 twice.
>>
>>
>> diff --git a/target/ppc/translate_init.inc.c
>> b/target/ppc/translate_init.inc.c
>> index 03f1d34a97..c971a5faf7 100644
>> --- a/target/ppc/translate_init.inc.c
>> +++ b/target/ppc/translate_init.inc.c
>> @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int
>> version)
>>       }
>>   
>>       if (version == fsl_e6500) {
>> -        spr_register(env, SPR_BOOKE_SPRG8, "SPRG8",
>> -                     SPR_NOACCESS, SPR_NOACCESS,
>> -                     &spr_read_generic, &spr_write_generic,
>> -                     0x00000000);
>> -        spr_register(env, SPR_BOOKE_SPRG9, "SPRG9",
>> -                     SPR_NOACCESS, SPR_NOACCESS,
>> -                     &spr_read_generic, &spr_write_generic,
>> -                     0x00000000);
>>           /* Thread identification */
>>           spr_register(env, SPR_TIR, "TIR",
>>                        SPR_NOACCESS, SPR_NOACCESS,
>> -- 
>> 2.20.1.3.gf17a2b179
>>
> 
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Tested-by: Laurent Vivier <laurent@vivier.eu>
> 

Thanks Jon, I did not test with e6500. The patch fixes the issue & 
debugging still works on e5500.

Roman Kapl

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
  2019-01-04 10:41   ` Roman Kapl
@ 2019-01-09 10:17     ` Laurent Vivier
  2019-01-11  0:35       ` David Gibson
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2019-01-09 10:17 UTC (permalink / raw)
  To: David Gibson
  Cc: Roman Kapl, Jon Diekema, qemu-trivial, Roman Kapl, qemu-ppc,
	QEMU Developers

David,

will you take this through your ppc branch?

Thanks,
Laurent

On 04/01/2019 11:41, Roman Kapl wrote:
>> Le 25/12/2018 à 10:50, Jon Diekema a écrit :
>>>  From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001
>>> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
>>> Date: Tue, 25 Dec 2018 04:36:06 -0500
>>> Subject: ppc: e6500 registers SPR 604 twice
>>>
>>> When using the e6500 CPU, QEMU generates a fatal error after
>>> complaining about registering SPR 604 twice.
>>>
>>>
>>> diff --git a/target/ppc/translate_init.inc.c
>>> b/target/ppc/translate_init.inc.c
>>> index 03f1d34a97..c971a5faf7 100644
>>> --- a/target/ppc/translate_init.inc.c
>>> +++ b/target/ppc/translate_init.inc.c
>>> @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int
>>> version)
>>>       }
>>>         if (version == fsl_e6500) {
>>> -        spr_register(env, SPR_BOOKE_SPRG8, "SPRG8",
>>> -                     SPR_NOACCESS, SPR_NOACCESS,
>>> -                     &spr_read_generic, &spr_write_generic,
>>> -                     0x00000000);
>>> -        spr_register(env, SPR_BOOKE_SPRG9, "SPRG9",
>>> -                     SPR_NOACCESS, SPR_NOACCESS,
>>> -                     &spr_read_generic, &spr_write_generic,
>>> -                     0x00000000);
>>>           /* Thread identification */
>>>           spr_register(env, SPR_TIR, "TIR",
>>>                        SPR_NOACCESS, SPR_NOACCESS,
>>> -- 
>>> 2.20.1.3.gf17a2b179
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>> Tested-by: Laurent Vivier <laurent@vivier.eu>
>>
> 
> Thanks Jon, I did not test with e6500. The patch fixes the issue &
> debugging still works on e5500.
> 
> Roman Kapl
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
  2019-01-09 10:17     ` Laurent Vivier
@ 2019-01-11  0:35       ` David Gibson
  2019-01-11  7:19         ` Laurent Vivier
  2019-01-17 17:51         ` Laurent Vivier
  0 siblings, 2 replies; 6+ messages in thread
From: David Gibson @ 2019-01-11  0:35 UTC (permalink / raw)
  To: Laurent Vivier
  Cc: Roman Kapl, Jon Diekema, qemu-trivial, Roman Kapl, qemu-ppc,
	QEMU Developers

[-- Attachment #1: Type: text/plain, Size: 2294 bytes --]

On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote:
> David,
> 
> will you take this through your ppc branch?

Somehow I missed this one, sorry.  Even when I look back through my
mail archives I can't see the original message of this thread.  Can
you resend please?

> 
> Thanks,
> Laurent
> 
> On 04/01/2019 11:41, Roman Kapl wrote:
> >> Le 25/12/2018 à 10:50, Jon Diekema a écrit :
> >>>  From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001
> >>> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
> >>> Date: Tue, 25 Dec 2018 04:36:06 -0500
> >>> Subject: ppc: e6500 registers SPR 604 twice
> >>>
> >>> When using the e6500 CPU, QEMU generates a fatal error after
> >>> complaining about registering SPR 604 twice.
> >>>
> >>>
> >>> diff --git a/target/ppc/translate_init.inc.c
> >>> b/target/ppc/translate_init.inc.c
> >>> index 03f1d34a97..c971a5faf7 100644
> >>> --- a/target/ppc/translate_init.inc.c
> >>> +++ b/target/ppc/translate_init.inc.c
> >>> @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int
> >>> version)
> >>>       }
> >>>         if (version == fsl_e6500) {
> >>> -        spr_register(env, SPR_BOOKE_SPRG8, "SPRG8",
> >>> -                     SPR_NOACCESS, SPR_NOACCESS,
> >>> -                     &spr_read_generic, &spr_write_generic,
> >>> -                     0x00000000);
> >>> -        spr_register(env, SPR_BOOKE_SPRG9, "SPRG9",
> >>> -                     SPR_NOACCESS, SPR_NOACCESS,
> >>> -                     &spr_read_generic, &spr_write_generic,
> >>> -                     0x00000000);
> >>>           /* Thread identification */
> >>>           spr_register(env, SPR_TIR, "TIR",
> >>>                        SPR_NOACCESS, SPR_NOACCESS,
> >>> -- 
> >>> 2.20.1.3.gf17a2b179
> >>>
> >>
> >> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> >> Tested-by: Laurent Vivier <laurent@vivier.eu>
> >>
> > 
> > Thanks Jon, I did not test with e6500. The patch fixes the issue &
> > debugging still works on e5500.
> > 
> > Roman Kapl
> > 
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
  2019-01-11  0:35       ` David Gibson
@ 2019-01-11  7:19         ` Laurent Vivier
  2019-01-17 17:51         ` Laurent Vivier
  1 sibling, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2019-01-11  7:19 UTC (permalink / raw)
  To: David Gibson
  Cc: Roman Kapl, Jon Diekema, qemu-trivial, Roman Kapl, qemu-ppc,
	QEMU Developers

On 11/01/2019 01:35, David Gibson wrote:
> On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote:
>> David,
>>
>> will you take this through your ppc branch?
> 
> Somehow I missed this one, sorry.  Even when I look back through my
> mail archives I can't see the original message of this thread.  Can
> you resend please?

Yes, the original message has only be sent to qemu-trivial ML.

Thanks,
Laurent

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
  2019-01-11  0:35       ` David Gibson
  2019-01-11  7:19         ` Laurent Vivier
@ 2019-01-17 17:51         ` Laurent Vivier
  1 sibling, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2019-01-17 17:51 UTC (permalink / raw)
  To: David Gibson
  Cc: Jon Diekema, Roman Kapl, qemu-trivial, QEMU Developers,
	Roman Kapl, qemu-ppc

On 11/01/2019 01:35, David Gibson wrote:
> On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote:
>> David,
>>
>> will you take this through your ppc branch?
> 
> Somehow I missed this one, sorry.  Even when I look back through my
> mail archives I can't see the original message of this thread.  Can
> you resend please?

As it is in the qemu-trivial ML, I've applied this patch to the 
trivial-patches branch.

Thanks,
Laurent

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-17 17:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CALvuzg43uSodseEHjNaRcPFBKKPTY2mcppUbYgiLL=QO9RxX_Q@mail.gmail.com>
2019-01-03 17:16 ` [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice Laurent Vivier
2019-01-04 10:41   ` Roman Kapl
2019-01-09 10:17     ` Laurent Vivier
2019-01-11  0:35       ` David Gibson
2019-01-11  7:19         ` Laurent Vivier
2019-01-17 17:51         ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.