From: Bartosz Golaszewski <brgl@bgdev.pl> To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Gleixner <tglx@linutronix.de> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: [PATCH 07/17] ARM: davinci: dm365: WARN() if clk_get() fails Date: Fri, 11 Jan 2019 18:21:24 +0100 [thread overview] Message-ID: <20190111172134.30147-8-brgl@bgdev.pl> (raw) In-Reply-To: <20190111172134.30147-1-brgl@bgdev.pl> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> Currently the timer code checks if the clock pointer passed to it is good (!IS_ERR(clk)). The new clocksource driver expects the clock to be functional and doesn't perform any checks so emit a warning if clk_get() fails. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/mach-davinci/dm365.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index 01fb2b0c82de..842b7e706ba1 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -786,6 +786,7 @@ void __init dm365_init_time(void) dm365_psc_init(NULL, psc); clk = clk_get(NULL, "timer0"); + WARN(IS_ERR(clk), "Unable to get the timer clock\n"); davinci_timer_init(clk); } -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl> To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Thomas Gleixner <tglx@linutronix.de> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: [PATCH 07/17] ARM: davinci: dm365: WARN() if clk_get() fails Date: Fri, 11 Jan 2019 18:21:24 +0100 [thread overview] Message-ID: <20190111172134.30147-8-brgl@bgdev.pl> (raw) In-Reply-To: <20190111172134.30147-1-brgl@bgdev.pl> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> Currently the timer code checks if the clock pointer passed to it is good (!IS_ERR(clk)). The new clocksource driver expects the clock to be functional and doesn't perform any checks so emit a warning if clk_get() fails. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/mach-davinci/dm365.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index 01fb2b0c82de..842b7e706ba1 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -786,6 +786,7 @@ void __init dm365_init_time(void) dm365_psc_init(NULL, psc); clk = clk_get(NULL, "timer0"); + WARN(IS_ERR(clk), "Unable to get the timer clock\n"); davinci_timer_init(clk); } -- 2.19.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 17:23 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-11 17:21 [PATCH 00/17] ARM: davinci: modernize the timer support Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 01/17] ARM: dts: da850: fix interrupt numbers for clocksource Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-17 14:22 ` Sekhar Nori 2019-01-17 14:22 ` Sekhar Nori 2019-01-17 14:22 ` Sekhar Nori 2019-01-17 14:32 ` Bartosz Golaszewski 2019-01-17 14:32 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 02/17] clocksource: davinci-timer: new driver Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-14 12:20 ` Sekhar Nori 2019-01-14 12:20 ` Sekhar Nori 2019-01-14 12:20 ` Sekhar Nori 2019-01-14 16:39 ` Bartosz Golaszewski 2019-01-14 16:39 ` Bartosz Golaszewski 2019-01-16 9:18 ` Sekhar Nori 2019-01-16 9:18 ` Sekhar Nori 2019-01-17 12:42 ` Sekhar Nori 2019-01-17 12:42 ` Sekhar Nori 2019-01-17 14:01 ` Bartosz Golaszewski 2019-01-17 14:01 ` Bartosz Golaszewski 2019-01-24 12:09 ` Sekhar Nori 2019-01-24 12:09 ` Sekhar Nori 2019-01-23 0:30 ` Kevin Hilman 2019-01-23 0:30 ` Kevin Hilman 2019-01-11 17:21 ` [PATCH 03/17] ARM: davinci: enable the clocksource driver for DT mode Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 04/17] ARM: davinci: da850: WARN() if clk_get() fails Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-14 12:22 ` Sekhar Nori 2019-01-14 12:22 ` Sekhar Nori 2019-01-14 12:22 ` Sekhar Nori 2019-01-11 17:21 ` [PATCH 05/17] ARM: davinci: da830: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 06/17] ARM: davinci: dm355: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski [this message] 2019-01-11 17:21 ` [PATCH 07/17] ARM: davinci: dm365: " Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 08/17] ARM: davinci: dm644x: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 09/17] ARM: davinci: dm646x: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 10/17] ARM: davinci: da850: switch to using the clocksource driver Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 11/17] ARM: davinci: da830: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 12/17] ARM: davinci: move timer definitions to davinci.h Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 13/17] ARM: davinci: dm355: switch to using the clocksource driver Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 14/17] ARM: davinci: dm365: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 15/17] ARM: davinci: dm644x: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 16/17] ARM: davinci: dm646x: " Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski 2019-01-11 17:21 ` [PATCH 17/17] ARM: davinci: remove legacy timer support Bartosz Golaszewski 2019-01-11 17:21 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190111172134.30147-8-brgl@bgdev.pl \ --to=brgl@bgdev.pl \ --cc=bgolaszewski@baylibre.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nsekhar@ti.com \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.