All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Alex Deucher <alexander.deucher@amd.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Chen Feng <puck.chen@hisilicon.com>,
	Christian Konig <christian.koenig@amd.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	David Zhou <David1.Zhou@amd.com>, Eric Anholt <eric@anholt.net>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Rob Clark <robdclark@gmail.com>,
	Rongrong Zou <zourongrong@gmail.com>, Sean Paul <sean@poorly.run>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v4 0/8] drm: minimize drmP.h dependencies
Date: Sat, 12 Jan 2019 20:32:43 +0100	[thread overview]
Message-ID: <20190112193251.20450-1-sam@ravnborg.org> (raw)

Updated patchset, with merged patches removed.
And one patch split in merge frindly bits.

As noted in the commit message for kirin a hack
to kirin/Kconfig was required to build it on my box.
It would be good if we could have this driver covered
by COMPILE_TEST.
There are likely others that could benefit from the same, but
this driver got my attention as Daniel reported build errors
that my setup did not trigger.
Build failed with my arm (32bit) toolchain, I did not investigate
this further.

From the original mail:

- drmP.h is now stripped down to include files and forward declarations.
- All header files in include/drm/ no longer include drmP.h.

The series was made on top of drm-misc-next
Build tested using arm and x86 allmodconfig

The patches are trivial but touches a lot of files,
so a lot of people on cc: for the individual patches.

I expect the full series to be applied to drm-misc-next

	Sam

v4:
- Rebased on top of drm-misc-next and dropped patches already merged
- Include build test of kirin (Daniel)
- Plug drm_util.h into drm-internals.rst (Daniel)
- Fix kernel-doc syntax in drm_util.h (Daniel)
- Split removal of drmP.h from drm_modeset_helper.h
  in smaller patches, to ease the merge process

v3:
- Added Acks/Reviewed annotations (thanks!)
- Add forward of drm_gem_object to drm_framebuffer.h (Noralf)
- Drop "drm: move DRM_IF_VERSION to drm_internal.h" as it is applied to drm-misc
- Drop "drm: make drm_file.h self contained" as Jan made a similar patch that was appleid to drm-misc
- Rebased on top of drm-misc-next

v2:
- DRM_SWITCH_POWER as enum (Daniel Vetter)
- Prefer forward decalration over includes (Laurent Pinchart)
- Updated drm_device to use kerneldoc style (Daniel Vetter)
- Improved commit messages (David Lechner)
- Split up patch when removing drmP.h from drm_gem_cma_helper.h
- rebased on top of drm-misc-next
- dropped patch already applied
- added reviewed-by from Laurent Pinchart (Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files



Sam Ravnborg (8):
      drm: move drm_can_sleep() to drm_util.h
      drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
      drm/stm: prepare for drmP.h removal from drm_modeset_helper.h
      drm/hisilicon/kirin: prepare for drmP.h removal from drm_modeset_helper.h
      drm/arcpgu: prepare for drmP.h removal from drm_modeset_helper.h
      drm/bridge: cdns: prepare for drmP.h removal from drm_modeset_helper.h
      drmi/rcar-du: prepare for drmP.h removal from drm_modeset_helper.h
      drm: remove drmP.h from drm_modeset_helper.h

 Documentation/gpu/drm-internals.rst             |  9 +++++
 drivers/gpu/drm/amd/amdgpu/atom.c               |  2 +
 drivers/gpu/drm/arc/arcpgu_sim.c                |  3 +-
 drivers/gpu/drm/ast/ast_fb.c                    |  2 +
 drivers/gpu/drm/bridge/cdns-dsi.c               |  2 +
 drivers/gpu/drm/cirrus/cirrus_fbdev.c           |  1 +
 drivers/gpu/drm/drm_damage_helper.c             |  1 +
 drivers/gpu/drm/drm_flip_work.c                 |  1 +
 drivers/gpu/drm/drm_framebuffer.c               |  1 +
 drivers/gpu/drm/drm_modeset_helper.c            |  2 +
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c    | 11 +++--
 drivers/gpu/drm/mgag200/mgag200_fb.c            |  1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c        |  1 +
 drivers/gpu/drm/omapdrm/omap_fbdev.c            |  1 +
 drivers/gpu/drm/qxl/qxl_cmd.c                   |  2 +
 drivers/gpu/drm/radeon/atom.c                   |  2 +
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |  1 +
 drivers/gpu/drm/rcar-du/rcar_lvds.c             |  1 +
 drivers/gpu/drm/stm/drv.c                       |  4 ++
 drivers/gpu/drm/stm/ltdc.c                      |  7 ++++
 drivers/gpu/drm/vc4/vc4_drv.h                   |  1 +
 include/drm/drmP.h                              | 19 +++------
 include/drm/drm_modeset_helper.h                |  6 ++-
 include/drm/drm_util.h                          | 53 ++++++++++++++++++++++++-
 24 files changed, 115 insertions(+), 19 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Alex Deucher <alexander.deucher@amd.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Chen Feng <puck.chen@hisilicon.com>,
	Christian Konig <christian.koenig@amd.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	David Zhou <David1.Zhou@amd.com>, Eric Anholt <eric@anholt.net>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Rob Clark <robdclark@gmail.com>,
	Rongrong Zou <zourongrong@gmail.com>, Sean Paul <sean@poorly.run>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>, Vincent Abriou <vin>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v4 0/8] drm: minimize drmP.h dependencies
Date: Sat, 12 Jan 2019 20:32:43 +0100	[thread overview]
Message-ID: <20190112193251.20450-1-sam@ravnborg.org> (raw)

Updated patchset, with merged patches removed.
And one patch split in merge frindly bits.

As noted in the commit message for kirin a hack
to kirin/Kconfig was required to build it on my box.
It would be good if we could have this driver covered
by COMPILE_TEST.
There are likely others that could benefit from the same, but
this driver got my attention as Daniel reported build errors
that my setup did not trigger.
Build failed with my arm (32bit) toolchain, I did not investigate
this further.

From the original mail:

- drmP.h is now stripped down to include files and forward declarations.
- All header files in include/drm/ no longer include drmP.h.

The series was made on top of drm-misc-next
Build tested using arm and x86 allmodconfig

The patches are trivial but touches a lot of files,
so a lot of people on cc: for the individual patches.

I expect the full series to be applied to drm-misc-next

	Sam

v4:
- Rebased on top of drm-misc-next and dropped patches already merged
- Include build test of kirin (Daniel)
- Plug drm_util.h into drm-internals.rst (Daniel)
- Fix kernel-doc syntax in drm_util.h (Daniel)
- Split removal of drmP.h from drm_modeset_helper.h
  in smaller patches, to ease the merge process

v3:
- Added Acks/Reviewed annotations (thanks!)
- Add forward of drm_gem_object to drm_framebuffer.h (Noralf)
- Drop "drm: move DRM_IF_VERSION to drm_internal.h" as it is applied to drm-misc
- Drop "drm: make drm_file.h self contained" as Jan made a similar patch that was appleid to drm-misc
- Rebased on top of drm-misc-next

v2:
- DRM_SWITCH_POWER as enum (Daniel Vetter)
- Prefer forward decalration over includes (Laurent Pinchart)
- Updated drm_device to use kerneldoc style (Daniel Vetter)
- Improved commit messages (David Lechner)
- Split up patch when removing drmP.h from drm_gem_cma_helper.h
- rebased on top of drm-misc-next
- dropped patch already applied
- added reviewed-by from Laurent Pinchart (Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files



Sam Ravnborg (8):
      drm: move drm_can_sleep() to drm_util.h
      drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
      drm/stm: prepare for drmP.h removal from drm_modeset_helper.h
      drm/hisilicon/kirin: prepare for drmP.h removal from drm_modeset_helper.h
      drm/arcpgu: prepare for drmP.h removal from drm_modeset_helper.h
      drm/bridge: cdns: prepare for drmP.h removal from drm_modeset_helper.h
      drmi/rcar-du: prepare for drmP.h removal from drm_modeset_helper.h
      drm: remove drmP.h from drm_modeset_helper.h

 Documentation/gpu/drm-internals.rst             |  9 +++++
 drivers/gpu/drm/amd/amdgpu/atom.c               |  2 +
 drivers/gpu/drm/arc/arcpgu_sim.c                |  3 +-
 drivers/gpu/drm/ast/ast_fb.c                    |  2 +
 drivers/gpu/drm/bridge/cdns-dsi.c               |  2 +
 drivers/gpu/drm/cirrus/cirrus_fbdev.c           |  1 +
 drivers/gpu/drm/drm_damage_helper.c             |  1 +
 drivers/gpu/drm/drm_flip_work.c                 |  1 +
 drivers/gpu/drm/drm_framebuffer.c               |  1 +
 drivers/gpu/drm/drm_modeset_helper.c            |  2 +
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c    | 11 +++--
 drivers/gpu/drm/mgag200/mgag200_fb.c            |  1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c        |  1 +
 drivers/gpu/drm/omapdrm/omap_fbdev.c            |  1 +
 drivers/gpu/drm/qxl/qxl_cmd.c                   |  2 +
 drivers/gpu/drm/radeon/atom.c                   |  2 +
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |  1 +
 drivers/gpu/drm/rcar-du/rcar_lvds.c             |  1 +
 drivers/gpu/drm/stm/drv.c                       |  4 ++
 drivers/gpu/drm/stm/ltdc.c                      |  7 ++++
 drivers/gpu/drm/vc4/vc4_drv.h                   |  1 +
 include/drm/drmP.h                              | 19 +++------
 include/drm/drm_modeset_helper.h                |  6 ++-
 include/drm/drm_util.h                          | 53 ++++++++++++++++++++++++-
 24 files changed, 115 insertions(+), 19 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2019-01-12 19:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 19:32 Sam Ravnborg [this message]
2019-01-12 19:32 ` [PATCH v4 0/8] drm: minimize drmP.h dependencies Sam Ravnborg
2019-01-12 19:32 ` [PATCH v4 1/8] drm: move drm_can_sleep() to drm_util.h Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-18 15:15   ` Laurent Pinchart
2019-01-18 15:15     ` Laurent Pinchart
2019-01-12 19:32 ` [PATCH v4 2/8] drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY " Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-18 15:21   ` Laurent Pinchart
2019-01-18 15:21     ` Laurent Pinchart
2019-01-12 19:32 ` [PATCH v4 3/8] drm/stm: prepare for drmP.h removal from drm_modeset_helper.h Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-14  9:59   ` Benjamin Gaignard
2019-01-14  9:59     ` Benjamin Gaignard
2019-01-12 19:32 ` [PATCH v4 4/8] drm/hisilicon/kirin: " Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-12 19:32 ` [PATCH v4 5/8] drm/arcpgu: " Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-14 13:48   ` Alexey Brodkin
2019-01-14 13:48     ` Alexey Brodkin
2019-01-12 19:32 ` [PATCH v4 6/8] drm/bridge: cdns: " Sam Ravnborg
2019-01-12 19:32   ` Sam Ravnborg
2019-01-12 19:32 ` [PATCH v4 7/8] drmi/rcar-du: " Sam Ravnborg
2019-01-12 19:32 ` Sam Ravnborg
2019-01-18 15:24   ` Laurent Pinchart
2019-01-18 15:24     ` Laurent Pinchart
2019-01-12 19:32 ` [PATCH v4 8/8] drm: remove drmP.h " Sam Ravnborg
2019-01-12 19:32 ` Sam Ravnborg
2019-01-14 10:03   ` Daniel Vetter
2019-01-14 10:03     ` Daniel Vetter
2019-01-18 15:25   ` Laurent Pinchart
2019-01-18 15:25     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190112193251.20450-1-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=David1.Zhou@amd.com \
    --cc=a.hajda@samsung.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=kraxel@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=tomi.valkeinen@ti.com \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.