All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	David Hildenbrand <david@redhat.com>,
	David Airlie <airlied@linux.ie>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	Matthew Wilcox <willy@infradead.org>
Subject: [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables
Date: Mon, 14 Jan 2019 13:58:55 +0100	[thread overview]
Message-ID: <20190114125903.24845-2-david@redhat.com> (raw)
In-Reply-To: <20190114125903.24845-1-david@redhat.com>

The l1 GATT page table is kept in a special on-chip page with 64 entries.
We allocate the l2 page table pages via get_zeroed_page() and enter them
into the table. These l2 pages are modified accordingly when
inserting/removing memory via efficeon_insert_memory and
efficeon_remove_memory.

Apart from that, these pages are not exposed or ioremap'ed. We can stop
setting them reserved (propably copied from generic code).

Cc: David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/char/agp/efficeon-agp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 7f88490b5479..c53f0f9ef5b0 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -163,7 +163,6 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge)
 		unsigned long page = efficeon_private.l1_table[index];
 		if (page) {
 			efficeon_private.l1_table[index] = 0;
-			ClearPageReserved(virt_to_page((char *)page));
 			free_page(page);
 			freed++;
 		}
@@ -219,7 +218,6 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge)
 			efficeon_free_gatt_table(agp_bridge);
 			return -ENOMEM;
 		}
-		SetPageReserved(virt_to_page((char *)page));
 
 		for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk)
 			clflush((char *)page+offset);
-- 
2.17.2


WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-s390@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	David Hildenbrand <david@redhat.com>,
	David Airlie <airlied@linux.ie>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-m68k@lists.linux-m68k.org,
	linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables
Date: Mon, 14 Jan 2019 13:58:55 +0100	[thread overview]
Message-ID: <20190114125903.24845-2-david@redhat.com> (raw)
In-Reply-To: <20190114125903.24845-1-david@redhat.com>

The l1 GATT page table is kept in a special on-chip page with 64 entries.
We allocate the l2 page table pages via get_zeroed_page() and enter them
into the table. These l2 pages are modified accordingly when
inserting/removing memory via efficeon_insert_memory and
efficeon_remove_memory.

Apart from that, these pages are not exposed or ioremap'ed. We can stop
setting them reserved (propably copied from generic code).

Cc: David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/char/agp/efficeon-agp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 7f88490b5479..c53f0f9ef5b0 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -163,7 +163,6 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge)
 		unsigned long page = efficeon_private.l1_table[index];
 		if (page) {
 			efficeon_private.l1_table[index] = 0;
-			ClearPageReserved(virt_to_page((char *)page));
 			free_page(page);
 			freed++;
 		}
@@ -219,7 +218,6 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge)
 			efficeon_free_gatt_table(agp_bridge);
 			return -ENOMEM;
 		}
-		SetPageReserved(virt_to_page((char *)page));
 
 		for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk)
 			clflush((char *)page+offset);
-- 
2.17.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-s390@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	David Hildenbrand <david@redhat.com>,
	David Airlie <airlied@linux.ie>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-m68k@lists.linux-m68k.org,
	linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables
Date: Mon, 14 Jan 2019 13:58:55 +0100	[thread overview]
Message-ID: <20190114125903.24845-2-david@redhat.com> (raw)
In-Reply-To: <20190114125903.24845-1-david@redhat.com>

The l1 GATT page table is kept in a special on-chip page with 64 entries.
We allocate the l2 page table pages via get_zeroed_page() and enter them
into the table. These l2 pages are modified accordingly when
inserting/removing memory via efficeon_insert_memory and
efficeon_remove_memory.

Apart from that, these pages are not exposed or ioremap'ed. We can stop
setting them reserved (propably copied from generic code).

Cc: David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/char/agp/efficeon-agp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 7f88490b5479..c53f0f9ef5b0 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -163,7 +163,6 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge)
 		unsigned long page = efficeon_private.l1_table[index];
 		if (page) {
 			efficeon_private.l1_table[index] = 0;
-			ClearPageReserved(virt_to_page((char *)page));
 			free_page(page);
 			freed++;
 		}
@@ -219,7 +218,6 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge)
 			efficeon_free_gatt_table(agp_bridge);
 			return -ENOMEM;
 		}
-		SetPageReserved(virt_to_page((char *)page));
 
 		for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk)
 			clflush((char *)page+offset);
-- 
2.17.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-mm@kvack.org
Cc: linux-s390@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	David Hildenbrand <david@redhat.com>,
	David Airlie <airlied@linux.ie>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-m68k@lists.linux-m68k.org,
	linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables
Date: Mon, 14 Jan 2019 13:58:55 +0100	[thread overview]
Message-ID: <20190114125903.24845-2-david@redhat.com> (raw)
In-Reply-To: <20190114125903.24845-1-david@redhat.com>

The l1 GATT page table is kept in a special on-chip page with 64 entries.
We allocate the l2 page table pages via get_zeroed_page() and enter them
into the table. These l2 pages are modified accordingly when
inserting/removing memory via efficeon_insert_memory and
efficeon_remove_memory.

Apart from that, these pages are not exposed or ioremap'ed. We can stop
setting them reserved (propably copied from generic code).

Cc: David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 drivers/char/agp/efficeon-agp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 7f88490b5479..c53f0f9ef5b0 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -163,7 +163,6 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge)
 		unsigned long page = efficeon_private.l1_table[index];
 		if (page) {
 			efficeon_private.l1_table[index] = 0;
-			ClearPageReserved(virt_to_page((char *)page));
 			free_page(page);
 			freed++;
 		}
@@ -219,7 +218,6 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge)
 			efficeon_free_gatt_table(agp_bridge);
 			return -ENOMEM;
 		}
-		SetPageReserved(virt_to_page((char *)page));
 
 		for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk)
 			clflush((char *)page+offset);
-- 
2.17.2


  reply	other threads:[~2019-01-14 12:59 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 12:58 [PATCH v2 0/9] mm: PG_reserved cleanups and documentation David Hildenbrand
2019-01-14 12:58 ` David Hildenbrand
2019-01-14 12:58 ` David Hildenbrand
2019-01-14 12:58 ` David Hildenbrand
2019-01-14 12:58 ` David Hildenbrand [this message]
2019-01-14 12:58   ` [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 2/9] s390/vdso: don't clear PG_reserved David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 3/9] powerpc/vdso: " David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 4/9] riscv/vdso: " David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-15 15:36   ` Christoph Hellwig
2019-01-15 15:36     ` Christoph Hellwig
2019-01-15 15:36     ` Christoph Hellwig
2019-01-15 15:36     ` Christoph Hellwig
2019-01-14 12:58 ` [PATCH v2 5/9] m68k/mm: use __ClearPageReserved() David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 12:58   ` David Hildenbrand
2019-01-14 14:02   ` Geert Uytterhoeven
2019-01-14 14:02     ` Geert Uytterhoeven
2019-01-14 14:02     ` Geert Uytterhoeven
2019-01-14 14:02     ` Geert Uytterhoeven
2019-01-14 14:02     ` Geert Uytterhoeven
2019-01-14 12:59 ` [PATCH v2 6/9] arm64: kexec: no need to ClearPageReserved() David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 15:50   ` Bhupesh Sharma
2019-01-14 15:50     ` Bhupesh Sharma
2019-01-14 15:50     ` Bhupesh Sharma
2019-01-14 15:50     ` Bhupesh Sharma
2019-01-14 15:50     ` Bhupesh Sharma
2019-01-25 16:25   ` Catalin Marinas
2019-01-25 16:25     ` Catalin Marinas
2019-01-25 16:25     ` Catalin Marinas
2019-01-25 16:25     ` Catalin Marinas
2019-01-14 12:59 ` [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages manually PG_reserved David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 15:52   ` Bhupesh Sharma
2019-01-14 15:52     ` Bhupesh Sharma
2019-01-14 15:52     ` Bhupesh Sharma
2019-01-14 15:52     ` Bhupesh Sharma
2019-01-14 15:52     ` Bhupesh Sharma
2019-01-14 15:52     ` Bhupesh Sharma
2019-01-25 16:28   ` Catalin Marinas
2019-01-25 16:28     ` Catalin Marinas
2019-01-25 16:28     ` Catalin Marinas
2019-01-25 16:28     ` Catalin Marinas
2019-01-25 16:28     ` Catalin Marinas
2019-01-14 12:59 ` [PATCH v2 8/9] ia64: perfmon: Don't mark buffer pages as PG_reserved David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59 ` [PATCH v2 9/9] mm: better document PG_reserved David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-14 12:59   ` David Hildenbrand
2019-01-15 15:38 ` [PATCH v2 0/9] mm: PG_reserved cleanups and documentation Christoph Hellwig
2019-01-15 15:38   ` Christoph Hellwig
2019-01-15 15:38   ` Christoph Hellwig
2019-01-15 15:38   ` Christoph Hellwig
2019-01-15 15:53   ` David Hildenbrand
2019-01-15 15:53     ` David Hildenbrand
2019-01-15 15:53     ` David Hildenbrand
2019-01-15 15:53     ` David Hildenbrand
2019-01-21 11:36 ` David Hildenbrand
2019-01-21 11:36   ` David Hildenbrand
2019-01-21 11:36   ` David Hildenbrand
2019-01-21 11:36   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114125903.24845-2-david@redhat.com \
    --to=david@redhat.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mhocko@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.