* [PATCH] lib/assoc_array: annotate implicit fall through
@ 2019-01-14 20:24 Mathieu Malaterre
2019-01-14 21:08 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:24 UTC (permalink / raw)
To: David Howells; +Cc: Mathieu Malaterre, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
lib/assoc_array.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/assoc_array.c b/lib/assoc_array.c
index c6659cb37033..0b61d3b77e5c 100644
--- a/lib/assoc_array.c
+++ b/lib/assoc_array.c
@@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
index_key))
goto found_leaf;
}
+ /* fall through */
case assoc_array_walk_tree_empty:
case assoc_array_walk_found_wrong_shortcut:
default:
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/assoc_array: annotate implicit fall through
2019-01-14 20:24 [PATCH] lib/assoc_array: annotate implicit fall through Mathieu Malaterre
@ 2019-01-14 21:08 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-14 21:08 UTC (permalink / raw)
To: Mathieu Malaterre, David Howells; +Cc: linux-kernel
On 1/14/19 2:24 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> lib/assoc_array.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
> index c6659cb37033..0b61d3b77e5c 100644
> --- a/lib/assoc_array.c
> +++ b/lib/assoc_array.c
> @@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
> index_key))
> goto found_leaf;
> }
> + /* fall through */
> case assoc_array_walk_tree_empty:
> case assoc_array_walk_found_wrong_shortcut:
> default:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-14 21:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:24 [PATCH] lib/assoc_array: annotate implicit fall through Mathieu Malaterre
2019-01-14 21:08 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.