* [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
@ 2018-12-20 13:26 Imre Deak
2018-12-20 13:26 ` [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT Imre Deak
` (8 more replies)
0 siblings, 9 replies; 16+ messages in thread
From: Imre Deak @ 2018-12-20 13:26 UTC (permalink / raw)
To: intel-gfx
We have already a function to detect DDI ports using VBT, so instead of
opencoding the DDI specific version of this, move the opencoded part to
the existing helper.
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
drivers/gpu/drm/i915/intel_display.c | 4 +---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 764d84d4109b..fa4091c0768b 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1947,6 +1947,15 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por
};
int i;
+ if (HAS_DDI(dev_priv)) {
+ const struct ddi_vbt_port_info *port_info =
+ &dev_priv->vbt.ddi_port_info[port];
+
+ return port_info->supports_dp ||
+ port_info->supports_dvi ||
+ port_info->supports_hdmi;
+ }
+
/* FIXME maybe deal with port A as well? */
if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping))
return false;
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 3b7094822aa9..a2f8aaf61c61 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14315,9 +14315,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
* On SKL we don't have a way to detect DDI-E so we rely on VBT.
*/
if (IS_GEN9_BC(dev_priv) &&
- (dev_priv->vbt.ddi_port_info[PORT_E].supports_dp ||
- dev_priv->vbt.ddi_port_info[PORT_E].supports_dvi ||
- dev_priv->vbt.ddi_port_info[PORT_E].supports_hdmi))
+ intel_bios_is_port_present(dev_priv, PORT_E))
intel_ddi_init(dev_priv, PORT_E);
} else if (HAS_PCH_SPLIT(dev_priv)) {
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
@ 2018-12-20 13:26 ` Imre Deak
2018-12-21 14:32 ` Jani Nikula
2018-12-20 13:26 ` [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection Imre Deak
` (7 subsequent siblings)
8 siblings, 1 reply; 16+ messages in thread
From: Imre Deak @ 2018-12-20 13:26 UTC (permalink / raw)
To: intel-gfx
Registering an output for a non-existent port (on a given SKU) can lead
to problems when trying to use the port, for instance timeouts during
power well enabling. Since there are no strap bits for port detection we
have to rely on VBT for this, so do that here.
There are no known SKUs where any of the A-E ports are non-existent, so
to reduce the likelihood of breakage due to incorrect VBT information,
do this detection only for port F (which is known to be missing on some
ICL SKUs).
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a2f8aaf61c61..2b81da068010 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14273,7 +14273,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
intel_ddi_init(dev_priv, PORT_C);
intel_ddi_init(dev_priv, PORT_D);
intel_ddi_init(dev_priv, PORT_E);
- intel_ddi_init(dev_priv, PORT_F);
+ /*
+ * On some ICL SKUs port F is not present. No strap bits for
+ * this, so rely on VBT.
+ */
+ if (intel_bios_is_port_present(dev_priv, PORT_F))
+ intel_ddi_init(dev_priv, PORT_F);
+
icl_dsi_init(dev_priv);
} else if (IS_GEN9_LP(dev_priv)) {
/*
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
2018-12-20 13:26 ` [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT Imre Deak
@ 2018-12-20 13:26 ` Imre Deak
2018-12-20 15:52 ` [PATCH v2 " Imre Deak
2018-12-20 15:02 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Patchwork
` (6 subsequent siblings)
8 siblings, 1 reply; 16+ messages in thread
From: Imre Deak @ 2018-12-20 13:26 UTC (permalink / raw)
To: intel-gfx
VBT may include incorrect information about the presence of port F. Work
around this on SKUs where we know the port is not present.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_display.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 815db160b966..13f94c4cc062 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2317,6 +2317,7 @@ intel_info(const struct drm_i915_private *dev_priv)
(dev_priv)->info.gt == 3)
#define IS_CNL_WITH_PORT_F(dev_priv) (IS_CANNONLAKE(dev_priv) && \
(INTEL_DEVID(dev_priv) & 0x0004) == 0x0004)
+#define IS_ICL_WITH_PORT_F(dev_priv) (INTEL_DEVID(dev_priv) != 0x8A51)
#define IS_ALPHA_SUPPORT(intel_info) ((intel_info)->is_alpha_support)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2b81da068010..bd7fdaf7e093 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14276,8 +14276,10 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
/*
* On some ICL SKUs port F is not present. No strap bits for
* this, so rely on VBT.
+ * Work around broken VBTs on SKUs known to have no port F.
*/
- if (intel_bios_is_port_present(dev_priv, PORT_F))
+ if (IS_ICL_WITH_PORT_F(dev_priv) &&
+ intel_bios_is_port_present(dev_priv, PORT_F))
intel_ddi_init(dev_priv, PORT_F);
icl_dsi_init(dev_priv);
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
2018-12-20 13:26 ` [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT Imre Deak
2018-12-20 13:26 ` [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection Imre Deak
@ 2018-12-20 15:02 ` Patchwork
2018-12-20 15:29 ` ✓ Fi.CI.BAT: success " Patchwork
` (5 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-12-20 15:02 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
URL : https://patchwork.freedesktop.org/series/54341/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/ddi: Move DDI port detection to the corresponding helper
Okay!
Commit: drm/i915/icl: Detect port F presence via VBT
Okay!
Commit: drm/i915/icl: Work around broken VBTs for port F detection
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3550:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3551:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (2 preceding siblings ...)
2018-12-20 15:02 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Patchwork
@ 2018-12-20 15:29 ` Patchwork
2018-12-20 16:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
` (4 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-12-20 15:29 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
URL : https://patchwork.freedesktop.org/series/54341/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11137
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11137 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11137, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54341/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11137:
### IGT changes ###
#### Warnings ####
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2
Known issues
------------
Here are the changes found in Patchwork_11137 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#108800]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108866]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: INCOMPLETE [fdo#105876] / [fdo#108714] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@gem_mmap_gtt@basic-small-copy-xy:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u3: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108714]: https://bugs.freedesktop.org/show_bug.cgi?id=108714
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108866]: https://bugs.freedesktop.org/show_bug.cgi?id=108866
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (49 -> 43)
------------------------------
Additional (1): fi-skl-6700hq
Missing (7): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y
Build changes
-------------
* Linux: CI_DRM_5336 -> Patchwork_11137
CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11137: b77346cbb6c5f94d4b2a364ed1270df788b454e5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b77346cbb6c5 drm/i915/icl: Work around broken VBTs for port F detection
524b5d6a2e13 drm/i915/icl: Detect port F presence via VBT
1f8b8a045206 drm/i915/ddi: Move DDI port detection to the corresponding helper
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11137/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 3/3] drm/i915/icl: Work around broken VBTs for port F detection
2018-12-20 13:26 ` [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection Imre Deak
@ 2018-12-20 15:52 ` Imre Deak
2019-01-17 1:33 ` Dhinakaran Pandiyan
0 siblings, 1 reply; 16+ messages in thread
From: Imre Deak @ 2018-12-20 15:52 UTC (permalink / raw)
To: intel-gfx
VBT may include incorrect information about the presence of port F. Work
around this on SKUs where we know the port is not present.
v2:
- Fix IS_ICL_WITH_PORT_F, so it's useable from any context.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_display.c | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 815db160b966..e45cda9d9555 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2317,6 +2317,8 @@ intel_info(const struct drm_i915_private *dev_priv)
(dev_priv)->info.gt == 3)
#define IS_CNL_WITH_PORT_F(dev_priv) (IS_CANNONLAKE(dev_priv) && \
(INTEL_DEVID(dev_priv) & 0x0004) == 0x0004)
+#define IS_ICL_WITH_PORT_F(dev_priv) (IS_ICELAKE(dev_priv) && \
+ INTEL_DEVID(dev_priv) != 0x8A51)
#define IS_ALPHA_SUPPORT(intel_info) ((intel_info)->is_alpha_support)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2b81da068010..bd7fdaf7e093 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14276,8 +14276,10 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
/*
* On some ICL SKUs port F is not present. No strap bits for
* this, so rely on VBT.
+ * Work around broken VBTs on SKUs known to have no port F.
*/
- if (intel_bios_is_port_present(dev_priv, PORT_F))
+ if (IS_ICL_WITH_PORT_F(dev_priv) &&
+ intel_bios_is_port_present(dev_priv, PORT_F))
intel_ddi_init(dev_priv, PORT_F);
icl_dsi_init(dev_priv);
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (3 preceding siblings ...)
2018-12-20 15:29 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-12-20 16:39 ` Patchwork
2018-12-20 16:40 ` ✗ Fi.CI.SPARSE: " Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-12-20 16:39 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
URL : https://patchwork.freedesktop.org/series/54341/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0f71660394ec drm/i915/ddi: Move DDI port detection to the corresponding helper
51299ac215a8 drm/i915/icl: Detect port F presence via VBT
2e4395c3050c drm/i915/icl: Work around broken VBTs for port F detection
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#25: FILE: drivers/gpu/drm/i915/i915_drv.h:2320:
+#define IS_ICL_WITH_PORT_F(dev_priv) (IS_ICELAKE(dev_priv) && \
+ INTEL_DEVID(dev_priv) != 0x8A51)
total: 0 errors, 0 warnings, 1 checks, 19 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (4 preceding siblings ...)
2018-12-20 16:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
@ 2018-12-20 16:40 ` Patchwork
2018-12-20 17:00 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-12-20 16:40 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
URL : https://patchwork.freedesktop.org/series/54341/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/ddi: Move DDI port detection to the corresponding helper
Okay!
Commit: drm/i915/icl: Detect port F presence via VBT
Okay!
Commit: drm/i915/icl: Work around broken VBTs for port F detection
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3550:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3552:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (5 preceding siblings ...)
2018-12-20 16:40 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2018-12-20 17:00 ` Patchwork
2018-12-21 14:26 ` [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Jani Nikula
2018-12-21 16:02 ` ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
8 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-12-20 17:00 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
URL : https://patchwork.freedesktop.org/series/54341/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11141
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11141 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_11141, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54341/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11141:
### IGT changes ###
#### Warnings ####
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2
Known issues
------------
Here are the changes found in Patchwork_11141 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: INCOMPLETE [fdo#105876] / [fdo#108714] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@gem_mmap_gtt@basic-small-copy-xy:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108714]: https://bugs.freedesktop.org/show_bug.cgi?id=108714
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (49 -> 44)
------------------------------
Additional (1): fi-skl-6700hq
Missing (6): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_5336 -> Patchwork_11141
CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11141: 2e4395c3050c99e51227b146a7048fd7c8498760 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2e4395c3050c drm/i915/icl: Work around broken VBTs for port F detection
51299ac215a8 drm/i915/icl: Detect port F presence via VBT
0f71660394ec drm/i915/ddi: Move DDI port detection to the corresponding helper
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11141/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (6 preceding siblings ...)
2018-12-20 17:00 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-12-21 14:26 ` Jani Nikula
2018-12-21 16:02 ` ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
8 siblings, 0 replies; 16+ messages in thread
From: Jani Nikula @ 2018-12-21 14:26 UTC (permalink / raw)
To: Imre Deak, intel-gfx
On Thu, 20 Dec 2018, Imre Deak <imre.deak@intel.com> wrote:
> We have already a function to detect DDI ports using VBT, so instead of
> opencoding the DDI specific version of this, move the opencoded part to
> the existing helper.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
> drivers/gpu/drm/i915/intel_display.c | 4 +---
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 764d84d4109b..fa4091c0768b 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1947,6 +1947,15 @@ bool intel_bios_is_port_present(struct drm_i915_private *dev_priv, enum port por
> };
> int i;
>
> + if (HAS_DDI(dev_priv)) {
> + const struct ddi_vbt_port_info *port_info =
> + &dev_priv->vbt.ddi_port_info[port];
> +
> + return port_info->supports_dp ||
> + port_info->supports_dvi ||
> + port_info->supports_hdmi;
> + }
> +
I think it's pretty silly that we have two ways to parse the child
device info, pre-ddi and post-ddi... but it's not a problem with this
specific patch.
Also this doesn't work for DSI... but not a problem with this specific
patch either...
I guess a bit hesitant
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
BR,
Jani.
> /* FIXME maybe deal with port A as well? */
> if (WARN_ON(port == PORT_A) || port >= ARRAY_SIZE(port_mapping))
> return false;
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 3b7094822aa9..a2f8aaf61c61 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14315,9 +14315,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> * On SKL we don't have a way to detect DDI-E so we rely on VBT.
> */
> if (IS_GEN9_BC(dev_priv) &&
> - (dev_priv->vbt.ddi_port_info[PORT_E].supports_dp ||
> - dev_priv->vbt.ddi_port_info[PORT_E].supports_dvi ||
> - dev_priv->vbt.ddi_port_info[PORT_E].supports_hdmi))
> + intel_bios_is_port_present(dev_priv, PORT_E))
> intel_ddi_init(dev_priv, PORT_E);
>
> } else if (HAS_PCH_SPLIT(dev_priv)) {
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT
2018-12-20 13:26 ` [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT Imre Deak
@ 2018-12-21 14:32 ` Jani Nikula
0 siblings, 0 replies; 16+ messages in thread
From: Jani Nikula @ 2018-12-21 14:32 UTC (permalink / raw)
To: Imre Deak, intel-gfx
On Thu, 20 Dec 2018, Imre Deak <imre.deak@intel.com> wrote:
> Registering an output for a non-existent port (on a given SKU) can lead
> to problems when trying to use the port, for instance timeouts during
> power well enabling. Since there are no strap bits for port detection we
> have to rely on VBT for this, so do that here.
>
> There are no known SKUs where any of the A-E ports are non-existent, so
> to reduce the likelihood of breakage due to incorrect VBT information,
> do this detection only for port F (which is known to be missing on some
> ICL SKUs).
Even this one relies on correct VBT... but the code does what it says on
the box, so
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a2f8aaf61c61..2b81da068010 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14273,7 +14273,13 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> intel_ddi_init(dev_priv, PORT_C);
> intel_ddi_init(dev_priv, PORT_D);
> intel_ddi_init(dev_priv, PORT_E);
> - intel_ddi_init(dev_priv, PORT_F);
> + /*
> + * On some ICL SKUs port F is not present. No strap bits for
> + * this, so rely on VBT.
> + */
> + if (intel_bios_is_port_present(dev_priv, PORT_F))
> + intel_ddi_init(dev_priv, PORT_F);
> +
> icl_dsi_init(dev_priv);
> } else if (IS_GEN9_LP(dev_priv)) {
> /*
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
` (7 preceding siblings ...)
2018-12-21 14:26 ` [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Jani Nikula
@ 2018-12-21 16:02 ` Patchwork
2019-01-15 14:51 ` Imre Deak
2019-01-31 14:48 ` Imre Deak
8 siblings, 2 replies; 16+ messages in thread
From: Patchwork @ 2018-12-21 16:02 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
URL : https://patchwork.freedesktop.org/series/54341/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11141_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_11141_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-skl: PASS -> TIMEOUT [fdo#108039]
* igt@i915_selftest@live_workarounds:
- shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
* igt@i915_suspend@shrink:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#108784]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-c-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-iclb: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-skl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +9
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +5
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#103167] +2
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-iclb: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-iclb: PASS -> FAIL [fdo#100047]
* igt@pm_rpm@fences:
- shard-iclb: NOTRUN -> INCOMPLETE [fdo#108840]
* igt@pm_rpm@i2c:
- shard-iclb: PASS -> FAIL [fdo#104097]
* igt@pm_rpm@universal-planes:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108654] / [fdo#108756]
* igt@sw_sync@sync_busy_fork:
- shard-iclb: PASS -> INCOMPLETE [fdo#108889]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-glk: FAIL [fdo#105957] -> PASS
* igt@gem_userptr_blits@readonly-unsync:
- shard-skl: TIMEOUT [fdo#108887] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +10
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +11
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-iclb: WARN [fdo#108336] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-skl: FAIL [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-iclb: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +8
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +7
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@pm_rpm@i2c:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
* igt@pm_rpm@legacy-planes:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS
* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- shard-iclb: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]
* igt@i915_suspend@shrink:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#108784]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-iclb: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#108948]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> DMESG-FAIL [fdo#108950]
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
[fdo#108889]: https://bugs.freedesktop.org/show_bug.cgi?id=108889
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5336 -> Patchwork_11141
CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11141: 2e4395c3050c99e51227b146a7048fd7c8498760 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11141/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-21 16:02 ` ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
@ 2019-01-15 14:51 ` Imre Deak
2019-01-31 14:48 ` Imre Deak
1 sibling, 0 replies; 16+ messages in thread
From: Imre Deak @ 2019-01-15 14:51 UTC (permalink / raw)
To: intel-gfx, Jani Nikula
On Fri, Dec 21, 2018 at 04:02:07PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
> URL : https://patchwork.freedesktop.org/series/54341/
> State : success
Thanks for the review, pushed patches 1 and 2 to -dinq. Any chance Jani
to get some comment on patch 3?
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11141_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_11141_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_exec_schedule@pi-ringfull-blt:
> - shard-skl: NOTRUN -> FAIL [fdo#103158]
>
> * igt@gem_ppgtt@blt-vs-render-ctxn:
> - shard-skl: PASS -> TIMEOUT [fdo#108039]
>
> * igt@i915_selftest@live_workarounds:
> - shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
>
> * igt@i915_suspend@shrink:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#108784]
>
> * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1
>
> * igt@kms_busy@extended-pageflip-hang-newfb-render-c:
> - shard-glk: PASS -> DMESG-WARN [fdo#107956]
>
> * igt@kms_color@pipe-c-ctm-max:
> - shard-apl: PASS -> FAIL [fdo#108147]
>
> * igt@kms_cursor_crc@cursor-128x128-onscreen:
> - shard-skl: NOTRUN -> FAIL [fdo#103232] +1
>
> * igt@kms_cursor_crc@cursor-128x128-suspend:
> - shard-iclb: NOTRUN -> FAIL [fdo#103232]
>
> * igt@kms_cursor_crc@cursor-256x256-onscreen:
> - shard-skl: PASS -> FAIL [fdo#103232] +1
>
> * igt@kms_cursor_crc@cursor-256x85-sliding:
> - shard-apl: PASS -> FAIL [fdo#103232]
>
> * igt@kms_flip@basic-flip-vs-wf_vblank:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] +9
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> - shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +4
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
> - shard-apl: PASS -> FAIL [fdo#103167] +1
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
> - shard-skl: PASS -> FAIL [fdo#103167] +3
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> - shard-glk: PASS -> FAIL [fdo#103167] +4
>
> * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +5
>
> * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
> - shard-iclb: PASS -> FAIL [fdo#103167] +2
>
> * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1
>
> * igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
> - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> - shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
> - shard-skl: NOTRUN -> FAIL [fdo#108145] +1
>
> * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> - shard-glk: PASS -> FAIL [fdo#103166] +4
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
> - shard-apl: PASS -> FAIL [fdo#103166] +1
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
> - shard-iclb: PASS -> FAIL [fdo#103166]
>
> * igt@kms_setmode@basic:
> - shard-kbl: PASS -> FAIL [fdo#99912]
>
> * igt@kms_sysfs_edid_timing:
> - shard-iclb: PASS -> FAIL [fdo#100047]
>
> * igt@pm_rpm@fences:
> - shard-iclb: NOTRUN -> INCOMPLETE [fdo#108840]
>
> * igt@pm_rpm@i2c:
> - shard-iclb: PASS -> FAIL [fdo#104097]
>
> * igt@pm_rpm@universal-planes:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108654] / [fdo#108756]
>
> * igt@sw_sync@sync_busy_fork:
> - shard-iclb: PASS -> INCOMPLETE [fdo#108889]
>
>
> #### Possible fixes ####
>
> * igt@gem_eio@unwedge-stress:
> - shard-glk: FAIL [fdo#105957] -> PASS
>
> * igt@gem_userptr_blits@readonly-unsync:
> - shard-skl: TIMEOUT [fdo#108887] -> PASS
>
> * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
> - shard-iclb: DMESG-WARN [fdo#107724] -> PASS +10
>
> * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> - shard-glk: FAIL [fdo#108145] -> PASS
>
> * igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
> - shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +11
>
> * igt@kms_cursor_crc@cursor-128x128-dpms:
> - shard-apl: FAIL [fdo#103232] -> PASS +1
>
> * igt@kms_cursor_crc@cursor-128x128-suspend:
> - shard-skl: INCOMPLETE [fdo#104108] -> PASS
>
> * igt@kms_cursor_crc@cursor-128x42-offscreen:
> - shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
>
> * igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
> - shard-iclb: WARN [fdo#108336] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
> - shard-apl: FAIL [fdo#103167] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
> - shard-skl: FAIL [fdo#105682] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> - shard-iclb: FAIL [fdo#103167] -> PASS +1
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> - shard-glk: FAIL [fdo#103167] -> PASS +5
>
> * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
> - shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +8
>
> * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
>
> * igt@kms_plane@plane-position-covered-pipe-a-planes:
> - shard-glk: FAIL [fdo#103166] -> PASS
>
> * igt@kms_plane@plane-position-covered-pipe-c-planes:
> - shard-apl: FAIL [fdo#103166] -> PASS +2
>
> * igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
> - shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +7
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
> - shard-iclb: FAIL [fdo#103166] -> PASS
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
> - shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
>
> * igt@kms_setmode@basic:
> - shard-apl: FAIL [fdo#99912] -> PASS
>
> * igt@pm_rpm@i2c:
> - shard-skl: INCOMPLETE [fdo#107807] -> PASS
>
> * igt@pm_rpm@legacy-planes:
> - shard-iclb: DMESG-WARN [fdo#108654] -> PASS
>
> * igt@pm_rpm@system-suspend-execbuf:
> - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] -> PASS
>
>
> #### Warnings ####
>
> * igt@i915_selftest@live_contexts:
> - shard-iclb: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]
>
> * igt@i915_suspend@shrink:
> - shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#108784]
>
> * igt@kms_cursor_crc@cursor-64x64-dpms:
> - shard-iclb: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]
>
> * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> - shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#108948]
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
> - shard-kbl: DMESG-WARN [fdo#105604] -> DMESG-FAIL [fdo#108950]
>
>
> [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> [fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
> [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
> [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
> [fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
> [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
> [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
> [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
> [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
> [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
> [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
> [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
> [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> [fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> [fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
> [fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
> [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
> [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
> [fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
> [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
> [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
> [fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
> [fdo#108889]: https://bugs.freedesktop.org/show_bug.cgi?id=108889
> [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
> [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
> [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
> [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (7 -> 7)
> ------------------------------
>
> No changes in participating hosts
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_5336 -> Patchwork_11141
>
> CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_11141: 2e4395c3050c99e51227b146a7048fd7c8498760 @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11141/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/3] drm/i915/icl: Work around broken VBTs for port F detection
2018-12-20 15:52 ` [PATCH v2 " Imre Deak
@ 2019-01-17 1:33 ` Dhinakaran Pandiyan
2019-01-17 16:09 ` Imre Deak
0 siblings, 1 reply; 16+ messages in thread
From: Dhinakaran Pandiyan @ 2019-01-17 1:33 UTC (permalink / raw)
To: Imre Deak, intel-gfx
On Thu, 2018-12-20 at 17:52 +0200, Imre Deak wrote:
> VBT may include incorrect information about the presence of port F.
> Work
> around this on SKUs where we know the port is not present.
If we cannot trust the data in VBT, can we not test for the absence of
port-F by enabling the powerwell and checking for a timeout? Or at
least mark up a non-existent port after the first timeout so that we
don't keep probing it.
This patch is an improvement over checking the VBT for all ports, so
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> v2:
> - Fix IS_ICL_WITH_PORT_F, so it's useable from any context.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/intel_display.c | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> index 815db160b966..e45cda9d9555 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2317,6 +2317,8 @@ intel_info(const struct drm_i915_private
> *dev_priv)
> (dev_priv)->info.gt == 3)
> #define IS_CNL_WITH_PORT_F(dev_priv) (IS_CANNONLAKE(dev_priv) && \
> (INTEL_DEVID(dev_priv) &
> 0x0004) == 0x0004)
> +#define IS_ICL_WITH_PORT_F(dev_priv) (IS_ICELAKE(dev_priv) && \
> + INTEL_DEVID(dev_priv) !=
> 0x8A51)
>
> #define IS_ALPHA_SUPPORT(intel_info) ((intel_info)-
> >is_alpha_support)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 2b81da068010..bd7fdaf7e093 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14276,8 +14276,10 @@ static void intel_setup_outputs(struct
> drm_i915_private *dev_priv)
> /*
> * On some ICL SKUs port F is not present. No strap
> bits for
> * this, so rely on VBT.
> + * Work around broken VBTs on SKUs known to have no
> port F.
> */
> - if (intel_bios_is_port_present(dev_priv, PORT_F))
> + if (IS_ICL_WITH_PORT_F(dev_priv) &&
> + intel_bios_is_port_present(dev_priv, PORT_F))
> intel_ddi_init(dev_priv, PORT_F);
>
> icl_dsi_init(dev_priv);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/3] drm/i915/icl: Work around broken VBTs for port F detection
2019-01-17 1:33 ` Dhinakaran Pandiyan
@ 2019-01-17 16:09 ` Imre Deak
0 siblings, 0 replies; 16+ messages in thread
From: Imre Deak @ 2019-01-17 16:09 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
Hi,
On Wed, Jan 16, 2019 at 05:33:19PM -0800, Dhinakaran Pandiyan wrote:
> On Thu, 2018-12-20 at 17:52 +0200, Imre Deak wrote:
> > VBT may include incorrect information about the presence of port F.
> > Work
> > around this on SKUs where we know the port is not present.
>
> If we cannot trust the data in VBT, can we not test for the absence of
> port-F by enabling the powerwell and checking for a timeout? Or at
> least mark up a non-existent port after the first timeout so that we
> don't keep probing it.
Yes, thought about it too, but I'm not sure if it's a good idea.
Enabling power wells has unexpected (at least to me) side effects on
ICL, so I'd rather avoid using that as a detection method. OTOH the PCI
ID list with fused-off ports must be well-defined and known, there just
seems to be a difficulty to get at that list internally.
So instead I'd suggest pushing for getting that list added to BSpec. I
opened already a change request in BSpec for that, but more poking would
be good.
>
> This patch is an improvement over checking the VBT for all ports, so
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Thanks for the review.
>
> >
> > v2:
> > - Fix IS_ICL_WITH_PORT_F, so it's useable from any context.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915
> > Cc: Mika Kahola <mika.kahola@intel.com>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > drivers/gpu/drm/i915/intel_display.c | 4 +++-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index 815db160b966..e45cda9d9555 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2317,6 +2317,8 @@ intel_info(const struct drm_i915_private
> > *dev_priv)
> > (dev_priv)->info.gt == 3)
> > #define IS_CNL_WITH_PORT_F(dev_priv) (IS_CANNONLAKE(dev_priv) && \
> > (INTEL_DEVID(dev_priv) &
> > 0x0004) == 0x0004)
> > +#define IS_ICL_WITH_PORT_F(dev_priv) (IS_ICELAKE(dev_priv) && \
> > + INTEL_DEVID(dev_priv) !=
> > 0x8A51)
> >
> > #define IS_ALPHA_SUPPORT(intel_info) ((intel_info)-
> > >is_alpha_support)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 2b81da068010..bd7fdaf7e093 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -14276,8 +14276,10 @@ static void intel_setup_outputs(struct
> > drm_i915_private *dev_priv)
> > /*
> > * On some ICL SKUs port F is not present. No strap
> > bits for
> > * this, so rely on VBT.
> > + * Work around broken VBTs on SKUs known to have no
> > port F.
> > */
> > - if (intel_bios_is_port_present(dev_priv, PORT_F))
> > + if (IS_ICL_WITH_PORT_F(dev_priv) &&
> > + intel_bios_is_port_present(dev_priv, PORT_F))
> > intel_ddi_init(dev_priv, PORT_F);
> >
> > icl_dsi_init(dev_priv);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
2018-12-21 16:02 ` ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
2019-01-15 14:51 ` Imre Deak
@ 2019-01-31 14:48 ` Imre Deak
1 sibling, 0 replies; 16+ messages in thread
From: Imre Deak @ 2019-01-31 14:48 UTC (permalink / raw)
To: intel-gfx, Dhinakaran Pandiyan
On Fri, Dec 21, 2018 at 04:02:07PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)
> URL : https://patchwork.freedesktop.org/series/54341/
> State : success
Pushed patch 3 too from the series, thanks for the review.
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11141_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_11141_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_exec_schedule@pi-ringfull-blt:
> - shard-skl: NOTRUN -> FAIL [fdo#103158]
>
> * igt@gem_ppgtt@blt-vs-render-ctxn:
> - shard-skl: PASS -> TIMEOUT [fdo#108039]
>
> * igt@i915_selftest@live_workarounds:
> - shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
>
> * igt@i915_suspend@shrink:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#108784]
>
> * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1
>
> * igt@kms_busy@extended-pageflip-hang-newfb-render-c:
> - shard-glk: PASS -> DMESG-WARN [fdo#107956]
>
> * igt@kms_color@pipe-c-ctm-max:
> - shard-apl: PASS -> FAIL [fdo#108147]
>
> * igt@kms_cursor_crc@cursor-128x128-onscreen:
> - shard-skl: NOTRUN -> FAIL [fdo#103232] +1
>
> * igt@kms_cursor_crc@cursor-128x128-suspend:
> - shard-iclb: NOTRUN -> FAIL [fdo#103232]
>
> * igt@kms_cursor_crc@cursor-256x256-onscreen:
> - shard-skl: PASS -> FAIL [fdo#103232] +1
>
> * igt@kms_cursor_crc@cursor-256x85-sliding:
> - shard-apl: PASS -> FAIL [fdo#103232]
>
> * igt@kms_flip@basic-flip-vs-wf_vblank:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] +9
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> - shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +4
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
> - shard-apl: PASS -> FAIL [fdo#103167] +1
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
> - shard-skl: PASS -> FAIL [fdo#103167] +3
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> - shard-glk: PASS -> FAIL [fdo#103167] +4
>
> * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +5
>
> * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
> - shard-iclb: PASS -> FAIL [fdo#103167] +2
>
> * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> - shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1
>
> * igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
> - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> - shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]
>
> * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
> - shard-skl: NOTRUN -> FAIL [fdo#108145] +1
>
> * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> - shard-glk: PASS -> FAIL [fdo#103166] +4
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
> - shard-apl: PASS -> FAIL [fdo#103166] +1
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
> - shard-iclb: PASS -> FAIL [fdo#103166]
>
> * igt@kms_setmode@basic:
> - shard-kbl: PASS -> FAIL [fdo#99912]
>
> * igt@kms_sysfs_edid_timing:
> - shard-iclb: PASS -> FAIL [fdo#100047]
>
> * igt@pm_rpm@fences:
> - shard-iclb: NOTRUN -> INCOMPLETE [fdo#108840]
>
> * igt@pm_rpm@i2c:
> - shard-iclb: PASS -> FAIL [fdo#104097]
>
> * igt@pm_rpm@universal-planes:
> - shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108654] / [fdo#108756]
>
> * igt@sw_sync@sync_busy_fork:
> - shard-iclb: PASS -> INCOMPLETE [fdo#108889]
>
>
> #### Possible fixes ####
>
> * igt@gem_eio@unwedge-stress:
> - shard-glk: FAIL [fdo#105957] -> PASS
>
> * igt@gem_userptr_blits@readonly-unsync:
> - shard-skl: TIMEOUT [fdo#108887] -> PASS
>
> * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
> - shard-iclb: DMESG-WARN [fdo#107724] -> PASS +10
>
> * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> - shard-glk: FAIL [fdo#108145] -> PASS
>
> * igt@kms_chv_cursor_fail@pipe-b-128x128-bottom-edge:
> - shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +11
>
> * igt@kms_cursor_crc@cursor-128x128-dpms:
> - shard-apl: FAIL [fdo#103232] -> PASS +1
>
> * igt@kms_cursor_crc@cursor-128x128-suspend:
> - shard-skl: INCOMPLETE [fdo#104108] -> PASS
>
> * igt@kms_cursor_crc@cursor-128x42-offscreen:
> - shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
>
> * igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
> - shard-iclb: WARN [fdo#108336] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
> - shard-apl: FAIL [fdo#103167] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
> - shard-skl: FAIL [fdo#105682] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> - shard-iclb: FAIL [fdo#103167] -> PASS +1
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> - shard-glk: FAIL [fdo#103167] -> PASS +5
>
> * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
> - shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +8
>
> * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
>
> * igt@kms_plane@plane-position-covered-pipe-a-planes:
> - shard-glk: FAIL [fdo#103166] -> PASS
>
> * igt@kms_plane@plane-position-covered-pipe-c-planes:
> - shard-apl: FAIL [fdo#103166] -> PASS +2
>
> * igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
> - shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +7
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
> - shard-iclb: FAIL [fdo#103166] -> PASS
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
> - shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS
>
> * igt@kms_setmode@basic:
> - shard-apl: FAIL [fdo#99912] -> PASS
>
> * igt@pm_rpm@i2c:
> - shard-skl: INCOMPLETE [fdo#107807] -> PASS
>
> * igt@pm_rpm@legacy-planes:
> - shard-iclb: DMESG-WARN [fdo#108654] -> PASS
>
> * igt@pm_rpm@system-suspend-execbuf:
> - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] -> PASS
>
>
> #### Warnings ####
>
> * igt@i915_selftest@live_contexts:
> - shard-iclb: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]
>
> * igt@i915_suspend@shrink:
> - shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#108784]
>
> * igt@kms_cursor_crc@cursor-64x64-dpms:
> - shard-iclb: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]
>
> * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> - shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#108948]
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
> - shard-kbl: DMESG-WARN [fdo#105604] -> DMESG-FAIL [fdo#108950]
>
>
> [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> [fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
> [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
> [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
> [fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
> [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
> [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
> [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
> [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
> [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
> [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
> [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
> [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> [fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> [fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
> [fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
> [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
> [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
> [fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
> [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
> [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
> [fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
> [fdo#108889]: https://bugs.freedesktop.org/show_bug.cgi?id=108889
> [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
> [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
> [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
> [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (7 -> 7)
> ------------------------------
>
> No changes in participating hosts
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_5336 -> Patchwork_11141
>
> CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_11141: 2e4395c3050c99e51227b146a7048fd7c8498760 @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11141/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-01-31 14:48 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 13:26 [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Imre Deak
2018-12-20 13:26 ` [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT Imre Deak
2018-12-21 14:32 ` Jani Nikula
2018-12-20 13:26 ` [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection Imre Deak
2018-12-20 15:52 ` [PATCH v2 " Imre Deak
2019-01-17 1:33 ` Dhinakaran Pandiyan
2019-01-17 16:09 ` Imre Deak
2018-12-20 15:02 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Patchwork
2018-12-20 15:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-20 16:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
2018-12-20 16:40 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-20 17:00 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-21 14:26 ` [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper Jani Nikula
2018-12-21 16:02 ` ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) Patchwork
2019-01-15 14:51 ` Imre Deak
2019-01-31 14:48 ` Imre Deak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.