* [U-Boot] [PATCH] mkimage: fixup CONFIG_FIT_EXTERNAL_OFFSET
@ 2019-01-15 15:34 Patrick Wildt
2019-01-19 2:53 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Wildt @ 2019-01-15 15:34 UTC (permalink / raw)
To: u-boot
The last parameter is expected to be the imagefile. Since -E is a
flag having the output name before -p will make mkimage ignore the
external offset option.
Signed-off-by: Patrick Wildt <patrick@blueri.se>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6aa08964ff..8efe51fb89 100644
--- a/Makefile
+++ b/Makefile
@@ -893,7 +893,7 @@ cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \
>$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT))
quiet_cmd_mkfitimage = MKIMAGE $@
-cmd_mkfitimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -f $(U_BOOT_ITS) -E $@ -p $(CONFIG_FIT_EXTERNAL_OFFSET)\
+cmd_mkfitimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -f $(U_BOOT_ITS) -E -p $(CONFIG_FIT_EXTERNAL_OFFSET) $@\
>$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT))
quiet_cmd_cat = CAT $@
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] mkimage: fixup CONFIG_FIT_EXTERNAL_OFFSET
2019-01-15 15:34 [U-Boot] [PATCH] mkimage: fixup CONFIG_FIT_EXTERNAL_OFFSET Patrick Wildt
@ 2019-01-19 2:53 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-01-19 2:53 UTC (permalink / raw)
To: u-boot
On Tue, Jan 15, 2019 at 04:34:19PM +0100, Patrick Wildt wrote:
> The last parameter is expected to be the imagefile. Since -E is a
> flag having the output name before -p will make mkimage ignore the
> external offset option.
>
> Signed-off-by: Patrick Wildt <patrick@blueri.se>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190118/5715b27f/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-19 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 15:34 [U-Boot] [PATCH] mkimage: fixup CONFIG_FIT_EXTERNAL_OFFSET Patrick Wildt
2019-01-19 2:53 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.