From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [GIT PULL] dtype handling cleanup for v4.21-rc1
Date: Tue, 15 Jan 2019 10:01:56 -0800 [thread overview]
Message-ID: <20190115180156.GB6310@bombadil.infradead.org> (raw)
In-Reply-To: <CAHk-=wiW=4k3iBkDzz5_LuyCRcduZJuk-Vwhz9vqrUMML6WVkg@mail.gmail.com>
On Wed, Jan 16, 2019 at 05:36:06AM +1200, Linus Torvalds wrote:
> On Tue, Jan 15, 2019 at 9:24 PM Jan Kara <jack@suse.cz> wrote:
> >
> > What has happened to this pull request? It may be too late for this to be
> > merged now but I'd like to understand why it was not merged or rejected...
>
> Sorry, initially I left if for later consideration after rc1, and then
> I just forgot about it.
>
> I didn't see much point to the cleanup when it actually adds lots of
> lines and no actual advantage. The whole dentry type translation
> really is fs-specific and it might just happen to be shared. But why
> share it if it only adds complexity and unnecessary abstraction?
The ext2/ext4 patches don't show much improvement. The other patches show
more:
fs/nilfs2/dir.c | 52 ++++++++++--------------------
include/uapi/linux/nilfs2_ondisk.h | 1 +
2 files changed, 18 insertions(+), 35 deletions(-)
(for example).
UFS ends up benefiting the most. You can see the whole diffstat here:
https://lore.kernel.org/lkml/20181023201952.GA15676@pathfinder/
We'd see a lot more improvement in line count if Philip weren't quite
so paranoid about checking FOOFS_FT_* == FT_* at build time; eg for btrfs:
https://lore.kernel.org/lkml/20181023211728.GA16584@pathfinder/
next prev parent reply other threads:[~2019-01-15 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 17:47 [GIT PULL] dtype handling cleanup for v4.21-rc1 Jan Kara
2019-01-08 10:05 ` Jan Kara
2019-01-15 9:24 ` Jan Kara
2019-01-15 17:36 ` Linus Torvalds
2019-01-15 18:01 ` Matthew Wilcox [this message]
2019-01-15 19:25 ` Linus Torvalds
2019-01-16 12:07 ` Jan Kara
2019-01-16 16:34 ` Phillip Potter
2019-01-16 16:51 ` Jan Kara
2019-01-16 16:56 ` Amir Goldstein
2019-01-17 9:35 ` Jan Kara
2019-01-17 11:17 ` Amir Goldstein
2019-01-16 6:22 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115180156.GB6310@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.