All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Matthias Reichl <hias@horus.com>,
	rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, vinod.koul@linaro.org,
	lgirdwood@gmail.com, plai@codeaurora.org,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	srinivas.kandagatla@linaro.org,
	Rohit kumar <rohitkr@codeaurora.org>,
	asishb@codeaurora.org, Ajit Pandey <ajitp@codeaurora.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component
Date: Tue, 15 Jan 2019 21:41:38 +0000	[thread overview]
Message-ID: <20190115214138.GL5522@sirena.org.uk> (raw)
In-Reply-To: <af2e9555-444f-7c40-865b-347f3db8fa76@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On Tue, Jan 15, 2019 at 03:16:57PM -0600, Pierre-Louis Bossart wrote:

> > Maybe the defer card probe logic needs to be extended to also check if
> > dai_link_name had already been registered (either cpu or cpu_dai_name
> > needs to be set), not 100% sure which problem the defer card probe patch
> > was trying to solve.

We were getting cards probing without the platforms being registered
(which in turn meant we were just skipping their init) and had patches
proposed to implement the deferral in the cards.  The deferral stuff is
supposed to making sure that everything is registered when we
instantiate.

> same here, I don't get why the deferred probe stuff only deals with one of
> the two options.

I think it's just an oversight - I think the change you were proposing
to check the cpu_dai_name is a good idea anyway as it makes things more
consistent and work more obviously by intention.  And more generally if
we can simplify the code by removing legacy options that'd be good but
that's a bigger bit of work...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, vinod.koul@linaro.org,
	plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com,
	Ajit Pandey <ajitp@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Matthias Reichl <hias@horus.com>,
	srinivas.kandagatla@linaro.org, asishb@codeaurora.org,
	Rohit kumar <rohitkr@codeaurora.org>
Subject: Re: [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component
Date: Tue, 15 Jan 2019 21:41:38 +0000	[thread overview]
Message-ID: <20190115214138.GL5522@sirena.org.uk> (raw)
In-Reply-To: <af2e9555-444f-7c40-865b-347f3db8fa76@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1025 bytes --]

On Tue, Jan 15, 2019 at 03:16:57PM -0600, Pierre-Louis Bossart wrote:

> > Maybe the defer card probe logic needs to be extended to also check if
> > dai_link_name had already been registered (either cpu or cpu_dai_name
> > needs to be set), not 100% sure which problem the defer card probe patch
> > was trying to solve.

We were getting cards probing without the platforms being registered
(which in turn meant we were just skipping their init) and had patches
proposed to implement the deferral in the cards.  The deferral stuff is
supposed to making sure that everything is registered when we
instantiate.

> same here, I don't get why the deferred probe stuff only deals with one of
> the two options.

I think it's just an oversight - I think the change you were proposing
to check the cpu_dai_name is a good idea anyway as it makes things more
consistent and work more obviously by intention.  And more generally if
we can simplify the code by removing legacy options that'd be good but
that's a bigger bit of work...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2019-01-15 21:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  8:14 [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component Rohit kumar
2019-01-11 15:44 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-11 21:49   ` Pierre-Louis Bossart
2019-01-12  6:07     ` Rohit kumar
2019-01-12  6:07       ` Rohit kumar
2019-01-14 15:40       ` [alsa-devel] " Liam Girdwood
2019-01-15  0:06     ` Mark Brown
2019-01-15  0:06       ` Mark Brown
2019-01-15  3:08       ` [alsa-devel] " Pierre-Louis Bossart
2019-01-15  3:08         ` Pierre-Louis Bossart
2019-01-15 19:35       ` [alsa-devel] " Pierre-Louis Bossart
2019-01-15 21:07         ` Mark Brown
2019-01-15 21:07           ` Mark Brown
2019-01-15 21:11         ` [alsa-devel] " Matthias Reichl
2019-01-15 21:11           ` Matthias Reichl
2019-01-15 21:16           ` [alsa-devel] " Pierre-Louis Bossart
2019-01-15 21:41             ` Mark Brown [this message]
2019-01-15 21:41               ` Mark Brown
2019-01-15 21:48               ` [alsa-devel] " Matthias Reichl
2019-01-18 23:02             ` Pierre-Louis Bossart
2019-01-19  1:12               ` Curtis Malainey
2019-01-19  1:15                 ` [alsa-devel] " Curtis Malainey
2019-01-21 18:30                   ` Mark Brown
2019-01-22 20:11                   ` Pierre-Louis Bossart
2019-01-22 20:11                     ` Pierre-Louis Bossart
2019-01-23  1:36                     ` [alsa-devel] " Curtis Malainey
2019-01-23  2:01                       ` Pierre-Louis Bossart
2019-01-23  2:01                         ` Pierre-Louis Bossart
2019-01-24 18:44                         ` Mark Brown
2019-01-24 18:44                           ` Mark Brown
2019-01-24 19:07                           ` [alsa-devel] " Pierre-Louis Bossart
2019-01-24 19:26                             ` Mark Brown
2019-01-24 19:26                               ` Mark Brown
2019-01-25  1:32                               ` [alsa-devel] " Curtis Malainey
2019-01-25  1:32                                 ` Curtis Malainey
2019-01-21 19:17               ` [alsa-devel] " Mark Brown
2019-01-21 19:17                 ` Mark Brown
2019-01-14 23:26 ` Mark Brown
2019-01-14 23:26   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190115214138.GL5522@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ajitp@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=asishb@codeaurora.org \
    --cc=bgoswami@codeaurora.org \
    --cc=hias@horus.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=plai@codeaurora.org \
    --cc=rohitkr@codeaurora.org \
    --cc=rohkumar@qti.qualcomm.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=vinod.koul@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.