[PATCH-for-4.10] correct release note link in SUPPORT.md

[PATCH-for-4.10] correct release note link in SUPPORT.md

[Juergen Gross]

The syntax for the release note link in SUPPORT.md is wrong. Correct
that.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 SUPPORT.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 6d417a618e..2ec77bf2cc 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -13,7 +13,9 @@ for the definitions of the support status levels etc.
     Initial-Release: 2017-12-13
     Supported-Until: 2019-06-13
     Security-Support-Until: 2020-12-13
-    Release-Notes: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
+
+Release-Notes
+: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
 
 # Feature Support
 
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH-for-4.10] correct release note link in SUPPORT.md

[George Dunlap]

On 1/16/19 9:46 AM, Juergen Gross wrote:
> The syntax for the release note link in SUPPORT.md is wrong. Correct
> that.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>> ---
>  SUPPORT.md | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 6d417a618e..2ec77bf2cc 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -13,7 +13,9 @@ for the definitions of the support status levels etc.
>      Initial-Release: 2017-12-13
>      Supported-Until: 2019-06-13
>      Security-Support-Until: 2020-12-13
> -    Release-Notes: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
> +
> +Release-Notes
> +: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>

This is in pandoc markdown, isn't it?  Why are we including HTML?

This should be[1] either:

[RN](https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes)

or

[RN][]

[RN] https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes

 -George

[1] https://pandoc.org/MANUAL.html#links

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH-for-4.10] correct release note link in SUPPORT.md

[Juergen Gross]

On 16/01/2019 15:57, George Dunlap wrote:
> On 1/16/19 9:46 AM, Juergen Gross wrote:
>> The syntax for the release note link in SUPPORT.md is wrong. Correct
>> that.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>> ---
>>  SUPPORT.md | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/SUPPORT.md b/SUPPORT.md
>> index 6d417a618e..2ec77bf2cc 100644
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -13,7 +13,9 @@ for the definitions of the support status levels etc.
>>      Initial-Release: 2017-12-13
>>      Supported-Until: 2019-06-13
>>      Security-Support-Until: 2020-12-13
>> -    Release-Notes: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
>> +
>> +Release-Notes
>> +: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
> 
> This is in pandoc markdown, isn't it?  Why are we including HTML?
> 
> This should be[1] either:
> 
> [RN](https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes)
> 
> or
> 
> [RN][]
> 
> [RN] https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes

I'm following the (working) example from staging. Have a look at e.g.

https://xenbits.xen.org/docs/unstable/support-matrix.html

where the 4.12-unstable release note is linked properly, while the 4.11
and 4.10 ones are not.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH-for-4.10] correct release note link in SUPPORT.md

[Ian Jackson]

Juergen Gross writes ("Re: [PATCH-for-4.10] correct release note link in SUPPORT.md"):
> On 16/01/2019 15:57, George Dunlap wrote:
> > On 1/16/19 9:46 AM, Juergen Gross wrote:
> >> +Release-Notes
> >> +: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
> > 
> > This is in pandoc markdown, isn't it?  Why are we including HTML?

I think because when I wrote dc5041ae52f7
    "SUPPORT.md: Turn release notes link into a proper link."
it was already in html, and the problem was that it was being treated
as a literal.  The html was introduced in 3beb42a090e34bad
    "Release: add release note link to SUPPORT.md"
but in that commit it did not actually generate a link in the output
html; the html is quoted by pandoc so that it appears as literal text.

So, overall, no good reason.

> > This should be[1] either:
> > 
> > [RN](https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes)
> > 
> > or
> > 
> > [RN][]
> > 
> > [RN] https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes
> 
> I'm following the (working) example from staging. Have a look at e.g.
> 
> https://xenbits.xen.org/docs/unstable/support-matrix.html
> 
> where the 4.12-unstable release note is linked properly, while the 4.11
> and 4.10 ones are not.

How about changing the syntax in staging first ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH-for-4.10] correct release note link in SUPPORT.md

[Juergen Gross]

On 16/01/2019 16:45, Ian Jackson wrote:
> Juergen Gross writes ("Re: [PATCH-for-4.10] correct release note link in SUPPORT.md"):
>> On 16/01/2019 15:57, George Dunlap wrote:
>>> On 1/16/19 9:46 AM, Juergen Gross wrote:
>>>> +Release-Notes
>>>> +: <a href="https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes">RN</a>
>>>
>>> This is in pandoc markdown, isn't it?  Why are we including HTML?
> 
> I think because when I wrote dc5041ae52f7
>     "SUPPORT.md: Turn release notes link into a proper link."
> it was already in html, and the problem was that it was being treated
> as a literal.  The html was introduced in 3beb42a090e34bad
>     "Release: add release note link to SUPPORT.md"
> but in that commit it did not actually generate a link in the output
> html; the html is quoted by pandoc so that it appears as literal text.
> 
> So, overall, no good reason.
> 
>>> This should be[1] either:
>>>
>>> [RN](https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes)
>>>
>>> or
>>>
>>> [RN][]
>>>
>>> [RN] https://wiki.xenproject.org/wiki/Xen_Project_4.10_Release_Notes
>>
>> I'm following the (working) example from staging. Have a look at e.g.
>>
>> https://xenbits.xen.org/docs/unstable/support-matrix.html
>>
>> where the 4.12-unstable release note is linked properly, while the 4.11
>> and 4.10 ones are not.
> 
> How about changing the syntax in staging first ?

staging seems to work (at least in above cited support-matrix.html).

So we can either try George's variant in staging and (if it works) do
the same in 4.11 and 4.10, or we can do the same as we have in staging
now in 4.11 and 4.10 (my patches).


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel