[PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

It's a debug hack flag useful to work around driver bugs. That's not a
good idea for a new driver. Especially for a new drm driver.

Aside: the fbdev support should probably be converted over to the new
generic fbdev support.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
 drivers/staging/vboxvideo/vbox_fb.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
index 2181c36c19ab..1da4cb7647b8 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
 	fb = &vbox->afb.base;
 	helper->fb = fb;
 
-	/*
-	 * The last flag forces a mode set on VT switches even if the kernel
-	 * does not think it is needed.
-	 */
-	info->flags = FBINFO_MISC_ALWAYS_SETPAR;
 	info->fbops = &vboxfb_ops;
 
 	/*
-- 
2.20.1

[PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

It's a debug hack flag useful to work around driver bugs. That's not a
good idea for a new driver. Especially for a new drm driver.

Aside: the fbdev support should probably be converted over to the new
generic fbdev support.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
 drivers/staging/vboxvideo/vbox_fb.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
index 2181c36c19ab..1da4cb7647b8 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
 	fb = &vbox->afb.base;
 	helper->fb = fb;
 
-	/*
-	 * The last flag forces a mode set on VT switches even if the kernel
-	 * does not think it is needed.
-	 */
-	info->flags = FBINFO_MISC_ALWAYS_SETPAR;
 	info->fbops = &vboxfb_ops;
 
 	/*
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] staging/xgifb: Needs to be converted to a drm driver

[Daniel Vetter]

Although given the lack of progress since 2010, maybe time to ditch it
from staging outright?

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/staging/xgifb/TODO | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/xgifb/TODO b/drivers/staging/xgifb/TODO
index 7eb99140a399..a1e25957bf1b 100644
--- a/drivers/staging/xgifb/TODO
+++ b/drivers/staging/xgifb/TODO
@@ -9,5 +9,8 @@ TODO:
 - remove useless/wrong/unused code...
 - get rid of non-linux related stuff
 
+This needs to become a drm driver, the fbdev subsystem doesn't take new drivers
+anymore.
+
 Please send patches to:
 Arnaud Patard <arnaud.patard@rtp-net.org>
-- 
2.20.1

[PATCH 2/2] staging/xgifb: Needs to be converted to a drm driver

[Daniel Vetter]

Although given the lack of progress since 2010, maybe time to ditch it
from staging outright?

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/staging/xgifb/TODO | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/xgifb/TODO b/drivers/staging/xgifb/TODO
index 7eb99140a399..a1e25957bf1b 100644
--- a/drivers/staging/xgifb/TODO
+++ b/drivers/staging/xgifb/TODO
@@ -9,5 +9,8 @@ TODO:
 - remove useless/wrong/unused code...
 - get rid of non-linux related stuff
 
+This needs to become a drm driver, the fbdev subsystem doesn't take new drivers
+anymore.
+
 Please send patches to:
 Arnaud Patard <arnaud.patard@rtp-net.org>
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Greg Kroah-Hartman]

On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> It's a debug hack flag useful to work around driver bugs. That's not a
> good idea for a new driver. Especially for a new drm driver.
> 
> Aside: the fbdev support should probably be converted over to the new
> generic fbdev support.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
>  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > It's a debug hack flag useful to work around driver bugs. That's not a
> > good idea for a new driver. Especially for a new drm driver.
> > 
> > Aside: the fbdev support should probably be converted over to the new
> > generic fbdev support.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > ---
> >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Since Hans wants to destage vboxvideo this cycle probably best I merge
this through drm-misc? Just to make sure it's not lost.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > It's a debug hack flag useful to work around driver bugs. That's not a
> > good idea for a new driver. Especially for a new drm driver.
> > 
> > Aside: the fbdev support should probably be converted over to the new
> > generic fbdev support.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > ---
> >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Since Hans wants to destage vboxvideo this cycle probably best I merge
this through drm-misc? Just to make sure it's not lost.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Greg Kroah-Hartman]

On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > good idea for a new driver. Especially for a new drm driver.
> > > 
> > > Aside: the fbdev support should probably be converted over to the new
> > > generic fbdev support.
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > ---
> > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > 
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Since Hans wants to destage vboxvideo this cycle probably best I merge
> this through drm-misc? Just to make sure it's not lost.

Feel free to do so!

thanks,

greg k-h

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Greg Kroah-Hartman]

On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > good idea for a new driver. Especially for a new drm driver.
> > > 
> > > Aside: the fbdev support should probably be converted over to the new
> > > generic fbdev support.
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > ---
> > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > 
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Since Hans wants to destage vboxvideo this cycle probably best I merge
> this through drm-misc? Just to make sure it's not lost.

Feel free to do so!

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > good idea for a new driver. Especially for a new drm driver.
> > > > 
> > > > Aside: the fbdev support should probably be converted over to the new
> > > > generic fbdev support.
> > > > 
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > > ---
> > > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > >  1 file changed, 5 deletions(-)
> > > > 
> > > 
> > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > this through drm-misc? Just to make sure it's not lost.
> 
> Feel free to do so!

Applied, thanks for your review.

I think 2/2 is directly staging material for you (somehow
get_maintainers.pl didn't add you to the cc: list, not sure why ...).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Greg Kroah-Hartman]

On Tue, Jan 15, 2019 at 04:15:49PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > > good idea for a new driver. Especially for a new drm driver.
> > > > > 
> > > > > Aside: the fbdev support should probably be converted over to the new
> > > > > generic fbdev support.
> > > > > 
> > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > > > ---
> > > > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > > >  1 file changed, 5 deletions(-)
> > > > > 
> > > > 
> > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > 
> > > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > > this through drm-misc? Just to make sure it's not lost.
> > 
> > Feel free to do so!
> 
> Applied, thanks for your review.
> 
> I think 2/2 is directly staging material for you (somehow
> get_maintainers.pl didn't add you to the cc: list, not sure why ...).

Can you resend it, I don't see it anywhere...

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Greg Kroah-Hartman]

On Tue, Jan 15, 2019 at 04:15:49PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > > good idea for a new driver. Especially for a new drm driver.
> > > > > 
> > > > > Aside: the fbdev support should probably be converted over to the new
> > > > > generic fbdev support.
> > > > > 
> > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > > > ---
> > > > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > > >  1 file changed, 5 deletions(-)
> > > > > 
> > > > 
> > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > 
> > > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > > this through drm-misc? Just to make sure it's not lost.
> > 
> > Feel free to do so!
> 
> Applied, thanks for your review.
> 
> I think 2/2 is directly staging material for you (somehow
> get_maintainers.pl didn't add you to the cc: list, not sure why ...).

Can you resend it, I don't see it anywhere...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 4:32 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 15, 2019 at 04:15:49PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > > > good idea for a new driver. Especially for a new drm driver.
> > > > > >
> > > > > > Aside: the fbdev support should probably be converted over to the new
> > > > > > generic fbdev support.
> > > > > >
> > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > > Cc: Hans de Goede <hdegoede@redhat.com>
> > > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > > > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> > > > > > ---
> > > > > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > > > >  1 file changed, 5 deletions(-)
> > > > > >
> > > > >
> > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >
> > > > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > > > this through drm-misc? Just to make sure it's not lost.
> > >
> > > Feel free to do so!
> >
> > Applied, thanks for your review.
> >
> > I think 2/2 is directly staging material for you (somehow
> > get_maintainers.pl didn't add you to the cc: list, not sure why ...).
>
> Can you resend it, I don't see it anywhere...

resent with you added explicitly to the Cc: list, it's

Subject: [PATCH] staging/xgifb: Needs to be converted to a drm driver
Date: Wed, 16 Jan 2019 11:04:40 +0100
Message-Id: <20190116100440.10071-1-daniel.vetter@ffwll.ch>

Cheers, Daniel

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> It's a debug hack flag useful to work around driver bugs. That's not a
> good idea for a new driver. Especially for a new drm driver.
> 
> Aside: the fbdev support should probably be converted over to the new
> generic fbdev support.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
>  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 2181c36c19ab..1da4cb7647b8 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
>  	fb = &vbox->afb.base;
>  	helper->fb = fb;
>  
> -	/*
> -	 * The last flag forces a mode set on VT switches even if the kernel
> -	 * does not think it is needed.
> -	 */
> -	info->flags = FBINFO_MISC_ALWAYS_SETPAR;

For the record I screwed up rebasing this one because it was in some patch
that also removed FBINFO_DEFAULT (which is 0, so pointless to set since
the structure is kzalloc'ed). Actually merged patch also removes
FBINFO_DEFAULT :-/ No real harm done though since as explained 0 doesn't
matter here.
-Daniel
>  	info->fbops = &vboxfb_ops;
>  
>  	/*
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

[Daniel Vetter]

On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> It's a debug hack flag useful to work around driver bugs. That's not a
> good idea for a new driver. Especially for a new drm driver.
> 
> Aside: the fbdev support should probably be converted over to the new
> generic fbdev support.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
>  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 2181c36c19ab..1da4cb7647b8 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
>  	fb = &vbox->afb.base;
>  	helper->fb = fb;
>  
> -	/*
> -	 * The last flag forces a mode set on VT switches even if the kernel
> -	 * does not think it is needed.
> -	 */
> -	info->flags = FBINFO_MISC_ALWAYS_SETPAR;

For the record I screwed up rebasing this one because it was in some patch
that also removed FBINFO_DEFAULT (which is 0, so pointless to set since
the structure is kzalloc'ed). Actually merged patch also removes
FBINFO_DEFAULT :-/ No real harm done though since as explained 0 doesn't
matter here.
-Daniel
>  	info->fbops = &vboxfb_ops;
>  
>  	/*
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel