All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop
@ 2019-01-16 16:05 Alex Deucher
  2019-01-17  4:52 ` 答复: " Qu, Jim
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Alex Deucher @ 2019-01-16 16:05 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher, stable

Needs ATPX rather than _PR3 for dGPU power control.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=202263
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
index a028661d9e20..92b11de19581 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
@@ -576,6 +576,7 @@ static const struct amdgpu_px_quirk amdgpu_px_quirk_list[] = {
 	{ 0x1002, 0x6900, 0x1028, 0x0812, AMDGPU_PX_QUIRK_FORCE_ATPX },
 	{ 0x1002, 0x6900, 0x1028, 0x0813, AMDGPU_PX_QUIRK_FORCE_ATPX },
 	{ 0x1002, 0x6900, 0x1025, 0x125A, AMDGPU_PX_QUIRK_FORCE_ATPX },
+	{ 0x1002, 0x6900, 0x17AA, 0x3806, AMDGPU_PX_QUIRK_FORCE_ATPX },
 	{ 0, 0, 0, 0, 0 },
 };
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* 答复: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop
  2019-01-16 16:05 [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop Alex Deucher
@ 2019-01-17  4:52 ` Qu, Jim
       [not found] ` <20190116160514.13477-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  2019-01-22 15:56   ` Sasha Levin
  2 siblings, 0 replies; 5+ messages in thread
From: Qu, Jim @ 2019-01-17  4:52 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx; +Cc: Deucher, Alexander, stable

Reviewed-by: Jim Qu <Jim.Qu@amd.com>

Thanks
JimQu

________________________________________
发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Alex Deucher <alexdeucher@gmail.com>
发送时间: 2019年1月17日 0:05:14
收件人: amd-gfx@lists.freedesktop.org
抄送: Deucher, Alexander; stable@vger.kernel.org
主题: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop

Needs ATPX rather than _PR3 for dGPU power control.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=202263
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
index a028661d9e20..92b11de19581 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
@@ -576,6 +576,7 @@ static const struct amdgpu_px_quirk amdgpu_px_quirk_list[] = {
        { 0x1002, 0x6900, 0x1028, 0x0812, AMDGPU_PX_QUIRK_FORCE_ATPX },
        { 0x1002, 0x6900, 0x1028, 0x0813, AMDGPU_PX_QUIRK_FORCE_ATPX },
        { 0x1002, 0x6900, 0x1025, 0x125A, AMDGPU_PX_QUIRK_FORCE_ATPX },
+       { 0x1002, 0x6900, 0x17AA, 0x3806, AMDGPU_PX_QUIRK_FORCE_ATPX },
        { 0, 0, 0, 0, 0 },
 };

--
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop
  2019-01-16 16:05 [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop Alex Deucher
@ 2019-01-22 15:56   ` Sasha Levin
       [not found] ` <20190116160514.13477-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  2019-01-22 15:56   ` Sasha Levin
  2 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2019-01-22 15:56 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher, amd-gfx; +Cc: Alex Deucher, stable, stable, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151, v4.4.171, v3.18.132.

v4.20.3: Build OK!
v4.19.16: Build OK!
v4.14.94: Failed to apply! Possible dependencies:
    Unable to calculate

v4.9.151: Failed to apply! Possible dependencies:
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")

v4.4.171: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6b1095eedd39 ("drm/amdgpu: init atpx at switcheroo register time (v2)")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")

v3.18.132: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    97b2e202fba0 ("drm/amdgpu: add amdgpu.h (v2)")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    bedf2a65c1aa ("drm/amdgpu: disable runtime pm on PX laptops without dGPU power control")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")
    d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
    e9bef455af8e ("Revert "drm/amdgpu: disable runtime pm on PX laptops without dGPU power control"")


How should we proceed with this patch?

--
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop
       [not found] ` <20190116160514.13477-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-01-22 15:56   ` Sasha Levin
  0 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2019-01-22 15:56 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151, v4.4.171, v3.18.132.

v4.20.3: Build OK!
v4.19.16: Build OK!
v4.14.94: Failed to apply! Possible dependencies:
    Unable to calculate

v4.9.151: Failed to apply! Possible dependencies:
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")

v4.4.171: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6b1095eedd39 ("drm/amdgpu: init atpx at switcheroo register time (v2)")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")

v3.18.132: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    97b2e202fba0 ("drm/amdgpu: add amdgpu.h (v2)")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    bedf2a65c1aa ("drm/amdgpu: disable runtime pm on PX laptops without dGPU power control")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")
    d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
    e9bef455af8e ("Revert "drm/amdgpu: disable runtime pm on PX laptops without dGPU power control"")


How should we proceed with this patch?

--
Thanks,
Sasha
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop
@ 2019-01-22 15:56   ` Sasha Levin
  0 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2019-01-22 15:56 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher, amd-gfx; +Cc: Alex Deucher, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151, v4.4.171, v3.18.132.

v4.20.3: Build OK!
v4.19.16: Build OK!
v4.14.94: Failed to apply! Possible dependencies:
    Unable to calculate

v4.9.151: Failed to apply! Possible dependencies:
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")

v4.4.171: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6b1095eedd39 ("drm/amdgpu: init atpx at switcheroo register time (v2)")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")

v3.18.132: Failed to apply! Possible dependencies:
    052c299080cd ("drm/amdgpu: add atpx quirk handling (v2)")
    1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")
    2f5af82eeab2 ("drm/amdgpu/atpx: track whether if this is a hybrid graphics platform")
    5c614792474b ("drm/amdgpu: disable power control on hybrid laptops")
    6c24a85d236e ("drm/amdgpu: add new device to use atpx quirk")
    7ac33e47d576 ("drm/amdgpu: fix check for port PM availability")
    8d45f80ed08b ("drm/amdgpu: clean up atpx power control handling")
    97b2e202fba0 ("drm/amdgpu: add amdgpu.h (v2)")
    a78fe13389f0 ("drm/amdgpu/atpx: add a query for ATPX dGPU power control")
    b3fc2ab37e27 ("drm/amdgpu: add another ATPX quirk for TOPAZ")
    bedf2a65c1aa ("drm/amdgpu: disable runtime pm on PX laptops without dGPU power control")
    c8791a13d281 ("drm/amdgpu: print a message if ATPX dGPU power control is missing")
    d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
    e9bef455af8e ("Revert "drm/amdgpu: disable runtime pm on PX laptops without dGPU power control"")


How should we proceed with this patch?

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-01-22 15:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 16:05 [PATCH] drm/amdgpu: Add APTX quirk for Lenovo laptop Alex Deucher
2019-01-17  4:52 ` 答复: " Qu, Jim
     [not found] ` <20190116160514.13477-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-01-22 15:56   ` Sasha Levin
2019-01-22 15:56 ` Sasha Levin
2019-01-22 15:56   ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.