From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 1/3] ts-livepatch-run: Treat (just) falseish from OutputCheck as fail
Date: Wed, 16 Jan 2019 11:36:58 -0500 [thread overview]
Message-ID: <20190116163658.GD7892@char.us.oracle.com> (raw)
In-Reply-To: <20190116113637.10819-1-ian.jackson@eu.citrix.com>
On Wed, Jan 16, 2019 at 11:36:35AM +0000, Ian Jackson wrote:
> This is more idiomatic. All existing OutputChecks return booleans, so
> no functional change.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thank you!
> ---
> ts-livepatch-run | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ts-livepatch-run b/ts-livepatch-run
> index f1194586..8fdb8004 100755
> --- a/ts-livepatch-run
> +++ b/ts-livepatch-run
> @@ -147,8 +147,8 @@ sub livepatch_test () {
> }
> if (defined($test->{OutputCheck})) {
> $_ = $output;
> - $rc=$test->{OutputCheck}->();
> - if ($rc ne 1) {
> + my $ok = $test->{OutputCheck}->();
> + if (!$ok) {
> die "FAILED! OutputCheck=$test->{OutputCheck}, input=$output\n";
> }
> }
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-01-16 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 11:36 [OSSTEST PATCH 1/3] ts-livepatch-run: Treat (just) falseish from OutputCheck as fail Ian Jackson
2019-01-16 11:36 ` [OSSTEST PATCH 2/3] ts-livepatch-run: Print a message about expected failures Ian Jackson
2019-01-16 16:37 ` Konrad Rzeszutek Wilk
2019-01-16 11:36 ` [OSSTEST PATCH 3/3] ts-livepatch-run: Fix erroneous $$ in double-check Ian Jackson
2019-01-16 16:37 ` Konrad Rzeszutek Wilk
2019-01-16 16:36 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116163658.GD7892@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.