Re: [OSSTEST PATCH 2/3] ts-livepatch-run: Print a message about expected failures

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Jan 16, 2019 at 11:36:36AM +0000, Ian Jackson wrote:
> target_cmd_output_root_status prints the command exit status.  If that
> was a failure and the failure was as expected, this can be confusing
> to readers who do not know that this is a possibility.  So print a
> message about it.
> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!
> ---
>  ts-livepatch-run | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ts-livepatch-run b/ts-livepatch-run
> index 8fdb8004..f011e64e 100755
> --- a/ts-livepatch-run
> +++ b/ts-livepatch-run
> @@ -152,6 +152,9 @@ sub livepatch_test () {
>                  die "FAILED! OutputCheck=$test->{OutputCheck}, input=$output\n";
>              }
>          }
> +	if ($expected_rc) {
> +	    logm "... that failure ($rc) was as required; all is well.";
> +        }
>     }
>     return 0;
>  }
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel