* [PATCH] sdl2: fix sdl2.pc include paths
@ 2019-01-11 10:16 Samuli Piippo
2019-01-14 10:51 ` Burton, Ross
2019-01-17 7:28 ` [PATCH v2] " Samuli Piippo
0 siblings, 2 replies; 4+ messages in thread
From: Samuli Piippo @ 2019-01-11 10:16 UTC (permalink / raw)
To: openembedded-core
SDL2 dumps all cflags to the sdl2.pc, which might then contain paths
to the recipe sysroot include dirs.
Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
index 812a9abf3c..a9c5d8a443 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
@@ -64,6 +64,10 @@ do_configure_prepend() {
export SYSROOT=$PKG_CONFIG_SYSROOT_DIR
}
+do_install_append() {
+ sed -i -e "s|${STAGING_INCDIR}|$\{includedir}|g" ${D}${libdir}/pkgconfig/sdl2.pc
+}
+
FILES_${PN}-dev += "${libdir}/cmake"
BBCLASSEXTEND = "native nativesdk"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sdl2: fix sdl2.pc include paths
2019-01-11 10:16 [PATCH] sdl2: fix sdl2.pc include paths Samuli Piippo
@ 2019-01-14 10:51 ` Burton, Ross
2019-01-14 13:52 ` Andreas Müller
2019-01-17 7:28 ` [PATCH v2] " Samuli Piippo
1 sibling, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2019-01-14 10:51 UTC (permalink / raw)
To: Samuli Piippo; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
Would it be easier to just remove @SDL_CFLAGS@ from sdl.pc.in? Does that
contain other values that are needed, or are they all spurious?
Ross
On Sat, 12 Jan 2019 at 08:43, Samuli Piippo <samuli.piippo@qt.io> wrote:
> SDL2 dumps all cflags to the sdl2.pc, which might then contain paths
> to the recipe sysroot include dirs.
>
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> ---
> meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> index 812a9abf3c..a9c5d8a443 100644
> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
> @@ -64,6 +64,10 @@ do_configure_prepend() {
> export SYSROOT=$PKG_CONFIG_SYSROOT_DIR
> }
>
> +do_install_append() {
> + sed -i -e "s|${STAGING_INCDIR}|$\{includedir}|g"
> ${D}${libdir}/pkgconfig/sdl2.pc
> +}
> +
> FILES_${PN}-dev += "${libdir}/cmake"
>
> BBCLASSEXTEND = "native nativesdk"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 2372 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sdl2: fix sdl2.pc include paths
2019-01-14 10:51 ` Burton, Ross
@ 2019-01-14 13:52 ` Andreas Müller
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Müller @ 2019-01-14 13:52 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
My two comments:
1. There is already an upgrade libsdl2 -> 2.09 pending so this patch
needs rebase [1]
2. Removing CFLAGS is easier but potentially a risk of unwanted
effects. My sdl2.pc contains -D_REENTRANT. This should be obsolete but
who guarantees that there isn't some old application still requiring
it (because it is set in other build environments).
[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-January/277739.html
Andreas
On Mon, Jan 14, 2019 at 11:52 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> Would it be easier to just remove @SDL_CFLAGS@ from sdl.pc.in? Does that contain other values that are needed, or are they all spurious?
>
> Ross
>
> On Sat, 12 Jan 2019 at 08:43, Samuli Piippo <samuli.piippo@qt.io> wrote:
>>
>> SDL2 dumps all cflags to the sdl2.pc, which might then contain paths
>> to the recipe sysroot include dirs.
>>
>> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
>> ---
>> meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> index 812a9abf3c..a9c5d8a443 100644
>> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.8.bb
>> @@ -64,6 +64,10 @@ do_configure_prepend() {
>> export SYSROOT=$PKG_CONFIG_SYSROOT_DIR
>> }
>>
>> +do_install_append() {
>> + sed -i -e "s|${STAGING_INCDIR}|$\{includedir}|g" ${D}${libdir}/pkgconfig/sdl2.pc
>> +}
>> +
>> FILES_${PN}-dev += "${libdir}/cmake"
>>
>> BBCLASSEXTEND = "native nativesdk"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] sdl2: fix sdl2.pc include paths
2019-01-11 10:16 [PATCH] sdl2: fix sdl2.pc include paths Samuli Piippo
2019-01-14 10:51 ` Burton, Ross
@ 2019-01-17 7:28 ` Samuli Piippo
1 sibling, 0 replies; 4+ messages in thread
From: Samuli Piippo @ 2019-01-17 7:28 UTC (permalink / raw)
To: openembedded-core
SDL2 dumps all cflags to the sdl2.pc, which might then contain paths
to the recipe sysroot include dirs.
Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
meta/recipes-graphics/libsdl2/libsdl2_2.0.9.bb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.9.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.9.bb
index a5ec77728a..8941f05958 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.9.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.9.bb
@@ -63,6 +63,10 @@ do_configure_prepend() {
export SYSROOT=$PKG_CONFIG_SYSROOT_DIR
}
+do_install_append() {
+ sed -i -e "s|${STAGING_INCDIR}|$\{includedir}|g" ${D}${libdir}/pkgconfig/sdl2.pc
+}
+
FILES_${PN}-dev += "${libdir}/cmake"
BBCLASSEXTEND = "native nativesdk"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-17 12:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 10:16 [PATCH] sdl2: fix sdl2.pc include paths Samuli Piippo
2019-01-14 10:51 ` Burton, Ross
2019-01-14 13:52 ` Andreas Müller
2019-01-17 7:28 ` [PATCH v2] " Samuli Piippo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.