All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
@ 2019-01-17  7:12 kai.kang
  2019-01-17  7:56 ` [PATCH] libidn2: fix buildpaths qa warning kai.kang
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: kai.kang @ 2019-01-17  7:12 UTC (permalink / raw)
  To: ross.burton; +Cc: openembedded-core

From: Kai Kang <kai.kang@windriver.com>

Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
Specifying -fdebug-prefix-map is equivalent to specifying all the
individual -f*-prefix-map options which means including
-fmacro-prefix-map and -fdebug-prefix-map currently. Option
-fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
by __FILE__ macro expansion for packages such as llvm and librepo.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/conf/bitbake.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 0bdcd04d74..d20460e845 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
 # Optimization flags.
 ##################################################################
 # Beware: applied last to first
-DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
-                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
-                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
+DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
+                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
+                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
 "
 DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
 
-- 
2.20.0



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH] libidn2: fix buildpaths qa warning
  2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
@ 2019-01-17  7:56 ` kai.kang
  2019-01-17 14:34 ` [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP Dan McGregor
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: kai.kang @ 2019-01-17  7:56 UTC (permalink / raw)
  To: openembedded-core

From: Kai Kang <kai.kang@windriver.com>

Fix buildpaths qa warning of libidn2:

| WARNING: libidn2-2.0.5-r0 do_package_qa: QA Issue: File
| /work/core2-64-poky-linux/libidn2/2.0.5-r0/packages-split/libidn2-dev/usr/lib/pkgconfig/libidn2.pc
| in package contained reference to tmpdir [buildpaths]

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-extended/libidn/libidn2_2.0.5.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-extended/libidn/libidn2_2.0.5.bb b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
index 0daf7a6877..da77c4402d 100644
--- a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
+++ b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
@@ -26,4 +26,8 @@ EXTRA_OECONF += "--disable-rpath \
 LICENSE_${PN} = "(GPLv2+ | LGPLv3)"
 LICENSE_${PN}-bin = "GPLv3+"
 
+do_install_append () {
+    sed -i 's#${RECIPE_SYSROOT}##' ${D}${libdir}/pkgconfig/libidn2.pc
+}
+
 BBCLASSEXTEND = "native nativesdk"
-- 
2.20.0



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
  2019-01-17  7:56 ` [PATCH] libidn2: fix buildpaths qa warning kai.kang
@ 2019-01-17 14:34 ` Dan McGregor
  2019-01-17 15:19 ` Christopher Larson
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Dan McGregor @ 2019-01-17 14:34 UTC (permalink / raw)
  To: kai.kang; +Cc: Patches and discussions about the oe-core layer

On Thu, 17 Jan 2019 at 01:13, <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
> Specifying -fdebug-prefix-map is equivalent to specifying all the
> individual -f*-prefix-map options which means including
> -fmacro-prefix-map and -fdebug-prefix-map currently. Option
> -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
> by __FILE__ macro expansion for packages such as llvm and librepo.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/conf/bitbake.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0bdcd04d74..d20460e845 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
>  # Optimization flags.
>  ##################################################################
>  # Beware: applied last to first
> -DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
> -                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
> +DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
> +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
>  "
>  DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
>

I like the idea of this, but it will break meta-clang until either 1)
https://reviews.llvm.org/D49466 lands, or 2) meta-clang sets its own
DEBUG_PREFIX_MAP.

> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
  2019-01-17  7:56 ` [PATCH] libidn2: fix buildpaths qa warning kai.kang
  2019-01-17 14:34 ` [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP Dan McGregor
@ 2019-01-17 15:19 ` Christopher Larson
  2019-01-17 15:19   ` Christopher Larson
  2019-01-18  1:29   ` Kang Kai
  2019-01-18 11:02 ` Richard Purdie
  2019-01-18 17:55 ` Khem Raj
  4 siblings, 2 replies; 14+ messages in thread
From: Christopher Larson @ 2019-01-17 15:19 UTC (permalink / raw)
  To: Kang Kai; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

The commit message doesn’t match what you’re actually doing. "Specifying
-fdebug-prefix-map is equivalent to specifying all the individual
-f*-prefix-map options which means including -fmacro-prefix-map and
-fdebug-prefix-map currently” I assume you mean "Specifying
-ffile-prefix-map” there.

On Thu, Jan 17, 2019 at 12:13 AM <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
> Specifying -fdebug-prefix-map is equivalent to specifying all the
> individual -f*-prefix-map options which means including
> -fmacro-prefix-map and -fdebug-prefix-map currently. Option
> -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
> by __FILE__ macro expansion for packages such as llvm and librepo.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/conf/bitbake.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0bdcd04d74..d20460e845 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =
> "${PARALLEL_MAKEINST} "
>  # Optimization flags.
>  ##################################################################
>  # Beware: applied last to first
> -DEBUG_PREFIX_MAP ?=
> "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
> -                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
> +DEBUG_PREFIX_MAP ?=
> "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
> +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
>  "
>  DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
>
> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 3265 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17 15:19 ` Christopher Larson
@ 2019-01-17 15:19   ` Christopher Larson
  2019-01-18  1:29   ` Kang Kai
  1 sibling, 0 replies; 14+ messages in thread
From: Christopher Larson @ 2019-01-17 15:19 UTC (permalink / raw)
  To: Kang Kai; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2686 bytes --]

You also aren’t “resetting” anything, I’d suggest clarifying the summary as
well.

On Thu, Jan 17, 2019 at 8:19 AM Christopher Larson <kergoth@gmail.com>
wrote:

> The commit message doesn’t match what you’re actually doing. "Specifying
> -fdebug-prefix-map is equivalent to specifying all the individual
> -f*-prefix-map options which means including -fmacro-prefix-map and
> -fdebug-prefix-map currently” I assume you mean "Specifying
> -ffile-prefix-map” there.
>
> On Thu, Jan 17, 2019 at 12:13 AM <kai.kang@windriver.com> wrote:
>
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
>> Specifying -fdebug-prefix-map is equivalent to specifying all the
>> individual -f*-prefix-map options which means including
>> -fmacro-prefix-map and -fdebug-prefix-map currently. Option
>> -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
>> by __FILE__ macro expansion for packages such as llvm and librepo.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>  meta/conf/bitbake.conf | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 0bdcd04d74..d20460e845 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =
>> "${PARALLEL_MAKEINST} "
>>  # Optimization flags.
>>  ##################################################################
>>  # Beware: applied last to first
>> -DEBUG_PREFIX_MAP ?=
>> "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
>> -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
>> -                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
>> +DEBUG_PREFIX_MAP ?=
>> "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
>> +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
>> +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
>>  "
>>  DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
>>
>> --
>> 2.20.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
>


-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 4100 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17 15:19 ` Christopher Larson
  2019-01-17 15:19   ` Christopher Larson
@ 2019-01-18  1:29   ` Kang Kai
  1 sibling, 0 replies; 14+ messages in thread
From: Kang Kai @ 2019-01-18  1:29 UTC (permalink / raw)
  To: Christopher Larson; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2809 bytes --]

On 2019/1/17 下午11:19, Christopher Larson wrote:
> The commit message doesn’t match what you’re actually doing. 
> "Specifying -fdebug-prefix-map is equivalent to specifying all 
> the individual -f*-prefix-map options which means 
> including -fmacro-prefix-map and -fdebug-prefix-map currently” I 
> assume you mean "Specifying -ffile-prefix-map” there.


Sorry typo here.

Regards,
Kai


>
> On Thu, Jan 17, 2019 at 12:13 AM <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     From: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>
>     Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
>     Specifying -fdebug-prefix-map is equivalent to specifying all the
>     individual -f*-prefix-map options which means including
>     -fmacro-prefix-map and -fdebug-prefix-map currently. Option
>     -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
>     by __FILE__ macro expansion for packages such as llvm and librepo.
>
>     Signed-off-by: Kai Kang <kai.kang@windriver.com
>     <mailto:kai.kang@windriver.com>>
>     ---
>      meta/conf/bitbake.conf | 6 +++---
>      1 file changed, 3 insertions(+), 3 deletions(-)
>
>     diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>     index 0bdcd04d74..d20460e845 100644
>     --- a/meta/conf/bitbake.conf
>     +++ b/meta/conf/bitbake.conf
>     @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install =
>     "${PARALLEL_MAKEINST} "
>      # Optimization flags.
>      ##################################################################
>      # Beware: applied last to first
>     -DEBUG_PREFIX_MAP ?=
>     "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}
>     \
>     -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
>     -  -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
>     +DEBUG_PREFIX_MAP ?=
>     "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}
>     \
>     +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
>     +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \
>      "
>      DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types
>     ${DEBUG_PREFIX_MAP}"
>
>     -- 
>     2.20.0
>
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> -- 
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics


-- 
Kai Kang


[-- Attachment #2: Type: text/html, Size: 5032 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
                   ` (2 preceding siblings ...)
  2019-01-17 15:19 ` Christopher Larson
@ 2019-01-18 11:02 ` Richard Purdie
  2019-01-18 11:15   ` Richard Purdie
  2019-01-18 17:55 ` Khem Raj
  4 siblings, 1 reply; 14+ messages in thread
From: Richard Purdie @ 2019-01-18 11:02 UTC (permalink / raw)
  To: kai.kang, ross.burton; +Cc: openembedded-core

On Thu, 2019-01-17 at 02:12 -0500, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
> Specifying -fdebug-prefix-map is equivalent to specifying all the
> individual -f*-prefix-map options which means including
> -fmacro-prefix-map and -fdebug-prefix-map currently. Option
> -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
> by __FILE__ macro expansion for packages such as llvm and librepo.
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/conf/bitbake.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I like the idea of the patch a lot. Unfortunately it causes an oe-
selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/131

in the go toolchain.

oe-selftest -r gotoolchain.oeGoToolchainSelfTest.test_go_dep_build

should reproduce.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-18 11:02 ` Richard Purdie
@ 2019-01-18 11:15   ` Richard Purdie
  0 siblings, 0 replies; 14+ messages in thread
From: Richard Purdie @ 2019-01-18 11:15 UTC (permalink / raw)
  To: kai.kang, ross.burton; +Cc: openembedded-core

On Fri, 2019-01-18 at 11:02 +0000, Richard Purdie wrote:
> On Thu, 2019-01-17 at 02:12 -0500, kai.kang@windriver.com wrote:
> > From: Kai Kang <kai.kang@windriver.com>
> > 
> > Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
> > Specifying -fdebug-prefix-map is equivalent to specifying all the
> > individual -f*-prefix-map options which means including
> > -fmacro-prefix-map and -fdebug-prefix-map currently. Option
> > -fmacro-prefix-map helps to avoid buildpaths qa warnings which
> > caused
> > by __FILE__ macro expansion for packages such as llvm and librepo.
> > 
> > Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > ---
> >  meta/conf/bitbake.conf | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> I like the idea of the patch a lot. Unfortunately it causes an oe-
> selftest failure:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/131
> 
> in the go toolchain.
> 
> oe-selftest -r gotoolchain.oeGoToolchainSelfTest.test_go_dep_build
> 
> should reproduce.

There does appear to be another issue:

http://git.yoctoproject.org/cgit.cgi/poky-buildhistory/commit/?h=poky/master-next/qemux86&id=e3195d9809716652546a1ac69a75287ec707e79b

The debug src files appear to be disappearing?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
                   ` (3 preceding siblings ...)
  2019-01-18 11:02 ` Richard Purdie
@ 2019-01-18 17:55 ` Khem Raj
  2019-01-18 20:43   ` Burton, Ross
  4 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2019-01-18 17:55 UTC (permalink / raw)
  To: Kang Kai; +Cc: Patches and discussions about the oe-core layer

On Wed, Jan 16, 2019 at 11:13 PM <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> Reset default value of DEBUG_PREFIX_MAP with '-fdebug-prefix-map'.
> Specifying -fdebug-prefix-map is equivalent to specifying all the
> individual -f*-prefix-map options which means including
> -fmacro-prefix-map and -fdebug-prefix-map currently. Option
> -fmacro-prefix-map helps to avoid buildpaths qa warnings which caused
> by __FILE__ macro expansion for packages such as llvm and librepo.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/conf/bitbake.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0bdcd04d74..d20460e845 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -599,9 +599,9 @@ EXTRA_OEMAKE_prepend_task-install = "${PARALLEL_MAKEINST} "
>  # Optimization flags.
>  ##################################################################
>  # Beware: applied last to first
> -DEBUG_PREFIX_MAP ?= "-fdebug-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> -                     -fdebug-prefix-map=${STAGING_DIR_HOST}= \
> -                     -fdebug-prefix-map=${STAGING_DIR_NATIVE}= \
> +DEBUG_PREFIX_MAP ?= "-ffile-prefix-map=${WORKDIR}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR} \
> +                     -ffile-prefix-map=${STAGING_DIR_HOST}= \
> +                     -ffile-prefix-map=${STAGING_DIR_NATIVE}= \

I am bit concerned about using -ffile-prefix-map here, its gcc only
option so will cause clang to fail

>  "
>  DEBUG_FLAGS ?= "-g -feliminate-unused-debug-types ${DEBUG_PREFIX_MAP}"
>
> --
> 2.20.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-18 17:55 ` Khem Raj
@ 2019-01-18 20:43   ` Burton, Ross
  2019-01-18 20:54     ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Burton, Ross @ 2019-01-18 20:43 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Fri, 18 Jan 2019 at 17:55, Khem Raj <raj.khem@gmail.com> wrote:
> I am bit concerned about using -ffile-prefix-map here, its gcc only
> option so will cause clang to fail

It's almost like we need a toolchain override so this can be gcc-specific...

I've been meaning to do that for about a year now :(

Until then, couldn't meta-clang just override the value from the layer?

Ross


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-18 20:43   ` Burton, Ross
@ 2019-01-18 20:54     ` Khem Raj
  2019-01-21  2:12       ` Kang Kai
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2019-01-18 20:54 UTC (permalink / raw)
  To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer

On Fri, Jan 18, 2019 at 12:43 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Fri, 18 Jan 2019 at 17:55, Khem Raj <raj.khem@gmail.com> wrote:
> > I am bit concerned about using -ffile-prefix-map here, its gcc only
> > option so will cause clang to fail
>
> It's almost like we need a toolchain override so this can be gcc-specific...
>
> I've been meaning to do that for about a year now :(
>
> Until then, couldn't meta-clang just override the value from the layer?

yes it can, but one by one there are many changes to keep and core becomes
tied to gcc. We should be conscious about it.

>
> Ross


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-18 20:54     ` Khem Raj
@ 2019-01-21  2:12       ` Kang Kai
  2019-01-21  2:17         ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Kang Kai @ 2019-01-21  2:12 UTC (permalink / raw)
  To: Khem Raj, Burton, Ross; +Cc: Patches and discussions about the oe-core layer

On 2019/1/19 上午4:54, Khem Raj wrote:
> On Fri, Jan 18, 2019 at 12:43 PM Burton, Ross <ross.burton@intel.com> wrote:
>> On Fri, 18 Jan 2019 at 17:55, Khem Raj <raj.khem@gmail.com> wrote:
>>> I am bit concerned about using -ffile-prefix-map here, its gcc only
>>> option so will cause clang to fail
>> It's almost like we need a toolchain override so this can be gcc-specific...
>>
>> I've been meaning to do that for about a year now :(
>>
>> Until then, couldn't meta-clang just override the value from the layer?
> yes it can, but one by one there are many changes to keep and core becomes
> tied to gcc. We should be conscious about it.


 From the link https://reviews.llvm.org/D49466 pasted by Dan, we know 
that clang will support option '-ffile-prefix-map'.
I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when 
clang support for '-ffile-prefix-map' implemented.

Regards,
Kai


>
>> Ross


-- 
Kai Kang



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-21  2:12       ` Kang Kai
@ 2019-01-21  2:17         ` Khem Raj
  2019-01-21  2:18           ` Kang Kai
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2019-01-21  2:17 UTC (permalink / raw)
  To: Kang Kai; +Cc: Patches and discussions about the oe-core layer

On Sun, Jan 20, 2019 at 6:12 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>
> On 2019/1/19 上午4:54, Khem Raj wrote:
> > On Fri, Jan 18, 2019 at 12:43 PM Burton, Ross <ross.burton@intel.com> wrote:
> >> On Fri, 18 Jan 2019 at 17:55, Khem Raj <raj.khem@gmail.com> wrote:
> >>> I am bit concerned about using -ffile-prefix-map here, its gcc only
> >>> option so will cause clang to fail
> >> It's almost like we need a toolchain override so this can be gcc-specific...
> >>
> >> I've been meaning to do that for about a year now :(
> >>
> >> Until then, couldn't meta-clang just override the value from the layer?
> > yes it can, but one by one there are many changes to keep and core becomes
> > tied to gcc. We should be conscious about it.
>
>
>  From the link https://reviews.llvm.org/D49466 pasted by Dan, we know
> that clang will support option '-ffile-prefix-map'.
> I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when
> clang support for '-ffile-prefix-map' implemented.

Thats ok, not worried about clang at this point. But the patch itself
was not working last time on gcc either. So if that is fixed we can consider it.

>
> Regards,
> Kai
>
>
> >
> >> Ross
>
>
> --
> Kai Kang
>


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP
  2019-01-21  2:17         ` Khem Raj
@ 2019-01-21  2:18           ` Kang Kai
  0 siblings, 0 replies; 14+ messages in thread
From: Kang Kai @ 2019-01-21  2:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On 2019/1/21 上午10:17, Khem Raj wrote:
> On Sun, Jan 20, 2019 at 6:12 PM Kang Kai <Kai.Kang@windriver.com> wrote:
>> On 2019/1/19 上午4:54, Khem Raj wrote:
>>> On Fri, Jan 18, 2019 at 12:43 PM Burton, Ross <ross.burton@intel.com> wrote:
>>>> On Fri, 18 Jan 2019 at 17:55, Khem Raj <raj.khem@gmail.com> wrote:
>>>>> I am bit concerned about using -ffile-prefix-map here, its gcc only
>>>>> option so will cause clang to fail
>>>> It's almost like we need a toolchain override so this can be gcc-specific...
>>>>
>>>> I've been meaning to do that for about a year now :(
>>>>
>>>> Until then, couldn't meta-clang just override the value from the layer?
>>> yes it can, but one by one there are many changes to keep and core becomes
>>> tied to gcc. We should be conscious about it.
>>
>>   From the link https://reviews.llvm.org/D49466 pasted by Dan, we know
>> that clang will support option '-ffile-prefix-map'.
>> I prefer to override DEBUG_PREFIX_MAP in meta-clang and remove it when
>> clang support for '-ffile-prefix-map' implemented.
> Thats ok, not worried about clang at this point. But the patch itself
> was not working last time on gcc either. So if that is fixed we can consider it.


OK. I am working on the issued pointed by Richard.


>
>> Regards,
>> Kai
>>
>>
>>>> Ross
>>
>> --
>> Kai Kang
>>

-- 
Kai Kang



^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-01-21  2:19 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17  7:12 [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP kai.kang
2019-01-17  7:56 ` [PATCH] libidn2: fix buildpaths qa warning kai.kang
2019-01-17 14:34 ` [PATCH] bitbake.conf: reset default value of DEBUG_PREFIX_MAP Dan McGregor
2019-01-17 15:19 ` Christopher Larson
2019-01-17 15:19   ` Christopher Larson
2019-01-18  1:29   ` Kang Kai
2019-01-18 11:02 ` Richard Purdie
2019-01-18 11:15   ` Richard Purdie
2019-01-18 17:55 ` Khem Raj
2019-01-18 20:43   ` Burton, Ross
2019-01-18 20:54     ` Khem Raj
2019-01-21  2:12       ` Kang Kai
2019-01-21  2:17         ` Khem Raj
2019-01-21  2:18           ` Kang Kai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.