All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/7] mmc: sunxi: Enable DM_MMC
Date: Fri, 18 Jan 2019 11:53:49 +0000	[thread overview]
Message-ID: <20190118113335.4cf300d2@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20190117170951.23623-1-jagan@amarulasolutions.com>

On Thu, 17 Jan 2019 22:39:44 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:

> V2 for previous version[1] changes, for enabling DM_MMC
> on Allwinner platform.

So this is a neat and simple solution to the DM_MMC problem, to the
point where I am wondering why we actually need all those DT driven
clock and reset drivers in the first place.
But as I understand using plat data in this way is somewhat frowned
upon and considered deprecated (although it makes a lot of sense in
this context).

Also, isn't this series independent from the clock gates/reset
patches? So why do you pile them on top of each other in sunxi/next?

If we really want to have the full featured DT driven clock and reset
support, why not use it together:
We keep the current mod clock support in the MMC driver, but use the
newly introduced clock gates and reset support via the new clock
driver, mostly replacing this series. This would give us some test
coverage of the new clock driver, while still avoiding to rush the MMC
mod clock implementation.

Does that make sense? Happy to bake some patches for that on the
weekend.

Btw: After talking to Tom on IRC, the DM_MMC deadline is actually
_after_ the 2019.04 release, so we don't need to have DM_MMC support in
this merge window.

Cheers,
Andre.

> Changes for v2:
> - update the 'reset enablement' logic to do
>   required SoC's
> 
> Note: All changes available at u-boot-sunxi/next	
> 
> [1] https://patchwork.ozlabs.org/cover/1023710/
> 
> Any comments?
> Jagan.
> 
> Jagan Teki (7):
>   mmc: sunxi: Configure reset support for DM_MMC
>   mmc: sunxi: Add A83T emmc compatible
>   mmc: sunxi: Add mmc, emmc H5/A64 compatible
>   mmc: sunxi: Add DM_MMC support for H6
>   mmc: sunxi: Add DM_MMC support for A80
>   arm: sunxi: Enable DM_MMC
>   arm: dts: sunxi: Enumerate MMC2 as MMC1
> 
>  arch/arm/Kconfig                              |  1 +
>  arch/arm/dts/sunxi-u-boot.dtsi                |  4 +
>  .../include/asm/arch-sunxi/clock_sun50i_h6.h  |  3 +
>  arch/arm/mach-sunxi/Kconfig                   |  1 -
>  configs/Linksprite_pcDuino3_defconfig         |  1 -
>  drivers/mmc/sunxi_mmc.c                       | 73
> ++++++++++++++++++- 6 files changed, 79 insertions(+), 4 deletions(-)
> 

  parent reply	other threads:[~2019-01-18 11:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 17:09 [U-Boot] [PATCH v2 0/7] mmc: sunxi: Enable DM_MMC Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 1/7] mmc: sunxi: Configure reset support for DM_MMC Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 2/7] mmc: sunxi: Add A83T emmc compatible Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 3/7] mmc: sunxi: Add mmc, emmc H5/A64 compatible Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 4/7] mmc: sunxi: Add DM_MMC support for H6 Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 5/7] mmc: sunxi: Add DM_MMC support for A80 Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 6/7] arm: sunxi: Enable DM_MMC Jagan Teki
2019-01-17 17:09 ` [U-Boot] [PATCH v2 7/7] arm: dts: sunxi: Enumerate MMC2 as MMC1 Jagan Teki
2019-01-18 11:53 ` Andre Przywara [this message]
2019-01-18 12:17   ` [U-Boot] [PATCH v2 0/7] mmc: sunxi: Enable DM_MMC Tom Rini
2019-01-18 12:30     ` Andre Przywara
2019-01-18 16:41       ` Jagan Teki
2019-01-18 17:48         ` Andre Przywara
2019-01-19  5:50           ` Jagan Teki
2019-01-19 10:17             ` André Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118113335.4cf300d2@donnerap.cambridge.arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.