All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	virtualization@lists.linux-foundation.org (open list:DRM DRIVER
	FOR QXL VIRTUAL GPU),
	spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL
	VIRTUAL GPU), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()
Date: Fri, 18 Jan 2019 13:19:58 +0100	[thread overview]
Message-ID: <20190118122020.27596-2-kraxel@redhat.com> (raw)
In-Reply-To: <20190118122020.27596-1-kraxel@redhat.com>

Not used, is always NULL.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_drv.h    |  3 +--
 drivers/gpu/drm/qxl/qxl_cmd.c    | 14 ++------------
 drivers/gpu/drm/qxl/qxl_object.c |  2 +-
 3 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 13a0254b59..38c5a8b1df 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -497,8 +497,7 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
 void qxl_surface_id_dealloc(struct qxl_device *qdev,
 			    uint32_t surface_id);
 int qxl_hw_surface_alloc(struct qxl_device *qdev,
-			 struct qxl_bo *surf,
-			 struct ttm_mem_reg *mem);
+			 struct qxl_bo *surf);
 int qxl_hw_surface_dealloc(struct qxl_device *qdev,
 			   struct qxl_bo *surf);
 
diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/gpu/drm/qxl/qxl_cmd.c
index 2e100f6442..5ba831c78c 100644
--- a/drivers/gpu/drm/qxl/qxl_cmd.c
+++ b/drivers/gpu/drm/qxl/qxl_cmd.c
@@ -460,8 +460,7 @@ void qxl_surface_id_dealloc(struct qxl_device *qdev,
 }
 
 int qxl_hw_surface_alloc(struct qxl_device *qdev,
-			 struct qxl_bo *surf,
-			 struct ttm_mem_reg *new_mem)
+			 struct qxl_bo *surf)
 {
 	struct qxl_surface_cmd *cmd;
 	struct qxl_release *release;
@@ -487,16 +486,7 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
 	cmd->u.surface_create.width = surf->surf.width;
 	cmd->u.surface_create.height = surf->surf.height;
 	cmd->u.surface_create.stride = surf->surf.stride;
-	if (new_mem) {
-		int slot_id = surf->type == QXL_GEM_DOMAIN_VRAM ? qdev->main_mem_slot : qdev->surfaces_mem_slot;
-		struct qxl_memslot *slot = &(qdev->mem_slots[slot_id]);
-
-		/* TODO - need to hold one of the locks to read tbo.offset */
-		cmd->u.surface_create.data = slot->high_bits;
-
-		cmd->u.surface_create.data |= (new_mem->start << PAGE_SHIFT) + surf->tbo.bdev->man[new_mem->mem_type].gpu_offset;
-	} else
-		cmd->u.surface_create.data = qxl_bo_physical_address(qdev, surf, 0);
+	cmd->u.surface_create.data = qxl_bo_physical_address(qdev, surf, 0);
 	cmd->surface_id = surf->surface_id;
 	qxl_release_unmap(qdev, release, &cmd->release_info);
 
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index 91f3bbc73e..34eff8b21e 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -332,7 +332,7 @@ int qxl_bo_check_id(struct qxl_device *qdev, struct qxl_bo *bo)
 		if (ret)
 			return ret;
 
-		ret = qxl_hw_surface_alloc(qdev, bo, NULL);
+		ret = qxl_hw_surface_alloc(qdev, bo);
 		if (ret)
 			return ret;
 	}
-- 
2.9.3


WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	"open list:DRM DRIVER FOR QXL VIRTUAL GPU"
	<virtualization@lists.linux-foundation.org>,
	"open list:DRM DRIVER FOR QXL VIRTUAL GPU"
	<spice-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc()
Date: Fri, 18 Jan 2019 13:19:58 +0100	[thread overview]
Message-ID: <20190118122020.27596-2-kraxel@redhat.com> (raw)
In-Reply-To: <20190118122020.27596-1-kraxel@redhat.com>

Not used, is always NULL.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_drv.h    |  3 +--
 drivers/gpu/drm/qxl/qxl_cmd.c    | 14 ++------------
 drivers/gpu/drm/qxl/qxl_object.c |  2 +-
 3 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 13a0254b59..38c5a8b1df 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -497,8 +497,7 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
 void qxl_surface_id_dealloc(struct qxl_device *qdev,
 			    uint32_t surface_id);
 int qxl_hw_surface_alloc(struct qxl_device *qdev,
-			 struct qxl_bo *surf,
-			 struct ttm_mem_reg *mem);
+			 struct qxl_bo *surf);
 int qxl_hw_surface_dealloc(struct qxl_device *qdev,
 			   struct qxl_bo *surf);
 
diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/gpu/drm/qxl/qxl_cmd.c
index 2e100f6442..5ba831c78c 100644
--- a/drivers/gpu/drm/qxl/qxl_cmd.c
+++ b/drivers/gpu/drm/qxl/qxl_cmd.c
@@ -460,8 +460,7 @@ void qxl_surface_id_dealloc(struct qxl_device *qdev,
 }
 
 int qxl_hw_surface_alloc(struct qxl_device *qdev,
-			 struct qxl_bo *surf,
-			 struct ttm_mem_reg *new_mem)
+			 struct qxl_bo *surf)
 {
 	struct qxl_surface_cmd *cmd;
 	struct qxl_release *release;
@@ -487,16 +486,7 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
 	cmd->u.surface_create.width = surf->surf.width;
 	cmd->u.surface_create.height = surf->surf.height;
 	cmd->u.surface_create.stride = surf->surf.stride;
-	if (new_mem) {
-		int slot_id = surf->type == QXL_GEM_DOMAIN_VRAM ? qdev->main_mem_slot : qdev->surfaces_mem_slot;
-		struct qxl_memslot *slot = &(qdev->mem_slots[slot_id]);
-
-		/* TODO - need to hold one of the locks to read tbo.offset */
-		cmd->u.surface_create.data = slot->high_bits;
-
-		cmd->u.surface_create.data |= (new_mem->start << PAGE_SHIFT) + surf->tbo.bdev->man[new_mem->mem_type].gpu_offset;
-	} else
-		cmd->u.surface_create.data = qxl_bo_physical_address(qdev, surf, 0);
+	cmd->u.surface_create.data = qxl_bo_physical_address(qdev, surf, 0);
 	cmd->surface_id = surf->surface_id;
 	qxl_release_unmap(qdev, release, &cmd->release_info);
 
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index 91f3bbc73e..34eff8b21e 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -332,7 +332,7 @@ int qxl_bo_check_id(struct qxl_device *qdev, struct qxl_bo *bo)
 		if (ret)
 			return ret;
 
-		ret = qxl_hw_surface_alloc(qdev, bo, NULL);
+		ret = qxl_hw_surface_alloc(qdev, bo);
 		if (ret)
 			return ret;
 	}
-- 
2.9.3

  reply	other threads:[~2019-01-18 12:21 UTC|newest]

Thread overview: 165+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 12:19 [PATCH v3 00/23] drm/qxl: ttm fixes, cleanups, allocation tweaks, multihead, fbdev Gerd Hoffmann
2019-01-18 12:19 ` Gerd Hoffmann [this message]
2019-01-18 12:19   ` [PATCH v3 01/23] drm/qxl: drop ttm_mem_reg arg from qxl_hw_surface_alloc() Gerd Hoffmann
2019-01-25 15:44   ` Noralf Trønnes
2019-01-25 15:44     ` Noralf Trønnes
2019-01-25 15:44   ` Noralf Trønnes
2019-01-18 12:19 ` Gerd Hoffmann
2019-01-18 12:19 ` [PATCH v3 02/23] drm/qxl: drop unused qxl_fb_virtual_address Gerd Hoffmann
2019-01-18 12:19   ` Gerd Hoffmann
2019-01-25 15:44   ` Noralf Trønnes
2019-01-25 15:44   ` Noralf Trønnes
2019-01-25 15:44     ` Noralf Trønnes
2019-01-18 12:19 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 03/23] drm/qxl: simplify slot management Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:52   ` Noralf Trønnes
2019-01-25 15:52   ` Noralf Trønnes
2019-01-25 15:52     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 04/23] drm/qxl: change the way slot is detected Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:52   ` Noralf Trønnes
2019-01-25 15:52     ` Noralf Trønnes
2019-01-25 15:52   ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 05/23] drm/qxl: drop unused fields from struct qxl_device Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:53   ` Noralf Trønnes
2019-01-25 15:53   ` Noralf Trønnes
2019-01-25 15:53     ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:57   ` Noralf Trønnes
2019-01-25 15:57     ` Noralf Trønnes
2019-01-25 15:57   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 07/23] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:58   ` Noralf Trønnes
2019-01-25 15:58   ` Noralf Trønnes
2019-01-25 15:58     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 08/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for shadow bo Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:58   ` Noralf Trønnes
2019-01-25 15:58   ` Noralf Trønnes
2019-01-25 15:58     ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 09/23] drm/qxl: use QXL_GEM_DOMAIN_SURFACE for dumb gem objects Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 15:59   ` Noralf Trønnes
2019-01-25 15:59     ` Noralf Trønnes
2019-01-25 15:59   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 16:09   ` Noralf Trønnes
2019-01-25 16:09     ` Noralf Trønnes
2019-01-28  8:10     ` Gerd Hoffmann
2019-01-28  8:10       ` Gerd Hoffmann
2019-01-28 10:38       ` Noralf Trønnes
2019-01-28 10:38       ` Noralf Trønnes
2019-01-28 10:38         ` Noralf Trønnes
2019-01-28 11:40         ` Gerd Hoffmann
2019-01-28 11:40           ` Gerd Hoffmann
2019-01-28 11:40         ` Gerd Hoffmann
2019-01-28  8:10     ` Gerd Hoffmann
2019-01-25 16:09   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 11/23] drm/qxl: drop unused offset parameter from qxl_io_create_primary() Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 16:10   ` Noralf Trønnes
2019-01-25 16:10   ` Noralf Trønnes
2019-01-25 16:10     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 12/23] drm/qxl: track primary bo Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 16:11   ` Noralf Trønnes
2019-01-25 16:11     ` Noralf Trønnes
2019-01-25 16:11   ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 13/23] drm/qxl: use shadow bo directly Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 16:59   ` Noralf Trønnes
2019-01-25 16:59   ` Noralf Trønnes
2019-01-25 16:59     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 14/23] drm/qxl: cover all crtcs in shadow bo Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:08   ` Noralf Trønnes
2019-01-25 17:08   ` Noralf Trønnes
2019-01-25 17:08     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 15/23] drm/qxl: use qxl_num_crtc directly Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:12   ` Noralf Trønnes
2019-01-25 17:12     ` Noralf Trønnes
2019-01-25 17:12   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 16/23] drm/qxl: implement prime kmap/kunmap Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:19   ` Noralf Trønnes
2019-01-25 17:19     ` Noralf Trønnes
2019-01-25 17:19   ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 17/23] drm/qxl: use generic fbdev emulation Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:25   ` Noralf Trønnes
2019-01-25 17:25     ` Noralf Trønnes
2019-01-28  8:59     ` Gerd Hoffmann
2019-01-28  8:59     ` Gerd Hoffmann
2019-01-28  8:59       ` Gerd Hoffmann
2019-01-28 10:39       ` Noralf Trønnes
2019-01-28 10:39         ` Noralf Trønnes
2019-01-28 10:39       ` Noralf Trønnes
2019-01-25 17:25   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:25   ` Noralf Trønnes
2019-01-25 17:25     ` Noralf Trønnes
2019-01-25 18:10     ` Sam Ravnborg
2019-01-25 18:10     ` Sam Ravnborg
2019-01-25 18:10       ` Sam Ravnborg
2019-01-25 18:44       ` Noralf Trønnes
2019-01-25 18:44         ` Noralf Trønnes
2019-01-25 18:44       ` Noralf Trønnes
2019-01-25 17:25   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 19/23] drm/qxl: implement qxl_gem_prime_(un)pin Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:26   ` Noralf Trønnes
2019-01-25 17:26   ` Noralf Trønnes
2019-01-25 17:26     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 20/23] drm/qxl: add mode/framebuffer check functions Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:30   ` Noralf Trønnes
2019-01-25 17:30   ` Noralf Trønnes
2019-01-25 17:30     ` Noralf Trønnes
2019-01-18 12:20 ` [PATCH v3 21/23] drm/qxl: add qxl_add_mode helper function Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:34   ` Noralf Trønnes
2019-01-25 17:34   ` Noralf Trønnes
2019-01-25 17:34     ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 22/23] drm/qxl: use kernel mode db Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-25 17:35   ` Noralf Trønnes
2019-01-25 17:35     ` Noralf Trønnes
2019-01-25 17:35   ` Noralf Trønnes
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20 ` [PATCH v3 23/23] drm/qxl: add overflow checks to qxl_mode_dumb_create() Gerd Hoffmann
2019-01-18 12:20 ` Gerd Hoffmann
2019-01-18 12:20   ` Gerd Hoffmann
2019-01-18 15:49   ` Daniel Vetter
2019-01-18 15:49   ` Daniel Vetter
2019-01-18 15:49     ` Daniel Vetter
2019-01-18 16:32     ` Ville Syrjälä
2019-01-18 16:32     ` Ville Syrjälä
2019-01-18 16:32       ` Ville Syrjälä
2019-01-18 17:15       ` Daniel Vetter
2019-01-18 17:15         ` Daniel Vetter
2019-01-18 17:15       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118122020.27596-2-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.