* [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler
@ 2019-01-18 14:26 Daniel Baluta
2019-01-18 18:38 ` Mark Brown
2019-01-18 20:08 ` Nicolin Chen
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Baluta @ 2019-01-18 14:26 UTC (permalink / raw)
To: broonie
Cc: Xiubo.Lee, alsa-devel, linux-kernel, S.j. Wang, dl-linux-imx,
Fabio Estevam, nicoleotsuka, Daniel Baluta
From: Shengjiu Wang <shengjiu.wang@nxp.com>
When stopping audio, ASoC will first stop DMA then CPU DAI.
Sometimes there is a delay between DMA stop and CPU DAI stop, which
triggers an underrun error. Now, because of the delay introduced
by dev_err another underrun error will occur causing a vicious circle
making impossible to stop CPU DAI.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
sound/soc/fsl/fsl_sai.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 4163f2cfc06f..db9e0872f73d 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Tx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Tx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Tx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Transmit underrun detected\n");
+ dev_dbg(dev, "isr: Transmit underrun detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
@@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Rx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Rx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Rx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Receive overflow detected\n");
+ dev_dbg(dev, "isr: Receive overflow detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "ASoC: fsl_sai: Remove expensive print in irq handler" to the asoc tree
2019-01-18 14:26 [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler Daniel Baluta
@ 2019-01-18 18:38 ` Mark Brown
2019-01-18 20:08 ` Nicolin Chen
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-01-18 18:38 UTC (permalink / raw)
To: Shengjiu Wang
Cc: Daniel Baluta, Mark Brown, broonie, alsa-devel, Xiubo.Lee,
S.j. Wang, linux-kernel, nicoleotsuka, dl-linux-imx,
Fabio Estevam, Daniel Baluta, alsa-devel
The patch
ASoC: fsl_sai: Remove expensive print in irq handler
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From e412fcb0db5c44a3450ca678b281ea9332e6bf82 Mon Sep 17 00:00:00 2001
From: Shengjiu Wang <shengjiu.wang@nxp.com>
Date: Fri, 18 Jan 2019 14:26:46 +0000
Subject: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler
When stopping audio, ASoC will first stop DMA then CPU DAI.
Sometimes there is a delay between DMA stop and CPU DAI stop, which
triggers an underrun error. Now, because of the delay introduced
by dev_err another underrun error will occur causing a vicious circle
making impossible to stop CPU DAI.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/fsl/fsl_sai.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 4163f2cfc06f..db9e0872f73d 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Tx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Tx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Tx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Transmit underrun detected\n");
+ dev_dbg(dev, "isr: Transmit underrun detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
@@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Rx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Rx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Rx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Receive overflow detected\n");
+ dev_dbg(dev, "isr: Receive overflow detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "ASoC: fsl_sai: Remove expensive print in irq handler" to the asoc tree
@ 2019-01-18 18:38 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-01-18 18:38 UTC (permalink / raw)
Cc: alsa-devel, Xiubo.Lee, S.j. Wang, linux-kernel, nicoleotsuka,
broonie, dl-linux-imx, Fabio Estevam, Daniel Baluta
The patch
ASoC: fsl_sai: Remove expensive print in irq handler
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From e412fcb0db5c44a3450ca678b281ea9332e6bf82 Mon Sep 17 00:00:00 2001
From: Shengjiu Wang <shengjiu.wang@nxp.com>
Date: Fri, 18 Jan 2019 14:26:46 +0000
Subject: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler
When stopping audio, ASoC will first stop DMA then CPU DAI.
Sometimes there is a delay between DMA stop and CPU DAI stop, which
triggers an underrun error. Now, because of the delay introduced
by dev_err another underrun error will occur causing a vicious circle
making impossible to stop CPU DAI.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/fsl/fsl_sai.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 4163f2cfc06f..db9e0872f73d 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Tx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Tx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Tx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Transmit underrun detected\n");
+ dev_dbg(dev, "isr: Transmit underrun detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
@@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
dev_dbg(dev, "isr: Start of Rx word detected\n");
if (flags & FSL_SAI_CSR_SEF)
- dev_warn(dev, "isr: Rx Frame sync error detected\n");
+ dev_dbg(dev, "isr: Rx Frame sync error detected\n");
if (flags & FSL_SAI_CSR_FEF) {
- dev_warn(dev, "isr: Receive overflow detected\n");
+ dev_dbg(dev, "isr: Receive overflow detected\n");
/* FIFO reset for safety */
xcsr |= FSL_SAI_CSR_FR;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler
2019-01-18 14:26 [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler Daniel Baluta
@ 2019-01-18 20:08 ` Nicolin Chen
2019-01-18 20:08 ` Nicolin Chen
1 sibling, 0 replies; 5+ messages in thread
From: Nicolin Chen @ 2019-01-18 20:08 UTC (permalink / raw)
To: Daniel Baluta
Cc: broonie, Xiubo.Lee, alsa-devel, linux-kernel, S.j. Wang,
dl-linux-imx, Fabio Estevam
On Fri, Jan 18, 2019 at 02:26:46PM +0000, Daniel Baluta wrote:
> From: Shengjiu Wang <shengjiu.wang@nxp.com>
>
> When stopping audio, ASoC will first stop DMA then CPU DAI.
> Sometimes there is a delay between DMA stop and CPU DAI stop, which
> triggers an underrun error. Now, because of the delay introduced
> by dev_err another underrun error will occur causing a vicious circle
> making impossible to stop CPU DAI.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> sound/soc/fsl/fsl_sai.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 4163f2cfc06f..db9e0872f73d 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
> dev_dbg(dev, "isr: Start of Tx word detected\n");
>
> if (flags & FSL_SAI_CSR_SEF)
> - dev_warn(dev, "isr: Tx Frame sync error detected\n");
> + dev_dbg(dev, "isr: Tx Frame sync error detected\n");
>
> if (flags & FSL_SAI_CSR_FEF) {
> - dev_warn(dev, "isr: Transmit underrun detected\n");
> + dev_dbg(dev, "isr: Transmit underrun detected\n");
> /* FIFO reset for safety */
> xcsr |= FSL_SAI_CSR_FR;
> }
> @@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
> dev_dbg(dev, "isr: Start of Rx word detected\n");
>
> if (flags & FSL_SAI_CSR_SEF)
> - dev_warn(dev, "isr: Rx Frame sync error detected\n");
> + dev_dbg(dev, "isr: Rx Frame sync error detected\n");
>
> if (flags & FSL_SAI_CSR_FEF) {
> - dev_warn(dev, "isr: Receive overflow detected\n");
> + dev_dbg(dev, "isr: Receive overflow detected\n");
> /* FIFO reset for safety */
> xcsr |= FSL_SAI_CSR_FR;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler
@ 2019-01-18 20:08 ` Nicolin Chen
0 siblings, 0 replies; 5+ messages in thread
From: Nicolin Chen @ 2019-01-18 20:08 UTC (permalink / raw)
To: Daniel Baluta
Cc: alsa-devel, Xiubo.Lee, S.j. Wang, linux-kernel, broonie,
dl-linux-imx, Fabio Estevam
On Fri, Jan 18, 2019 at 02:26:46PM +0000, Daniel Baluta wrote:
> From: Shengjiu Wang <shengjiu.wang@nxp.com>
>
> When stopping audio, ASoC will first stop DMA then CPU DAI.
> Sometimes there is a delay between DMA stop and CPU DAI stop, which
> triggers an underrun error. Now, because of the delay introduced
> by dev_err another underrun error will occur causing a vicious circle
> making impossible to stop CPU DAI.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> sound/soc/fsl/fsl_sai.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 4163f2cfc06f..db9e0872f73d 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
> dev_dbg(dev, "isr: Start of Tx word detected\n");
>
> if (flags & FSL_SAI_CSR_SEF)
> - dev_warn(dev, "isr: Tx Frame sync error detected\n");
> + dev_dbg(dev, "isr: Tx Frame sync error detected\n");
>
> if (flags & FSL_SAI_CSR_FEF) {
> - dev_warn(dev, "isr: Transmit underrun detected\n");
> + dev_dbg(dev, "isr: Transmit underrun detected\n");
> /* FIFO reset for safety */
> xcsr |= FSL_SAI_CSR_FR;
> }
> @@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid)
> dev_dbg(dev, "isr: Start of Rx word detected\n");
>
> if (flags & FSL_SAI_CSR_SEF)
> - dev_warn(dev, "isr: Rx Frame sync error detected\n");
> + dev_dbg(dev, "isr: Rx Frame sync error detected\n");
>
> if (flags & FSL_SAI_CSR_FEF) {
> - dev_warn(dev, "isr: Receive overflow detected\n");
> + dev_dbg(dev, "isr: Receive overflow detected\n");
> /* FIFO reset for safety */
> xcsr |= FSL_SAI_CSR_FR;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-18 20:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 14:26 [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler Daniel Baluta
2019-01-18 18:38 ` Applied "ASoC: fsl_sai: Remove expensive print in irq handler" to the asoc tree Mark Brown
2019-01-18 18:38 ` Mark Brown
2019-01-18 20:08 ` [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler Nicolin Chen
2019-01-18 20:08 ` Nicolin Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.