From: Dave Chinner <david@fromorbit.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org, houtao1@huawei.com,
zhaohongjiang@huawei.com
Subject: Re: [PATCH 0/1] squashfs: introduce squashfs support
Date: Tue, 22 Jan 2019 09:49:19 +1100 [thread overview]
Message-ID: <20190121224919.GF4205@dastard> (raw)
In-Reply-To: <20190118093725.103172-1-zhengbin13@huawei.com>
On Fri, Jan 18, 2019 at 05:37:24PM +0800, zhengbin wrote:
> This patch add squashfs support in xfstests-dev. Add two directories
> in tests directory, readonly can also be used for other readonly
> filesystem, squashfs is just used for squashfs filesystem.
> tests/readonly/001 mount test
> tests/readonly/002--010 metadata test
> tests/readonly/011--018 data test
> tests/readonly/019--021 xattr test
> tests/squashfs/001--005 mksquashfs options test
>
> zhengbin (1):
> squashfs: add squashfs tests
This needs to be broken up into multiple patches.
At least:
- one that adds squashfs support
- one for each of the different infrastructure changes
that are needed (e.g. to common/config, to common/rc, etc)
- one that adds squashfs specific tests
- the "read-only" tests need to be separated out - 20 tests
in a single patch is way too many to review in a single
file.
> .gitignore | 1 +
> README.squashfs | 12 ++
> check | 19 ++-
> common/attr | 5 +
> common/config | 6 +
> common/rc | 63 ++++++++-
> src/aio-dio-regress/aio-subblock-eof-read.c | 84 ++++++++++++
Why is there a new AIO test hidden in all this? That needs to be in
it's own patch (along with the test that uses it).
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-01-21 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:37 [PATCH 0/1] squashfs: introduce squashfs support zhengbin
2019-01-18 9:37 ` [PATCH 1/1] squashfs: add squashfs tests zhengbin
2019-01-18 12:43 ` [PATCH 0/1] squashfs: introduce squashfs support Eryu Guan
2019-01-21 1:48 ` zhengbin (A)
2019-01-21 22:49 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121224919.GF4205@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=houtao1@huawei.com \
--cc=zhaohongjiang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.