From: "zhengbin (A)" <zhengbin13@huawei.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org, houtao1@huawei.com, zhaohongjiang@huawei.com
Subject: Re: [PATCH 0/1] squashfs: introduce squashfs support
Date: Mon, 21 Jan 2019 09:48:46 +0800 [thread overview]
Message-ID: <6caf7cea-581c-f02c-beb9-3f18474340e2@huawei.com> (raw)
In-Reply-To: <20190118124356.GK2713@desktop>
> Would you please split the patch into multiple patches? So that it's
> much easier to review. e.g.
---->Copy that, I will send a v2 patch later
> Also, the 'readonly' tests should really be in in 'shared' dir with
> proper '_supported_fs' statement, if they're meant to be shared with
> other readonly filesystems.
---->My advice is that the 'readonly' tests should still be in 'readonly' dir.
The step of tests in readonly filesystem(such as squashfs) are as follows:
1. write data in $SCRATCH_DEV
2. mkfs $SCRATCH_DEV file
3. mount file $SCRATCH_MNT
4. test in $SCRATCH_MNT
While the rw filesystems are as follows:
1. mkfs $SCRATCH_DEV
2. mount $SCRATCH_DEV $SCRATCH_MNT
3. test in $SCRATCH_MNT(just write data in $SCRATCH_MNT)
The tests in generic/shared are set as rw filesystem, it is hard to use this in
readonly filesystem, So I use 'readonly' dir which can be easier to read.
This is my advice, looking forward to your reply, thanks.
PS: As readonly filesystems need to mkfs in every test, I do not use TEST_DEV & TEST_DIR
On 2019/1/18 20:43, Eryu Guan wrote:
> On Fri, Jan 18, 2019 at 05:37:24PM +0800, zhengbin wrote:
>> This patch add squashfs support in xfstests-dev. Add two directories
>
> Would you please split the patch into multiple patches? So that it's
> much easier to review. e.g.
>
>> in tests directory, readonly can also be used for other readonly
>> filesystem, squashfs is just used for squashfs filesystem.
>
> The squashfs support is one patch.
>
>> tests/readonly/001 mount test
>> tests/readonly/002--010 metadata test
>> tests/readonly/011--018 data test
>> tests/readonly/019--021 xattr test
>> tests/squashfs/001--005 mksquashfs options test
>
> And each test group in one patch.
>
> Also, the 'readonly' tests should really be in in 'shared' dir with
> proper '_supported_fs' statement, if they're meant to be shared with
> other readonly filesystems.
>
> Thanks,
> Eryu
>
>>
>> zhengbin (1):
>> squashfs: add squashfs tests
>>
>> .gitignore | 1 +
>> README.squashfs | 12 ++
>> check | 19 ++-
>> common/attr | 5 +
>> common/config | 6 +
>> common/rc | 63 ++++++++-
>> src/aio-dio-regress/aio-subblock-eof-read.c | 84 ++++++++++++
>> tests/readonly/001 | 97 ++++++++++++++
>> tests/readonly/001.out | 2 +
>> tests/readonly/002 | 48 +++++++
>> tests/readonly/002.out | 6 +
>> tests/readonly/003 | 72 +++++++++++
>> tests/readonly/003.out | 5 +
>> tests/readonly/004 | 50 +++++++
>> tests/readonly/004.out | 3 +
>> tests/readonly/005 | 77 +++++++++++
>> tests/readonly/005.out | 2 +
>> tests/readonly/006 | 48 +++++++
>> tests/readonly/006.out | 4 +
>> tests/readonly/007 | 74 +++++++++++
>> tests/readonly/007.out | 9 ++
>> tests/readonly/008 | 193 ++++++++++++++++++++++++++++
>> tests/readonly/008.out | 34 +++++
>> tests/readonly/009 | 50 +++++++
>> tests/readonly/009.out | 2 +
>> tests/readonly/010 | 49 +++++++
>> tests/readonly/010.out | 4 +
>> tests/readonly/011 | 92 +++++++++++++
>> tests/readonly/011.out | 30 +++++
>> tests/readonly/012 | 56 ++++++++
>> tests/readonly/012.out | 5 +
>> tests/readonly/013 | 47 +++++++
>> tests/readonly/013.out | 2 +
>> tests/readonly/014 | 46 +++++++
>> tests/readonly/014.out | 2 +
>> tests/readonly/015 | 42 ++++++
>> tests/readonly/015.out | 2 +
>> tests/readonly/016 | 145 +++++++++++++++++++++
>> tests/readonly/016.out | 8 ++
>> tests/readonly/017 | 107 +++++++++++++++
>> tests/readonly/017.out | 2 +
>> tests/readonly/018 | 49 +++++++
>> tests/readonly/018.out | 2 +
>> tests/readonly/019 | 109 ++++++++++++++++
>> tests/readonly/019.out | 45 +++++++
>> tests/readonly/020 | 56 ++++++++
>> tests/readonly/020.out | 9 ++
>> tests/readonly/021 | 74 +++++++++++
>> tests/readonly/021.out | 11 ++
>> tests/readonly/Makefile | 20 +++
>> tests/readonly/group | 26 ++++
>> tests/squashfs/001 | 60 +++++++++
>> tests/squashfs/001.out | 9 ++
>> tests/squashfs/002 | 40 ++++++
>> tests/squashfs/002.out | 2 +
>> tests/squashfs/003 | 55 ++++++++
>> tests/squashfs/003.out | 12 ++
>> tests/squashfs/004 | 73 +++++++++++
>> tests/squashfs/004.out | 23 ++++
>> tests/squashfs/005 | 54 ++++++++
>> tests/squashfs/005.out | 13 ++
>> tests/squashfs/Makefile | 20 +++
>> tests/squashfs/group | 10 ++
>> 63 files changed, 2372 insertions(+), 5 deletions(-)
>> create mode 100644 README.squashfs
>> create mode 100644 src/aio-dio-regress/aio-subblock-eof-read.c
>> create mode 100755 tests/readonly/001
>> create mode 100644 tests/readonly/001.out
>> create mode 100755 tests/readonly/002
>> create mode 100644 tests/readonly/002.out
>> create mode 100755 tests/readonly/003
>> create mode 100644 tests/readonly/003.out
>> create mode 100755 tests/readonly/004
>> create mode 100644 tests/readonly/004.out
>> create mode 100755 tests/readonly/005
>> create mode 100644 tests/readonly/005.out
>> create mode 100755 tests/readonly/006
>> create mode 100644 tests/readonly/006.out
>> create mode 100755 tests/readonly/007
>> create mode 100644 tests/readonly/007.out
>> create mode 100755 tests/readonly/008
>> create mode 100644 tests/readonly/008.out
>> create mode 100755 tests/readonly/009
>> create mode 100644 tests/readonly/009.out
>> create mode 100755 tests/readonly/010
>> create mode 100644 tests/readonly/010.out
>> create mode 100755 tests/readonly/011
>> create mode 100644 tests/readonly/011.out
>> create mode 100755 tests/readonly/012
>> create mode 100644 tests/readonly/012.out
>> create mode 100755 tests/readonly/013
>> create mode 100644 tests/readonly/013.out
>> create mode 100755 tests/readonly/014
>> create mode 100644 tests/readonly/014.out
>> create mode 100755 tests/readonly/015
>> create mode 100644 tests/readonly/015.out
>> create mode 100755 tests/readonly/016
>> create mode 100644 tests/readonly/016.out
>> create mode 100755 tests/readonly/017
>> create mode 100644 tests/readonly/017.out
>> create mode 100755 tests/readonly/018
>> create mode 100644 tests/readonly/018.out
>> create mode 100755 tests/readonly/019
>> create mode 100644 tests/readonly/019.out
>> create mode 100755 tests/readonly/020
>> create mode 100644 tests/readonly/020.out
>> create mode 100755 tests/readonly/021
>> create mode 100644 tests/readonly/021.out
>> create mode 100644 tests/readonly/Makefile
>> create mode 100644 tests/readonly/group
>> create mode 100755 tests/squashfs/001
>> create mode 100644 tests/squashfs/001.out
>> create mode 100755 tests/squashfs/002
>> create mode 100644 tests/squashfs/002.out
>> create mode 100755 tests/squashfs/003
>> create mode 100644 tests/squashfs/003.out
>> create mode 100755 tests/squashfs/004
>> create mode 100644 tests/squashfs/004.out
>> create mode 100755 tests/squashfs/005
>> create mode 100644 tests/squashfs/005.out
>> create mode 100644 tests/squashfs/Makefile
>> create mode 100644 tests/squashfs/group
>>
>> --
>> 2.16.2.dirty
>>
>
> .
>
next prev parent reply other threads:[~2019-01-21 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:37 [PATCH 0/1] squashfs: introduce squashfs support zhengbin
2019-01-18 9:37 ` [PATCH 1/1] squashfs: add squashfs tests zhengbin
2019-01-18 12:43 ` [PATCH 0/1] squashfs: introduce squashfs support Eryu Guan
2019-01-21 1:48 ` zhengbin (A) [this message]
2019-01-21 22:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6caf7cea-581c-f02c-beb9-3f18474340e2@huawei.com \
--to=zhengbin13@huawei.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=houtao1@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.