From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Sérgio Peixoto" <sergio.peixoto@gmail.com>,
"Brandon Williams" <bwilliams.eng@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] attr: do not mark queried macros as unset
Date: Tue, 22 Jan 2019 02:21:11 -0500 [thread overview]
Message-ID: <20190122072111.GD28555@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8DFX2P6nF200YV_3VjXiags0W28awbSAwc9ztfEZPbJ4g@mail.gmail.com>
On Mon, Jan 21, 2019 at 05:05:56PM +0700, Duy Nguyen wrote:
> > It should be possible to salvage this optimization, but let's start with
> > just removing the remnants. It hasn't been doing anything (except
> > creating bugs) since 60a12722ac, and nobody seems to have noticed the
> > performance regression. It's more important to fix the correctness
> > problem clearly first.
>
> But muh optimization!!! You're right of course, correctness comes
> first. I did try to look at this code but it's been a while and I'm
> afraid I don't have anything valuable to say. I'll dig in more in the
> next couple days.
:) See the side-thread, and the response I just wrote to Stefan. At this
point I do think it's possible, but my hope is that I could call it
quits with the bugfix portion and hand it off to somebody interested in
this area. I know you're juggling quite a few other series, though.
-Peff
next prev parent reply other threads:[~2019-01-22 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:47 Change on check-attr behavior Sérgio Peixoto
2019-01-17 16:07 ` Jeff King
2019-01-18 9:41 ` Sérgio Peixoto
2019-01-18 16:58 ` Jeff King
2019-01-18 21:34 ` [PATCH] attr: do not mark queried macros as unset Jeff King
2019-01-18 21:46 ` Jeff King
2019-01-18 22:19 ` Stefan Beller
2019-01-22 7:19 ` Jeff King
2019-01-22 9:50 ` Duy Nguyen
2019-01-22 22:00 ` Junio C Hamano
2019-01-21 10:05 ` Duy Nguyen
2019-01-22 7:21 ` Jeff King [this message]
2019-01-22 9:34 ` Duy Nguyen
2019-01-22 21:48 ` Junio C Hamano
2019-01-23 5:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122072111.GD28555@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bwilliams.eng@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sergio.peixoto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.