From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Sérgio Peixoto" <sergio.peixoto@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Brandon Williams" <bwilliams.eng@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] attr: do not mark queried macros as unset
Date: Wed, 23 Jan 2019 00:40:26 -0500 [thread overview]
Message-ID: <20190123054026.GA19443@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqlg3ce545.fsf@gitster-ct.c.googlers.com>
On Tue, Jan 22, 2019 at 01:48:10PM -0800, Junio C Hamano wrote:
> > When 06a604e670 later refactored the macro code, it dropped maybe_real
>
> I think 60a12722ac is what you meant here.
Yes indeed, too many 6's, 0's, and a's. :) I see you marked it up when
you picked up the patch. Thanks.
I should also have added:
Reported-by: Sérgio Peixoto <sergio.peixoto@gmail.com>
to the original, if it's not too late.
-Peff
prev parent reply other threads:[~2019-01-23 5:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:47 Change on check-attr behavior Sérgio Peixoto
2019-01-17 16:07 ` Jeff King
2019-01-18 9:41 ` Sérgio Peixoto
2019-01-18 16:58 ` Jeff King
2019-01-18 21:34 ` [PATCH] attr: do not mark queried macros as unset Jeff King
2019-01-18 21:46 ` Jeff King
2019-01-18 22:19 ` Stefan Beller
2019-01-22 7:19 ` Jeff King
2019-01-22 9:50 ` Duy Nguyen
2019-01-22 22:00 ` Junio C Hamano
2019-01-21 10:05 ` Duy Nguyen
2019-01-22 7:21 ` Jeff King
2019-01-22 9:34 ` Duy Nguyen
2019-01-22 21:48 ` Junio C Hamano
2019-01-23 5:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123054026.GA19443@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bwilliams.eng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sergio.peixoto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.