* [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
@ 2019-01-22 12:41 Juha-Pekka Heikkila
2019-01-22 14:03 ` Juha-Pekka Heikkila
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-22 12:41 UTC (permalink / raw)
To: intel-gfx
Using visible plane width for testing NV12 source suitability may fail
randomly when plane is clipped.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109381
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index b02d3d9..a15c5ef 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1516,7 +1516,7 @@ static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_s
{
const struct drm_framebuffer *fb = plane_state->base.fb;
unsigned int rotation = plane_state->base.rotation;
- int src_w = drm_rect_width(&plane_state->base.src) >> 16;
+ int src_w = plane_state->base.fb->width;
/* Display WA #1106 */
if (fb->format->format == DRM_FORMAT_NV12 && src_w & 3 &&
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
2019-01-22 12:41 [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 Juha-Pekka Heikkila
@ 2019-01-22 14:03 ` Juha-Pekka Heikkila
2019-01-22 14:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-22 17:17 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Juha-Pekka Heikkila @ 2019-01-22 14:03 UTC (permalink / raw)
To: intel-gfx
Please ignore this. This patch is all wrong.
/Juha-Pekka
On 22.1.2019 14.41, Juha-Pekka Heikkila wrote:
> Using visible plane width for testing NV12 source suitability may fail
> randomly when plane is clipped.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109381
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index b02d3d9..a15c5ef 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1516,7 +1516,7 @@ static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_s
> {
> const struct drm_framebuffer *fb = plane_state->base.fb;
> unsigned int rotation = plane_state->base.rotation;
> - int src_w = drm_rect_width(&plane_state->base.src) >> 16;
> + int src_w = plane_state->base.fb->width;
>
> /* Display WA #1106 */
> if (fb->format->format == DRM_FORMAT_NV12 && src_w & 3 &&
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
2019-01-22 12:41 [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 Juha-Pekka Heikkila
2019-01-22 14:03 ` Juha-Pekka Heikkila
@ 2019-01-22 14:38 ` Patchwork
2019-01-22 17:17 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-22 14:38 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
URL : https://patchwork.freedesktop.org/series/55558/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5463 -> Patchwork_12004
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55558/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12004 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u3}: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
Participating hosts (41 -> 39)
------------------------------
Additional (2): fi-icl-u2 fi-apl-guc
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* Linux: CI_DRM_5463 -> Patchwork_12004
CI_DRM_5463: 6bd1569466edcb2f890a374be27f0eb6780963f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12004: d607a5109524a7bf7a9d77b1465a627a20c42021 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d607a5109524 drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12004/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
2019-01-22 12:41 [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 Juha-Pekka Heikkila
2019-01-22 14:03 ` Juha-Pekka Heikkila
2019-01-22 14:38 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-22 17:17 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-22 17:17 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12
URL : https://patchwork.freedesktop.org/series/55558/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5463_full -> Patchwork_12004_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12004_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_nop@signal-all:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_color@pipe-c-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109381] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109381]: https://bugs.freedesktop.org/show_bug.cgi?id=109381
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5463 -> Patchwork_12004
CI_DRM_5463: 6bd1569466edcb2f890a374be27f0eb6780963f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12004: d607a5109524a7bf7a9d77b1465a627a20c42021 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12004/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-22 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 12:41 [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 Juha-Pekka Heikkila
2019-01-22 14:03 ` Juha-Pekka Heikkila
2019-01-22 14:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-22 17:17 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.