All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Avoid divide by zero
@ 2019-01-22 12:58 Mika Kahola
  2019-01-22 13:07 ` Jani Nikula
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Mika Kahola @ 2019-01-22 12:58 UTC (permalink / raw)
  To: intel-gfx

Avoid divide by zero warning on static analysis.

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 8b63afa3a221..6a8e8b3f44c2 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct drm_i915_private *dev_priv,
 			pipe_width = hdisplay;
 	}
 
-	alloc->start = ddb_size * width_before_pipe / total_width;
-	alloc->end = ddb_size * (width_before_pipe + pipe_width) / total_width;
+	alloc->start = total_width == 0 ?
+		0 : ddb_size * width_before_pipe / total_width;
+	alloc->end = total_width == 0 ?
+		0 : ddb_size * (width_before_pipe + pipe_width) / total_width;
 }
 
 static unsigned int skl_cursor_allocation(int num_active)
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 12:58 [PATCH] drm/i915: Avoid divide by zero Mika Kahola
@ 2019-01-22 13:07 ` Jani Nikula
  2019-01-22 13:22   ` Kahola, Mika
  2019-01-22 16:00 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-01-22 13:07 UTC (permalink / raw)
  To: Mika Kahola, intel-gfx

On Tue, 22 Jan 2019, Mika Kahola <mika.kahola@intel.com> wrote:
> Avoid divide by zero warning on static analysis.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8b63afa3a221..6a8e8b3f44c2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct drm_i915_private *dev_priv,
>  			pipe_width = hdisplay;
>  	}

if (WARN_ON(total_width == 0))
	return;

?

BR,
Jani.


>  
> -	alloc->start = ddb_size * width_before_pipe / total_width;
> -	alloc->end = ddb_size * (width_before_pipe + pipe_width) / total_width;
> +	alloc->start = total_width == 0 ?
> +		0 : ddb_size * width_before_pipe / total_width;
> +	alloc->end = total_width == 0 ?
> +		0 : ddb_size * (width_before_pipe + pipe_width) / total_width;
>  }
>  
>  static unsigned int skl_cursor_allocation(int num_active)

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 13:07 ` Jani Nikula
@ 2019-01-22 13:22   ` Kahola, Mika
  0 siblings, 0 replies; 10+ messages in thread
From: Kahola, Mika @ 2019-01-22 13:22 UTC (permalink / raw)
  To: intel-gfx, jani.nikula

On Tue, 2019-01-22 at 15:07 +0200, Jani Nikula wrote:
> On Tue, 22 Jan 2019, Mika Kahola <mika.kahola@intel.com> wrote:
> > Avoid divide by zero warning on static analysis.
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c
> > b/drivers/gpu/drm/i915/intel_pm.c
> > index 8b63afa3a221..6a8e8b3f44c2 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct
> > drm_i915_private *dev_priv,
> >  			pipe_width = hdisplay;
> >  	}
> 
> if (WARN_ON(total_width == 0))
> 	return;
Warning might be enough here. Switching to use this in this patch.

Thanks for the review!

Cheers,
Mika

> 
> ?
> 
> BR,
> Jani.
> 
> 
> >  
> > -	alloc->start = ddb_size * width_before_pipe / total_width;
> > -	alloc->end = ddb_size * (width_before_pipe + pipe_width) /
> > total_width;
> > +	alloc->start = total_width == 0 ?
> > +		0 : ddb_size * width_before_pipe / total_width;
> > +	alloc->end = total_width == 0 ?
> > +		0 : ddb_size * (width_before_pipe + pipe_width) /
> > total_width;
> >  }
> >  
> >  static unsigned int skl_cursor_allocation(int num_active)
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Avoid divide by zero
  2019-01-22 12:58 [PATCH] drm/i915: Avoid divide by zero Mika Kahola
  2019-01-22 13:07 ` Jani Nikula
@ 2019-01-22 16:00 ` Patchwork
  2019-01-22 16:23 ` [PATCH] " Ville Syrjälä
  2019-01-22 19:36 ` ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-01-22 16:00 UTC (permalink / raw)
  To: Kahola, Mika; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid divide by zero
URL   : https://patchwork.freedesktop.org/series/55560/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5464 -> Patchwork_12005
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/55560/revisions/1/mbox/

Known issues
------------

  Here are the changes found in Patchwork_12005 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108094]

  * igt@amdgpu/amd_prime@amd-to-i915:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#107341]

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       NOTRUN -> INCOMPLETE [fdo#107718]

  * igt@kms_busy@basic-flip-b:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       PASS -> FAIL [fdo#108767]

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-skl-6700hq:      PASS -> DMESG-WARN [fdo#105998]

  * igt@prime_vgem@basic-fence-flip:
    - fi-ilk-650:         PASS -> FAIL [fdo#104008]

  
#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       DMESG-WARN [fdo#108965] -> PASS

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
  [fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
  [fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (45 -> 41)
------------------------------

  Additional (1): fi-skl-6770hq 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-y 


Build changes
-------------

    * Linux: CI_DRM_5464 -> Patchwork_12005

  CI_DRM_5464: af90b519a670a3aec89045d9fcca8f2d174adeda @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12005: d2fc4d12140ad34b584bb8c0ca2074af9a821794 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d2fc4d12140a drm/i915: Avoid divide by zero

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12005/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 12:58 [PATCH] drm/i915: Avoid divide by zero Mika Kahola
  2019-01-22 13:07 ` Jani Nikula
  2019-01-22 16:00 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-22 16:23 ` Ville Syrjälä
  2019-01-22 18:09   ` Jani Nikula
  2019-01-22 19:36 ` ✓ Fi.CI.IGT: success for " Patchwork
  3 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2019-01-22 16:23 UTC (permalink / raw)
  To: Mika Kahola; +Cc: intel-gfx

On Tue, Jan 22, 2019 at 02:58:24PM +0200, Mika Kahola wrote:
> Avoid divide by zero warning on static analysis.
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 8b63afa3a221..6a8e8b3f44c2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct drm_i915_private *dev_priv,
>  			pipe_width = hdisplay;
>  	}
>  
> -	alloc->start = ddb_size * width_before_pipe / total_width;
> -	alloc->end = ddb_size * (width_before_pipe + pipe_width) / total_width;
> +	alloc->start = total_width == 0 ?
> +		0 : ddb_size * width_before_pipe / total_width;
> +	alloc->end = total_width == 0 ?
> +		0 : ddb_size * (width_before_pipe + pipe_width) / total_width;

Can't happen.

>  }
>  
>  static unsigned int skl_cursor_allocation(int num_active)
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 16:23 ` [PATCH] " Ville Syrjälä
@ 2019-01-22 18:09   ` Jani Nikula
  2019-01-22 19:09     ` Ville Syrjälä
  0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-01-22 18:09 UTC (permalink / raw)
  To: Ville Syrjälä, Mika Kahola; +Cc: intel-gfx

On Tue, 22 Jan 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Jan 22, 2019 at 02:58:24PM +0200, Mika Kahola wrote:
>> Avoid divide by zero warning on static analysis.
>> 
>> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 8b63afa3a221..6a8e8b3f44c2 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct drm_i915_private *dev_priv,
>>  			pipe_width = hdisplay;
>>  	}
>>  
>> -	alloc->start = ddb_size * width_before_pipe / total_width;
>> -	alloc->end = ddb_size * (width_before_pipe + pipe_width) / total_width;
>> +	alloc->start = total_width == 0 ?
>> +		0 : ddb_size * width_before_pipe / total_width;
>> +	alloc->end = total_width == 0 ?
>> +		0 : ddb_size * (width_before_pipe + pipe_width) / total_width;
>
> Can't happen.

Yeah, it's about stfu the checker...

>
>>  }
>>  
>>  static unsigned int skl_cursor_allocation(int num_active)
>> -- 
>> 2.17.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 18:09   ` Jani Nikula
@ 2019-01-22 19:09     ` Ville Syrjälä
  2019-01-23  7:21       ` Kahola, Mika
  0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2019-01-22 19:09 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Tue, Jan 22, 2019 at 08:09:40PM +0200, Jani Nikula wrote:
> On Tue, 22 Jan 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Jan 22, 2019 at 02:58:24PM +0200, Mika Kahola wrote:
> >> Avoid divide by zero warning on static analysis.
> >> 
> >> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> >> index 8b63afa3a221..6a8e8b3f44c2 100644
> >> --- a/drivers/gpu/drm/i915/intel_pm.c
> >> +++ b/drivers/gpu/drm/i915/intel_pm.c
> >> @@ -3912,8 +3912,10 @@ skl_ddb_get_pipe_allocation_limits(struct drm_i915_private *dev_priv,
> >>  			pipe_width = hdisplay;
> >>  	}
> >>  
> >> -	alloc->start = ddb_size * width_before_pipe / total_width;
> >> -	alloc->end = ddb_size * (width_before_pipe + pipe_width) / total_width;
> >> +	alloc->start = total_width == 0 ?
> >> +		0 : ddb_size * width_before_pipe / total_width;
> >> +	alloc->end = total_width == 0 ?
> >> +		0 : ddb_size * (width_before_pipe + pipe_width) / total_width;
> >
> > Can't happen.
> 
> Yeah, it's about stfu the checker...

Feels like the tip of an iceberg. How many more uglies are we going to
have to add?

> 
> >
> >>  }
> >>  
> >>  static unsigned int skl_cursor_allocation(int num_active)
> >> -- 
> >> 2.17.1
> >> 
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Avoid divide by zero
  2019-01-22 12:58 [PATCH] drm/i915: Avoid divide by zero Mika Kahola
                   ` (2 preceding siblings ...)
  2019-01-22 16:23 ` [PATCH] " Ville Syrjälä
@ 2019-01-22 19:36 ` Patchwork
  3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-01-22 19:36 UTC (permalink / raw)
  To: Kahola, Mika; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid divide by zero
URL   : https://patchwork.freedesktop.org/series/55560/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5464_full -> Patchwork_12005_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_12005_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          PASS -> FAIL [fdo#106641]
    - shard-glk:          PASS -> FAIL [fdo#106641]

  * igt@kms_busy@extended-pageflip-hang-newfb-render-a:
    - shard-glk:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
    - shard-snb:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_color@pipe-c-ctm-max:
    - shard-apl:          PASS -> FAIL [fdo#108147]

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-glk:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-64x64-onscreen:
    - shard-apl:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          PASS -> FAIL [fdo#105767]

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          PASS -> FAIL [fdo#103355]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-apl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-glk:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-glk:          PASS -> FAIL [fdo#103166] +1

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          PASS -> FAIL [fdo#103166] +1

  
#### Possible fixes ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-dpms:
    - shard-glk:          FAIL [fdo#103232] -> PASS +3

  * igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
    - shard-snb:          {SKIP} [fdo#109271] -> PASS +4

  * igt@kms_cursor_legacy@pipe-c-torture-move:
    - shard-hsw:          DMESG-WARN [fdo#107122] -> PASS

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          FAIL [fdo#105363] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          FAIL [fdo#103167] -> PASS +1

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
    - shard-glk:          FAIL [fdo#103167] -> PASS

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-apl:          FAIL [fdo#108948] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-apl:          FAIL [fdo#103166] -> PASS +2

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
    - shard-glk:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-apl:          DMESG-FAIL [fdo#108950] -> PASS

  * igt@kms_setmode@basic:
    - shard-glk:          FAIL [fdo#99912] -> PASS

  * igt@prime_vgem@basic-fence-flip:
    - shard-kbl:          FAIL [fdo#104008] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * Linux: CI_DRM_5464 -> Patchwork_12005

  CI_DRM_5464: af90b519a670a3aec89045d9fcca8f2d174adeda @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12005: d2fc4d12140ad34b584bb8c0ca2074af9a821794 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12005/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-22 19:09     ` Ville Syrjälä
@ 2019-01-23  7:21       ` Kahola, Mika
  2019-01-23 18:32         ` Ville Syrjälä
  0 siblings, 1 reply; 10+ messages in thread
From: Kahola, Mika @ 2019-01-23  7:21 UTC (permalink / raw)
  To: ville.syrjala, jani.nikula; +Cc: intel-gfx

On Tue, 2019-01-22 at 21:09 +0200, Ville Syrjälä wrote:
> On Tue, Jan 22, 2019 at 08:09:40PM +0200, Jani Nikula wrote:
> > On Tue, 22 Jan 2019, Ville Syrjälä <ville.syrjala@linux.intel.com>
> > wrote:
> > > On Tue, Jan 22, 2019 at 02:58:24PM +0200, Mika Kahola wrote:
> > > > Avoid divide by zero warning on static analysis.
> > > > 
> > > > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > > > ---
> > > >  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
> > > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c
> > > > b/drivers/gpu/drm/i915/intel_pm.c
> > > > index 8b63afa3a221..6a8e8b3f44c2 100644
> > > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > > @@ -3912,8 +3912,10 @@
> > > > skl_ddb_get_pipe_allocation_limits(struct drm_i915_private
> > > > *dev_priv,
> > > >  			pipe_width = hdisplay;
> > > >  	}
> > > >  
> > > > -	alloc->start = ddb_size * width_before_pipe /
> > > > total_width;
> > > > -	alloc->end = ddb_size * (width_before_pipe +
> > > > pipe_width) / total_width;
> > > > +	alloc->start = total_width == 0 ?
> > > > +		0 : ddb_size * width_before_pipe / total_width;
> > > > +	alloc->end = total_width == 0 ?
> > > > +		0 : ddb_size * (width_before_pipe + pipe_width)
> > > > / total_width;
> > > 
> > > Can't happen.
I'd say it's very unlikely to happen but in theory possible. If we
don't have any crtc_state enabled we end up having total_width = 0. In
this case it probably won't matter what numbers we end up with alloc-
>start and alloc->end.

Anyway, this was something that caught my eye while looking into crc
mismatch errors and static checker results.

Like Jani said, warn is sufficient with this case.

Cheers,
Mika

> > 
> > Yeah, it's about stfu the checker...
> 
> Feels like the tip of an iceberg. How many more uglies are we going
> to
> have to add?
> 
> > 
> > > 
> > > >  }
> > > >  
> > > >  static unsigned int skl_cursor_allocation(int num_active)
> > > > -- 
> > > > 2.17.1
> > > > 
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > -- 
> > Jani Nikula, Intel Open Source Graphics Center
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915: Avoid divide by zero
  2019-01-23  7:21       ` Kahola, Mika
@ 2019-01-23 18:32         ` Ville Syrjälä
  0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2019-01-23 18:32 UTC (permalink / raw)
  To: Kahola, Mika; +Cc: intel-gfx

On Wed, Jan 23, 2019 at 07:21:57AM +0000, Kahola, Mika wrote:
> On Tue, 2019-01-22 at 21:09 +0200, Ville Syrjälä wrote:
> > On Tue, Jan 22, 2019 at 08:09:40PM +0200, Jani Nikula wrote:
> > > On Tue, 22 Jan 2019, Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > wrote:
> > > > On Tue, Jan 22, 2019 at 02:58:24PM +0200, Mika Kahola wrote:
> > > > > Avoid divide by zero warning on static analysis.
> > > > > 
> > > > > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > > > > ---
> > > > >  drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
> > > > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c
> > > > > b/drivers/gpu/drm/i915/intel_pm.c
> > > > > index 8b63afa3a221..6a8e8b3f44c2 100644
> > > > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > > > @@ -3912,8 +3912,10 @@
> > > > > skl_ddb_get_pipe_allocation_limits(struct drm_i915_private
> > > > > *dev_priv,
> > > > >  			pipe_width = hdisplay;
> > > > >  	}
> > > > >  
> > > > > -	alloc->start = ddb_size * width_before_pipe /
> > > > > total_width;
> > > > > -	alloc->end = ddb_size * (width_before_pipe +
> > > > > pipe_width) / total_width;
> > > > > +	alloc->start = total_width == 0 ?
> > > > > +		0 : ddb_size * width_before_pipe / total_width;
> > > > > +	alloc->end = total_width == 0 ?
> > > > > +		0 : ddb_size * (width_before_pipe + pipe_width)
> > > > > / total_width;
> > > > 
> > > > Can't happen.
> I'd say it's very unlikely to happen but in theory possible. If we
> don't have any crtc_state enabled we end up having total_width = 0. In
> this case it probably won't matter what numbers we end up with alloc-
> >start and alloc->end.

The caller bails out early in that case:

if (!cstate->base.active) {
	alloc->start = alloc->end = 0;
	return 0;
}

> 
> Anyway, this was something that caught my eye while looking into crc
> mismatch errors and static checker results.
> 
> Like Jani said, warn is sufficient with this case.
> 
> Cheers,
> Mika
> 
> > > 
> > > Yeah, it's about stfu the checker...
> > 
> > Feels like the tip of an iceberg. How many more uglies are we going
> > to
> > have to add?
> > 
> > > 
> > > > 
> > > > >  }
> > > > >  
> > > > >  static unsigned int skl_cursor_allocation(int num_active)
> > > > > -- 
> > > > > 2.17.1
> > > > > 
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > 
> > > -- 
> > > Jani Nikula, Intel Open Source Graphics Center
> > 
> > 

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-01-23 18:32 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 12:58 [PATCH] drm/i915: Avoid divide by zero Mika Kahola
2019-01-22 13:07 ` Jani Nikula
2019-01-22 13:22   ` Kahola, Mika
2019-01-22 16:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-22 16:23 ` [PATCH] " Ville Syrjälä
2019-01-22 18:09   ` Jani Nikula
2019-01-22 19:09     ` Ville Syrjälä
2019-01-23  7:21       ` Kahola, Mika
2019-01-23 18:32         ` Ville Syrjälä
2019-01-22 19:36 ` ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.