All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
@ 2019-01-22 16:29 Stefan Hajnoczi
  2019-01-23  6:19 ` Thomas Huth
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-01-22 16:29 UTC (permalink / raw)
  To: qemu-devel; +Cc: Peter Maydell, contrib, jusual, joel, jim, Stefan Hajnoczi

New source files were added without corresponding ./MAINTAINERS file
entries.  Let's get things up to date.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
This also includes the I2C/TWI stub which Peter has merged into his
target-arm.next tree but isn't in qemu.git/master yet.
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index af339b86db..e3cb67e81d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/arm/nrf51_soc.c
 F: hw/arm/microbit.c
+F: hw/char/nrf51_uart.c
+F: hw/gpio/nrf51_gpio.c
+F: hw/i2c/microbit_i2c.c
+F: hw/misc/nrf51_rng.c
+F: hw/timer/nrf51_timer.c
 F: include/hw/arm/nrf51_soc.h
+F: include/hw/arm/nrf51.h
+F: include/hw/char/nrf51_uart.h
+F: include/hw/gpio/nrf51_gpio.h
+F: include/hw/i2c/microbit_i2c.h
+F: include/hw/misc/nrf51_rng.h
+F: include/hw/timer/nrf51_timer.h
+F: tests/microbit-test.c
 
 CRIS Machines
 -------------
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
  2019-01-22 16:29 [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files Stefan Hajnoczi
@ 2019-01-23  6:19 ` Thomas Huth
  2019-01-23 18:23   ` Philippe Mathieu-Daudé
  2019-01-23 18:33   ` Stefan Hajnoczi
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2019-01-23  6:19 UTC (permalink / raw)
  To: Stefan Hajnoczi, qemu-devel; +Cc: Peter Maydell, jim, contrib, joel, jusual

On 2019-01-22 17:29, Stefan Hajnoczi wrote:
> New source files were added without corresponding ./MAINTAINERS file
> entries.  Let's get things up to date.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> This also includes the I2C/TWI stub which Peter has merged into his
> target-arm.next tree but isn't in qemu.git/master yet.
> ---
>  MAINTAINERS | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index af339b86db..e3cb67e81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
>  S: Maintained
>  F: hw/arm/nrf51_soc.c
>  F: hw/arm/microbit.c
> +F: hw/char/nrf51_uart.c
> +F: hw/gpio/nrf51_gpio.c
> +F: hw/i2c/microbit_i2c.c
> +F: hw/misc/nrf51_rng.c
> +F: hw/timer/nrf51_timer.c
>  F: include/hw/arm/nrf51_soc.h
> +F: include/hw/arm/nrf51.h
> +F: include/hw/char/nrf51_uart.h
> +F: include/hw/gpio/nrf51_gpio.h
> +F: include/hw/i2c/microbit_i2c.h
> +F: include/hw/misc/nrf51_rng.h
> +F: include/hw/timer/nrf51_timer.h
> +F: tests/microbit-test.c

Looks like using wildcards would be easier here:

F: hw/*/nrf51*.c
F: hw/*/microbit*.c
F: include/hw/*/nrf51*.h
...

?

Anyway:

Reviewed-by: Thomas Huth <thuth@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
  2019-01-23  6:19 ` Thomas Huth
@ 2019-01-23 18:23   ` Philippe Mathieu-Daudé
  2019-01-23 18:33   ` Stefan Hajnoczi
  1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-23 18:23 UTC (permalink / raw)
  To: Thomas Huth, Stefan Hajnoczi, qemu-devel
  Cc: Peter Maydell, jim, jusual, contrib, joel

On 1/23/19 7:19 AM, Thomas Huth wrote:
> On 2019-01-22 17:29, Stefan Hajnoczi wrote:
>> New source files were added without corresponding ./MAINTAINERS file
>> entries.  Let's get things up to date.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> This also includes the I2C/TWI stub which Peter has merged into his
>> target-arm.next tree but isn't in qemu.git/master yet.
>> ---
>>  MAINTAINERS | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index af339b86db..e3cb67e81d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
>>  S: Maintained
>>  F: hw/arm/nrf51_soc.c
>>  F: hw/arm/microbit.c
>> +F: hw/char/nrf51_uart.c
>> +F: hw/gpio/nrf51_gpio.c
>> +F: hw/i2c/microbit_i2c.c
>> +F: hw/misc/nrf51_rng.c
>> +F: hw/timer/nrf51_timer.c
>>  F: include/hw/arm/nrf51_soc.h
>> +F: include/hw/arm/nrf51.h
>> +F: include/hw/char/nrf51_uart.h
>> +F: include/hw/gpio/nrf51_gpio.h
>> +F: include/hw/i2c/microbit_i2c.h
>> +F: include/hw/misc/nrf51_rng.h
>> +F: include/hw/timer/nrf51_timer.h
>> +F: tests/microbit-test.c
> 
> Looks like using wildcards would be easier here:
> 
> F: hw/*/nrf51*.c
> F: hw/*/microbit*.c
> F: include/hw/*/nrf51*.h

Agreed :)

> ...
> 
> ?
> 
> Anyway:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
  2019-01-23  6:19 ` Thomas Huth
  2019-01-23 18:23   ` Philippe Mathieu-Daudé
@ 2019-01-23 18:33   ` Stefan Hajnoczi
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-01-23 18:33 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-devel, Peter Maydell, jim, contrib, joel, jusual

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

On Wed, Jan 23, 2019 at 07:19:57AM +0100, Thomas Huth wrote:
> On 2019-01-22 17:29, Stefan Hajnoczi wrote:
> > New source files were added without corresponding ./MAINTAINERS file
> > entries.  Let's get things up to date.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > This also includes the I2C/TWI stub which Peter has merged into his
> > target-arm.next tree but isn't in qemu.git/master yet.
> > ---
> >  MAINTAINERS | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index af339b86db..e3cb67e81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
> >  S: Maintained
> >  F: hw/arm/nrf51_soc.c
> >  F: hw/arm/microbit.c
> > +F: hw/char/nrf51_uart.c
> > +F: hw/gpio/nrf51_gpio.c
> > +F: hw/i2c/microbit_i2c.c
> > +F: hw/misc/nrf51_rng.c
> > +F: hw/timer/nrf51_timer.c
> >  F: include/hw/arm/nrf51_soc.h
> > +F: include/hw/arm/nrf51.h
> > +F: include/hw/char/nrf51_uart.h
> > +F: include/hw/gpio/nrf51_gpio.h
> > +F: include/hw/i2c/microbit_i2c.h
> > +F: include/hw/misc/nrf51_rng.h
> > +F: include/hw/timer/nrf51_timer.h
> > +F: tests/microbit-test.c
> 
> Looks like using wildcards would be easier here:
> 
> F: hw/*/nrf51*.c
> F: hw/*/microbit*.c
> F: include/hw/*/nrf51*.h
> ...
> 
> ?

Will send v2.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-23 18:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 16:29 [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files Stefan Hajnoczi
2019-01-23  6:19 ` Thomas Huth
2019-01-23 18:23   ` Philippe Mathieu-Daudé
2019-01-23 18:33   ` Stefan Hajnoczi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.