All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	David Airlie <airlied@linux.ie>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support
Date: Tue, 22 Jan 2019 19:07:51 +0200	[thread overview]
Message-ID: <20190122170751.GB26166@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1548170749-12773-5-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

Thank you for the patch.

On Tue, Jan 22, 2019 at 03:25:48PM +0000, Biju Das wrote:
> Add du node to r8a7744 SoC DT. Boards that want to enable the DU
> need to specify the output topology.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I expect Simon to pick this up.

> ---
>  arch/arm/boot/dts/r8a7744.dtsi | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
> index 8d25a0a..83804aa 100644
> --- a/arch/arm/boot/dts/r8a7744.dtsi
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -1645,8 +1645,14 @@
>  		};
>  
>  		du: display@feb00000 {
> -			reg = <0 0xfeb00000 0 0x40000>,
> -			      <0 0xfeb90000 0 0x1c>;
> +			compatible = "renesas,du-r8a7744";
> +			reg = <0 0xfeb00000 0 0x40000>;
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>,
> +				 <&cpg CPG_MOD 723>;
> +			clock-names = "du.0", "du.1";
> +			status = "disabled";
>  
>  			ports {
>  				#address-cells = <1>;
> @@ -1663,7 +1669,6 @@
>  					};
>  				};
>  			};
> -			/* placeholder */
>  		};
>  
>  		prr: chipid@ff000044 {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support
Date: Tue, 22 Jan 2019 19:07:51 +0200	[thread overview]
Message-ID: <20190122170751.GB26166@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1548170749-12773-5-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

Thank you for the patch.

On Tue, Jan 22, 2019 at 03:25:48PM +0000, Biju Das wrote:
> Add du node to r8a7744 SoC DT. Boards that want to enable the DU
> need to specify the output topology.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I expect Simon to pick this up.

> ---
>  arch/arm/boot/dts/r8a7744.dtsi | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
> index 8d25a0a..83804aa 100644
> --- a/arch/arm/boot/dts/r8a7744.dtsi
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -1645,8 +1645,14 @@
>  		};
>  
>  		du: display@feb00000 {
> -			reg = <0 0xfeb00000 0 0x40000>,
> -			      <0 0xfeb90000 0 0x1c>;
> +			compatible = "renesas,du-r8a7744";
> +			reg = <0 0xfeb00000 0 0x40000>;
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>,
> +				 <&cpg CPG_MOD 723>;
> +			clock-names = "du.0", "du.1";
> +			status = "disabled";
>  
>  			ports {
>  				#address-cells = <1>;
> @@ -1663,7 +1669,6 @@
>  					};
>  				};
>  			};
> -			/* placeholder */
>  		};
>  
>  		prr: chipid@ff000044 {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2019-01-22 17:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
2019-01-22 15:25 ` Biju Das
2019-01-22 15:25 ` [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings Biju Das
2019-01-22 17:13   ` Laurent Pinchart
2019-01-23  9:01     ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
2019-01-22 15:25   ` Biju Das
2019-01-22 15:44   ` Laurent Pinchart
2019-01-22 15:44     ` Laurent Pinchart
2019-01-23  8:59     ` Simon Horman
2019-01-23  8:59       ` Simon Horman
2019-01-30 16:39     ` Rob Herring
2019-01-30 16:39       ` Rob Herring
2019-02-01 15:16       ` Laurent Pinchart
2019-02-01 15:16         ` Laurent Pinchart
2019-01-30 16:39   ` Rob Herring
2019-01-30 16:39     ` Rob Herring
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
2019-01-22 15:25   ` Biju Das
2019-01-22 15:45   ` Laurent Pinchart
2019-01-22 15:45     ` Laurent Pinchart
2019-01-23  8:59   ` Simon Horman
2019-01-23  8:59     ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support Biju Das
2019-01-22 15:25   ` Biju Das
2019-01-22 17:07   ` Laurent Pinchart [this message]
2019-01-22 17:07     ` Laurent Pinchart
2019-01-23  9:02     ` Simon Horman
2019-01-23  9:02       ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support Biju Das
2019-01-22 17:14   ` Laurent Pinchart
2019-01-23  9:03     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122170751.GB26166@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.