From: Wolfram Sang <wsa@the-dreams.de>
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: linux-i2c@vger.kernel.org, linux-imx@nxp.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabio.estevam@nxp.com,
leoyang.li@nxp.com
Subject: Re: [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling
Date: Tue, 22 Jan 2019 23:51:55 +0100 [thread overview]
Message-ID: <20190122225155.vfy37bfuikzzymao@ninjato> (raw)
In-Reply-To: <20190116112855.13824-1-laurentiu.tudor@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote:
> Use the correct error pointer when extracting the error code.
>
> Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request")
This is not the sha1 in my tree. Maybe you rebased? I applied another
patch meanwhile fixing the same issue. Still thanks!
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 09b124547669..42fed40198a0 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
>
> dma->chan_tx = dma_request_chan(dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> - ret = PTR_ERR(dma->chan_rx);
> + ret = PTR_ERR(dma->chan_tx);
> if (ret != -ENODEV && ret != -EPROBE_DEFER)
> dev_err(dev, "can't request DMA tx channel (%d)\n", ret);
> goto fail_al;
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
leoyang.li@nxp.com, linux-i2c@vger.kernel.org,
kernel@pengutronix.de, fabio.estevam@nxp.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com
Subject: Re: [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling
Date: Tue, 22 Jan 2019 23:51:55 +0100 [thread overview]
Message-ID: <20190122225155.vfy37bfuikzzymao@ninjato> (raw)
In-Reply-To: <20190116112855.13824-1-laurentiu.tudor@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]
On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote:
> Use the correct error pointer when extracting the error code.
>
> Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request")
This is not the sha1 in my tree. Maybe you rebased? I applied another
patch meanwhile fixing the same issue. Still thanks!
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 09b124547669..42fed40198a0 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
>
> dma->chan_tx = dma_request_chan(dev, "tx");
> if (IS_ERR(dma->chan_tx)) {
> - ret = PTR_ERR(dma->chan_rx);
> + ret = PTR_ERR(dma->chan_tx);
> if (ret != -ENODEV && ret != -EPROBE_DEFER)
> dev_err(dev, "can't request DMA tx channel (%d)\n", ret);
> goto fail_al;
> --
> 2.17.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-22 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 11:28 [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling Laurentiu Tudor
2019-01-16 11:28 ` Laurentiu Tudor
2019-01-16 11:28 ` [PATCH v2 2/2] i2c: imx: defer probing on dma channel request Laurentiu Tudor
2019-01-16 11:28 ` Laurentiu Tudor
2019-01-16 16:47 ` [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling Uwe Kleine-König
2019-01-16 16:47 ` Uwe Kleine-König
2019-01-22 22:51 ` Wolfram Sang [this message]
2019-01-22 22:51 ` Wolfram Sang
2019-01-25 9:20 ` Laurentiu Tudor
2019-01-25 9:20 ` Laurentiu Tudor
2019-01-25 9:20 ` Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122225155.vfy37bfuikzzymao@ninjato \
--to=wsa@the-dreams.de \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.