* [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
@ 2019-01-23 6:59 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-23 6:59 UTC (permalink / raw)
To: robert.jarzmik, dwmw2, computersforpeace, bbrezillon,
marek.vasut, richard
Cc: linux-kernel, linux-mtd, YueHaibing
In case DOC_CHIPID_G3, mtd->name should be freed in the
err handling path, which is alloced by kasprintf.
Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mtd/devices/docg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 60ddc38..cbd25f9 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
nomem4:
kfree(docg3->bbt);
+ kfree(mtd->name);
nomem3:
kfree(mtd);
nomem2:
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
@ 2019-01-23 6:59 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-23 6:59 UTC (permalink / raw)
To: robert.jarzmik, dwmw2, computersforpeace, bbrezillon,
marek.vasut, richard
Cc: YueHaibing, linux-mtd, linux-kernel
In case DOC_CHIPID_G3, mtd->name should be freed in the
err handling path, which is alloced by kasprintf.
Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mtd/devices/docg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 60ddc38..cbd25f9 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
nomem4:
kfree(docg3->bbt);
+ kfree(mtd->name);
nomem3:
kfree(mtd);
nomem2:
--
2.7.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
2019-01-23 6:59 ` YueHaibing
@ 2019-01-23 8:46 ` Boris Brezillon
-1 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2019-01-23 8:46 UTC (permalink / raw)
To: YueHaibing
Cc: robert.jarzmik, dwmw2, computersforpeace, marek.vasut, richard,
linux-kernel, linux-mtd
On Wed, 23 Jan 2019 14:59:43 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> In case DOC_CHIPID_G3, mtd->name should be freed in the
> err handling path, which is alloced by kasprintf.
>
> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mtd/devices/docg3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 60ddc38..cbd25f9 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
>
> nomem4:
> kfree(docg3->bbt);
> + kfree(mtd->name);
Please use devm_kasprintf() instead.
> nomem3:
> kfree(mtd);
> nomem2:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
@ 2019-01-23 8:46 ` Boris Brezillon
0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2019-01-23 8:46 UTC (permalink / raw)
To: YueHaibing
Cc: robert.jarzmik, linux-kernel, marek.vasut, linux-mtd, richard,
computersforpeace, dwmw2
On Wed, 23 Jan 2019 14:59:43 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> In case DOC_CHIPID_G3, mtd->name should be freed in the
> err handling path, which is alloced by kasprintf.
>
> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mtd/devices/docg3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 60ddc38..cbd25f9 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
>
> nomem4:
> kfree(docg3->bbt);
> + kfree(mtd->name);
Please use devm_kasprintf() instead.
> nomem3:
> kfree(mtd);
> nomem2:
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
2019-01-23 8:46 ` Boris Brezillon
@ 2019-01-23 8:54 ` YueHaibing
-1 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-23 8:54 UTC (permalink / raw)
To: Boris Brezillon
Cc: robert.jarzmik, dwmw2, computersforpeace, marek.vasut, richard,
linux-kernel, linux-mtd
On 2019/1/23 16:46, Boris Brezillon wrote:
> On Wed, 23 Jan 2019 14:59:43 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> In case DOC_CHIPID_G3, mtd->name should be freed in the
>> err handling path, which is alloced by kasprintf.
>>
>> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/mtd/devices/docg3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 60ddc38..cbd25f9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
>>
>> nomem4:
>> kfree(docg3->bbt);
>> + kfree(mtd->name);
>
> Please use devm_kasprintf() instead.
Ok, will do it in v2.
>
>> nomem3:
>> kfree(mtd);
>> nomem2:
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
@ 2019-01-23 8:54 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-23 8:54 UTC (permalink / raw)
To: Boris Brezillon
Cc: robert.jarzmik, linux-kernel, marek.vasut, linux-mtd, richard,
computersforpeace, dwmw2
On 2019/1/23 16:46, Boris Brezillon wrote:
> On Wed, 23 Jan 2019 14:59:43 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> In case DOC_CHIPID_G3, mtd->name should be freed in the
>> err handling path, which is alloced by kasprintf.
>>
>> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/mtd/devices/docg3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 60ddc38..cbd25f9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
>>
>> nomem4:
>> kfree(docg3->bbt);
>> + kfree(mtd->name);
>
> Please use devm_kasprintf() instead.
Ok, will do it in v2.
>
>> nomem3:
>> kfree(mtd);
>> nomem2:
>
>
> .
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-23 8:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 6:59 [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name YueHaibing
2019-01-23 6:59 ` YueHaibing
2019-01-23 8:46 ` Boris Brezillon
2019-01-23 8:46 ` Boris Brezillon
2019-01-23 8:54 ` YueHaibing
2019-01-23 8:54 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.