From: Kees Cook <keescook@chromium.org> To: linux-kernel@vger.kernel.org Cc: Kees Cook <keescook@chromium.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laura Abbott <labbott@redhat.com>, Alexander Popov <alex.popov@linux.com>, xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dev@openvswitch.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: [PATCH 0/3] gcc-plugins: Introduce stackinit plugin Date: Wed, 23 Jan 2019 03:03:46 -0800 [thread overview] Message-ID: <20190123110349.35882-1-keescook@chromium.org> (raw) This adds a new plugin "stackinit" that attempts to perform unconditional initialization of all stack variables[1]. It has wider effects than GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=y since BYREF_ALL does not consider non-structures. A notable weakness is that padding bytes in many cases remain uninitialized since GCC treats these bytes as "undefined". I'm hoping we can improve the compiler (or the plugin) to cover that too. (It's worth noting that BYREF_ALL actually does handle the padding -- I think this is due to the different method of detecting if initialization is needed.) Included is a tree-wide change to move switch variables up and out of their switch and into the top-level variable declarations. Included is a set of test cases for evaluating stack initialization, which checks for padding, different types, etc. Feedback welcome! :) -Kees [1] https://lkml.kernel.org/r/CA+55aFykZL+cSBJjBBts7ebEFfyGPdMzTmLSxKnT_29=j942dA@mail.gmail.com Kees Cook (3): treewide: Lift switch variables out of switches gcc-plugins: Introduce stackinit plugin lib: Introduce test_stackinit module arch/x86/xen/enlighten_pv.c | 7 +- drivers/char/pcmcia/cm4000_cs.c | 2 +- drivers/char/ppdev.c | 20 +- drivers/gpu/drm/drm_edid.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 +- drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +- drivers/tty/n_tty.c | 3 +- drivers/usb/gadget/udc/net2280.c | 5 +- fs/fcntl.c | 3 +- lib/Kconfig.debug | 9 + lib/Makefile | 1 + lib/test_stackinit.c | 327 ++++++++++++++++++ mm/shmem.c | 5 +- net/core/skbuff.c | 4 +- net/ipv6/ip6_gre.c | 4 +- net/ipv6/ip6_tunnel.c | 4 +- net/openvswitch/flow_netlink.c | 7 +- scripts/Makefile.gcc-plugins | 6 + scripts/gcc-plugins/Kconfig | 9 + scripts/gcc-plugins/gcc-common.h | 11 +- scripts/gcc-plugins/stackinit_plugin.c | 79 +++++ security/tomoyo/common.c | 3 +- security/tomoyo/condition.c | 7 +- security/tomoyo/util.c | 4 +- 25 files changed, 484 insertions(+), 49 deletions(-) create mode 100644 lib/test_stackinit.c create mode 100644 scripts/gcc-plugins/stackinit_plugin.c -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH 0/3] gcc-plugins: Introduce stackinit plugin Date: Wed, 23 Jan 2019 03:03:46 -0800 [thread overview] Message-ID: <20190123110349.35882-1-keescook@chromium.org> (raw) This adds a new plugin "stackinit" that attempts to perform unconditional initialization of all stack variables[1]. It has wider effects than GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=y since BYREF_ALL does not consider non-structures. A notable weakness is that padding bytes in many cases remain uninitialized since GCC treats these bytes as "undefined". I'm hoping we can improve the compiler (or the plugin) to cover that too. (It's worth noting that BYREF_ALL actually does handle the padding -- I think this is due to the different method of detecting if initialization is needed.) Included is a tree-wide change to move switch variables up and out of their switch and into the top-level variable declarations. Included is a set of test cases for evaluating stack initialization, which checks for padding, different types, etc. Feedback welcome! :) -Kees [1] https://lkml.kernel.org/r/CA+55aFykZL+cSBJjBBts7ebEFfyGPdMzTmLSxKnT_29=j942dA at mail.gmail.com Kees Cook (3): treewide: Lift switch variables out of switches gcc-plugins: Introduce stackinit plugin lib: Introduce test_stackinit module arch/x86/xen/enlighten_pv.c | 7 +- drivers/char/pcmcia/cm4000_cs.c | 2 +- drivers/char/ppdev.c | 20 +- drivers/gpu/drm/drm_edid.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 +- drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +- drivers/tty/n_tty.c | 3 +- drivers/usb/gadget/udc/net2280.c | 5 +- fs/fcntl.c | 3 +- lib/Kconfig.debug | 9 + lib/Makefile | 1 + lib/test_stackinit.c | 327 ++++++++++++++++++ mm/shmem.c | 5 +- net/core/skbuff.c | 4 +- net/ipv6/ip6_gre.c | 4 +- net/ipv6/ip6_tunnel.c | 4 +- net/openvswitch/flow_netlink.c | 7 +- scripts/Makefile.gcc-plugins | 6 + scripts/gcc-plugins/Kconfig | 9 + scripts/gcc-plugins/gcc-common.h | 11 +- scripts/gcc-plugins/stackinit_plugin.c | 79 +++++ security/tomoyo/common.c | 3 +- security/tomoyo/condition.c | 7 +- security/tomoyo/util.c | 4 +- 25 files changed, 484 insertions(+), 49 deletions(-) create mode 100644 lib/test_stackinit.c create mode 100644 scripts/gcc-plugins/stackinit_plugin.c -- 2.17.1
next reply other threads:[~2019-01-23 11:04 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-23 11:03 Kees Cook [this message] 2019-01-23 11:03 ` [Intel-wired-lan] [PATCH 0/3] gcc-plugins: Introduce stackinit plugin Kees Cook 2019-01-23 11:03 ` [PATCH 1/3] treewide: Lift switch variables out of switches Kees Cook 2019-01-23 11:03 ` Kees Cook 2019-01-23 11:03 ` [Intel-wired-lan] " Kees Cook 2019-01-23 11:03 ` Kees Cook 2019-01-23 11:03 ` [1/3] " Kees Cook 2019-01-23 11:58 ` [PATCH 1/3] " Greg KH 2019-01-23 11:58 ` Greg KH 2019-01-23 11:58 ` [Intel-wired-lan] " Greg KH 2019-01-23 11:58 ` [1/3] " Greg Kroah-Hartman 2019-01-23 12:09 ` [PATCH 1/3] " Jann Horn 2019-01-23 12:09 ` Jann Horn 2019-01-23 12:09 ` [Intel-wired-lan] " Jann Horn 2019-01-23 12:09 ` Jann Horn 2019-01-23 12:09 ` [1/3] " Jann Horn 2019-01-23 12:12 ` [PATCH 1/3] " Ard Biesheuvel 2019-01-23 12:12 ` Ard Biesheuvel 2019-01-23 12:12 ` [Intel-wired-lan] " Ard Biesheuvel 2019-01-23 12:12 ` Ard Biesheuvel 2019-01-23 12:12 ` [1/3] " Ard Biesheuvel 2019-01-23 13:21 ` [PATCH 1/3] " William Kucharski 2019-01-23 13:21 ` William Kucharski 2019-01-23 13:21 ` [Intel-wired-lan] " William Kucharski 2019-01-23 13:21 ` [1/3] " William Kucharski 2019-01-23 14:17 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula 2019-01-23 14:17 ` [Intel-wired-lan] " Jani Nikula 2019-01-23 14:17 ` Jani Nikula 2019-01-23 14:17 ` [1/3] " Jani Nikula 2019-01-23 14:23 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula 2019-01-23 14:23 ` Jani Nikula 2019-01-23 14:23 ` [Intel-wired-lan] " Jani Nikula 2019-01-23 14:23 ` [1/3] " Jani Nikula 2019-01-23 14:47 ` [Intel-gfx] [PATCH 1/3] " Edwin Zimmerman 2019-01-23 14:47 ` [Intel-wired-lan] " Edwin Zimmerman 2019-01-23 14:47 ` Edwin Zimmerman 2019-01-23 14:47 ` [1/3] " Edwin Zimmerman 2019-01-23 14:47 ` [Intel-gfx] [PATCH 1/3] " Edwin Zimmerman 2019-01-23 15:46 ` Jani Nikula 2019-01-23 15:46 ` Jani Nikula 2019-01-23 15:46 ` [Intel-wired-lan] " Jani Nikula 2019-01-23 15:46 ` Jani Nikula 2019-01-23 15:46 ` [1/3] " Jani Nikula 2019-01-23 18:55 ` [Intel-gfx] [PATCH 1/3] " Kees Cook 2019-01-23 18:55 ` [Intel-wired-lan] " Kees Cook 2019-01-23 18:55 ` Kees Cook 2019-01-23 18:55 ` [1/3] " Kees Cook 2019-01-23 18:55 ` [Intel-gfx] [PATCH 1/3] " Kees Cook 2019-01-24 8:10 ` Greg KH 2019-01-24 8:10 ` Greg KH 2019-01-24 8:10 ` [Intel-wired-lan] " Greg KH 2019-01-24 8:10 ` [1/3] " Greg Kroah-Hartman 2019-01-24 8:10 ` [Intel-gfx] [PATCH 1/3] " Greg KH 2019-01-23 18:55 ` Kees Cook 2019-01-23 19:18 ` Matthew Wilcox 2019-01-23 19:18 ` [Intel-wired-lan] " Matthew Wilcox 2019-01-23 19:18 ` [1/3] " Matthew Wilcox 2019-01-23 20:36 ` [Intel-gfx] [PATCH 1/3] " Kees Cook 2019-01-23 20:36 ` Kees Cook 2019-01-23 20:36 ` [Intel-wired-lan] " Kees Cook 2019-01-23 20:36 ` Kees Cook 2019-01-23 20:36 ` [1/3] " Kees Cook 2019-01-23 20:36 ` [Intel-gfx] [PATCH 1/3] " Kees Cook 2019-01-23 19:18 ` Matthew Wilcox 2019-01-23 14:17 ` Jani Nikula 2019-01-23 16:51 ` [Intel-wired-lan] " Jeff Kirsher 2019-01-23 16:51 ` Jeff Kirsher 2019-01-23 16:51 ` Jeff Kirsher 2019-01-23 16:51 ` [1/3] " Jeff Kirsher 2019-01-23 16:51 ` [Intel-wired-lan] [PATCH 1/3] " Jeff Kirsher 2019-01-24 12:58 ` Edwin Zimmerman 2019-01-24 12:58 ` [Intel-wired-lan] " Edwin Zimmerman 2019-01-24 12:58 ` [1/3] " Edwin Zimmerman 2019-01-24 12:58 ` [PATCH 1/3] " Edwin Zimmerman 2019-01-24 12:58 ` Edwin Zimmerman 2019-01-23 11:03 ` [PATCH 2/3] gcc-plugins: Introduce stackinit plugin Kees Cook 2019-01-23 11:03 ` [Intel-wired-lan] " Kees Cook 2019-01-23 11:03 ` Kees Cook 2019-01-23 11:03 ` [2/3] " Kees Cook 2019-01-23 11:03 ` [PATCH 2/3] " Kees Cook 2019-01-23 11:03 ` [PATCH 3/3] lib: Introduce test_stackinit module Kees Cook 2019-01-23 11:03 ` [Intel-wired-lan] " Kees Cook 2019-01-23 11:03 ` Kees Cook 2019-01-23 11:03 ` [3/3] " Kees Cook 2019-01-23 11:03 ` [PATCH 3/3] " Kees Cook 2019-01-23 11:20 ` ✗ Fi.CI.BAT: failure for gcc-plugins: Introduce stackinit plugin Patchwork 2019-01-23 14:26 ` Jani Nikula 2019-01-29 0:12 ` [PATCH 0/3] " Alexander Popov 2019-01-29 0:12 ` Alexander Popov 2019-01-29 0:12 ` [Intel-wired-lan] " Alexander Popov 2019-02-12 17:54 ` Kees Cook 2019-02-12 17:54 ` Kees Cook 2019-02-12 17:54 ` [Intel-wired-lan] " Kees Cook 2019-02-12 17:54 ` Kees Cook 2019-02-12 17:54 ` Kees Cook 2019-02-12 17:54 ` Kees Cook -- strict thread matches above, loose matches on Subject: below -- 2019-01-23 11:03 Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190123110349.35882-1-keescook@chromium.org \ --to=keescook@chromium.org \ --cc=alex.popov@linux.com \ --cc=ard.biesheuvel@linaro.org \ --cc=dev@openvswitch.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=labbott@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.