All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <christian@brauner.io>
To: shuah <shuah@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	tkjos@android.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	arve@android.com, maco@android.com, joel@joelfernandes.org,
	tkjos@google.com
Subject: Re: [PATCH v3] selftests: add binderfs selftests
Date: Wed, 23 Jan 2019 15:27:04 +0100	[thread overview]
Message-ID: <20190123142703.ta7j3jnyaqc7ahgn@brauner.io> (raw)
In-Reply-To: <d1893da7-1222-d303-04c7-fb0500b55088@kernel.org>

On Wed, Jan 23, 2019 at 07:15:01AM -0700, shuah wrote:
> On 1/23/19 4:00 AM, Greg KH wrote:
> > On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote:
> > > On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote:
> > > > This adds the promised selftest for binderfs. It will verify the following
> > > > things:
> > > > - binderfs mounting works
> > > > - binder device allocation works
> > > > - performing a binder ioctl() request through a binderfs device works
> > > > - binder device removal works
> > > > - binder-control removal fails
> > > > - binderfs unmounting works
> > > > 
> > > > The tests are performed both privileged and unprivileged. The latter
> > > > verifies that binderfs behaves correctly in user namespaces.
> > > > 
> > > > Cc: Todd Kjos <tkjos@google.com>
> > > > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> > > 
> > > Hey Shuah,
> > > 
> > > If you're ok with the patch in its current form, can you please make
> > > sure that this still lands in 5.0? If at all possible I'd like to have
> > > all ducks in a row and release binderfs with selftests and everything.
> > > :)
> > 
> 
> The patch is good and I was planning to get this into 5.1.
> 
> > I can take it in my tree with the other binderfs patches if I can get an
> > ack from Shuah.
> > 
> 
> Great. It is good for the test patch to go with the other binderfs
> patches.
> 
> Acked-by: Shuah Khan <shuah@kernel.org>

Thanks for the quick response!
Christian

WARNING: multiple messages have this Message-ID (diff)
From: christian at brauner.io (Christian Brauner)
Subject: [PATCH v3] selftests: add binderfs selftests
Date: Wed, 23 Jan 2019 15:27:04 +0100	[thread overview]
Message-ID: <20190123142703.ta7j3jnyaqc7ahgn@brauner.io> (raw)
In-Reply-To: <d1893da7-1222-d303-04c7-fb0500b55088@kernel.org>

On Wed, Jan 23, 2019 at 07:15:01AM -0700, shuah wrote:
> On 1/23/19 4:00 AM, Greg KH wrote:
> > On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote:
> > > On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote:
> > > > This adds the promised selftest for binderfs. It will verify the following
> > > > things:
> > > > - binderfs mounting works
> > > > - binder device allocation works
> > > > - performing a binder ioctl() request through a binderfs device works
> > > > - binder device removal works
> > > > - binder-control removal fails
> > > > - binderfs unmounting works
> > > > 
> > > > The tests are performed both privileged and unprivileged. The latter
> > > > verifies that binderfs behaves correctly in user namespaces.
> > > > 
> > > > Cc: Todd Kjos <tkjos at google.com>
> > > > Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
> > > 
> > > Hey Shuah,
> > > 
> > > If you're ok with the patch in its current form, can you please make
> > > sure that this still lands in 5.0? If at all possible I'd like to have
> > > all ducks in a row and release binderfs with selftests and everything.
> > > :)
> > 
> 
> The patch is good and I was planning to get this into 5.1.
> 
> > I can take it in my tree with the other binderfs patches if I can get an
> > ack from Shuah.
> > 
> 
> Great. It is good for the test patch to go with the other binderfs
> patches.
> 
> Acked-by: Shuah Khan <shuah at kernel.org>

Thanks for the quick response!
Christian

WARNING: multiple messages have this Message-ID (diff)
From: christian@brauner.io (Christian Brauner)
Subject: [PATCH v3] selftests: add binderfs selftests
Date: Wed, 23 Jan 2019 15:27:04 +0100	[thread overview]
Message-ID: <20190123142703.ta7j3jnyaqc7ahgn@brauner.io> (raw)
Message-ID: <20190123142704.k7AINV6TN7A52MkTZvzU9JtnbHKIMVhLYKvTUykvkwY@z> (raw)
In-Reply-To: <d1893da7-1222-d303-04c7-fb0500b55088@kernel.org>

On Wed, Jan 23, 2019@07:15:01AM -0700, shuah wrote:
> On 1/23/19 4:00 AM, Greg KH wrote:
> > On Wed, Jan 23, 2019@11:54:58AM +0100, Christian Brauner wrote:
> > > On Thu, Jan 17, 2019@12:48:54PM +0100, Christian Brauner wrote:
> > > > This adds the promised selftest for binderfs. It will verify the following
> > > > things:
> > > > - binderfs mounting works
> > > > - binder device allocation works
> > > > - performing a binder ioctl() request through a binderfs device works
> > > > - binder device removal works
> > > > - binder-control removal fails
> > > > - binderfs unmounting works
> > > > 
> > > > The tests are performed both privileged and unprivileged. The latter
> > > > verifies that binderfs behaves correctly in user namespaces.
> > > > 
> > > > Cc: Todd Kjos <tkjos at google.com>
> > > > Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
> > > 
> > > Hey Shuah,
> > > 
> > > If you're ok with the patch in its current form, can you please make
> > > sure that this still lands in 5.0? If at all possible I'd like to have
> > > all ducks in a row and release binderfs with selftests and everything.
> > > :)
> > 
> 
> The patch is good and I was planning to get this into 5.1.
> 
> > I can take it in my tree with the other binderfs patches if I can get an
> > ack from Shuah.
> > 
> 
> Great. It is good for the test patch to go with the other binderfs
> patches.
> 
> Acked-by: Shuah Khan <shuah at kernel.org>

Thanks for the quick response!
Christian

  reply	other threads:[~2019-01-23 14:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 11:48 [PATCH v3] selftests: add binderfs selftests Christian Brauner
2019-01-17 11:48 ` Christian Brauner
2019-01-17 11:48 ` christian
2019-01-23 10:54 ` Christian Brauner
2019-01-23 10:54   ` Christian Brauner
2019-01-23 10:54   ` christian
2019-01-23 11:00   ` Greg KH
2019-01-23 11:00     ` Greg KH
2019-01-23 11:00     ` gregkh
2019-01-23 14:15     ` shuah
2019-01-23 14:15       ` shuah
2019-01-23 14:15       ` shuah
2019-01-23 14:27       ` Christian Brauner [this message]
2019-01-23 14:27         ` Christian Brauner
2019-01-23 14:27         ` christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123142703.ta7j3jnyaqc7ahgn@brauner.io \
    --to=christian@brauner.io \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maco@android.com \
    --cc=shuah@kernel.org \
    --cc=tkjos@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.