From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: acme@kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com,
tglx@linutronix.de, alexander.shishkin@linux.intel.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
will.deacon@arm.com, mark.rutland@arm.com, jolsa@redhat.com,
namhyung@kernel.org, adrian.hunter@intel.com, ast@kernel.org,
hpa@zytor.com, suzuki.poulose@arm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection
Date: Wed, 23 Jan 2019 22:03:33 +0100 [thread overview]
Message-ID: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190115230742.13730-4-mathieu.poirier@linaro.org>
On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote:
> + /* First get the selected sink from user space. */
> + sink = coresight_get_sink_by_id(event->attr.config2);
(I know there's a new version out, I'll go look there shortly)
should this patch not also have something like:
PMU_FORMAT_ATTR(sinkid, "config2:0-63");
> + if (!sink)
> + sink = coresight_get_enabled_sink(true);
> if (!sink || !sink_ops(sink)->alloc_buffer)
> goto err;
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org,
suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com,
gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com,
adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org,
mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com,
schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de,
jolsa@redhat.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection
Date: Wed, 23 Jan 2019 22:03:33 +0100 [thread overview]
Message-ID: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190115230742.13730-4-mathieu.poirier@linaro.org>
On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote:
> + /* First get the selected sink from user space. */
> + sink = coresight_get_sink_by_id(event->attr.config2);
(I know there's a new version out, I'll go look there shortly)
should this patch not also have something like:
PMU_FORMAT_ATTR(sinkid, "config2:0-63");
> + if (!sink)
> + sink = coresight_get_enabled_sink(true);
> if (!sink || !sink_ops(sink)->alloc_buffer)
> goto err;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-23 21:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 23:07 [PATCH 0/7] perf: Communicate sink via event::attr:config2 Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-15 23:07 ` [PATCH 1/7] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-16 10:21 ` Suzuki K Poulose
2019-01-16 10:21 ` Suzuki K Poulose
2019-01-15 23:07 ` [PATCH 2/7] coresight: perf: Add "sinks" group to PMU directory Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-16 10:29 ` Suzuki K Poulose
2019-01-16 10:29 ` Suzuki K Poulose
2019-01-16 23:43 ` Mathieu Poirier
2019-01-16 23:43 ` Mathieu Poirier
2019-01-17 11:55 ` Suzuki K Poulose
2019-01-17 11:55 ` Suzuki K Poulose
2019-01-16 15:39 ` Greg KH
2019-01-16 15:39 ` Greg KH
2019-01-16 16:14 ` Mathieu Poirier
2019-01-16 16:14 ` Mathieu Poirier
2019-01-16 16:33 ` Greg KH
2019-01-16 16:33 ` Greg KH
2019-01-16 16:38 ` Mathieu Poirier
2019-01-16 16:38 ` Mathieu Poirier
2019-01-16 17:12 ` Greg KH
2019-01-16 17:12 ` Greg KH
2019-01-16 17:30 ` Mathieu Poirier
2019-01-16 17:30 ` Mathieu Poirier
2019-01-15 23:07 ` [PATCH 3/7] coresight: Use event attributes for sink selection Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-16 10:36 ` Suzuki K Poulose
2019-01-16 10:36 ` Suzuki K Poulose
2019-01-16 23:57 ` Mathieu Poirier
2019-01-16 23:57 ` Mathieu Poirier
2019-01-17 17:33 ` Suzuki K Poulose
2019-01-17 17:33 ` Suzuki K Poulose
2019-01-23 21:03 ` Peter Zijlstra [this message]
2019-01-23 21:03 ` Peter Zijlstra
2019-01-23 21:05 ` Peter Zijlstra
2019-01-23 21:05 ` Peter Zijlstra
2019-01-15 23:07 ` [PATCH 4/7] perf pmu: Moving EVENT_SOURCE_DEVICE_PATH to PMU header file Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-16 10:37 ` Suzuki K Poulose
2019-01-16 10:37 ` Suzuki K Poulose
2019-01-15 23:07 ` [PATCH 5/7] perf tools: Use event attributes to send sink information to kernel Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-15 23:07 ` [PATCH 6/7] perf tools: Removing CoreSight set_drv_config() API Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
2019-01-15 23:07 ` [PATCH 7/7] perf tools: Remove PMU::set_drv_config API Mathieu Poirier
2019-01-15 23:07 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123210333.GZ27931@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.