From: jglisse@redhat.com To: linux-mm@kvack.org Cc: "Ralph Campbell" <rcampbell@nvidia.com>, "Jan Kara" <jack@suse.cz>, "Arnd Bergmann" <arnd@arndb.de>, kvm@vger.kernel.org, "Matthew Wilcox" <mawilcox@microsoft.com>, linux-rdma@vger.kernel.org, "John Hubbard" <jhubbard@nvidia.com>, "Felix Kuehling" <Felix.Kuehling@amd.com>, "Radim Krčmář" <rkrcmar@redhat.com>, "Dan Williams" <dan.j.williams@intel.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Michal Hocko" <mhocko@kernel.org>, "Jérôme Glisse" <jglisse@redhat.com>, "Jason Gunthorpe" <jgg@mellanox.com>, "Ross Zwisler" <zwisler@kernel.org>, linux-fsdevel@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Christian König" <christian.koenig@amd.com> Subject: [PATCH v4 7/9] gpu/drm/amdgpu: optimize out the case when a range is updated to read only Date: Wed, 23 Jan 2019 17:23:13 -0500 [thread overview] Message-ID: <20190123222315.1122-8-jglisse@redhat.com> (raw) In-Reply-To: <20190123222315.1122-1-jglisse@redhat.com> From: Jérôme Glisse <jglisse@redhat.com> When range of virtual address is updated read only and corresponding user ptr object are already read only it is pointless to do anything. Optimize this case out. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Cc: Christian König <christian.koenig@amd.com> Cc: Jan Kara <jack@suse.cz> Cc: Felix Kuehling <Felix.Kuehling@amd.com> Cc: Jason Gunthorpe <jgg@mellanox.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Matthew Wilcox <mawilcox@microsoft.com> Cc: Ross Zwisler <zwisler@kernel.org> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Radim Krčmář <rkrcmar@redhat.com> Cc: Michal Hocko <mhocko@kernel.org> Cc: Ralph Campbell <rcampbell@nvidia.com> Cc: John Hubbard <jhubbard@nvidia.com> Cc: kvm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-rdma@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c index 3e6823fdd939..7880eda064cd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -294,6 +294,7 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, { struct amdgpu_mn *amn = container_of(mn, struct amdgpu_mn, mn); struct interval_tree_node *it; + bool update_to_read_only; unsigned long end; /* notification is exclusive, but interval is inclusive */ @@ -302,6 +303,8 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, if (amdgpu_mn_read_lock(amn, range->blockable)) return -EAGAIN; + update_to_read_only = mmu_notifier_range_update_to_read_only(range); + it = interval_tree_iter_first(&amn->objects, range->start, end); while (it) { struct amdgpu_mn_node *node; @@ -317,6 +320,16 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, list_for_each_entry(bo, &node->bos, mn_list) { struct kgd_mem *mem = bo->kfd_bo; + bool read_only; + + /* + * If it is already read only and we are updating to + * read only then we do not need to change anything. + * So save time and skip this one. + */ + read_only = amdgpu_ttm_tt_is_readonly(bo->tbo.ttm); + if (update_to_read_only && read_only) + continue; if (amdgpu_ttm_tt_affect_userptr(bo->tbo.ttm, range->start, -- 2.17.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: jglisse@redhat.com To: linux-mm@kvack.org Cc: "Andrew Morton" <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>, "Christian König" <christian.koenig@amd.com>, "Jan Kara" <jack@suse.cz>, "Felix Kuehling" <Felix.Kuehling@amd.com>, "Jason Gunthorpe" <jgg@mellanox.com>, "Matthew Wilcox" <mawilcox@microsoft.com>, "Ross Zwisler" <zwisler@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Radim Krčmář" <rkrcmar@redhat.com>, "Michal Hocko" <mhocko@kernel.org>, "Ralph Campbell" <rcampbell@nvidia.com>, "John Hubbard" <jhubbard@nvidia.com>, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de> Subject: [PATCH v4 7/9] gpu/drm/amdgpu: optimize out the case when a range is updated to read only Date: Wed, 23 Jan 2019 17:23:13 -0500 [thread overview] Message-ID: <20190123222315.1122-8-jglisse@redhat.com> (raw) In-Reply-To: <20190123222315.1122-1-jglisse@redhat.com> From: Jérôme Glisse <jglisse@redhat.com> When range of virtual address is updated read only and corresponding user ptr object are already read only it is pointless to do anything. Optimize this case out. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Cc: Christian König <christian.koenig@amd.com> Cc: Jan Kara <jack@suse.cz> Cc: Felix Kuehling <Felix.Kuehling@amd.com> Cc: Jason Gunthorpe <jgg@mellanox.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Matthew Wilcox <mawilcox@microsoft.com> Cc: Ross Zwisler <zwisler@kernel.org> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Radim Krčmář <rkrcmar@redhat.com> Cc: Michal Hocko <mhocko@kernel.org> Cc: Ralph Campbell <rcampbell@nvidia.com> Cc: John Hubbard <jhubbard@nvidia.com> Cc: kvm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-rdma@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c index 3e6823fdd939..7880eda064cd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -294,6 +294,7 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, { struct amdgpu_mn *amn = container_of(mn, struct amdgpu_mn, mn); struct interval_tree_node *it; + bool update_to_read_only; unsigned long end; /* notification is exclusive, but interval is inclusive */ @@ -302,6 +303,8 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, if (amdgpu_mn_read_lock(amn, range->blockable)) return -EAGAIN; + update_to_read_only = mmu_notifier_range_update_to_read_only(range); + it = interval_tree_iter_first(&amn->objects, range->start, end); while (it) { struct amdgpu_mn_node *node; @@ -317,6 +320,16 @@ static int amdgpu_mn_invalidate_range_start_hsa(struct mmu_notifier *mn, list_for_each_entry(bo, &node->bos, mn_list) { struct kgd_mem *mem = bo->kfd_bo; + bool read_only; + + /* + * If it is already read only and we are updating to + * read only then we do not need to change anything. + * So save time and skip this one. + */ + read_only = amdgpu_ttm_tt_is_readonly(bo->tbo.ttm); + if (update_to_read_only && read_only) + continue; if (amdgpu_ttm_tt_affect_userptr(bo->tbo.ttm, range->start, -- 2.17.2
next prev parent reply other threads:[~2019-01-23 22:23 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-23 22:23 [PATCH v4 0/9] mmu notifier provide context informations jglisse 2019-01-23 22:23 ` [PATCH v4 1/9] mm/mmu_notifier: contextual information for event enums jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` [PATCH v4 2/9] mm/mmu_notifier: contextual information for event triggering invalidation jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` [PATCH v4 3/9] mm/mmu_notifier: use correct mmu_notifier events for each invalidation jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` [PATCH v4 4/9] mm/mmu_notifier: pass down vma and reasons why mmu notifier is happening jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` [PATCH v4 5/9] mm/mmu_notifier: mmu_notifier_range_update_to_read_only() helper jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` [PATCH v4 6/9] gpu/drm/radeon: optimize out the case when a range is updated to read only jglisse 2019-01-23 22:23 ` jglisse 2019-01-23 22:23 ` jglisse [this message] 2019-01-23 22:23 ` [PATCH v4 7/9] gpu/drm/amdgpu: " jglisse 2019-01-23 22:23 ` [PATCH v4 8/9] gpu/drm/i915: " jglisse 2019-01-23 22:23 ` jglisse 2019-01-24 12:09 ` Joonas Lahtinen 2019-01-24 12:09 ` Joonas Lahtinen 2019-01-24 12:09 ` Joonas Lahtinen 2019-01-24 12:09 ` Joonas Lahtinen 2019-01-24 15:30 ` Jerome Glisse 2019-01-24 15:30 ` Jerome Glisse 2019-01-29 14:20 ` Joonas Lahtinen 2019-01-29 14:20 ` Joonas Lahtinen 2019-01-29 16:21 ` Jerome Glisse 2019-01-23 22:23 ` [PATCH v4 9/9] RDMA/umem_odp: " jglisse 2019-01-23 22:32 ` Jason Gunthorpe 2019-01-23 22:32 ` Jason Gunthorpe 2019-01-23 22:46 ` Jerome Glisse 2019-01-23 22:46 ` Jerome Glisse 2019-01-23 22:54 ` [PATCH v4 0/9] mmu notifier provide context informations Dan Williams 2019-01-23 22:54 ` Dan Williams 2019-01-23 23:04 ` Jerome Glisse 2019-01-23 23:04 ` Jerome Glisse 2019-01-24 0:00 ` Dan Williams 2019-01-24 0:00 ` Dan Williams 2019-01-31 16:10 ` Jerome Glisse 2019-01-31 16:10 ` Jerome Glisse 2019-01-31 19:55 ` Andrew Morton 2019-01-31 20:33 ` Jerome Glisse 2019-02-01 12:24 ` Christian König 2019-02-01 12:24 ` Christian König 2019-02-01 21:02 ` Jan Kara 2019-02-01 21:02 ` Jan Kara 2019-02-11 18:54 ` Jerome Glisse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190123222315.1122-8-jglisse@redhat.com \ --to=jglisse@redhat.com \ --cc=Felix.Kuehling@amd.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=christian.koenig@amd.com \ --cc=dan.j.williams@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jack@suse.cz \ --cc=jgg@mellanox.com \ --cc=jhubbard@nvidia.com \ --cc=kvm@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-rdma@vger.kernel.org \ --cc=mawilcox@microsoft.com \ --cc=mhocko@kernel.org \ --cc=pbonzini@redhat.com \ --cc=rcampbell@nvidia.com \ --cc=rkrcmar@redhat.com \ --cc=zwisler@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.