* [PATCH net-next] net/mlx4_core: A write memory barrier is sufficient in EQ ci update
@ 2019-01-22 13:25 Tariq Toukan
2019-01-25 5:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2019-01-22 13:25 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Eran Ben Elisha, Eric Dumazet, Tariq Toukan
Soften the memory barrier call of mb() by a sufficient wmb() in the
consumer index update of the event queues.
Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/eq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 4953c852c247..56395aa04ca1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -100,7 +100,7 @@ static void eq_set_ci(struct mlx4_eq *eq, int req_not)
req_not << 31),
eq->doorbell);
/* We still want ordering, just not swabbing, so add a barrier */
- mb();
+ wmb();
}
static struct mlx4_eqe *get_eqe(struct mlx4_eq *eq, u32 entry, u8 eqe_factor,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/mlx4_core: A write memory barrier is sufficient in EQ ci update
2019-01-22 13:25 [PATCH net-next] net/mlx4_core: A write memory barrier is sufficient in EQ ci update Tariq Toukan
@ 2019-01-25 5:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-25 5:54 UTC (permalink / raw)
To: tariqt; +Cc: netdev, eranbe, edumazet
From: Tariq Toukan <tariqt@mellanox.com>
Date: Tue, 22 Jan 2019 15:25:50 +0200
> Soften the memory barrier call of mb() by a sufficient wmb() in the
> consumer index update of the event queues.
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-25 5:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 13:25 [PATCH net-next] net/mlx4_core: A write memory barrier is sufficient in EQ ci update Tariq Toukan
2019-01-25 5:54 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.