[Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Wei Yang]

Function pc_acpi_init() is now used in no place.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5317e08f60..734d3268fa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9d29c4b1df..541124ba6d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
-- 
2.19.1

[Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

[Wei Yang]

Function acpi_table_add_builtin() is now used in no place.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/acpi/core.c         | 6 ------
 include/hw/acpi/acpi.h | 1 -
 2 files changed, 7 deletions(-)

diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index d6f0709691..e9b1a85e54 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -305,12 +305,6 @@ out:
 
 static bool acpi_table_builtin = false;
 
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
-    acpi_table_builtin = true;
-    acpi_table_add(opts, errp);
-}
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
index c20ace0d0b..4a8bbaf1b5 100644
--- a/include/hw/acpi/acpi.h
+++ b/include/hw/acpi/acpi.h
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
 uint8_t *acpi_table_next(uint8_t *current);
 unsigned acpi_table_len(void *current);
 void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
 
 typedef struct AcpiSlicOem AcpiSlicOem;
 struct AcpiSlicOem {
-- 
2.19.1

[Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

[Wei Yang]

acpi_table_builtin is now always false, it is not necessary to check it
again.

This patch just removes it.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/acpi/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index e9b1a85e54..f9c96535d1 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -303,8 +303,6 @@ out:
     error_propagate(errp, err);
 }
 
-static bool acpi_table_builtin = false;
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
 
 uint8_t *acpi_table_first(void)
 {
-    if (acpi_table_builtin || !acpi_tables) {
+    if (!acpi_tables) {
         return NULL;
     }
     return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
-- 
2.19.1

Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Igor Mammedov]

On Fri, 25 Jan 2019 14:01:55 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:

> Function pc_acpi_init() is now used in no place.
s/is now used in no place./in not used anymore,/

fixup the same phrase in other patches.

otherwise series looks good, so fix commit messages and resubmit series.

Also when sending  multi-patch series, pls use cover letter
(see help for git format-patch --cover-letter)

 
> Remove the definition and declaration.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  hw/i386/pc.c         | 27 ---------------------------
>  include/hw/i386/pc.h |  1 -
>  2 files changed, 28 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5317e08f60..734d3268fa 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
>                                          pci_address_space, -1);
>  }
>  
> -void pc_acpi_init(const char *default_dsdt)
> -{
> -    char *filename;
> -
> -    if (acpi_tables != NULL) {
> -        /* manually set via -acpitable, leave it alone */
> -        return;
> -    }
> -
> -    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
> -    if (filename == NULL) {
> -        warn_report("failed to find %s", default_dsdt);
> -    } else {
> -        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
> -                                          &error_abort);
> -        Error *err = NULL;
> -
> -        qemu_opt_set(opts, "file", filename, &error_abort);
> -
> -        acpi_table_add_builtin(opts, &err);
> -        if (err) {
> -            warn_reportf_err(err, "failed to load %s: ", filename);
> -        }
> -        g_free(filename);
> -    }
> -}
> -
>  void xen_load_linux(PCMachineState *pcms)
>  {
>      int i;
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9d29c4b1df..541124ba6d 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
>  
>  void pc_cpus_init(PCMachineState *pcms);
>  void pc_hot_add_cpu(const int64_t id, Error **errp);
> -void pc_acpi_init(const char *default_dsdt);
>  
>  void pc_guest_info_init(PCMachineState *pcms);
>  

Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Wei Yang]

On Mon, Jan 28, 2019 at 02:32:30PM +0100, Igor Mammedov wrote:
>On Fri, 25 Jan 2019 14:01:55 +0800
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>
>> Function pc_acpi_init() is now used in no place.
>s/is now used in no place./in not used anymore,/
>
>fixup the same phrase in other patches.
>
>otherwise series looks good, so fix commit messages and resubmit series.
>
>Also when sending  multi-patch series, pls use cover letter
>(see help for git format-patch --cover-letter)

Thanks :-)

Will change and re-submit.

>
> 
>> Remove the definition and declaration.
>> 
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>>  hw/i386/pc.c         | 27 ---------------------------
>>  include/hw/i386/pc.h |  1 -
>>  2 files changed, 28 deletions(-)
>> 
>> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
>> index 5317e08f60..734d3268fa 100644
>> --- a/hw/i386/pc.c
>> +++ b/hw/i386/pc.c
>> @@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
>>                                          pci_address_space, -1);
>>  }
>>  
>> -void pc_acpi_init(const char *default_dsdt)
>> -{
>> -    char *filename;
>> -
>> -    if (acpi_tables != NULL) {
>> -        /* manually set via -acpitable, leave it alone */
>> -        return;
>> -    }
>> -
>> -    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
>> -    if (filename == NULL) {
>> -        warn_report("failed to find %s", default_dsdt);
>> -    } else {
>> -        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
>> -                                          &error_abort);
>> -        Error *err = NULL;
>> -
>> -        qemu_opt_set(opts, "file", filename, &error_abort);
>> -
>> -        acpi_table_add_builtin(opts, &err);
>> -        if (err) {
>> -            warn_reportf_err(err, "failed to load %s: ", filename);
>> -        }
>> -        g_free(filename);
>> -    }
>> -}
>> -
>>  void xen_load_linux(PCMachineState *pcms)
>>  {
>>      int i;
>> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
>> index 9d29c4b1df..541124ba6d 100644
>> --- a/include/hw/i386/pc.h
>> +++ b/include/hw/i386/pc.h
>> @@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
>>  
>>  void pc_cpus_init(PCMachineState *pcms);
>>  void pc_hot_add_cpu(const int64_t id, Error **errp);
>> -void pc_acpi_init(const char *default_dsdt);
>>  
>>  void pc_guest_info_init(PCMachineState *pcms);
>>  

-- 
Wei Yang
Help you, Help me

[Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Wei Yang]

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Wei Yang (3):
  hw/i386/pc.c: remove unused function pc_acpi_init()
  hw/acpi: remove unused function acpi_table_add_builtin()
  hw/acpi: remove unnecessary variable acpi_table_builtin

 hw/acpi/core.c         | 10 +---------
 hw/i386/pc.c           | 27 ---------------------------
 include/hw/acpi/acpi.h |  1 -
 include/hw/i386/pc.h   |  1 -
 4 files changed, 1 insertion(+), 38 deletions(-)

-- 
2.19.1

[Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Wei Yang]

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5317e08f60..734d3268fa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 9d29c4b1df..541124ba6d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
-- 
2.19.1

[Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

[Wei Yang]

Function acpi_table_add_builtin() is not used anymore.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/acpi/core.c         | 6 ------
 include/hw/acpi/acpi.h | 1 -
 2 files changed, 7 deletions(-)

diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index d6f0709691..e9b1a85e54 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -305,12 +305,6 @@ out:
 
 static bool acpi_table_builtin = false;
 
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
-    acpi_table_builtin = true;
-    acpi_table_add(opts, errp);
-}
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
index c20ace0d0b..4a8bbaf1b5 100644
--- a/include/hw/acpi/acpi.h
+++ b/include/hw/acpi/acpi.h
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
 uint8_t *acpi_table_next(uint8_t *current);
 unsigned acpi_table_len(void *current);
 void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
 
 typedef struct AcpiSlicOem AcpiSlicOem;
 struct AcpiSlicOem {
-- 
2.19.1

[Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

[Wei Yang]

acpi_table_builtin is now always false, it is not necessary to check it
again.

This patch just removes it.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/acpi/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index e9b1a85e54..f9c96535d1 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -303,8 +303,6 @@ out:
     error_propagate(errp, err);
 }
 
-static bool acpi_table_builtin = false;
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
 
 uint8_t *acpi_table_first(void)
 {
-    if (acpi_table_builtin || !acpi_tables) {
+    if (!acpi_tables) {
         return NULL;
     }
     return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
-- 
2.19.1

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Philippe Mathieu-Daudé]

Hi Wei,

On 1/29/19 1:08 AM, Wei Yang wrote:
> There are several functions/variable which are not used anymore.
> 
> This serials just remove those without functional change.
> 
> Wei Yang (3):
>   hw/i386/pc.c: remove unused function pc_acpi_init()
>   hw/acpi: remove unused function acpi_table_add_builtin()
>   hw/acpi: remove unnecessary variable acpi_table_builtin
> 
>  hw/acpi/core.c         | 10 +---------
>  hw/i386/pc.c           | 27 ---------------------------
>  include/hw/acpi/acpi.h |  1 -
>  include/hw/i386/pc.h   |  1 -
>  4 files changed, 1 insertion(+), 38 deletions(-)
> 

Please do not post iterated series in reply to previous version, but as
new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to
this thread will be masked.

Regards,

Phil.

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Wei Yang]

On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
>Hi Wei,
>
>On 1/29/19 1:08 AM, Wei Yang wrote:
>> There are several functions/variable which are not used anymore.
>> 
>> This serials just remove those without functional change.
>> 
>> Wei Yang (3):
>>   hw/i386/pc.c: remove unused function pc_acpi_init()
>>   hw/acpi: remove unused function acpi_table_add_builtin()
>>   hw/acpi: remove unnecessary variable acpi_table_builtin
>> 
>>  hw/acpi/core.c         | 10 +---------
>>  hw/i386/pc.c           | 27 ---------------------------
>>  include/hw/acpi/acpi.h |  1 -
>>  include/hw/i386/pc.h   |  1 -
>>  4 files changed, 1 insertion(+), 38 deletions(-)
>> 
>
>Please do not post iterated series in reply to previous version, but as
>new thread:
>- patches are parsed by scripts
>- some email clients can tag a thread as "reviewed, skip" and replies to
>this thread will be masked.
>

Well, do I need to repost it in a new thread?

>Regards,
>
>Phil.

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Philippe Mathieu-Daudé]

On 1/29/19 9:04 AM, Wei Yang wrote:
> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
>> Hi Wei,
>>
>> On 1/29/19 1:08 AM, Wei Yang wrote:
>>> There are several functions/variable which are not used anymore.
>>>
>>> This serials just remove those without functional change.
>>>
>>> Wei Yang (3):
>>>   hw/i386/pc.c: remove unused function pc_acpi_init()
>>>   hw/acpi: remove unused function acpi_table_add_builtin()
>>>   hw/acpi: remove unnecessary variable acpi_table_builtin
>>>
>>>  hw/acpi/core.c         | 10 +---------
>>>  hw/i386/pc.c           | 27 ---------------------------
>>>  include/hw/acpi/acpi.h |  1 -
>>>  include/hw/i386/pc.h   |  1 -
>>>  4 files changed, 1 insertion(+), 38 deletions(-)
>>>
>>
>> Please do not post iterated series in reply to previous version, but as
>> new thread:
>> - patches are parsed by scripts
>> - some email clients can tag a thread as "reviewed, skip" and replies to
>> this thread will be masked.
>>
> 
> Well, do I need to repost it in a new thread?

It depends who will take this patchset and his mood :)
Let's wait and see.

Re: [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

[Philippe Mathieu-Daudé]

On 1/29/19 1:08 AM, Wei Yang wrote:
> Function pc_acpi_init() is not used anymore.
> 
> Remove the definition and declaration.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/i386/pc.c         | 27 ---------------------------
>  include/hw/i386/pc.h |  1 -
>  2 files changed, 28 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5317e08f60..734d3268fa 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
>                                          pci_address_space, -1);
>  }
>  
> -void pc_acpi_init(const char *default_dsdt)
> -{
> -    char *filename;
> -
> -    if (acpi_tables != NULL) {
> -        /* manually set via -acpitable, leave it alone */
> -        return;
> -    }
> -
> -    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
> -    if (filename == NULL) {
> -        warn_report("failed to find %s", default_dsdt);
> -    } else {
> -        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
> -                                          &error_abort);
> -        Error *err = NULL;
> -
> -        qemu_opt_set(opts, "file", filename, &error_abort);
> -
> -        acpi_table_add_builtin(opts, &err);
> -        if (err) {
> -            warn_reportf_err(err, "failed to load %s: ", filename);
> -        }
> -        g_free(filename);
> -    }
> -}
> -
>  void xen_load_linux(PCMachineState *pcms)
>  {
>      int i;
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9d29c4b1df..541124ba6d 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
>  
>  void pc_cpus_init(PCMachineState *pcms);
>  void pc_hot_add_cpu(const int64_t id, Error **errp);
> -void pc_acpi_init(const char *default_dsdt);
>  
>  void pc_guest_info_init(PCMachineState *pcms);
>  
> 

Re: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

[Philippe Mathieu-Daudé]

On 1/29/19 1:08 AM, Wei Yang wrote:
> Function acpi_table_add_builtin() is not used anymore.
> 
> Remove the definition and declaration.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/acpi/core.c         | 6 ------
>  include/hw/acpi/acpi.h | 1 -
>  2 files changed, 7 deletions(-)
> 
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index d6f0709691..e9b1a85e54 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -305,12 +305,6 @@ out:
>  
>  static bool acpi_table_builtin = false;
>  
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
> -{
> -    acpi_table_builtin = true;
> -    acpi_table_add(opts, errp);
> -}
> -
>  unsigned acpi_table_len(void *current)
>  {
>      struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
> index c20ace0d0b..4a8bbaf1b5 100644
> --- a/include/hw/acpi/acpi.h
> +++ b/include/hw/acpi/acpi.h
> @@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
>  uint8_t *acpi_table_next(uint8_t *current);
>  unsigned acpi_table_len(void *current);
>  void acpi_table_add(const QemuOpts *opts, Error **errp);
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
>  
>  typedef struct AcpiSlicOem AcpiSlicOem;
>  struct AcpiSlicOem {
> 

Re: [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

[Philippe Mathieu-Daudé]

On 1/29/19 1:08 AM, Wei Yang wrote:
> acpi_table_builtin is now always false, it is not necessary to check it
> again.
> 
> This patch just removes it.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/acpi/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index e9b1a85e54..f9c96535d1 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -303,8 +303,6 @@ out:
>      error_propagate(errp, err);
>  }
>  
> -static bool acpi_table_builtin = false;
> -
>  unsigned acpi_table_len(void *current)
>  {
>      struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> @@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
>  
>  uint8_t *acpi_table_first(void)
>  {
> -    if (acpi_table_builtin || !acpi_tables) {
> +    if (!acpi_tables) {
>          return NULL;
>      }
>      return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
> 

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Laurent Vivier]

On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote:
> On 1/29/19 9:04 AM, Wei Yang wrote:
>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
>>> Hi Wei,
>>>
>>> On 1/29/19 1:08 AM, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> Wei Yang (3):
>>>>   hw/i386/pc.c: remove unused function pc_acpi_init()
>>>>   hw/acpi: remove unused function acpi_table_add_builtin()
>>>>   hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>
>>>>  hw/acpi/core.c         | 10 +---------
>>>>  hw/i386/pc.c           | 27 ---------------------------
>>>>  include/hw/acpi/acpi.h |  1 -
>>>>  include/hw/i386/pc.h   |  1 -
>>>>  4 files changed, 1 insertion(+), 38 deletions(-)
>>>>
>>>
>>> Please do not post iterated series in reply to previous version, but as
>>> new thread:
>>> - patches are parsed by scripts
>>> - some email clients can tag a thread as "reviewed, skip" and replies to
>>> this thread will be masked.
>>>
>>
>> Well, do I need to repost it in a new thread?
> 
> It depends who will take this patchset and his mood :)
> Let's wait and see.
> 

No need to repost if they go through the trivial branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Wei Yang]

On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote:
>On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote:
>> On 1/29/19 9:04 AM, Wei Yang wrote:
>>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
>>>> Hi Wei,
>>>>
>>>> On 1/29/19 1:08 AM, Wei Yang wrote:
>>>>> There are several functions/variable which are not used anymore.
>>>>>
>>>>> This serials just remove those without functional change.
>>>>>
>>>>> Wei Yang (3):
>>>>>   hw/i386/pc.c: remove unused function pc_acpi_init()
>>>>>   hw/acpi: remove unused function acpi_table_add_builtin()
>>>>>   hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>>
>>>>>  hw/acpi/core.c         | 10 +---------
>>>>>  hw/i386/pc.c           | 27 ---------------------------
>>>>>  include/hw/acpi/acpi.h |  1 -
>>>>>  include/hw/i386/pc.h   |  1 -
>>>>>  4 files changed, 1 insertion(+), 38 deletions(-)
>>>>>
>>>>
>>>> Please do not post iterated series in reply to previous version, but as
>>>> new thread:
>>>> - patches are parsed by scripts
>>>> - some email clients can tag a thread as "reviewed, skip" and replies to
>>>> this thread will be masked.
>>>>
>>>
>>> Well, do I need to repost it in a new thread?
>> 
>> It depends who will take this patchset and his mood :)
>> Let's wait and see.
>> 
>
>No need to repost if they go through the trivial branch.

Thanks :-)

>
>Thanks,
>Laurent

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Michael S. Tsirkin]

On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote:
> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote:
> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote:
> >> On 1/29/19 9:04 AM, Wei Yang wrote:
> >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
> >>>> Hi Wei,
> >>>>
> >>>> On 1/29/19 1:08 AM, Wei Yang wrote:
> >>>>> There are several functions/variable which are not used anymore.
> >>>>>
> >>>>> This serials just remove those without functional change.
> >>>>>
> >>>>> Wei Yang (3):
> >>>>>   hw/i386/pc.c: remove unused function pc_acpi_init()
> >>>>>   hw/acpi: remove unused function acpi_table_add_builtin()
> >>>>>   hw/acpi: remove unnecessary variable acpi_table_builtin
> >>>>>
> >>>>>  hw/acpi/core.c         | 10 +---------
> >>>>>  hw/i386/pc.c           | 27 ---------------------------
> >>>>>  include/hw/acpi/acpi.h |  1 -
> >>>>>  include/hw/i386/pc.h   |  1 -
> >>>>>  4 files changed, 1 insertion(+), 38 deletions(-)
> >>>>>
> >>>>
> >>>> Please do not post iterated series in reply to previous version, but as
> >>>> new thread:
> >>>> - patches are parsed by scripts
> >>>> - some email clients can tag a thread as "reviewed, skip" and replies to
> >>>> this thread will be masked.
> >>>>
> >>>
> >>> Well, do I need to repost it in a new thread?
> >> 
> >> It depends who will take this patchset and his mood :)
> >> Let's wait and see.
> >> 
> >
> >No need to repost if they go through the trivial branch.
> 
> Thanks :-)
> 
> >
> >Thanks,
> >Laurent

Pls repost with all acks etc and I'll pick it up.

> -- 
> Wei Yang
> Help you, Help me

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

[Wei Yang]

On Tue, Jan 29, 2019 at 10:58:50AM -0500, Michael S. Tsirkin wrote:
>On Tue, Jan 29, 2019 at 03:32:54PM +0000, Wei Yang wrote:
>> On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote:
>> >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote:
>> >> On 1/29/19 9:04 AM, Wei Yang wrote:
>> >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote:
>> >>>> Hi Wei,
>> >>>>
>> >>>> On 1/29/19 1:08 AM, Wei Yang wrote:
>> >>>>> There are several functions/variable which are not used anymore.
>> >>>>>
>> >>>>> This serials just remove those without functional change.
>> >>>>>
>> >>>>> Wei Yang (3):
>> >>>>>   hw/i386/pc.c: remove unused function pc_acpi_init()
>> >>>>>   hw/acpi: remove unused function acpi_table_add_builtin()
>> >>>>>   hw/acpi: remove unnecessary variable acpi_table_builtin
>> >>>>>
>> >>>>>  hw/acpi/core.c         | 10 +---------
>> >>>>>  hw/i386/pc.c           | 27 ---------------------------
>> >>>>>  include/hw/acpi/acpi.h |  1 -
>> >>>>>  include/hw/i386/pc.h   |  1 -
>> >>>>>  4 files changed, 1 insertion(+), 38 deletions(-)
>> >>>>>
>> >>>>
>> >>>> Please do not post iterated series in reply to previous version, but as
>> >>>> new thread:
>> >>>> - patches are parsed by scripts
>> >>>> - some email clients can tag a thread as "reviewed, skip" and replies to
>> >>>> this thread will be masked.
>> >>>>
>> >>>
>> >>> Well, do I need to repost it in a new thread?
>> >> 
>> >> It depends who will take this patchset and his mood :)
>> >> Let's wait and see.
>> >> 
>> >
>> >No need to repost if they go through the trivial branch.
>> 
>> Thanks :-)
>> 
>> >
>> >Thanks,
>> >Laurent
>
>Pls repost with all acks etc and I'll pick it up.
>

Got it.

>> -- 
>> Wei Yang
>> Help you, Help me

-- 
Wei Yang
Help you, Help me