* [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
@ 2019-01-22 20:07 Dr. David Alan Gilbert
2019-01-23 3:00 ` Michael S. Tsirkin
0 siblings, 1 reply; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-01-22 20:07 UTC (permalink / raw)
To: imammedo, mst; +Cc: qemu-devel
Hi,
I noticed that the acpi_1_compatible flag was misspelt as
apci_1_compatible
so have a trivial patch to fix that, but looking at it - are
thre any cases where a[cp]i_1_compatible can possibly be false?
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-22 20:07 [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures Dr. David Alan Gilbert
@ 2019-01-23 3:00 ` Michael S. Tsirkin
2019-01-23 18:28 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 7+ messages in thread
From: Michael S. Tsirkin @ 2019-01-23 3:00 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: imammedo, qemu-devel
On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> Hi,
> I noticed that the acpi_1_compatible flag was misspelt as
> apci_1_compatible
>
> so have a trivial patch to fix that, but looking at it - are
> thre any cases where a[cp]i_1_compatible can possibly be false?
>
> Dave
legacy_cpu_hotplug so machine 2.6 and older - no?
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-23 3:00 ` Michael S. Tsirkin
@ 2019-01-23 18:28 ` Dr. David Alan Gilbert
2019-01-25 8:26 ` Igor Mammedov
0 siblings, 1 reply; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-01-23 18:28 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: imammedo, qemu-devel
* Michael S. Tsirkin (mst@redhat.com) wrote:
> On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > I noticed that the acpi_1_compatible flag was misspelt as
> > apci_1_compatible
> >
> > so have a trivial patch to fix that, but looking at it - are
> > thre any cases where a[cp]i_1_compatible can possibly be false?
> >
> > Dave
>
> legacy_cpu_hotplug so machine 2.6 and older - no?
That doesn't seem to affect that flag by my reading;
the only place I see legacy_cpu_hotplug checked is
acpi-build.c:build_dsdt and we have:
if (pcmc->legacy_cpu_hotplug) {
build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
} else {
CPUHotplugFeatures opts = {
.acpi_1_compatible = true, .has_legacy_cphp = true
};
build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base,
"\\_SB.PCI0", "\\_GPE._E02");
}
so the 'opts' field is only used in the non-legacy case.
That's the only caller of build_cpus_aml, and I'm not seeing another
user of CPUHotplugFeatures.
Dave
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-23 18:28 ` Dr. David Alan Gilbert
@ 2019-01-25 8:26 ` Igor Mammedov
2019-01-25 9:41 ` Dr. David Alan Gilbert
2019-01-25 19:49 ` Michael S. Tsirkin
0 siblings, 2 replies; 7+ messages in thread
From: Igor Mammedov @ 2019-01-25 8:26 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: Michael S. Tsirkin, qemu-devel
On Wed, 23 Jan 2019 18:28:59 +0000
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi,
> > > I noticed that the acpi_1_compatible flag was misspelt as
> > > apci_1_compatible
> > >
> > > so have a trivial patch to fix that,
pls post it.
> > > but looking at it - are
> > > thre any cases where a[cp]i_1_compatible can possibly be false?
ATM it's not possible, but I've wrote it with intent to reuse
build_cpus_aml() in arm/virt board and there we shall use newer
aml_device() instead of legacy aml_processor(), hence a feature flag
to toggle behavior.
> > >
> > > Dave
> >
> > legacy_cpu_hotplug so machine 2.6 and older - no?
>
> That doesn't seem to affect that flag by my reading;
> the only place I see legacy_cpu_hotplug checked is
> acpi-build.c:build_dsdt and we have:
>
> if (pcmc->legacy_cpu_hotplug) {
> build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
> } else {
> CPUHotplugFeatures opts = {
> .acpi_1_compatible = true, .has_legacy_cphp = true
> };
> build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base,
> "\\_SB.PCI0", "\\_GPE._E02");
> }
>
> so the 'opts' field is only used in the non-legacy case.
>
> That's the only caller of build_cpus_aml, and I'm not seeing another
> user of CPUHotplugFeatures.
>
> Dave
>
> > > --
> > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-25 8:26 ` Igor Mammedov
@ 2019-01-25 9:41 ` Dr. David Alan Gilbert
2019-01-25 19:49 ` Michael S. Tsirkin
1 sibling, 0 replies; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-01-25 9:41 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Michael S. Tsirkin, qemu-devel
* Igor Mammedov (imammedo@redhat.com) wrote:
> On Wed, 23 Jan 2019 18:28:59 +0000
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
>
> > * Michael S. Tsirkin (mst@redhat.com) wrote:
> > > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> > > > Hi,
> > > > I noticed that the acpi_1_compatible flag was misspelt as
> > > > apci_1_compatible
> > > >
> > > > so have a trivial patch to fix that,
> pls post it.
Done.
> > > > but looking at it - are
> > > > thre any cases where a[cp]i_1_compatible can possibly be false?
> ATM it's not possible, but I've wrote it with intent to reuse
> build_cpus_aml() in arm/virt board and there we shall use newer
> aml_device() instead of legacy aml_processor(), hence a feature flag
> to toggle behavior.
OK, that's fine, I just couldn't see why the flag was there given the
current uses.
Dave
>
> > > >
> > > > Dave
> > >
> > > legacy_cpu_hotplug so machine 2.6 and older - no?
> >
> > That doesn't seem to affect that flag by my reading;
> > the only place I see legacy_cpu_hotplug checked is
> > acpi-build.c:build_dsdt and we have:
> >
> > if (pcmc->legacy_cpu_hotplug) {
> > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
> > } else {
> > CPUHotplugFeatures opts = {
> > .acpi_1_compatible = true, .has_legacy_cphp = true
> > };
> > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base,
> > "\\_SB.PCI0", "\\_GPE._E02");
> > }
> >
> > so the 'opts' field is only used in the non-legacy case.
> >
> > That's the only caller of build_cpus_aml, and I'm not seeing another
> > user of CPUHotplugFeatures.
> >
> > Dave
> >
> > > > --
> > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-25 8:26 ` Igor Mammedov
2019-01-25 9:41 ` Dr. David Alan Gilbert
@ 2019-01-25 19:49 ` Michael S. Tsirkin
2019-01-28 10:41 ` Igor Mammedov
1 sibling, 1 reply; 7+ messages in thread
From: Michael S. Tsirkin @ 2019-01-25 19:49 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Dr. David Alan Gilbert, qemu-devel
On Fri, Jan 25, 2019 at 09:26:05AM +0100, Igor Mammedov wrote:
> On Wed, 23 Jan 2019 18:28:59 +0000
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
>
> > * Michael S. Tsirkin (mst@redhat.com) wrote:
> > > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> > > > Hi,
> > > > I noticed that the acpi_1_compatible flag was misspelt as
> > > > apci_1_compatible
> > > >
> > > > so have a trivial patch to fix that,
> pls post it.
>
> > > > but looking at it - are
> > > > thre any cases where a[cp]i_1_compatible can possibly be false?
> ATM it's not possible, but I've wrote it with intent to reuse
> build_cpus_aml() in arm/virt board and there we shall use newer
> aml_device() instead of legacy aml_processor(), hence a feature flag
> to toggle behavior.
Are there imminent plans to do this? If not why don't we
drop unused code? One can always bring it back from git
history if need arises but for now there's no guarantee
it's not broken as it never runs.
>
> > > >
> > > > Dave
> > >
> > > legacy_cpu_hotplug so machine 2.6 and older - no?
> >
> > That doesn't seem to affect that flag by my reading;
> > the only place I see legacy_cpu_hotplug checked is
> > acpi-build.c:build_dsdt and we have:
> >
> > if (pcmc->legacy_cpu_hotplug) {
> > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
> > } else {
> > CPUHotplugFeatures opts = {
> > .acpi_1_compatible = true, .has_legacy_cphp = true
> > };
> > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base,
> > "\\_SB.PCI0", "\\_GPE._E02");
> > }
> >
> > so the 'opts' field is only used in the non-legacy case.
> >
> > That's the only caller of build_cpus_aml, and I'm not seeing another
> > user of CPUHotplugFeatures.
> >
> > Dave
> >
> > > > --
> > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures
2019-01-25 19:49 ` Michael S. Tsirkin
@ 2019-01-28 10:41 ` Igor Mammedov
0 siblings, 0 replies; 7+ messages in thread
From: Igor Mammedov @ 2019-01-28 10:41 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Dr. David Alan Gilbert, qemu-devel
On Fri, 25 Jan 2019 14:49:28 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Jan 25, 2019 at 09:26:05AM +0100, Igor Mammedov wrote:
> > On Wed, 23 Jan 2019 18:28:59 +0000
> > "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> >
> > > * Michael S. Tsirkin (mst@redhat.com) wrote:
> > > > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote:
> > > > > Hi,
> > > > > I noticed that the acpi_1_compatible flag was misspelt as
> > > > > apci_1_compatible
> > > > >
> > > > > so have a trivial patch to fix that,
> > pls post it.
> >
> > > > > but looking at it - are
> > > > > thre any cases where a[cp]i_1_compatible can possibly be false?
> > ATM it's not possible, but I've wrote it with intent to reuse
> > build_cpus_aml() in arm/virt board and there we shall use newer
> > aml_device() instead of legacy aml_processor(), hence a feature flag
> > to toggle behavior.
>
> Are there imminent plans to do this? If not why don't we
> drop unused code? One can always bring it back from git
> history if need arises but for now there's no guarantee
> it's not broken as it never runs.
I'm working on it (I mean adding CPU hotplug support for ARM (QEMU side of it)),
so I'd keep it.
> >
> > > > >
> > > > > Dave
> > > >
> > > > legacy_cpu_hotplug so machine 2.6 and older - no?
> > >
> > > That doesn't seem to affect that flag by my reading;
> > > the only place I see legacy_cpu_hotplug checked is
> > > acpi-build.c:build_dsdt and we have:
> > >
> > > if (pcmc->legacy_cpu_hotplug) {
> > > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
> > > } else {
> > > CPUHotplugFeatures opts = {
> > > .acpi_1_compatible = true, .has_legacy_cphp = true
> > > };
> > > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base,
> > > "\\_SB.PCI0", "\\_GPE._E02");
> > > }
> > >
> > > so the 'opts' field is only used in the non-legacy case.
> > >
> > > That's the only caller of build_cpus_aml, and I'm not seeing another
> > > user of CPUHotplugFeatures.
> > >
> > > Dave
> > >
> > > > > --
> > > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > > --
> > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-28 10:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 20:07 [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures Dr. David Alan Gilbert
2019-01-23 3:00 ` Michael S. Tsirkin
2019-01-23 18:28 ` Dr. David Alan Gilbert
2019-01-25 8:26 ` Igor Mammedov
2019-01-25 9:41 ` Dr. David Alan Gilbert
2019-01-25 19:49 ` Michael S. Tsirkin
2019-01-28 10:41 ` Igor Mammedov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.